summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)Author
2016-05-21GLX_EXT_texture_from_pixmap path cannot be called...Caolán McNamara
slideshow mbHasTFPVisual is always false since commit eccaf91ec9c50d42ce98c90abe2c129bedbbc60e Date: Mon May 19 19:21:29 2014 +0200 use VCL's OpenGLContext for 3D transitions Change-Id: I510518461eb8bc9669d0de2679c34c473f66b175 and GLWindow fbc has always been null since that incarnation of opengl started, so even if mbHasTFPVisual was true it would crash. OpenGLHelper::GetPixmapFBConfig is *almost* the same as the old removed code for setting fbc, but if I use that then for me the transitions still don't work at all. Examining further shows GetPixmapFBConfig lacks the test for GLX_BIND_TO_MIPMAP_TEXTURE_EXT that the old code had. If I add than, then it "works", but examining *that*, reveals it only works because GLX_BIND_TO_MIPMAP_TEXTURE_EXT is unsupported on my rig, so the GLX_EXT_texture_from_pixmap code still doesn't get executed. I apparently can't test the original working configuration, and I'm not particularly interested in getting X working and I just wanted to make sure I didn't break that case, so... this removes the uncallable since 2014 code entirely rather than try to fix it. I suspect this may leave the cairo-canvas CanvasBitmap::getFastPropertyValue "1" branch now also dead Change-Id: I6727576056533fa54a4f82378954fb53891f5873
2016-05-21Split OpenGLContext up into SalInstance specific classesCaolán McNamara
which, at least theoretically, allows there to be vclplug specific ones. i.e. a gtk3 specific one which doesn't assume gtk3 is running under X Change-Id: I6c007a87abbd3049b6fffc70d349e3b7ac445eec
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13slideshow: replace boost::mem_fn with std::mem_fnMichael Stahl
Change-Id: I0b02b2b13cacac48d94e541671a446368f5e527f Reviewed-on: https://gerrit.libreoffice.org/24885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13slideshow: tweak BaseContainerNode::forEachChildNodeMichael Stahl
Mac OS X clang/libc++ refuse to invoke a "const" std::mem_fn object. And you thought that MSVC was the only one with a deficient stdlib. Change-Id: Ib7a659adbd270a20b9fdcd661df1bd78d40768ca Reviewed-on: https://gerrit.libreoffice.org/24901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13convert EXCEPTION_ to scoped enumNoel Grandin
- simplify VCLExceptionSignal_impl - drop "minor" part of error code, nobody passes it in, and nobody checks it - rename Display to UserInterface, to prevent -Werror=shadow Change-Id: I503fd8a50ded30d59c30fb388796f6b1a0c058de Reviewed-on: https://gerrit.libreoffice.org/24892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11slideshow: tweak ListenerOperations<std::weak_ptr<ListenerTargetT>>Michael Stahl
Pretty sure FuncT(...value_type) is wrong since value_type is std::weak_ptr which does not implicitly convert to a callable pointer; this caused build failure on Mac OS X with clang/libc++. Change-Id: Id9de4a7825347a84cce2aab5367a457a003bb352
2016-05-11slideshow: replace boost::mem_fn with C++11 lambdasMichael Stahl
A bit more verbose but we have less than 10 mem_fn now so better elimintate them all so hopefully we can get rid of the corresponding boost warning patches. Change-Id: I79e2f9994841125916d92bdce9973d956f2a68ce
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-06basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Ic748f5d0df9622aae0faa600fe13f82103bbf4bf
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘and’ of equal expressions", as DEFAULT and INHERIT are both defined as zero in the UNOIDL css.animations.AnimationFill constant group Change-Id: I59e53fe9bf73f6eec8f7aa82a216736a79e0d47c
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in slideshowNoel Grandin
Change-Id: I6a58315ae63d543053d613a18ff769329f309c32
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I blindly replaced OSL_DEBUG_LEVEL > 1 conditionals to OSL_DEBUG_LEVEL > 0 as suggested in the easy hack Change-Id: Iac829aa648fd0bd5d170e92a72809a2078e1f020 Reviewed-on: https://gerrit.libreoffice.org/23066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I364aa7d67c2bf867588798e07df95c3f3f2bd7f3 Reviewed-on: https://gerrit.libreoffice.org/23676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-25fix headless buildOliver Specht
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-23loplugin:constantparam in slideshowNoel Grandin
Change-Id: I36215c1e5c698b1dd2a984163639b024739b3113
2016-03-09loplugin:constantparam in slideshowNoel Grandin
Change-Id: If6c9b8e551d6e6dc857f634e1e8db092541c1031
2016-03-09Add missing includesDavid Ostrovsky
These include were needed to compile on Windows, MSVC 14.0 with clang-cl. Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29 Reviewed-on: https://gerrit.libreoffice.org/23044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-02tdf#98175 fix Impress crashNoel Grandin
Caused by my commit f29c0b2b3e8861909fa2c6c37bf631ab01590541 "boost::shared_ptr->std::shared_ptr in slideshow" where I foolishly converted shared_from_this() to std::shared_ptr<Activity>((Activity*)this) ) all over the place, which is bad, I should have used std::dynamic_pointer_cast<ViewEventHandler>(shared_from_this()) Ah, the joys of C++ memory management. Change-Id: I9b538e78730c9107870f406cb8ba482d491dd568
2016-02-26Missing includeStephan Bergmann
Change-Id: I6f2d7dc98b6c3b98a7ed27552c1e8b3b9481f619
2016-02-25slideshow: Blur the shadows the further they are from the objectEmmanuel Gil Peyrot
Change-Id: I63f4fda670b86db2ee1ea66d8755d71697fac0c7 Reviewed-on: https://gerrit.libreoffice.org/22678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-25slideshow: Only use texture() in GLSL 1.50, fixes Intel on WindowsEmmanuel Gil Peyrot
texture2D() is still available, but not in the geometry stage, so better be consistent everywhere. Change-Id: I86bf1921713bcbf32946190525401bfcc633a69f Reviewed-on: https://gerrit.libreoffice.org/22468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-25slideshow: Add an ugly workaround for Intel’s matrix multiplicationEmmanuel Gil Peyrot
When more than three multiplications are chained, Intel’s Windows driver returns a mat4 containing only zeroes, likely due to a misbehaving optimisation. This patch prevents it from doing any optimisation by doing each multiplication in its own uniform block. Change-Id: I0b435d3a5444afd47f78c379f0d2e442d2c2cfc0 Reviewed-on: https://gerrit.libreoffice.org/22470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-25slideshow: Move Vortex calculations to the geometry stage, fixes IntelEmmanuel Gil Peyrot
Their Windows driver was failing due to too many varyings being used between the vertex and the geometry stages. Change-Id: Iec69a2ef29e6ed4ba5ce6e46c7a5eb7db5098d1b Reviewed-on: https://gerrit.libreoffice.org/22469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-25slideshow: Move Vortex’ tileInfo attribute upload to the first frameEmmanuel Gil Peyrot
Change-Id: Ifbc154755d43a085b78740a5a3c97ed2cbe9a905 Reviewed-on: https://gerrit.libreoffice.org/22467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-24remove boost/shared_ptr fooCaolán McNamara
Change-Id: Id208712f80e820f23d898359a4d58297a09e5a77
2016-02-24loplugin:unreffunStephan Bergmann
...of boost::sp_scalar_con-/destructor_hook overrides declared in boost/smart_ptr/detail/sp_counted_impl.hpp Change-Id: I5486dd890ef2ffdcb5973f3a8959ac0b6da376ee
2016-02-24loplugin:cstylecastStephan Bergmann
Change-Id: Iffad73733edc9b43b00784373f2c5c8bc69dc7c4
2016-02-24loplugin:cstylecastStephan Bergmann
Change-Id: If6f3a7bd48402ed1377359b748f9253efe50b71b
2016-02-24boost::shared_ptr->std::shared_ptr in slideshowNoel Grandin
Change-Id: I27da6bc550488ea65ccdf1d26f8178f803f495d6
2016-02-21WaE unqualifed float literal are doubleNorbert Thiebaud
1.0 - float => double which then trigger a warning when implicitely downcasted to float Change-Id: Ic48f753e7ccf834fd36ff1b26d315b1267a15955 Reviewed-on: https://gerrit.libreoffice.org/22594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-19new loplugin: find write-only fieldsNoel Grandin
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-11tdf#97197 - GL transitions should use their context not VCL's.Michael Meeks
Change-Id: Ifab7da221e73e068ebe0856a4224ec4ca4d611b5
2016-02-10loplugin:nullptrStephan Bergmann
Change-Id: If248c921cd5c64c74f36193f3928835f0059834d
2016-02-09slideshow: Add shadows to Honeycomb, using the same way as VortexEmmanuel Gil Peyrot
Change-Id: I1f8f11f900f281792b417c1efead272fe3e8432e