summaryrefslogtreecommitdiff
path: root/solenv/clang-format
AgeCommit message (Collapse)Author
2020-02-08move some headers inside basicNoel Grandin
Change-Id: If711825c36bd4f9836fcd3ba26e5d4f38a5f3e36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88166 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-08move some headers inside frameworkNoel Grandin
Change-Id: Ia005938c6a3a954eba910981dde5010a1f977fca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07move some headers inside svtools moduleNoel Grandin
Change-Id: I62fe3345aebe148010971bc8c487d96fa601d420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07clang-format cui with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I2886b6da85043218505ff9f3e40a8e28289c6f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88152 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-07Remove erroneous whitespace in update_pchMuhammet Kara
This was causing generation of code in violation of clang-format conformance in these files: * xmlsecurity/inc/pch/precompiled_xsec_xmlsec.hxx * connectivity/inc/pch/precompiled_ado.hxx Also remove these 2 files from the clang-format blacklist. Change-Id: I882028c0553a3ff7fb356611f498d50dea984a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88143 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-06Remove correctly formatted files from the clang-format blacklistMuhammet Kara
Change-Id: I80554560d55601ece243620a11dc2931144c7e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88132 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-05move some toolkit/ headers inside the moduleNoel Grandin
Change-Id: I88badb1eb586db00a350afbcd6f4903a5623c724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-04remove controlprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I8918f8c9e4f27a287c98dadd51a11acf3338daa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove borderlineprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I9e8efbf2a947688fe3ec74fa1b2175a089b91a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87939 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove backgroundcolorprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I8ad988dd0eb6a4bbbe9fc9bbc773c692cab4401f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87936 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove animatedprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I6e4b2bc524a0880631735fb79b3545e88bf50f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87933 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04move some headers inside ucbhelperNoel Grandin
Change-Id: Iccd80aa4e631abe002837ca61248e136de9a62eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03remove bitmapprimitive2d.{cxx,hxx} from clang-format blacklistTomaž Vajngerl
Change-Id: I9d9d7cd8bba489c71a5c1ac0b23755d572696e10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87904 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-03make some headers privateCaolán McNamara
as shown with ./bin/find-headers-to-move-inside-modules.py Change-Id: I7662417e76fe00c0fc352957560e104b6c2a3d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03drop unused controldims.hxxCaolán McNamara
Change-Id: I7d20159d3515cced8f1ede2899e180e146327355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03significantly reduce build time of sharedvisitor.cxxLuboš Luňák
In the sharedvisitor.cxx mode all plugins need just one shared RecursiveASTVisitor template instance, but as long as they use another instance each as the base class, Clang still instantiates those templates and then spends a lot of time optimizing each of them, even though they should never get used. So when compiling using sharedvisitor.cxx simply use dummy base classes that do not do anything. As an additional check they abort() if any of the functions get called, this needed removing vclwidgets and unusedmember from shared plugins, because they call TraverseStmt(), maybe this can get handled somehow later. Change-Id: Ic5a350da2c3ba31521f71077b1776b1ee8f06dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87561 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-03move some xmloff/ headers inside the moduleNoel Grandin
Change-Id: I57e97da952c18c33af85a8fe24ebf021fc0631d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-02remove some unused headersNoel Grandin
found with a little python script(include) and some grepping, so probably not 100% reliable. Change-Id: I1a26a37ef7297c2cc07ed5fd2e0af45280e64c13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-01no direct users of slider.hxx outside vcl anymoreCaolán McNamara
Change-Id: I6bf80bb125512a483aba3aed3c5a6a16d14e31d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-31new loplugin:namespaceindentationNoel Grandin
check indentation of braces in namespace decls, and the comments that often appear with them. This is my penance for messing up the indentation with clang-tidy-modernize-namespaces. As such I have limited it to new-style namespaces for now, and the check is off by default. Change-Id: I4db7f10a81c79bc0eece8f8e3ee564da8bc7f168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29Add wrongly formatted files to blacklistStephan Bergmann
Change-Id: I5453f58db919faa8799e6fe46201818df17f43f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29Sort solenv/clang-format/blacklistStephan Bergmann
(lexicographically, by Unicode code point values; to make it easier to add further entries) Change-Id: Ie9c426e74b79cab241695d1ecd58c78704820649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28tdf#123936: remove non-existent files from blacklistBatuhan Taskaya
Change-Id: If2f6971dd49440a050bfbb42ba7eace75c780218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87572 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28move private TimeBox to toolkit-only headersCaolán McNamara
move private DateBox to toolkit-only headers move private CurrencyBox to toolkit-only headers move private PatternBox to toolkit-only headers move private CurrencyField to toolkit-only headers move private CurrencyFormatter to toolkit-only headers Change-Id: If5ba9e07b20cdc69ca554af388ec9d9e362cbf9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ToolbarMenu is now unusedCaolán McNamara
Change-Id: Id48bb98045886ee79149f27c58e54488a80af41f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-23SdDocPreviewWin is unusedCaolán McNamara
since... commit bb8040595c9b6f0ccde39e6833f27a50abb891d8 Date: Mon May 30 01:57:00 2016 +0530 Impress: Replace Presentation Wizard with Template Manager Change-Id: Ibe610beb8ae98aca9bf29554528127ed1518179d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87219 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22rework line style to be a wide toolbar buttonCaolán McNamara
involves converting SvxLineStyleToolBoxControl to a PopupWindowController because chart is doing interesting things in its panel there needs to be a non-standard way to report/detect the selected line style, which is then reused to disable/enable the arrows when none is selected/deselected in non-chart sidebars SvxLineBox becomes a toolbar dropdown instead of a combobox itemwindow linectrl.cxx split into linewidthctrl.cxx and linewidthctrl because SvxLineBox is now needed in svxcore Change-Id: Icf0ef5e612b894a43d389af8a2908138c2e9c580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21remove unused GSOC 2005 "Tabbed Document Windows for OOo"Caolán McNamara
this was #i54847# Change-Id: I312e3ea9b123976e9929f6601a931ff8a108d7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21weld gallery panelCaolán McNamara
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Drop empty eventhandler files from svx/Gabor Kelemen
Change-Id: I42e33999cbfc5a39bd79f2711c2df7ad13d14f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14svmedit2.hxx doesn't need to be a public headerCaolán McNamara
Change-Id: I8f193478eb74b544a075b477fbeed5dc5b55402e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06convert SkImage -> SkBitmap only on demandLuboš Luňák
This should possibly save some unneeded conversions. Change-Id: Ice8a186f13a0e61bee260cf910f8a4d0538ef974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85542 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-01drawinglayer: clang-format BasePrimitive2D + remove from blacklistTomaž Vajngerl
No functional change was made, only formatting of the code. The code was formatted with clang-format and moves the files baseprimitve2d.{cxx,hxx} out of blacklist so it will be auto formatted with every change from now on. Change-Id: If49ec94f91e58825f7aa94dc54cff8374467aa30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86078 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-30SidebarDialControl is now unusedCaolán McNamara
Change-Id: I949276018ed1867ce2a450c013c7fa41206fe68c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-21SlideTransitionBox is unusedCaolán McNamara
since... commit 57ca02a7486090f1dd63977bb8fb351f9bf9a7f3 Date: Wed Apr 18 00:04:09 2018 +0200 NB Impress tabbed toolbar big update Change-Id: I599e84f4bec66eff301ab1a92cc1206a47068e02 Reviewed-on: https://gerrit.libreoffice.org/85654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-17tdf#42949 Fix IWYU warnings in filter/Gabor Kelemen
Also drop inc/gfxtypes.hxx and source/svg/spirit_supplements.hxx which are unused since commit 3ca7be09834a26fbd1c371deabd7a58111092676 "Replace SVGFilter using SVGIO" Drop now unneeded pass-through header source/graphicfilter/icgm/main.hxx too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8abaf294370c98256815a226168085dd01123f3e Reviewed-on: https://gerrit.libreoffice.org/84734 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-13loplugin:unusedmethodsNoel Grandin
Change-Id: I8ad75d1251df4d6f8097aaa68e4ec92331e38ad4 Reviewed-on: https://gerrit.libreoffice.org/85077 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11clang-format for infobar filesSamuel Mehrbrodt
Change-Id: Iba097ebe214a6904caf01bfb880b34fdccf673ea Reviewed-on: https://gerrit.libreoffice.org/84570 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-04drop dbgutil SdrItemBrowser FloatingWindowCaolán McNamara
Change-Id: I7a4ca90ea23271e7b6f60d7e47e4513978d3222d Reviewed-on: https://gerrit.libreoffice.org/84356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27add .cxx file for SalBitmapLuboš Luňák
And move the non-trivial virtual UpdateChecksum() there. Change-Id: I6776a51373e375e12f1ec9588a9c49410ae5124a
2019-11-27move opengl vcl files to opengl/Luboš Luňák
Better to have all of them together rather than scattered. Change-Id: I1f8bbfb7018a6c28c87e4dfa2acbf4efde62894b
2019-11-25Turn on clang-format for these filesMiklos Vajna
I (tried to) keep these files consistent locally with astyle in the past, switching to clang-format makes sure that the recent problem with introducing inconsistencies with automatic loplugin rewrites doesn't happen again. Change-Id: I86def0d13a1d16f8cedb7cf9927a48ce14c2b3bf Reviewed-on: https://gerrit.libreoffice.org/83690 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-21tdf#42949 tdf#119699 Fix IWYU warnings in chart2/Gabor Kelemen
* Recheck after recent refactorings and improvements in f-u-i * Drop now unused TabPageIds.h * The problem noticed in bug #119699 now seems to be gone too so drop those lines from the blacklist. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15 Reviewed-on: https://gerrit.libreoffice.org/83182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-20tdf#42949 Fix IWYU warnings in framework/*/*cxxGabor Kelemen
Also drop the now unused framework/inc/general.h Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8e19036a507dbdcd178835b6ac4182719d27a654 Reviewed-on: https://gerrit.libreoffice.org/82744 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-13Extend loplugin:salbool to loplugin:fakeboolStephan Bergmann
...checking for unnecessary uses of more "fake bool" types. In the past, some of the checks involving the types of variables or data members, or the return types of functions, issued warnings that required surrounding code to be changed too (e.g., when changing the signature of a function whose address was taken). These checks have been tightened now to not warn in such cases (which avoids warnings that require changes to additional code, or changes that might even be impossible to make, at the cost of being less aggressive about removing all unnecessary uses of those "fake bool" types). Change-Id: I70eb75039817cda34ed611387ee27dc5f36a3e2e Reviewed-on: https://gerrit.libreoffice.org/82554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-13chart2: Separate ChartResourceGroups to reuseMuhammet Kara
Change-Id: I0ca2ea9cd520013250faaba0e17e713da1e6fca3 Reviewed-on: https://gerrit.libreoffice.org/81581 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82462 Tested-by: Jenkins
2019-11-12chart2: Move some headers to incMuhammet Kara
So that they will be accessible from inside the sidebar dir. Change-Id: Iaf7b1a800a3b35a5c497d8122f68c97c8cdc9eff Reviewed-on: https://gerrit.libreoffice.org/80922 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82461 Tested-by: Jenkins
2019-11-11tdf#42949 Fix IWYU warnings in framework/*/*hxxGabor Kelemen
Also drop unused framework/inc/fwkdllapi.h Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61 Reviewed-on: https://gerrit.libreoffice.org/81927 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-08sw: no reason why SwModelTestBase can be used only by "extras" testsMiklos Vajna
So move it one level up, this way more tests can share code in the future. Change-Id: I35300b3c88ac9a5c39916f53b1b1743aa85869a0 Reviewed-on: https://gerrit.libreoffice.org/82252 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-04ProgressBar now only use in vcl and toolkitCaolán McNamara
Change-Id: I5d56a4df155806e41cafa6f65a3a030e8443b8f7 Reviewed-on: https://gerrit.libreoffice.org/82005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>