| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This reverts commit 07c0b800d9d70857882238204820f75b8dc98b26.
|
|
The OUTDIR RDB depends on Packages for IDL and headers, the latter of
which depends on the WORKDIR RDB, hence preserving timestamps here leads
to spurious re-delivery because the OUTDIR RDB always has older
timestamp than the headers Package.
|
|
Change-Id: I6f468005c8d8d99d9251a9c4fe4629b98bc4aa5e
|
|
make 3.82 understands mixed paths, so use them.
This allows us to get rid of evil in BuildDirs.mk.
Hopefully, life will be simpler now.
Change-Id: I I I641f28c6af1948963f7004f8071af62e21caabb3
|
|
OOo used to use debug level this way:
0 is default for product build
1 for --enable-dbgutil
2 for environment variable debug=t, regardless of dbgutil setting
in LO these have now morphed into:
0 is default for product build
1 for environment variable debug=t
2 for --enable-dbgutil (at some intermediate stage in the past)
1 for --enable-dbgutil (today)
This has caused a lot of confusion and some things were not converted
properly, including a check in LinkTarget.mk.
Developers should use --enable-debug to get useful information,
including full debug info and assertions.
--enable-symbols is not intended for developers, but for people
who need their builds to be able to produce useful stack traces;
--enable-symbols is for example set unconditionally in the Fedora RPM
spec, and for this purpose disabling of inlining is not wanted.
It is unlikely that somebody wants symbols for only part of the build,
and consequently a different mechanism is used to set the corresponding
flags: they are set into global gb_LinkTarget_C{,XX}FLAGS.
So move the selective symbol feature back to --enable-debug.
(this substantially reverts db8df57acd601ed084bd0122683e1bd066a4f143)
|
|
GNU coding standards say that user should be able to override the build
system's default flags with CFLAGS/CXXFLAGS environment vars;
also these ended up twice on the command line due to historic accident.
|
|
|
|
so that e.g. 'make dbglevel=2' works even if --enable-symbols disabled
it for the specific target
Change-Id: If2fff3ef8e42c3b35545b5d8101ef87380412cc7
|
|
|
|
Signed-off-by: Petr Mladek <pmladek@suse.cz>
|
|
This is a partial revert of db8df57acd601ed084bd0122683e1bd066a4f143 "fixes for
debug flags handling." Removing this caused various nastinesses, at least:
* Some tinderbox started to emit bogus compiler warnings at -O2 vs. -O0, see
cf9c715aee2f97a1a6f611fe46a47e238cb03658 "Avoid bogus warnings (GCC 4.4.6)"
* General DBG_UTIL vs. OSL_DEBUG_LEVEL confusion in the code, see
729165ebacc6ff8bd1e5c936252cdace1782824b "OSL_DEBUG_LEVEL > 0 -> defined
DBG_UTIL" and a7c7942fd1946da978673d2c350630f83603d18d "DBG_UTIL vs
OSL_DEBUG_LEVEL confusion"
* --enable-dbgutil would no longer prevent -DNDEBUG (i.e., assert became
ineffective in such builds)
|
|
This somehow fell through the cracks of gbuildification -
make timelog=t now again enables those RTL_LOGFILE_ macros.
|
|
|
|
- move using optimization, symbols (i.e. debug) and environment
cflags/cxxflags into one place
- --enable-dbgutils is independent from --enable-debug, and thus
also --enable-symbols, so it should not set debuglevel
- setting -g flag is controlled by --enable-symbols, not --enable-debug,
so it should be used also for selective -g enabling
- setting debug flags depending on debuglevel being 2 is certainly wrong
- do not let environment cflags/cxxflags disable optimization/symbols flags
completely, if one wants, it's possible to explicitly specify e.g. -g0,
but the current way does not make it easily possible to specify e.g.
-fcolor-diagnostics
- do not set debug flag globally now that it can be done selectively
|
|
This brings two changes:
- no more recursive calling of make
- gbuild_simple is now not used => removed
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
tml reminds us that use a generic and potentially clash-prone word
like HEADLESS as preprocessor defintion is pretty lame.
He suggests to put it under the already used LIBO namespace.
To sum it up let's do a s/HEADLESS/LIBO_HEADLESS/g.
|
|
Define HEADLESS globally as it is meant to be.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
So drop the GVER thing and -DVCL and -DNT351.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
