summaryrefslogtreecommitdiff
path: root/solenv/gbuild
AgeCommit message (Collapse)Author
2019-04-08support for CCACHE_PCH_EXTSUMLuboš Luňák
Manpage for ccache says that hashing large PCH files may take a bit, so if CCACHE_PCH_EXTSUM is set, ccache will instead try to hash just a file named as the PCH file with .sum added. The build system is responsible for handling the file. Change-Id: I33fd04f54952d00c0f84ca364f939a86a4844fa6 Reviewed-on: https://gerrit.libreoffice.org/70380 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-04-08Use sort on finds to improve deterministic buildTomáš Chvátal
This should sort out all outputs prior processing them further resulting in equal output among multiple builds. Change-Id: Iaf24bbb94eb7b8960177bcf2c3e08d31d2fb7210 Reviewed-on: https://gerrit.libreoffice.org/70254 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-07pass all arguments to gb_LinkTarget_add_cxxobject properlyLuboš Luňák
Change-Id: Ie7469f32f08c7acf5a972dec12fa75604aa8336d Reviewed-on: https://gerrit.libreoffice.org/70368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-04-02Force UITests locale en_USMike Kaganski
... otherwise they fail e.g. on Russian locale like this: $ /opt/lo/bin/make UITest_calc_tests7 UITEST_TEST_NAME="tdf123479.tdf123479.test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken" C:/cygwin64/opt/lo/bin/make -j 12 -rs -f C:/lo/src/core2/Makefile.gbuild UITest_calc_tests7 ... [UIT] calc_tests7 ... Execution time for tdf123479.tdf123479.test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken: 3.847 tearDown: calling terminate()... ...done FAIL ====================================================================== FAIL: test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken (tdf123479.tdf123479) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:/lo/src/core2/sc/qa/uitest/calc_tests7/tdf123479.py", line 42, in test_tdf123479_Crash_ScFormulaResult_GetMatrixFormulaCellToken self.assertEqual(get_state_as_dict(edArg2)["Text"], "OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3)") AssertionError: 'OFFSET($Data.$A$2:$Data.$A$4;0;COLUMN()-3)' != 'OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3)' - OFFSET($Data.$A$2:$Data.$A$4;0;COLUMN()-3) ? ^ ^ + OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3) ? ^ ^ ---------------------------------------------------------------------- Ran 1 test in 77.822s FAILED (failures=1) Tests run: 1 Tests failed: 1 Tests errors: 0 Tests skipped: 0 Change-Id: I65a199cc3f9667b8a2d72ba09ceb68732da3ec88 Reviewed-on: https://gerrit.libreoffice.org/70127 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-22SmallButton unusedCaolán McNamara
since... commit 57ca02a7486090f1dd63977bb8fb351f9bf9a7f3 Date: Wed Apr 18 00:04:09 2018 +0200 NB Impress tabbed toolbar big update Change-Id: I7c59d5388138166851c24d1494dc3293a32f8330 Reviewed-on: https://gerrit.libreoffice.org/69537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21weld HangulHanjaConversionDialogCaolán McNamara
Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d Reviewed-on: https://gerrit.libreoffice.org/68099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-24Drop unnecessary gb_DEBUG_CFLAGSStephan Bergmann
...which was at maximum set to GCC's -finline-limit=0 -fno-inline (solenv/gbuild/platform/com_GCC_defs.mk). Those options were set for debug builds "since forever", but that looks very much like cargo cult: -fno-inline "is the default when not optimizing" anyway (<https://gcc.gnu.org/onlinedocs/gcc-7.4.0/gcc/Optimize-Options.html>), and it is unclear to me how -finline-limit=0 should have any impact beyond -fno-inline (and maybe was present for ancient compilers that only supported -finline-limit but not -fno-inline?). Change-Id: Id6752d03b1b7ec8763defabc5720d4dd08790874 Reviewed-on: https://gerrit.libreoffice.org/66836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-23Drop use of obsolete GCC -fno-default-inlineStephan Bergmann
...that is documented as: "Does nothing. Preserved for backward compatibility." ever since <https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=160384> from 2010. -fno-default-inline was the only value ever set in gb_DEBUG_CXXFLAGS, so the latter can be removed now. The use of gb_DEBUG_CXXFLAGS had accidentally already been removed from gb_LinkTarget__get_debugcxxflags with e751e24250fda31dde52b3c65ca79f86142dc789 "--enable-optimized should be orthogonal to --enable-debug/--enable-dbgutil", and that leaves gb_LinkTarget__get_debugcflags and gb_LinkTarget__get_debugcxxflags with identical definitions, so replace those two with a single gb_LinkTarget__get_debugflags. Some external modules had used only gb_DEBUG_CXXFLAGS, when this was apparently meant to be used in addition to gb_DEBUG_CFLAGS, so those uses have been changed to gb_DEBUG_CFLAGS now. Change-Id: I84ea0ab1233569b0b02ca057240a71f138352381 Reviewed-on: https://gerrit.libreoffice.org/66808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Slience bogus -Werror=maybe-uninitializedStephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized, e.g. at: > In file included from include/rtl/ustring.hxx:37, > from include/cppuhelper/factory.hxx:26, > from unoxml/source/rdf/librdf_repository.hxx:24, > from unoxml/source/rdf/librdf_repository.cxx:20: > include/rtl/string.hxx: In static member function ‘static std::shared_ptr<{anonymous}::librdf_TypeConverter::Node> {anonymous}::librdf_TypeConverter::extractNode_NoLock(const com::sun::star::uno::Reference<com::sun::star::rdf::XNode>&)’: > include/rtl/string.hxx:294:27: error: ‘*((void*)(& type)+8).rtl::OString::pData’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > rtl_string_release( pData ); > ~~~~~~~~~~~~~~~~~~^~~~~~~~~ > unoxml/source/rdf/librdf_repository.cxx:2094:30: note: ‘*((void*)(& type)+8).rtl::OString::pData’ was declared here > boost::optional<OString> type; > ^~~~ This appears to be a common pattern of false positives with uses of boost::optional, common enough to disable the warning globally for affected compilers, even if there would also be useful findings by that warning (e.g., <https://gerrit.libreoffice.org/#/c/66619/> "Fix -Werror=maybe-uninitialized"). I didn't bother to file a GCC bug for the reproducer used in configure.ac, <https://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=maybe-uninitialized> already shows lots of open bugs in that area, and the documentation at <https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Warning-Options.html> states that "GCC may not be able to determine when the code is correct in spite of appearing to have an error." (Clang appears to not support -Wmaybe-uninitialized at all, so exclude it from the configure.ac check, to not have the check's failure result in an unsupported -Wno-maybe-uninitialized end up on the compiler command line.) Change-Id: Ifb9ca4c342750eae54f7e1a01506101310484c7e Reviewed-on: https://gerrit.libreoffice.org/66621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-16Minimum Supported Version is VS2017himajin100000
Change-Id: Id771f1fe0d8c6702a52836f6229a944d259fed4c Reviewed-on: https://gerrit.libreoffice.org/66424 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-09update uitest debugging instructions to account for gtk3 backend issueNoel Grandin
e.g. when debugging UITest_writer_tests2 it gets stuck when the uitest invokes dialogs Change-Id: I8276a8d7e885be5f47309beeec1f4c3c9d12ee32 Reviewed-on: https://gerrit.libreoffice.org/66002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-31for tests MOZILLA_CERTIFICATE_FOLDER should be set to empty not 0Tomaž Vajngerl
0 means it has a value (string "0") but we check for an empty string. The end result is the same however. Change-Id: I01fed189eaf37673fdb254884c5e7382914b5211 Reviewed-on: https://gerrit.libreoffice.org/65766 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-12-29tdf#114635: reimplement TWAIN-based scan using 32-bit shim on WindowsMike Kaganski
Since TWAIN is only actually available as 32-bit component on Windows, to use it in a 64-bit program, we need a 32-bit shim program that does all actual communication with TWAIN subsystem. This change reimplements TWAIN implementation to be a separate 32-bit process. Image is transfered from the shim to main program using file mapping API. This reverts most of commit 585d9806961342e95f7318fb947bd31e9f86dee0. 64-bit LibreOffice doesn't bundle TWAIN DSM library now. TWAIN DSM source code is still used for TWAIN headers. Change-Id: I46f178ad36acd97a9eff156624b99036fcbb83f8 Reviewed-on: https://gerrit.libreoffice.org/65688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-27URL fixed. Was broken & linking to deleted page.Howard Johnson
Change-Id: Iefe842aa8ef3b183b90f896902edd8941fb1b238 Reviewed-on: https://gerrit.libreoffice.org/63967 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-21restore the UI test 'debug with two shells' instructionNoel Grandin
seems to be working for me now (and since I was the one that commented the instruction out, seems I must have had something wrong in my environment) Change-Id: Ie8e180a22d6a3dec61686cb38fd41b00f22fe5c7 Reviewed-on: https://gerrit.libreoffice.org/65492 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-17kde5: remove older kde/tde plugins, and references to thatThorsten Behrens
KDE4 is out of maintenance upstream since Nov. 2014, and binaries provided by TDF have switched to KDE5 as the official backend. Change-Id: I165465b56d3ba3a18912b203c06ae8fc6111c0c9 Reviewed-on: https://gerrit.libreoffice.org/60014 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-13Switch Android armeabi-v7a to libc++/libc++abi/libunwind tooStephan Bergmann
It had been left out in 4082a18406c18af7b4fcef7bd501c3679c3be56b "android: use unified headers and llvm-c++ STL (x86) with NDK 16" because "arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix that later". Making armeabi-v7a work with libc++ etc. required a number of changes, listed below, in this commit and in preceding ones. At least 32-bit x86 already worked with libc++ etc. prior to these changes in view mode, though it crashed in the experimental editing mode (enabled with strippedUIEditing in android/soruce/Makefile) as soon as one types in something, But it is not entirely clear to me why 32-bit x86 view mode didn't also fail similar to how I saw armeabi-v7a fail. (On 32-bit x86, these changes appear to neither improve nor worsen the current state, view mode still appears to work fine while editing still crashes upon typing anything. With these changes, editing mode on armeabi-v7a appears to work fine. But I tested armeabi-v7a only with a real device and 32-bit x86 only with an emulator, in case that might make a difference.) * Preceding <https://gerrit.libreoffice.org/#/c/64964/> "Move NSSLIBS to a more sensible place on the linker command line" plus this change's addition of -lunwind to the liblo-native-code.so linker command line make sure that liblo-native-code.so uses _Unwind_* functions from libunwind.a, instead of erroneously picking up the ones from libgcc.a that happen to be included in NSSLIB's nspr4 (-lgcc is automatically added to the end of the linker command line by the invoking compiler, that's how libgcc.a's _Unwind_* end up in NSSLIB's nspr4; it is neither clear to me why NSSLIB's nspr4, being a pure C library, uses _Unwind_* functions, nor why exception handling in liblo-native-code.so fails when using _Unwind_* functions from libgcc.a instead of from libunwind on armeabi-v7a, nor why that would work on 32-bit x86, but that's what I observed: ModuleManager::identify (framework/source/services/modulemanager.cxx) throws a css::lang::IllegalArgumentException, which calls __cxa_throw -> _Unwind_RaiseException, which ultimately lead to odd misbehavior and std::abort during stack unwinding when using _Unwind_RaiseException from libgcc.a instead of from libunwind). (There is no libunwind.* in android-ndk-r16b for 32-bit x86 at least, so is presumably using _Unwind_* functions from libgcc.a. It doesn't appear to make a difference if it indirectly uses those _Unwind_* functions from NSSLIB's nspr4, or directly from libgcc.a included in liblo-native-code.so if the $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind) had a ",-lgcc" else branch.) * Preceding <https://gerrit.libreoffice.org/#/c/64965/> "Export RTTI symbols from liblo-native-code.so, for binary UNO bridge" makes sure that excpetions thrown from the binary UNO bridge can be caught by compiled catch clauses. Not sure why the corresponding state of bridges/source/cpp_uno/gcc3_linux_intel shouldn't have run into the same issue. * Preceding <https://gerrit.libreoffice.org/#/c/64966/> "Adapt gcc3_linux_arm __cxa_exception to NDK 18 libc++abi" makes sure that our version of __cxa_exception matches the version from libc++abi. This is clearly not relevant for 32-bit x86. (The comment there android-ndk-r18b, but the additional member is already present in android-ndk-r16b/sources/cxx-stl/llvm-libc++abi/src/cxa_exception.hpp, too.) The remainder of this change just drops old armeabi-v7a--specific workarounds that are no longer needed/no longer work. Change-Id: Ief4c2d562c5032abe6c3b94ca3b3394be6fcd4d3 Reviewed-on: https://gerrit.libreoffice.org/64973 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-11tdf#121685: also apply DeclareDPIAware manifest to console applicationsMike Kaganski
There's no reason not to; and now soffice.bin itself is built as a console application. Change-Id: Iba080498b02af04780fdfe1053fb00f584eaae81 Reviewed-on: https://gerrit.libreoffice.org/64915 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-06Remove obsolete GCC version checksStephan Bergmann
...after <https://gerrit.libreoffice.org/63951> "Bump (Linux) GCC baseline to 7.0.0". (In some cases, those checks now need to check for __clang__, which was implicitly covered in the past by Clang consistently reporting to be GCC 4.2.1.) Change-Id: I860fef8c4ca41c22a7541f0fb2d34b37d1d69bed Reviewed-on: https://gerrit.libreoffice.org/63952 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-06Default all tests to run with the svp pluginJan-Marek Glogowski
Otherwise a test can already require a windowed VCL plugin by calling gb_CppunitTest_use_vcl_non_headless(_with_windows)?. For compatibility on unix --headless still implies the use of the svp plugin, but now a SAL_USE_VCLPLUGIN will override it. All the explicit SAL_USE_VCLPLUGIN=svp are not needed, as this is now included in the gb_TEST_ENV_VARS variable and gengal already calls Application::EnableConsoleOnly(). Change-Id: I6b4e75282aa88d747db87d60ffe6c8f282187c5f Reviewed-on: https://gerrit.libreoffice.org/64052 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-06Drop juh.jar dependency from Java UNO testsJan-Marek Glogowski
Since upstream Java reverted the strict classpath checks, it's not needed anymore. See discussion in https://gerrit.libreoffice.org/#/c/63118 and http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8513ac27b651 Change-Id: Iff863702b1aeda157c8e230ab36372a71dcfb4bb Todo: tdf#121925 Reviewed-on: https://gerrit.libreoffice.org/64634 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-29Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-27gbuild: MacOSX: use tr instead of sed for newlinesMichael Stahl
At least on tinderbox MacOSX-x86_64@49-TDF the sed appears to ignore the literal newline character, which is unfortunate, particularly since it worked on the Jenkins builder. Blind fix to replace this with a tr invocation that already appears to work in Zip.mk. Change-Id: I7a77e69774b050a018b12c73ddd9eff849c33a86
2018-11-26Use -filelist with macOS linkerAlyssa Ross
macOS's linker can take a -filelist argument, in place of taking the list of object files to link on the command line. This is a more limited version of "response files" as used elsewhere in the code base, and by using it we make it far less likely that a linker invocation will hit ARG_MAX. A standard LibreOffice build probably won't hit ARG_MAX on macOS just yet, but it's not far off - some LDFLAGS are enough to tip it over the edge, which is what prompted me to fix the issue. If not fixed, a few more object files will probably break LibreOffice builds on macOS! An example of another large program that has encountered this issue is Thunderbird, which implemented the same fix[1]. The changes I've made to use -filelist are adapted from the code elsewhere in gbuild that creates response files, but this is slightly different because -filelist files are a bit different - they can only contain object files, as opposed to arbitrary linker arguments, and arguments are separated by newlines rather than spaces. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=837618 Change-Id: I01b9126aad95056c3dc82f941dea4fd43f95d0f2 Reviewed-on: https://gerrit.libreoffice.org/64010 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-25Generally set CCACHE_CPP2 for --enable-werror GCCStephan Bergmann
This obsoletes <https://gerrit.libreoffice.org/plugins/gitiles/lode/+/ b82e0a9d26ef4c81046c053ff831dccfc84c56be%5E!> "For linux_gcc_release_64, don't let ccache strip comments" and fixes ccache for all builds using (recent) GCC. Change-Id: I5fd20b2565f57073c545fe5d3a9639c2c0583a74 Reviewed-on: https://gerrit.libreoffice.org/63979 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23Revert "Do use -O1 for Apple Clang older than 9.1.0"Stephan Bergmann
This reverts commit 55b9706bea5aa9b654ab39bc7d56339422e17087, which is obsoleted by b4f666f2e677b05cab8395fe7972b45b15f60c3f "Bump Xcode baseline to 9.3". Change-Id: Id2240351ed9495e311d55887b8e34f2aa776ae06 Reviewed-on: https://gerrit.libreoffice.org/63896 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22python tests: fix user config for autotext functionsThorsten Behrens
Seems that the code in SwGlossaries::GetGlosDoc() expects subdirs to exist in user config, and would otherwise fail miserably. Change-Id: I2da6bca46ae5e0d9d90bc23eb710396dbede37f4 Reviewed-on: https://gerrit.libreoffice.org/63798 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22Pass some env vars into all kinds of testsStephan Bergmann
...not only CppunitTests, as had been changed with d5ed903618f200456feed9b410b7bd1ed8daeb62 "Set CppunitTest-related env vars only during CppunitTest". Despite those env vars having been deceptively set up in solenv/gbuild/CppunitTest.mk, at least some of them may also be useful during other tests, and may actually have been relied upon by other tests in the past. Change-Id: I854dfb1786bb5e9e2de5fd77cb6323299320b544 Reviewed-on: https://gerrit.libreoffice.org/63784 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-20Set CppunitTest-related env vars only during CppunitTestStephan Bergmann
...and not for every target's recipe, once solenv/gbuild/CppunitTest.mk is included Change-Id: I710160def23fae5f93c5a67ab25e03fdaa008e00 Reviewed-on: https://gerrit.libreoffice.org/63655 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-20Drop some headless mode variantsJan-Marek Glogowski
This fixes OSX "make debugrun" by dropping VCL_HIDE_WINDOWS handling and removing the internal GetPseudoHeadless() API. While at it moves the DialogCancelMode enum out of Application. Change-Id: I4876e752ddbfc39dd44faa673fb0e97810089a75 Reviewed-on: https://gerrit.libreoffice.org/61598 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-15Use C locale in UITestStephan Bergmann
b96180cb9bbec90b0faaf61c78c71bd4f6499e40 "uitest: set en_US.UTF8 for the LibreOffice instance" had made UITest use the en_US.UTF-8 locale (passed from LIBO_LANG to LC_ALL when starting soffice in uitest/libreoffice/connection.py), for unstated reasons. The mail sub-thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-October/081318.html> "Re: master build problems with en_US.utf8 locale" now argues that support for an en_US.UTF-8 locale in the OS should not be necessary when building LO. While absence of OS-support for en_US.UTF-8 apparently doesn't break the UITests (see <https://lists.freedesktop.org/archives/libreoffice/2018-November/081375.html> "Re: master build problems with en_US.utf8 locale"), it feels better to make these tests not use the en_US.UTF-8 locale at all. At least for me, the tests ran fine when using the C locale instead. Change-Id: I23eb2ce540bb40a7b7d13c2a396e313966f03f6e Reviewed-on: https://gerrit.libreoffice.org/63360 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-14Prepare gb_AllLangHelp_add_helpfiles for special bookmark needsStephan Bergmann
...where (according to a request by buovjaga) in instdir/help/*/bookmarks.js, lines mentioning "/shared/explorer/database/" should appear with app:"BASE" instead of app:"SHARED". That change will come in a follow-up commit to the helpcontent2 repo. Change-Id: I7c99e5f89e001d1e507f283d16e2ee264f3ab33a Reviewed-on: https://gerrit.libreoffice.org/63364 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-09Fix many Java subsequentcheck test by using JUHJan-Marek Glogowski
Splits gb_JunitTest_set_unoapi_test_class_and_jars into two separate defines as: - gb_JunitTest_use_unoapi_jars - gb_JunitTest_use_unoapi_test_class Then replaces many of the gb_JunitTest_use_jars lists with the new gb_JunitTest_use_unoapi_jars to fix the JUH dependencies. This probably adds some unneeded JUH dependencies to some Java tests, but that shouldn't be a problem. Change-Id: I0c4fce6b50f7c6eb8d62bfb2c50f056b97584794 Reviewed-on: https://gerrit.libreoffice.org/63119 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-09Simplify and fix Java UNO API test makefilesJan-Marek Glogowski
Originally I just wanted to add the juh.jar to the list of jars of the UNO API tests, but this became tedious work, so after the first few files I decided to replace the similiar makefiles with a common define for the *_unoapi* tests. This patch adds two new make defines to be used used by Java UNO and UNO API tests: - gb_JunitTest_set_unoapi_test_defaults - gb_JunitTest_set_unoapi_test_class_and_jars The first one will deduce most defaults from the test name, but still allows to optionally override most settings. If a test doesn't match the default at all, the 2nd define still shares the common jar files and the main Java UNO class, so the second define adds these to your makefile. The real fix is to add juh.jar to gb_JunitTest_use_jars. Change-Id: I4342fdac5e31f85ea18fb4268e13c287a7adc2b7 Reviewed-on: https://gerrit.libreoffice.org/63118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-01gbuild: rename value OS=IOS to OS=iOSMichael Stahl
This gets rid of the horrible hack in gbuild.mk to accomodate the case-incorrect iOS platform makefiles that cannot be renamed without upsetting git on file systems that sadly lack the case sensitivity feature. Keep the macro defined to IOS though. Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234 Reviewed-on: https://gerrit.libreoffice.org/62705 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-25avoid running into commandline length limits on win with all-lang helpChristian Lohmaier
also simplify the recipe by removing the one-time-use only calls to helper commands Unclear though why help adds the lang-dirs individually, as all come from the same subdir and end up in the same target dir... Change-Id: I489b1ac3f1312a565fb2a9cfc071d94201c74555 Reviewed-on: https://gerrit.libreoffice.org/62304 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-11Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski
Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-04Missing CppunitTest dependencies on new macOS/Windows vclplug backendsStephan Bergmann
...after 1698debed2993fc5f262aa3ebbdb32fc112ac556 "Implement Windows VCL backend as plugin" and 3af4e1a0825c5b11ae4ef58fc411378aab669387 "Implement MacOSX VCL backend as plugin". (On these platforms, the tests apparently call into the respective vclplug backend code regardless of whether the test is "headless" or not.) Change-Id: I6d93eacd9f94047add94ba3e866e6be1eb35c879 Reviewed-on: https://gerrit.libreoffice.org/61376 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-01Change all font-based tests to depend on ooo_fontsJan-Marek Glogowski
Instead of depending on individual font packages. Most didn't depend on fonts at all. Change-Id: I190295bbecb1b44aa34aaf0874afadd35b5daeb4 Reviewed-on: https://gerrit.libreoffice.org/61159 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-12No more use of MACOSX_SDK_VERSION outside configure.acStephan Bergmann
...after <https://gerrit.libreoffice.org/60376> "Remove Library_avmediaQuickTime, which is dead" and <https://gerrit.libreoffice.org/60377> "Remove MACOSX_SDK_VERSION < 101200 code, which is dead". (This commit can be reverted if MACOSX_SDK_VERSION ever needs to be used again in makefiles or source code.) Change-Id: Iaff300d325e357f96c329cc84b3b37d91863d4b0 Reviewed-on: https://gerrit.libreoffice.org/60378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-09gbuildtojson ide-integration: unblacklist most of modulesMike Kaganski
This unblacklistes following modules: connectivity compilerplugins dictionaries bridges helpcompiler helpcontent2 icon-themes javaunohelper lingucomponent odk solenv stoc translations udkapi unoidl Change-Id: I482f4256dd72bea1ed4a370aca41e0bd1829961c Reviewed-on: https://gerrit.libreoffice.org/60213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-09gbuild: record UITest as wellMichael Stahl
This will rr record the python process of the UITest as well if RR=1 is set. Change-Id: Id0955511fa5a25795ab4bfe1b96b0b403c07ea8d Reviewed-on: https://gerrit.libreoffice.org/60167 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-07improve help message for uitest failureNoel Grandin
Change-Id: I7213ee2ca55ddc1a11c4f411d3b72f1b2382f7e7
2018-09-07DeInitVCL in PythonTestStephan Bergmann
After b9757f5cfdb62b24e79eeb4c0ef0c8b98056cecf "loplugin:useuniqueptr in vcl/svdata" ASan/UBSan builds started to fail (like <https://ci.libreoffice.org//job/lo_ubsan/1025/>) at the end of PythonTest_dbaccess_python (and probably other PythonTests), when during exit the static utl::ConfigManager instance already happens to be destroyed by the time the static ImplSVData's mpSettingsConfigItem is destroyed (which would normally be cleared during DeInitVCL, if PythonTests would call that, and which in the past had thus simply been leaked in PythonTests when that mpSettingsConfigItem was a plain pointer instead of std::unique_ptr). So ensure that PythonTests that initialize VCL also call DeInitVCL, via a new private_deinitTestEnvironment, complementing the existing private_initTestEnvironment. However, while private_initTestEnvironment is called once (typically via UnoInProcess.setUp, which internally makes sure to only call it once) as soon as the first executed test needs it, private_deinitTestEnvironment must be called once after the lasts test needing it has executed. The only way that I found to do that is to override unittest.TextTestResult's stopTestRun method, which is called once after all tests have been executed. Hence a new test runner setup in unotest/source/python/org/libreoffice/unittest.py that is now called from solenv/gbuild/PythonTest.mk. That revealed a few places in PythonTests that didn't yet close/delete documents that they had opened, which has now been added. One remaining problem then is that classes like SwXTextDocument and friends call Application::GetSolarMutex from their dtors, via sw::UnoImplPtrDeleter (a "Smart pointer class ensuring that the pointed object is deleted with a locked SolarMutex", sw/inc/unobaseclass.hxx). That means that any PyUNO proxies to such C++ objects that remain alive after private_deinitTestEnvironment will cause issues at exit, when Python does a final garbage collection of those objects. The ultimate fix will be to remove that unhelpful UnoImplPtrDeleter and its locking of SolarMutex from the dtors of UNO objects; until then, the Python code is now sprinkled with some HACKs to make sure all those PyUNO proxies are released in a timely fashion (see the comment in unotest/source/python/org/libreoffice/unittest.py for details). (Also, it would probably help if UnoInProcess didn't keep a local self.xDoc around referencing (just) the last result of calling one of its open* methods, confusingly making it the responsibility of UnoInProcess to close that one document while making it the responsibility of the test code making the other UnoInProcess.open* calls to close any other documents.) Change-Id: Ief27c81e2b763e9be20cbf3234b68924315f13be Reviewed-on: https://gerrit.libreoffice.org/60100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-05gbuild: allow recording of CppunitTests and PythonTests tooMichael Stahl
Since these don't use soffice they need to be tweaked to use RR variable. A rr git master build from some weeks ago can record all tests, except CppunitTest_dbaccess_firebird_test which fails. smoketest is a bit tricky because it spawns soffice which checks RR variable again and starts a nested rr, but fortunately there's a flag to prevent it from aborting in this situation. For UITests currently only the soffice.bin is recorded, not the python test process. The size of all the recording is about 35G per run in a --enable-dbgutil build. Change-Id: I2143618fa2181e36b6aaeded43637cb3481f5e47 Reviewed-on: https://gerrit.libreoffice.org/60032 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-05Already set MSVC's -std:c++17 during the configure.ac feature checksStephan Bergmann
For cl version 19.15.26726 (VS 2017 15.8.1) that would detect HAVE_CPP_GUARANTEED_COPY_ELISION, but wrongly so as it turns out. :( The compiler has C++20's __cpp_guaranteed_copy_elision feature-test macro defined (and <https://en.cppreference.com/w/cpp/compiler_support> claims that C++17 "Guaranteed copy elision" is supported in "MSVC 19.13", aka VS 2017 15.6). But the build then failed at > [build CXX] sw/source/uibase/app/docsh2.cxx [...] > C:/lo/core/sw/source/uibase/app/docsh2.cxx(427): error C2248: 'editeng::SortedAutoCompleteStrings::SortedAutoCompleteStrings': cannot access private member declared in class 'editeng::SortedAutoCompleteStrings' > C:\lo\core\include\editeng/swafopt.hxx(66): note: see declaration of 'editeng::SortedAutoCompleteStrings::SortedAutoCompleteStrings' > C:\lo\core\include\editeng/swafopt.hxx(55): note: see declaration of 'editeng::SortedAutoCompleteStrings' due to enabling the HAVE_CPP_GUARANTEED_COPY_ELISION-conditional code in include/editeng/swafopt.hxx. (And while my VS 15.8.1 stopped detecting HAVE_CPP_GUARANTEED_COPY_ELISION then, <https://ci.libreoffice.org/job/gerrit_windows/14774/>, reportedly done with 15.7.4 aka 15.7.27703.2035, still mis-detected it and then failed at sw/source/uibase/app/docsh2.cxx(427) as above, so needed a tweak to the check in configure.ac.) Change-Id: Ie14d74f3f795d819047deaafdb1e644ed00ee406 Reviewed-on: https://gerrit.libreoffice.org/59835 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-05Workaround for file name case inconsistencyTor Lillqvist
Change-Id: Ia13dc01f86e51064658d5ad9a996c6bd555cbeef
2018-08-31Make --enable-assert-always-abort orthogonal of --enable-debug/dbgutilStephan Bergmann
(and keep enabled by default iff --enable-debug/dbgutil) Change-Id: I962230b4c6623220603cb713c787c69274f63a8f Reviewed-on: https://gerrit.libreoffice.org/59859 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-29Various Haiku improvementsKacper Kasper
* Fix make distro-pack-install. * Remove Xorg dependency. * Remove stack protector workaround. * Update distro-config and enabled features. Change-Id: I273dc8343ad84bd77b86453cc01ff427b50ea0b5 Reviewed-on: https://gerrit.libreoffice.org/58634 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-27rename ENABLE_HEADLESS option to DISABLE_GUINoel Grandin
since it has nothing to do with the headless command line option, so use the name it has in the configure.ac file Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70 Reviewed-on: https://gerrit.libreoffice.org/59611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-08 18:38:53 +0000