summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2018-10-07move com_sun_star_comp_Writer_RtfExport_get_implementation to writerCaolán McNamara
Change-Id: I039d416adc23722740125c5f0845e79c47505f03 Reviewed-on: https://gerrit.libreoffice.org/61503 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06make scrollabledialog.hxx a private headerCaolán McNamara
Change-Id: I16c68436c35568867677c33f70ef48287bc9e8ac Reviewed-on: https://gerrit.libreoffice.org/61470 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06Add GlyphCache instance to GenericUnixSalDataJan-Marek Glogowski
This gets rid of some statics and drops some duplicate code: - the X11 based GlyphCache => gone - the svp version of the GlyphCache => gone - the "normal" GlyphCache - the PrintFontManager And while at it move the implementation into its own file gendata.cxx. Change-Id: I9063139c9482f5f37285505f389cf5f32c02426b Reviewed-on: https://gerrit.libreoffice.org/61454 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-05sw: create RtfExport instances with an uno constructorMiklos Vajna
Change-Id: I08cbfa2b9ccc7bc1c5d1ebeb9e06238472b2fa26 Reviewed-on: https://gerrit.libreoffice.org/61393 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-04Missing CppunitTest dependencies on new macOS/Windows vclplug backendsStephan Bergmann
...after 1698debed2993fc5f262aa3ebbdb32fc112ac556 "Implement Windows VCL backend as plugin" and 3af4e1a0825c5b11ae4ef58fc411378aab669387 "Implement MacOSX VCL backend as plugin". (On these platforms, the tests apparently call into the respective vclplug backend code regardless of whether the test is "headless" or not.) Change-Id: I6d93eacd9f94047add94ba3e866e6be1eb35c879 Reviewed-on: https://gerrit.libreoffice.org/61376 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-03tdf#72987 split firebird test into a regression test and a "new" testRene Engelhard
former with endianness and latter with the new fbk format. Add new endianness-independent firebird test odbs Change-Id: I29be2e6916fcca74744211dba04463376fb6b8d5 Reviewed-on: https://gerrit.libreoffice.org/60917 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02sd a11y: fix dozen of missing mnemonicsKatarina Behrens
Change-Id: Ie0a7f85624da2ef2cd60fe7e074fa98cf64e779e Reviewed-on: https://gerrit.libreoffice.org/61179 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-02Unify sal plugin loadersJan-Marek Glogowski
Change-Id: Ic099761eaff80349e985ccf62e3f4aa6b2e98022 Reviewed-on: https://gerrit.libreoffice.org/61103 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Implement MacOSX VCL backend as pluginJan-Marek Glogowski
Change-Id: Ie90af62eff146064c3b066a8f7ca1c3a69f44c39 Reviewed-on: https://gerrit.libreoffice.org/61102 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Implement Windows VCL backend as pluginJan-Marek Glogowski
Change-Id: If9c7c67f48311ac68ecc9f8e3a07f9bb7c73d962 Reviewed-on: https://gerrit.libreoffice.org/61101 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-01weld SvxLineTabPageCaolán McNamara
Change-Id: I91d7ec8a51ce935db40c57feeeed7b160cf4dad8 Reviewed-on: https://gerrit.libreoffice.org/61172 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01Change all font-based tests to depend on ooo_fontsJan-Marek Glogowski
Instead of depending on individual font packages. Most didn't depend on fonts at all. Change-Id: I190295bbecb1b44aa34aaf0874afadd35b5daeb4 Reviewed-on: https://gerrit.libreoffice.org/61159 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-30weld SvxLineDefTabPageCaolán McNamara
Change-Id: I7a7f421190c89cec8e1a772015b7544d60b26298 Reviewed-on: https://gerrit.libreoffice.org/61158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28Revert "Personas: add 6 themes to the selection dialog"Muhammet Kara
This reverts commit 9927a3ab9edec7ae9f41ecaa8025a2a920321997. Change-Id: I7282bb5734c4cad2cf2d375d4a6bfc03a759ce19 Reviewed-on: https://gerrit.libreoffice.org/61055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-28oox: create ShapeContextHandler instances with an uno constructorMiklos Vajna
Change-Id: Ie780ff9f3a8c61d13ad10cc2dbe24d3ec165470e Reviewed-on: https://gerrit.libreoffice.org/61063 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-28Fix TRANPARENT -> TRANSPARENTAndrea Gelmini
It passed "make check" on Linux. Change-Id: I70ccaae61eb7961a331cabcd8f4e56b5ea5dfc4c Reviewed-on: https://gerrit.libreoffice.org/61045 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28Fix typoAndrea Gelmini
Change-Id: I1493733ebbe796e4ba3ec6f2dc69b4b91f79efdf Reviewed-on: https://gerrit.libreoffice.org/61027 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27printdialog: fix some accessibility warningsSamuel Thibault
Change-Id: Icf508473d194bc8c6f01e551b6659a625b8ee229 Reviewed-on: https://gerrit.libreoffice.org/60141 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-24Personas: add 6 themes to the selection dialogandreas kainz
Change-Id: I1e8c28f477602c7578ca7e40bd7d14550dc1aaf8 Reviewed-on: https://gerrit.libreoffice.org/60930 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-20weld SvxHyphenWordDialogCaolán McNamara
Change-Id: If92d57c5c807a7fc04fe66a748aa385c558be664 Reviewed-on: https://gerrit.libreoffice.org/60774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld BreakPointDialogCaolán McNamara
Change-Id: Icecef8b0b939c5d87bdf1bb781731df8fc4419b5 Reviewed-on: https://gerrit.libreoffice.org/60756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld SmFontDialogCaolán McNamara
Change-Id: Id253631e7dfd44570a4261b7a7a5db1fac9d68ba Reviewed-on: https://gerrit.libreoffice.org/60728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18weld SvxTabulatorTabPageCaolán McNamara
Change-Id: Ife45f59e63309046e532fcb4377e66a887d11f34 Reviewed-on: https://gerrit.libreoffice.org/60504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18weld SvxMeasurePageCaolán McNamara
Change-Id: I08f177d74aff278c62f76e32a1401ff24f249c57 Reviewed-on: https://gerrit.libreoffice.org/60589 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17compilerplugins/clang/test/constfields doesn't work for clang-clStephan Bergmann
...because loplugin:constfields is wrapped in #if !defined _WIN32 //TODO, #include <sys/file.h> Change-Id: I9b2a72ecd31f561c71be5a74a752344c24d40f26 Reviewed-on: https://gerrit.libreoffice.org/60598 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17weld SvxBackgroundTabPageCaolán McNamara
Change-Id: I7b80ba0b2c85b191d5a7bec44d22293eb772d925 Reviewed-on: https://gerrit.libreoffice.org/60575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17Natvis: add boost::optionalMike Kaganski
Change-Id: I64c5ff89bedcee0d955e4aa12035302e413d0c02 Reviewed-on: https://gerrit.libreoffice.org/60567 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17tdf#119897: "Version " prefix is optionalMike Kaganski
Hopefully this fixes the problem, which is being incorrect version written for the font in MSI (1.0.0.0), and comparing with installed one (1.3), the font is removed and not reinstalled. Change-Id: Iee675e2c2b3f29c76e35dcf41bbcce9b6181bf62 Reviewed-on: https://gerrit.libreoffice.org/60548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-16rename conststringfield loplugin to staticconstfieldNoel Grandin
in preparation for making it more general Change-Id: I2fc8d0f99140dc7ef72341f8cbf28d6536ebd61f Reviewed-on: https://gerrit.libreoffice.org/60525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14weld SvxCharNamePageCaolán McNamara
Change-Id: Ia54a5ac4fe4a11b7c03508c336193bb52c616e7f
2018-09-13new loplugin simplifyconstructNoel Grandin
no need to init smart pointers with nullptr, they all have default constructors that do this already Change-Id: Ief20c060daa0def8c1aa82f1cf8dc4bc696761e9 Reviewed-on: https://gerrit.libreoffice.org/59818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-13new loplugin:constfieldsNoel Grandin
look for fields which are only assigned to in the constructor, so they can be made const Change-Id: I0b76817c2181227b04f6a29d6a808f5e31999765 Reviewed-on: https://gerrit.libreoffice.org/60393 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12No more use of MACOSX_SDK_VERSION outside configure.acStephan Bergmann
...after <https://gerrit.libreoffice.org/60376> "Remove Library_avmediaQuickTime, which is dead" and <https://gerrit.libreoffice.org/60377> "Remove MACOSX_SDK_VERSION < 101200 code, which is dead". (This commit can be reverted if MACOSX_SDK_VERSION ever needs to be used again in makefiles or source code.) Change-Id: Iaff300d325e357f96c329cc84b3b37d91863d4b0 Reviewed-on: https://gerrit.libreoffice.org/60378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-11WIN drop unused fpicker subdirsJan-Marek Glogowski
While the folder picker had some shared code with the file picker, the folder hierarchy made some sense, but since it's gone now, move the files to the base directory. Change-Id: Ib78ada9cdb570df64ccbc28da835cfcaf25009db Reviewed-on: https://gerrit.libreoffice.org/60145 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-10a11y: Remove unused warningsKatarina Behrens
since commit 1188bebbc53d0519733cfe98cfab4d83474e8ddf tdf#118742 - Input field dialog workflow Change-Id: Ied80dca50222de8dfea93d4d4fbee74c5255943c Reviewed-on: https://gerrit.libreoffice.org/60248 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-10a11y: Fix multiple instances of duplicate mnemonicsKatarina Behrens
Change-Id: I0ffe2a7c6b8102aa977af16232ce930541a8b816 Reviewed-on: https://gerrit.libreoffice.org/60246 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-09weld SvxShadowTabPageCaolán McNamara
Change-Id: I5447641216c8cba3d275d76c00bf7306df8acf19 Reviewed-on: https://gerrit.libreoffice.org/60221 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09gbuildtojson ide-integration: unblacklist most of modulesMike Kaganski
This unblacklistes following modules: connectivity compilerplugins dictionaries bridges helpcompiler helpcontent2 icon-themes javaunohelper lingucomponent odk solenv stoc translations udkapi unoidl Change-Id: I482f4256dd72bea1ed4a370aca41e0bd1829961c Reviewed-on: https://gerrit.libreoffice.org/60213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-09gbuild: record UITest as wellMichael Stahl
This will rr record the python process of the UITest as well if RR=1 is set. Change-Id: Id0955511fa5a25795ab4bfe1b96b0b403c07ea8d Reviewed-on: https://gerrit.libreoffice.org/60167 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-09weld SfxNewStyleDlgCaolán McNamara
set some parents and replace VclComboBoxText with an entry and a treeview Change-Id: Ied75176355f23c986eac4d5de8654472a15dbbbf Reviewed-on: https://gerrit.libreoffice.org/52517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07improve help message for uitest failureNoel Grandin
Change-Id: I7213ee2ca55ddc1a11c4f411d3b72f1b2382f7e7
2018-09-07oox: create PowerPointImport instances with an uno constructorMiklos Vajna
PowerPointImport_getSupportedServiceNames() was copy&pasted from oox::core::FilterBase::getSupportedServiceNames(), so it can go away entirely. Change-Id: Ia6352cea1c2d65ba94cae66b500de951d82f455a Reviewed-on: https://gerrit.libreoffice.org/60124 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-07DeInitVCL in PythonTestStephan Bergmann
After b9757f5cfdb62b24e79eeb4c0ef0c8b98056cecf "loplugin:useuniqueptr in vcl/svdata" ASan/UBSan builds started to fail (like <https://ci.libreoffice.org//job/lo_ubsan/1025/>) at the end of PythonTest_dbaccess_python (and probably other PythonTests), when during exit the static utl::ConfigManager instance already happens to be destroyed by the time the static ImplSVData's mpSettingsConfigItem is destroyed (which would normally be cleared during DeInitVCL, if PythonTests would call that, and which in the past had thus simply been leaked in PythonTests when that mpSettingsConfigItem was a plain pointer instead of std::unique_ptr). So ensure that PythonTests that initialize VCL also call DeInitVCL, via a new private_deinitTestEnvironment, complementing the existing private_initTestEnvironment. However, while private_initTestEnvironment is called once (typically via UnoInProcess.setUp, which internally makes sure to only call it once) as soon as the first executed test needs it, private_deinitTestEnvironment must be called once after the lasts test needing it has executed. The only way that I found to do that is to override unittest.TextTestResult's stopTestRun method, which is called once after all tests have been executed. Hence a new test runner setup in unotest/source/python/org/libreoffice/unittest.py that is now called from solenv/gbuild/PythonTest.mk. That revealed a few places in PythonTests that didn't yet close/delete documents that they had opened, which has now been added. One remaining problem then is that classes like SwXTextDocument and friends call Application::GetSolarMutex from their dtors, via sw::UnoImplPtrDeleter (a "Smart pointer class ensuring that the pointed object is deleted with a locked SolarMutex", sw/inc/unobaseclass.hxx). That means that any PyUNO proxies to such C++ objects that remain alive after private_deinitTestEnvironment will cause issues at exit, when Python does a final garbage collection of those objects. The ultimate fix will be to remove that unhelpful UnoImplPtrDeleter and its locking of SolarMutex from the dtors of UNO objects; until then, the Python code is now sprinkled with some HACKs to make sure all those PyUNO proxies are released in a timely fashion (see the comment in unotest/source/python/org/libreoffice/unittest.py for details). (Also, it would probably help if UnoInProcess didn't keep a local self.xDoc around referencing (just) the last result of calling one of its open* methods, confusingly making it the responsibility of UnoInProcess to close that one document while making it the responsibility of the test code making the other UnoInProcess.open* calls to close any other documents.) Change-Id: Ief27c81e2b763e9be20cbf3234b68924315f13be Reviewed-on: https://gerrit.libreoffice.org/60100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-06weld SwColumnPage and SwColumnDialogCaolán McNamara
Change-Id: Ia649785047db2551044b4d765881309f83b5c838 Reviewed-on: https://gerrit.libreoffice.org/60044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06sc header-footer dlg: Suppress false-positive warningSamuel Thibault
labelFT_H_DEFINED and labelFT_F_DEFINED are indeed two labels for the same widget, and only one appears at the same time. Change-Id: Ie8c29a43408d1ee29f15c686af906359ef3c50b9 Reviewed-on: https://gerrit.libreoffice.org/60046 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-06sc [tz]test dlg: fix duplicate mnemonic labelKatarina Behrens
Change-Id: Ibf2780a2eb658f7210cb5e80cf2b8e2e65fe1bda Reviewed-on: https://gerrit.libreoffice.org/59979 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-06sc random number gen dlg: fix some a11y issuesKatarina Behrens
Change-Id: I04c31c96538cb7da07e6bf2e43e6150f04f9d247 Reviewed-on: https://gerrit.libreoffice.org/59978 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-05gbuild: allow recording of CppunitTests and PythonTests tooMichael Stahl
Since these don't use soffice they need to be tweaked to use RR variable. A rr git master build from some weeks ago can record all tests, except CppunitTest_dbaccess_firebird_test which fails. smoketest is a bit tricky because it spawns soffice which checks RR variable again and starts a nested rr, but fortunately there's a flag to prevent it from aborting in this situation. For UITests currently only the soffice.bin is recorded, not the python test process. The size of all the recording is about 35G per run in a --enable-dbgutil build. Change-Id: I2143618fa2181e36b6aaeded43637cb3481f5e47 Reviewed-on: https://gerrit.libreoffice.org/60032 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit (git 2.34.1) at 2024-08-18 15:49:04 +0000