summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2019-03-12make (some) clang plugins share the same RecursiveASTVisitorLuboš Luňák
Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all. This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin. The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it. Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-11weld ScRetypePassDlgCaolán McNamara
Change-Id: I50c9ce27e7a5e469423d2d23e45038b73983fec5 Reviewed-on: https://gerrit.libreoffice.org/69045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11weld SvxMenuConfigPage/SvxToolbarConfigPageCaolán McNamara
Change-Id: I166ac6c0be8461ea38db711796d1e14fc5b78998 Reviewed-on: https://gerrit.libreoffice.org/68889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-09sc/qa/extras: enable clang-formatJens Carl
Accidentally formatted some files, and decided to keep them formatted then revert everything. Change-Id: I8e3127fc1e255dfe95ba0736d9cabeeede17ae24 Reviewed-on: https://gerrit.libreoffice.org/68950 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05weld SfxAcceleratorConfigPageCaolán McNamara
fixes a leak in the KeyList too Change-Id: I603218ff99481bc006df329c770ea6fe6f147483 Reviewed-on: https://gerrit.libreoffice.org/68694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-03weld SvxMacroAssignDlgCaolán McNamara
and SvxEventConfigPage, SvxMacroTabPage_, SvxMacroTabPage Change-Id: I98a2e71794f098015927dc7cd7ec4e258f56e703 Reviewed-on: https://gerrit.libreoffice.org/68649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02weld SwInsertAbstractDlgCaolán McNamara
Change-Id: Ib3e9d0a7ff7e0fd3b0cf7bf492ca2bf59788fa2a Reviewed-on: https://gerrit.libreoffice.org/68594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01weld CuiAboutConfigValueDialogCaolán McNamara
Change-Id: I91f5fb2bcd7eb365214278d9683d71c78ad45617 Reviewed-on: https://gerrit.libreoffice.org/68547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01clang-format DispatchHelperSamuel Mehrbrodt
To reduce excessive whitespace in function definitons Change-Id: I8dbf58e5ba53ddcf6c5a8e212636c1306584aa2e Reviewed-on: https://gerrit.libreoffice.org/68533 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-01weld SwAddressListDialogCaolán McNamara
Change-Id: I0a62f2c03b5c8acef9d4231be1a1d5f0b83e81fb Reviewed-on: https://gerrit.libreoffice.org/68501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-01test: enable clang-format for xnamecontainerJens Carl
Unintentionally formatted these files with commit 4b98337699e5e59a543d95c73ea7c64b3d9a1caf with my Vim set up (better keep them formatted then revert everything). Change-Id: Ie017fae2bdf952a5d0313d8b5654813ff8d402ad Reviewed-on: https://gerrit.libreoffice.org/68476 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-26loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-25Drop include/o3tl/make_unique.hxxGabor Kelemen
In favor of std::make_unique Change-Id: I0428076a10fb7b61c5add994c9970661b375b82c Reviewed-on: https://gerrit.libreoffice.org/68254 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25Speed up languagepack installationMichael Schroeder
Reorder the order the filelists are initialized per package. Optimize speed of find_files_for_package: We can simply check if the modules entry is the same as last time. The code uses iterators instead of that C-ish for loops. Create a hash from the packagemodules to speed up the check if a module is included in the hash. Change-Id: I1e8ae394634a527880e08ef8ff333d94d04f49fd Before: 12s per language/package After: <1s per language/package Reviewed-on: https://gerrit.libreoffice.org/68339 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
2019-02-22weld SvxScriptOrgDialogCaolán McNamara
Change-Id: Ic196887e963bb96f330e47a7a507c143f95e7a61 Reviewed-on: https://gerrit.libreoffice.org/68204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21xmloff: create XMLImpressContentExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I75301ca29794dd42a966faa36add3078c8c55211 Reviewed-on: https://gerrit.libreoffice.org/68166 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-21weld HangulHanjaConversionDialogCaolán McNamara
Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d Reviewed-on: https://gerrit.libreoffice.org/68099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17weld HangulHanjaEditDictDialogCaolán McNamara
Change-Id: If0d49a65735b66eaa8db11686099ed29b01711c4 Reviewed-on: https://gerrit.libreoffice.org/67929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-16drop newly unused codeCaolán McNamara
drop now unused ListBoxWrapper Change-Id: I19271de67269a9e23cf889a32910405cf3dc7a2a drop unused SingleControlWrapper Change-Id: I80bd639a9d64a1b35249c1c59c1c9d134ae6f1ca drop unused PosValueMapper Change-Id: I5e3d9ed48b5f544215ae82ba7899a62be4e59a25 drop unused ControlWrapperBase Change-Id: I1890f492604ac848775e8d4b0070a3189a719a18 drop now empty itemconnect.cxx Change-Id: I5374dbf91dbe715a563e7c694c9d96fb07d8f9c8 drop unnecessary controlwrapper.hxx Change-Id: Ide633f64ca2851aee4f29a7f86e09cb78043d388 Reviewed-on: https://gerrit.libreoffice.org/67887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPFunctionDlgCaolán McNamara
Change-Id: I49428a9e6cd07a962c55939477f8408822170590 Reviewed-on: https://gerrit.libreoffice.org/67881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPDateGroupDlgCaolán McNamara
adding a weld::Calendar and a pretty menubutton to access it, sidestepping the difficulty of abusing a spinbutton to select a date. The prettiness is wasted on this hard to find obscure dialog Change-Id: I51d461fe0220f947c106d96965e6422b4b26575b Reviewed-on: https://gerrit.libreoffice.org/67863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15move Calendar to vcl and map to GtkCalendarCaolán McNamara
Change-Id: I1784d4d69c6c069ef1b0ad6412e83e6a0b1db12a Reviewed-on: https://gerrit.libreoffice.org/67840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15xmloff: create XMLImpressStylesExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I831321bcce241bc180e22b20364137f776fee0f9 Reviewed-on: https://gerrit.libreoffice.org/67847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-15Format anchor.cxx with clang-formatSamuel Mehrbrodt
It has nearly correct formatting already, lets keep that. Change-Id: I0b3b7baf69655cb3241ba039b181b0d8262a3f55 Reviewed-on: https://gerrit.libreoffice.org/67845 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-14weld ScDPNumGroupDlgCaolán McNamara
Change-Id: I5f5861a1f39307133f4c87e4d5ca50ced24409ba Reviewed-on: https://gerrit.libreoffice.org/67813 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14move pngwrite/pngread to vcl/filter/pngTomaž Vajngerl
Change-Id: Ib6bf092854208eea5257c357850213815639968c Reviewed-on: https://gerrit.libreoffice.org/67821 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13weld CertificateViewer clusterCaolán McNamara
CertificateViewer, CertificateViewerGeneralTP, CertificateViewerDetailsTP, CertificateViewerCertPathTP Change-Id: I5792b673f17b3cd465ff17444776066139877ec1 Reviewed-on: https://gerrit.libreoffice.org/67756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-13Move desktop-file-edit calls to assemble-flatpak.shStephan Bergmann
(and fix one comment) Change-Id: I1e2e72427b6021194b2010535e01b9ca69e4a029 Reviewed-on: https://gerrit.libreoffice.org/67760 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-13Make loplugin:stringconcat more robustStephan Bergmann
Change-Id: Ib8adefd90141007c0422b4c15ba9c2cc5f707f3f Reviewed-on: https://gerrit.libreoffice.org/67762 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-13Merge in Flatpak improvementsStephan Bergmann
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>: commit ab8032d1e660db5e77ec7b64ac1d02e27941dfc5 Merge: d1aa013 42b6543 Author: stbergmann <sbergman@redhat.com> Date: Wed Feb 13 10:01:33 2019 +0100 Merge pull request #73 from flathub/fix-quoting fix quoting commit 42b6543ee833e5610465118bbea310ab87807d48 Author: Stephan Bergmann <sbergman@redhat.com> Date: Tue Feb 12 16:34:08 2019 +0100 fix quoting commit d1aa013fb631191174f6eb4d390ad5ea0b68a053 Merge: 35de93f dd48ab6 Author: stbergmann <sbergman@redhat.com> Date: Tue Feb 12 10:33:21 2019 +0100 Merge pull request #69 from flathub/dotty-app-IDs rename sub-app .desktop files so they are strict sub-IDs commit dd48ab67b00859a36c3f40a08112afb6078deecc Author: Robert McQueen <rob@endlessm.com> Date: Fri Jun 1 12:27:05 2018 +0100 rename sub-app .desktop files so they are strict sub-IDs The org.libreoffice.LibreOffice-foo names are not actually sub-IDs of org.libreoffice.LibreOffice which means that Flatpak will not export the additional components in the appstream. Change the - to . so that the sub-apps are correctly within the org.libreoffice.LibreOffice namespace rather than a mere prefix match. Set the X-Flatpak-RenamedFrom list in the .desktop files to include both the original upstream names and the - delimited old IDs that we used previous in the Flatpak. https://github.com/flathub/org.libreoffice.LibreOffice/issues/36 Change-Id: Ida8d5dc8ea38362f77ffb0cf58d3c998b69bd587 Reviewed-on: https://gerrit.libreoffice.org/67737 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-12makeSvTabListBox is gone nowTor Lillqvist
Change-Id: Idc42c0649279cb710ca1dbf1a9a67da4d006c735
2019-02-12weld ScSolverOptionsDialogCaolán McNamara
Change-Id: I940fe1c5b4edf41c66a729c56fa789488fd39ba6 Reviewed-on: https://gerrit.libreoffice.org/67713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11Merge in Flatpak improvementsStephan Bergmann
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>: commit 35de93fdcbfc7c7f6972812535e832f1405658cb Merge: b397586 06020ec Author: stbergmann <sbergman@redhat.com> Date: Mon Feb 11 10:18:24 2019 +0100 Merge pull request #70 from Erick555/patch-1 Update gvfs to 1.38.1; apache-ant to 1.10.5 commit 06020ec8be69c8c2d22265c7066c2b838d231400 Author: Erick555 <37542552+Erick555@users.noreply.github.com> Date: Sat Feb 9 21:24:57 2019 +0100 Update apache-ant to 1.10.5 commit 7c0a9d3fcd5988bc955bf5d67aa3249d45727bb4 Author: Erick555 <37542552+Erick555@users.noreply.github.com> Date: Sat Feb 9 21:19:16 2019 +0100 Update gvfs to 1.38.1 * use meson as autotools support was removed. * use same config options as gnome runtime does: https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/gnome-3-30/elements/sdk/gvfs.bst#L17 Change-Id: Ib4314ea49220bcac01fafb600065e41b434c395b Reviewed-on: https://gerrit.libreoffice.org/67672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-11new loplugin indentationNoel Grandin
look for mixed indentation in compound statements, which makes them hard to read, and sometimes makes it look like a statement is associated with a nearby if/for Change-Id: Ic8429cee1f9a86d938097a4a8769a2bce97b3361 Reviewed-on: https://gerrit.libreoffice.org/63283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11remove ControlDependencyManagerNoel Grandin
and just use our normal handlers, instead of this weird magic Change-Id: I8245787bec2a755ce6aba31ed681577771537ca1 Reviewed-on: https://gerrit.libreoffice.org/67534 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09weld SvxEditDictionaryDialogCaolán McNamara
Change-Id: Ia35ef42a570353e26a8969a322b04768a4ac042f Reviewed-on: https://gerrit.libreoffice.org/67553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-09move and extend primitive2dxmldump to drawinglayerTomaž Vajngerl
Also needs extending the XmlWriter to output double numbers as the attribute content. Change-Id: Ie749ea990d856c8c90092ed8153c24efda99c444 Reviewed-on: https://gerrit.libreoffice.org/67573 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-08xmloff: create XMLImpressExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I58c689f5a1b034f64687031e24b82a3ac56e4bae Reviewed-on: https://gerrit.libreoffice.org/67519 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-01xmloff: create XMLImpressImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I10cac20b8180c0fc4d7cade2ab3d5de0f9380a88 Reviewed-on: https://gerrit.libreoffice.org/67240 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-31be more lenient wrt patched epmCaolán McNamara
commit c3ab3df902b9e2ad363d1eca14da8f9f7f1567bb Date: Thu Oct 14 09:53:40 2010 +0200 changed the configure.ac to require "Patched by Libreoffice", which was possibly an error Change-Id: I6f8e302baeed054f36b54f8bfb6f5cad826ee788 Reviewed-on: https://gerrit.libreoffice.org/67199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31Fix confusing message... if EPM is patched, be sure to log thatJim Jagielski
(cherry picked from commit e774041ec07d7f168c41a42b6ffa6aacc816d442) Change-Id: Ie21b6a4a20199e4c7b7ef891719916db4ffba545 Reviewed-on: https://gerrit.libreoffice.org/67198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31Removed whitespace, fixed typosMatthias Seidel
(cherry picked from commit fef416499d3559230d78288661d73fe59838273e) Change-Id: I0a8f766fb5255628ea58679acca5c6b5fcefe2b1 Reviewed-on: https://gerrit.libreoffice.org/67196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-11 09:40:39 +0000