Age | Commit message (Collapse) | Author |
|
Currently LFS_CFLAGS are only used in a handful of libraries but there's
no obvious reason why it can't just be set everywhere.
Also set it in windows.mk, i have no idea if it's needed for MinGW
(certainly not for MSVC).
Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
|
|
signedness and long vs int corrections
Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48
Reviewed-on: https://gerrit.libreoffice.org/29355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9
Reviewed-on: https://gerrit.libreoffice.org/29436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Commit b078e0d638514b298616838fae090b8294bac32f introduced the problem
that gdb will load via LD_LIBRARY_PATH the libpython3.5m.so.1.0 from
INSTDIR instead of the one from the system, which makes it unhappy (at
least on Fedora 24).
Try to hack around that by detecting that the user wants to run gdb, and
passing in a command "set environment LD_LIBRARY_PATH ..." so that "run"
inside gdb uses the custom LD_LIBRARY_PATH but gdb itself does not.
Change-Id: I1d29d2af1a77ffab3e718a876c17c29de444c6d9
Reviewed-on: https://gerrit.libreoffice.org/29349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I8574c0b731efecb174370d09cfea2c89c27ab974
|
|
Change-Id: Iaf77d03d8116273054ae3efca88f44fd926bf211
|
|
Change-Id: Ic7515c1d43737fb6864228d37be1b356acecfdc3
Reviewed-on: https://gerrit.libreoffice.org/29253
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This did not take effect anyway because unxgcc.mk unconditionally
overwrites it; see
https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html
Nobody knows why it was added so just remove it.
Change-Id: Ib1a6d06ed8e380e63c588a72b6a65bfbeaacb924
|
|
This did not take effect anyway because unxgcc.mk unconditionally
overwrites it; see
https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html
Change-Id: I33a2ae9aae44d974d6b5466a2d7dae61ae5cc92c
|
|
... since commit 8541943b8d08f62217e99c9d47a5f222e1fba86e
Change-Id: I56b12ebd59b8387878f20d625381d3f743558a43
|
|
Removes 220 warnings from build log (at least under Windows).
Requires Python 2.5+
Change-Id: I06b18b14a08f2c27528fcb009faddff081ffd54e
Reviewed-on: https://gerrit.libreoffice.org/29172
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iec52b93746b2fd9bbd6ad67667092717f39222d7
|
|
...after ecd5d49dc30d11845ccc1a14e26bf37d73959463 "liblangtag: prevent libtool
from adding annoying stuff to RPATH". "Outsmarting" libtool in the way
described in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1 "Fix Linux RPATH of
various external modules" only works if there's no utility applications in the
outsmarted module, that are run while building the outsmarted module (cf. the
redland case in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1). To work around that,
pass in an LD_LIBRARY_PATH (or equivalent) that finds the relevant libs as built
in that module.
(And gb_Helper_extend_ld_path was until now only available in com_GCC_defs.mk.
There, it accepts any number of paths separated by ":". When used in a
platform-independend way like it is used here, it will only support a single
path.)
Change-Id: Ic615e436b19b8b9aa7daa019c8f5287de90c3abc
|
|
The check for broken -fvisiblity-inlines-hidden doesn't mention a specific bug.
Its roots date back to 072e89cf68dcf9b6713945e402dd7a9fe5cea48d "INTEGRATION:
CWS newportstl" of the --with(out)-stlport area. Lets assume whatever failure
is long since fixed.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I7c64c2e8b9bd342beec9b84ff71f5712a6155b7d
Reviewed-on: https://gerrit.libreoffice.org/29075
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* GCC documents -fvisibility at least as far back as the GCC 4.0 online
documentation at
<https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>.
* For external code, odk/settings/settings.mk unconditionally set
HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112
Reviewed-on: https://gerrit.libreoffice.org/29073
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Already with Xcode 7.3.1 some unit tests crash when the code is built
with full optimisation. Xcode 8 did not help. So use -O1. Yeah, this
sucks. Don't have time to investigate in detail.
Change-Id: I0cffad1a3ee3ee86b61eca3c856476133125049b
|
|
...at least with both gcc-6.1.1-3.fc24.x86_64 and a recent GCC 7 trunk build it
produces lots of incomprehensible (potentially false positive) occurrences in a
--disable-debug build, like
> [CXX] store/source/stordir.cxx
> In file included from /home/sbergman/lo/core/store/source/stordir.hxx:30:0,
> from /home/sbergman/lo/core/store/source/stordir.cxx:20:
> /home/sbergman/lo/core/store/source/storbase.hxx: In member function ‘storeError store::OStoreDirectory_Impl::create(store::OStorePageManager*, rtl_String*, rtl_String*, storeAccessMode)’:
> /home/sbergman/lo/core/store/source/storbase.hxx:237:23: error: potential null pointer dereference [-Werror=null-dereference]
> m_nUsed = rhs.m_nUsed;
> ~~~~^~~~~~~
> /home/sbergman/lo/core/store/source/storbase.hxx:236:23: error: potential null pointer dereference [-Werror=null-dereference]
> m_nSize = rhs.m_nSize;
> ~~~~^~~~~~~
> /home/sbergman/lo/core/store/source/storbase.hxx:235:23: error: potential null pointer dereference [-Werror=null-dereference]
> m_nAddr = rhs.m_nAddr;
> ~~~~^~~~~~~
> [...]
> [CXX] store/source/storlckb.cxx
> In file included from /home/sbergman/lo/core/store/source/storlckb.hxx:29:0,
> from /home/sbergman/lo/core/store/source/storlckb.cxx:20:
> /home/sbergman/lo/core/store/source/storbase.hxx: In member function ‘storeError store::OStoreLockBytes::readAt(sal_uInt32, void*, sal_uInt32, sal_uInt32&)’:
> /home/sbergman/lo/core/store/source/storbase.hxx:595:26: error: potential null pointer dereference [-Werror=null-dereference]
> return isA<U>(p) ? static_cast<U*>(p) : 0;
> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351> "NULL dereference warnings"
looks like this is a known problem.
Change-Id: I5eb0c9def7dd12e3a440d280e3fa2331317031b4
|
|
Since there's hardly any 'deliver' going on anymore...
Change-Id: Id349958d299c9742382d37deab2125bc09930c14
Reviewed-on: https://gerrit.libreoffice.org/28655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I643eb91691dddf2c4ece2edb27383cb7dd0e3fdc
|
|
Change-Id: Id9ae15aaf24b65abfcb4006490836eae8a1d8db6
|
|
Change-Id: I0c89d1c23ddc1d0d6cd98d95ef31622a30d4862b
|
|
Change-Id: Ic84b49029c2c773a59c286add3602bcd5540368d
|
|
Up to now the screenshot creation was added/dependent of
target slowcheck. Since quite some modules have added screenshot
creations now, I added an own target 'screenshot' to allow to keep
current slowcheck and screenshot creation separated
Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
|
|
Those screenshot cppunit tests need to run in non-headless mode with
dialog windows exposed (i.e. VCL_HIDE_WINDOWS must not be set)
To preserve the current behaviour (VCL_HIDE_WINDOWS is set always on Win
and Mac, and in use_vcl_non_headless case on Linux), introduce 2 new
variables:
gb_CppunitTest_show_windows: unset VCL_HIDE_WINDOWS unconditionally
gb_CppunitTest_hide_windows: set VCL_HIDE_WINDOWS=1 if HEADLESS is empty
(i.e. let's not use emptiness of HEADLESS as an indicator, as it is
empty in 2 mutually exclusive cases)
Change-Id: Ib2f7a9cfb1202944d10856c44b6ac7c41156b333
|
|
gerrit says they build with this cert folder
disable variable in place
Change-Id: Ibf711a01e6c055613c65dd94d85b523e7c8b5acd
|
|
Change-Id: I6497a87d3071f91d5465033d2dc6ecafaa6461f4
Revert "use div() instead of /0 to content ubsan"
This reverts commit fa293f7d6792a2beab048461c8a067e9ca980bb8.
Revert "use div() instead of /0 to content ubsan"
This reverts commit e043cce9a48c1e4f4dd232a58de64f03d1d3919f.
Revert "use div() instead of /0 to content ubsan"
This reverts commit ebe04c075649c677b55941e3b4e57fbca150b5db.
Revert "use div() instead of /0 to content ubsan"
This reverts commit fb2c146752074b132d665e40343a08dcb2e6672e.
|
|
...that rely on floating-point division by zero to produce infinity
Change-Id: I081c88a9631b1d8aab85c600c6da04f158089644
|
|
...which had inadvertently been broken with
99db9f2295eb9a8b3288df9798a292b8d6e1b854 "Make --enable-symbols orthogonal to
--enable-debug/-dbgutil"
Change-Id: I3962aa8c67426f3aebc5ad746f7ac281c68d941a
|
|
Change-Id: I006d19498f4b5c3bd4088fd1e290c30e7022b1c9
|
|
Change-Id: I8ec9bb5415a9e6b9083ba89a7790872d67625de1
|
|
Hopefully will not break building for a dmg-stye distribution.
Change-Id: Ibf32bb8e43fe4745461eb78e9e7e60d37163934f
|
|
The new option thoroughly replaces the product name mentioned in the
AC_INIT() call. Work in progress.
Also take care of spaces in the product name in a more systematic
fashion.
This should affect mainly OS X where the final app bundle that is
installed should use the product name as such, including spaces, if
any. However, our build system does not cope that well with having an
app bundle with spaces in it in instdir. So in instdir, and also in
test-install, spaces are stripped away from the product name when used
as part of the app bundle name.
Change-Id: Ic16b5039f23c96a4f39387a1869faeb25e05aafb
|
|
I could not find that SHORTSTDC3 or SHORTSTDCPP3 would have any
meaning. They only occur here (and in our history).
Change-Id: I45141e60c144207fbf3fc0c5e59340b80951b212
|
|
Change-Id: I55f332117cc7530eb6d562846db379d95e628a22
|
|
There are not only spurious warnings from loplugin, but also from plain
clang, at least with the Fedora 24 version. So let's just try to always
set CCACHE_CPP2=1.
This should make the configure check for that obsolete. The check didn't
do anything on Fedora anyway because it sets up ccache by putting
wrappers like /usr/lib64/ccache/clang on PATH.
Change-Id: Ieb17be4a1b1fd0f7aedb16b18cb49015917a26d3
Reviewed-on: https://gerrit.libreoffice.org/27345
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
The plugins are confused about source file locations without
CCACHE_CPP2, so try to avoid having to set it manually.
Change-Id: I8c19cb1b4bea27963b2f416faa67a70c6c65da38
Reviewed-on: https://gerrit.libreoffice.org/27344
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I839b9f8769508b8b4cc4e766db51188353767b0c
|
|
Change-Id: I523bc1d848e40489370eefe00046e0a257ed2505
Reviewed-on: https://gerrit.libreoffice.org/27058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* None of the other ENABLE_* support anything but TRUE or empty.
* Other checks for -n "$ENABLE_SYMBOLS" in configure.ac are confused by it.
* solenv/gbuild/gbuild.help.txt talks about "If not empty", not mentioning "FALSE".
* A missing (redundant) explicit --disable-symbols left gb_SYMBOL uninitialized
(instead of setting it to $(false))---but without consequences, as all the places
checking gb_SYMBOL explicitly check for $(true).
Change-Id: Id004189de27a7936862dab3a5fd84d549c06af2b
Reviewed-on: https://gerrit.libreoffice.org/27057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...in preparation of making them orthogonal
Change-Id: If75b334c954138b3aed4f8d1ac33061a2267ad52
Reviewed-on: https://gerrit.libreoffice.org/27056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie8ca63d48f66833a778342af8fbe19006fb6f143
Reviewed-on: https://gerrit.libreoffice.org/27055
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: If1e1d9217cfcc1f51fa611457ac7758fd2d9960b
|
|
Change-Id: I5b0667c4c2808913cde686afa7315ef2319b4d49
|
|
... implementing signed years with year 0 gap.
Date(31,12,-1) last day BCE
Date(1,1,1) first day CE
New class Date member functions:
* AddYears(sal_Int16) to be used instead of
aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap.
* convenience GetNextYear() to be used insted of GetYear()+1
* convenience GetPrevYear() to be used insted of GetYear()-1
* AddMonths(sal_Int32)
* operator=(const css::util::Date&)
New class DateTime member functions:
* operator=(const css::util::DateTime&)
Made some conversion ctors explicit, specifically Date(sal_Int32)
Adapted hopefully all places that used a sal_uInt16 year to use
sal_Int16 where appropriate.
Eliminated some quirks in date handling found on the fly.
Added era handling to i18npool icu calendar setting interface, which
missing was responsible for 0001-01-01 entered in Calc being set as
-0001-01-01, hence subtracting one day resulted in -0002-12-31.
Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f
Reviewed-on: https://gerrit.libreoffice.org/27049
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Ie7619ec157c1ce825ad82b2de8b5e7742fd5c96e
|
|
Seems to have changed from Fedora 23, where it was just "screen", to 24.
Change-Id: I9078c337093d12d62e9afe10b1f02aaf346d4b43
|
|
Change-Id: Ia725af391dcfe6a1d8d2f79317ddfde241951d26
Reviewed-on: https://gerrit.libreoffice.org/26623
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ica1efa92d6b3b26b3d138763c8f548c59d53e346
Reviewed-on: https://gerrit.libreoffice.org/26622
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ic6e0d99a567b7080928accb61ed036b1c25ec7ff
|
|
starting LO once satisfies Gatekeeper's verification, even when the
langaugepack's content are added afterwards
Change-Id: Ie548df39a7ec07cc485c40148e4ca75101346798
|