summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2017-09-21fix 'make solenv' test failure on clang-3.8Noel Grandin
clang-3.8 and clang trunk differ in how they represent ranged-for which leads to a test failure Change-Id: Ia8965802260fdc946d3a705c6fef82d98eeb8230
2017-09-21loplugin:unusedfields, fix var taking refNoel Grandin
Change-Id: I0ea1f0c7488c140fca9f64de326c6ac588ece925
2017-09-20Don't expand $(call gb_Executable_get_target,python) too earlyStephan Bergmann
Caused a clean 'make PythonTest_pyuno_pytests_ssl' to fail for me with ".../instdir/program/python.exe: No such file or directory" as the above apparently expands to nothing at the time solenv/gbuild/platform/com_MSC_class.mk is read. Change-Id: I33ad8d8d0876dcec9b9cb02b71a9399d959cf660
2017-09-20gbuild: remove obsolete commentMichael Stahl
There is only one PCH since commit "kill gb_NoexPrecompiledHeader" 2bf530153e9fb24aef62bf5e16e23ea1412887dd Change-Id: I1b31462227df021068e8a6320d0613809d2503bc
2017-09-20new loplugin flattenNoel Grandin
look for places where we can flatten the control flow in a method by exiting early with a throw, ie. instead of if (cond) stuff(); else throw ex; we change it to: if (!cond) throw ex; stuff(); Change-Id: I8b6bdf883b325807c7e3a3ef698e4f4606e7d38b
2017-09-19iOS, remove support for 32bit (arm).jan Iversen
Supporting 32bit iOS, means a.o. adding several libraries to the dependency list because macOSX does not install them by default (e.g. zlib). 32bit is only used in old iPhones. updated configure.ac removed from solenv/gbuild/platform bridges corrected Change-Id: I415e744a9cb4acb3b5fbfca33c22940a1d56e390
2017-09-19gpg4libre: have gcc-wrapper handle linking properlyDavid Ostrovsky
Change-Id: I83305f504f7d492195f07f11f06d2c9855d92400 Reviewed-on: https://gerrit.libreoffice.org/42441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-18Upgrade to Boost 1.65.1Stephan Bergmann
...<https://dl.bintray.com/boostorg/release/1.65.1/source/boost_1_65_1.tar.bz2>. One reason to upgrade is that with 1.63 CppunitTest_tools_test started to fail with -fsanitize=signed-integer-overflow after 331e2e5ed3bf4e0b2c1fab3b7bca836170317827 "long->sal_Int32 in Fraction", > workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:300:5: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself > #0 0x7f0f99bea71b in boost::integer::detail::gcd_optimal_evaluator<int>::operator()(int, int) const workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:300:5 > #1 0x7f0f99bea52a in int boost::integer::detail::gcd_optimal<int>(int const&, int const&) workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:372:16 > #2 0x7f0f99be7d70 in int boost::integer::gcd<int>(int const&, int const&) workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:435:12 > #3 0x7f0f99be7620 in boost::rational<int>::normalize() workdir/UnpackedTarball/boost/boost/rational.hpp:559:17 > #4 0x7f0f99bdff29 in rational_FromDouble(double) tools/source/generic/fract.cxx:449:12 > #5 0x7f0f99bdf8b4 in Fraction::Fraction(double) tools/source/generic/fract.cxx:93:25 > #6 0x7f0f9a1bb987 in tools::FractionTest::testMinLongDouble() tools/qa/cppunit/test_fract.cxx:79:18 > #7 0x7f0f9a1bddd2 in void std::_Bind<std::_Mem_fn<void (tools::FractionTest::*)()> (tools::FractionTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933:11 > #8 0x7f0f9a1bdbe9 in void std::_Bind<std::_Mem_fn<void (tools::FractionTest::*)()> (tools::FractionTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991:17 > #9 0x7f0fa5eb53b0 in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #10 0x7f0fa5e1bd1b in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #11 0x7f0fa5e8653d in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #12 0x7f0fa5e7fb7c in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #13 0x7f0fa5f17fe0 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #14 0x7f0fa5eb398c in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #15 0x7f0fa5eb7887 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #16 0x7f0fa5eb6a78 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #17 0x7f0fa5eb7887 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #18 0x7f0fa5eb6a78 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #19 0x7f0fa5f46655 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #20 0x7f0fa5f16a66 in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #21 0x7f0fa5f475c6 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #22 0x534a01 in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316:20 > #23 0x532ac4 in sal_main() sal/cppunittester/cppunittester.cxx:466:20 > #24 0x5324f2 in main sal/cppunittester/cppunittester.cxx:373:1 > #25 0x7f0fa436e430 in __libc_start_main /usr/src/debug/glibc-2.24-66-gd5a4092c36/csu/../csu/libc-start.c:289 > #26 0x4387b9 in _start (workdir/LinkTarget/Executable/cppunittester+0x4387b9) Change-Id: Id1c3b216ee18c1d622768dc960ac257d5415c664 Reviewed-on: https://gerrit.libreoffice.org/42427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-18Reflect recent download.lst changes to flatpak-manifest.inStephan Bergmann
Change-Id: I5df5e2384670a5ca10ad8ed30a2f6d76a0f7b906
2017-09-18clang plugins: this test fails on 32-bit LinuxMichael Stahl
... where sal_uIntPtr and sal_uInt32 are both "unsigned long"; disable test for now. Change-Id: I8357bf425ab5d9166cd45ba5fb81ec6c1fac957a error: 'error' diagnostics expected but not seen: File compilerplugins/clang/test/convertuintptr.cxx Line 15: cast from 'sal_uIntPtr' (aka 'unsigned {{.+}}') to 'sal_uInt32' (aka 'unsigned {{.+}}') [loplugin:convertuintptr] File compilerplugins/clang/test/convertuintptr.cxx Line 16: cast from 'sal_uIntPtr' (aka 'unsigned {{.+}}') to 'sal_uInt32' (aka 'unsigned {{.+}}') [loplugin:convertuintptr]
2017-09-15update-for-gettext is no more nowCaolán McNamara
Change-Id: I3da463ce2233512cb9b616fa75d7a07d9b32aeb5
2017-09-15ofz: need more servicesCaolán McNamara
Change-Id: Iaa594d85aad4b1ee3dd31029fc50c5a1d8997f57
2017-09-15Convert com.sun.star.comp.stoc.CoreReflection to direct constructionCaolán McNamara
Change-Id: Iac6f30dbb9173e2ccc38b236efc4715ba7f2b67f Reviewed-on: https://gerrit.libreoffice.org/42289 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-15solenv: fix GDB pretty-printers for SwNodes yet againMichael Stahl
Change-Id: I1eb1efedb98979b692874ae0ec48120cb5a38188
2017-09-15consistent naming of externals: jpeg-turbo->libjpeg-turboMichael Stahl
Change-Id: I63fcebc36559c2698bbedd3501285a388ce8c257 Reviewed-on: https://gerrit.libreoffice.org/42291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-14remove interim update module for gettext supportCaolán McNamara
Change-Id: I05df619848cde842a5cda79d20e013914ce882d4
2017-09-14Adapt flatpak-manifest.in to updated poppler and libwpgStephan Bergmann
...1c983335116a6f09cabf0b3eae7f51951111341e "upload poppler 0.59.0" and 1a2b33348e53a4c3262494cfc5bfa7cbd1bb4e36 "upload libwpg 0.3.2" Change-Id: I8b6d5f6bb96a8bd668abebbdc6087cdb93226db6
2017-09-13Enable -Wunreachable-codeStephan Bergmann
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-12android: tune symbols for lldb & we actually target 14 as minSDKChristian Lohmaier
-glldb might be placebo switch like -ggdb2, but at last it won't hurt :-) increase java heap size for gradle to allow inprocess dex as well as actually processing the huge files. furthermore fix platform level in configure to match the minSDK value from build.gradle Change-Id: I57d7d4c67bc3e5ed8bfed1e592b85211b5b8905a Reviewed-on: https://gerrit.libreoffice.org/42162 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-10iOS, make common iOS GCC file.jan Iversen
Combine common parts for iOS files into one Change-Id: Ibbc6cbb69d0521a5b35ac1817c74bff1dccaddf5
2017-09-09iOS, update gbuild platformjan Iversen
IOS => iOS added iOS_ARM64 added iOS_X86_64 and iOS_I386 for simulator Change-Id: Ia788765aab4ef51a7cc7c67d5faff1197e90696c
2017-09-07Adapt flatpak-manifest.in to updated pdfiumStephan Bergmann
...0365ca351aac534d3fc09d22f6a91017525bfef8 "pdfium: update to 3196" Change-Id: Ia291b30b79bb0873529e474164d24dcb8b491f40
2017-09-07Adapt flatpak-manifest.in to updated language-subtag-registryStephan Bergmann
...04d70c0999c716f5465631eca50945915ec607c4 "Upgrade to language-subtag-registry-2017-08-15" Change-Id: I4178545869a6d97cb1f90034f3944d9c72700bd6
2017-09-07No libqxp in org.gnome.Sdk//3.24Stephan Bergmann
Change-Id: Ia3551572269e1cf04b2a398cd08f718fd248c6e6
2017-09-07Include all .desktop files in the FlatpakStephan Bergmann
...GNOME Software reportedly is fine with that now. Change-Id: I418fc60a3215078109d3d8e9f426f98fdf37322b
2017-09-06Move git source details to solenv/flatpak-manifest.inStephan Bergmann
...from dev-tools' flatpak/build.sh, as the Flathub build plans to use that git source, too Change-Id: I5a23ad0eddd8b7d89e941217c66f5354936c10fc
2017-09-04new loplugin:redundantpointeropsNoel Grandin
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-30Adapt getcompver.awk to Java 9Stephan Bergmann
...where at least <http://jdk.java.net/9/> "JDK 9 Early-Access Builds" 'java -version' outputs a single-digit java version "9" Change-Id: I7807f56593e5436418b49950ca6c2a178d6721f5
2017-08-25create-tags: find UNO IDL exceptions tooMichael Stahl
Change-Id: I3eff2bdd5da3710bc130a5d9965a8c84c74ee55b
2017-08-25updater: fix the handling of ~ in the update configMarkus Mohrhard
Change-Id: I5c07039e336de9362fdd92be29de516da0846998
2017-08-24Explicitly specify -finput-charset=UTF-8 for GCC/ClangStephan Bergmann
...after 9a7d2d72cef7ff14a020c1024fbff8c00e4e4aff "tell msvc our source code is written using utf-8" did the equivalent for MSVC. That should cause the C++ string literal u8"ßa" (in vcl/qa/cppunit/mnemonic.cxx) introduced with that commit to reliably be interpreted as intended by all our toolchains. Change-Id: Ibbda8588a3ca66d1c2764f70aa999fad243f1bb1
2017-08-22unotest: really run every CppunitTest with its own user profileMichael Stahl
Apparently a sw unit test randomly read a partially written autotbl.fmt that was written by another unit test, in particular the file workdir/unittest/user/config/autotbl.fmt. The tests are actually started with -env:UserInstallation=$(call gb_Helper_make_url,$(call gb_CppunitTest_get_target,$*).user) to prevent exactly this problem, but unfortunately it's then overridden by a call to rtl::Bootstrap::set(), which overrides even command line arguments, from test::BootstrapFixtureBase::setUp(). Change-Id: I618574e94755ea38caf9583f3dcf7715396bca48 Reviewed-on: https://gerrit.libreoffice.org/41432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22Put flatpak-builder manifest file into core repoStephan Bergmann
...where its content can be kept in sync as necessary. The flatpak/build.sh script in the dev-tools repo will be updated accordingly. Change-Id: I6937a619dbf54686f8dcfd9b98200c14198dde8e
2017-08-21updater: also write channel to version.ini outside of instdirMarkus Mohrhard
Change-Id: Ibb087fc9cd17e50accf78f805e0fec4f202334b1
2017-08-18new loplugin:expressionalwayszeroNoel Grandin
The code in SvXMLExportItemMapper::exportXML was broken as far back as its introduction in commit 0c28e3c480a95c03b513c55f029b979bcd9c0401 "Move SvXMLAttrContainerItem to SVX, moved writer only code to sw" Change-Id: I90043ce8b7263aa56fd0883d350e29b97eeaf99b Reviewed-on: https://gerrit.libreoffice.org/41282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Add hu-Hung -> hu@hungEike Rathke
... and hope that actually will be recognized.. Change-Id: Ib7a73eca63caeb8791a06fa26cd31a15407de065
2017-08-17loplugin:passstuffbyref ignore params that are assigned toNoel Grandin
makes writing nice code awkward sometimes. Also split plugin into two different plugins, the logic was getting tangled up. Change-Id: I232e314d29c766c160c29373988dc37a466505be
2017-08-17new loplugin convertuintptrNoel Grandin
an experiment to see if I can make the process of eliminating sal_uIntPtr a little easier Change-Id: I808185fbf18826cb9ab5612a7be4148d52045957
2017-08-16tdf#70280 crete-tags: tweak the UNOIDL regexesMichael Stahl
To more precisely get definitions of top-level entities; particularly nice for interfaces where we don't want to find the ubiqitous forward declarations. Change-Id: I8e0e67506d5c67bfff351c4129c3e7eeda6e67a5
2017-08-16tdf#70280 Add UNOIDL support to ctagsJens Carl
This supports the UNOIDL language constructs Enumeration, ElementName, Structure, Interface, FunctioName, Service, and PropertyName. The values are mapping to ctags as: UNOIDL ctags Enumeration e,enum ElementName m,member Structure s,struct Interface i,interface FunctioName f,function Service g,service PropertyName p,property Change-Id: I4ca5dcb289360f7630a85bb3a62ec3b60a8a88e6 Reviewed-on: https://gerrit.libreoffice.org/40911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16move deadclass plugin to storeNoel Grandin
<sberg> noelgrandin, and is loplugin:deadclass even sound? struct B { B(B const &) {} }; struct D: B { D(): B(*this) {} }; Change-Id: Idadd379b925aa6f9de6c625bffa8560ec4192ac7
2017-08-16Fix typo in buildingAndrea Gelmini
Change-Id: I727d50ce4725f10efbeaedd70ed961e726f99a5e Reviewed-on: https://gerrit.libreoffice.org/41190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-14new loplugin:droplongNoel Grandin
The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholy unsuitable for portable code. And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different bit sizes. Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d Reviewed-on: https://gerrit.libreoffice.org/41130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11new loplugin:deadclassNoel Grandin
look for classes which only have copy/move constructors, and so are effectively dead Change-Id: I0b844f301e2200c2b40031856bfdb0b0e2c8f77d Reviewed-on: https://gerrit.libreoffice.org/41039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-29Fix no longer valid commentPranav Kant
This was changed in d72aad218c9737fb19d1a835b03c13b7107a96c0 Change-Id: Ie93f603c82669ca612fbf9635a62c50e63702a85
2017-07-28Fix scheduler GDB pretty printerJan-Marek Glogowski
mbDelete is gone, as we simply check for mpTask. Change-Id: I9d451f2445fb6b978d177b45d75abde2595c5fac
2017-07-28loplugin:constparams handle constructorsNoel Grandin
had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27LibreOffice.natvis: fix BigPrtArray visualiser.Mike Kaganski
Also visualisers for uno_Any and SwNode are tweaked. Visualisers for uno::Reference, rtl::Reference and VclPtr added. SwFrameFormats visualiser reimplemented to follow implementation of boost::multi_index_container. Minor reformatting. Change-Id: I24ccb8bfccd7f7514697ca3f36490672ad549aef Reviewed-on: https://gerrit.libreoffice.org/40466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-26gbuild: strip away unexpected CR char at the end of Windows filenamesMiklos Vajna
As reported at e.g. <https://ask.libreoffice.org/en/question/90346/building-libreoffice-in-cygwin-leads-to-infinite-loop/>, sometimes MSVC (seen with 2013 on libreoffice-5-2, but there is no indication that 2015 on master would be different) emits CR characters at the end of filenames, resulting in unnecessary rebuilds at per-module builds, and actually to an infinite loop when doing toplevel make. Given that CR characters are unexpected in any filenames, it should be safe to just strip those away unconditionally. Change-Id: I3d56670b4d930a32489f889085711bfd436de82a Reviewed-on: https://gerrit.libreoffice.org/40452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-19 23:30:02 +0000