Age | Commit message (Collapse) | Author |
|
Change-Id: I8f5fc0a80e84dc4aa79f7488591fb4904e5f5338
Reviewed-on: https://gerrit.libreoffice.org/80763
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...to find matches of
... << s.getStr()
(for the rtl string classes) that can be written as just
... << s
Some notes:
* The OUStringToOString(..., RTL_TEXTENCODING_UTF8) is left explicit in
desktop/source/app/crashreport.cxx (even though that would also be done
internally by the "<< OUString" operator) to clarify that these values are
written out as UTF-8 (and not as what that operator << happens to use, which
just also happens to be UTF-8).
* OUSTRING_TO_CSTR (include/oox/helper/helper.hxx) is no longer used now.
* Just don't bother to use osl_getThreadTextEncoding() in the SAL_WARN in
lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx.
* The toUtf8() in the SAL_DEBUG in pyuno/source/module/pyuno_module.cxx can just
go, too.
Change-Id: I4602f0379ef816bff310f1e51b57c56b7e3f0136
Reviewed-on: https://gerrit.libreoffice.org/80762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5e492fda0ce2b88c4e6790a6972bc36f082003a1
Reviewed-on: https://gerrit.libreoffice.org/80691
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I87c03555c5555b12a1be997e368a96d9b07d2b63
Reviewed-on: https://gerrit.libreoffice.org/80689
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...on our baselines, since <https://gcc.gnu.org/git/
?p=gcc.git;a=commitdiff;h=b156ec373ccf27f4fcce7972de5e043d35acea43> (GCC 4.9?)
and <https://github.com/llvm/llvm-project/commit/
e0fc1a80cba8b91e3943f3287e7dcf68c6bb9b7f> "[stackprotector] Add command line
option -fstack-protector-strong" (Clang 3.5?)
Change-Id: I48237b2304a1ee273cc66f0bb458e890a5a2f21a
Reviewed-on: https://gerrit.libreoffice.org/80700
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...which was added with 8f4fdb405a8470b9d06ab14ced120da89b213e82 "New
loplugin:classmemaccess", but I forgot to include this change to
solenv/CompilerTest_compilerplugins_clang.mk in that commit
Change-Id: If1580b28369443f09dae8882346b1e0ff8214ab4
Reviewed-on: https://gerrit.libreoffice.org/80699
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
(609cbacc0e134f81f2e1acb5bbe483563fa1c6b9)
Change-Id: Iefa8332b98c06fdc43a009d42a3fafe602107ddc
Reviewed-on: https://gerrit.libreoffice.org/80656
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
See tdf#74608 for motivation.
Change-Id: I15c879fd2be820a1b6ee878149442ebb46588a30
Reviewed-on: https://gerrit.libreoffice.org/80629
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
...ever since 9055fb48402eaeb9ba876b7893e2f9a39fea06b1 "clang-cl: Enable more
warnings etc. (like in the Clang/GCC case)"
Change-Id: I2c7b36f6d0852ebf6c660e79e6a9bad057ec0153
Reviewed-on: https://gerrit.libreoffice.org/80608
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It cannot be turned off, it doesn't bring any value and it pollutes
gbuild output.
Change-Id: Ie3684e5fc30c9c5d34bd991e928a8d3f11f0b823
Reviewed-on: https://gerrit.libreoffice.org/80492
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
add org_openoffice_comp_Draw_framework_PanelFactory_get_implementation
make it build
Change-Id: I522f3d684c52caf15a78d5eff29e78e645588481
Reviewed-on: https://gerrit.libreoffice.org/80515
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
These files were removed in the meantime. Also add ones which don't
conform to the enforced style but somehow bypassed CI.
Change-Id: I50cfc35d882615b52fc5ca157eb8ae92515bb2fe
Reviewed-on: https://gerrit.libreoffice.org/80494
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654
Reviewed-on: https://gerrit.libreoffice.org/80416
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I97ff0418e25aeaea4cae349f2d228fb35219b5c2
Reviewed-on: https://gerrit.libreoffice.org/80374
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I7762d95290a0b35de4f909895a4e28b52c436ed9
Reviewed-on: https://gerrit.libreoffice.org/80307
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibb21567c11adef233061cb53f787a73eb56cc282
Reviewed-on: https://gerrit.libreoffice.org/74848
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Nah. We already have
com_sun_star_comp_Writer_DocxExport_get_implementation as it is called
in this branch.
This reverts commit 98deb6e96f547e8eedff40c992fefe3514021447.
Change-Id: Ic5db66420db9ef2477df8d9905ba3525f3b57e5b
Reviewed-on: https://gerrit.libreoffice.org/79010
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit cb61889e8761837150236c617e806d52c54fd72f)
|
|
They are needed for .docx and .rtf export at least. No idea how we
have managed without it previously.
Change-Id: Iff9224f92520e19d9baa691a9e7cd3c944004eed
Reviewed-on: https://gerrit.libreoffice.org/78125
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 1a0bd0c6914bf93733c7ab3a27741fc1dc0e3f26)
Reviewed-on: https://gerrit.libreoffice.org/78996
(cherry picked from commit 98deb6e96f547e8eedff40c992fefe3514021447)
|
|
(I saw warnings about it missing in the iOS app.)
Change-Id: Ib286b107e529e80ec36ffb87059f4f5923867abe
Reviewed-on: https://gerrit.libreoffice.org/77399
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I2095308943c94ad16c110d5fac47715398eb5d39
Reviewed-on: https://gerrit.libreoffice.org/80187
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I52edd5166edc9aceeafffed898835fe5bc46880c
Reviewed-on: https://gerrit.libreoffice.org/80232
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I47cc2cb7db396a06a2abeffe4a5d40a039f21c58
Reviewed-on: https://gerrit.libreoffice.org/80222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
through the fpicker constructs one directly
Change-Id: Ic365231e78ca9425b97006a156273479d104eae9
Reviewed-on: https://gerrit.libreoffice.org/80211
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3aac2b42442ec3f61c2d18369eae061ae44880a5
Reviewed-on: https://gerrit.libreoffice.org/80205
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
which is useful because our MSVC build will warn about this by default
Change-Id: Idcc0f08b69b6eda4dd2ab010a5fdb674787bebcf
Reviewed-on: https://gerrit.libreoffice.org/80184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
See tdf#74608 for motivation.
Change-Id: Ia7ca975486be09acd2655c59b65e1f2a57774f32
Reviewed-on: https://gerrit.libreoffice.org/80166
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
And make it simple to disable the whole feature by setting
gb_DISABLE_PCH_REUSE=1, just in case.
Also work around a possible BOOST_ALL_NO_LIB mismatch when
using the common PCH.
Change-Id: I96fd507edf1ada6242ac225026250e5a588d0193
Reviewed-on: https://gerrit.libreoffice.org/79365
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Where reasonable means they are from a list of defines known not
to affect the system headers, and so they are safe to differ from
how the PCH was built. A bit hackish, but works in practice.
Change-Id: Ia00d2e4c56212aca05ba9d47abbb0d253998219f
Reviewed-on: https://gerrit.libreoffice.org/79364
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Similar to gb_LinkTarget_set_precompiled_header, but uses PCH
created by another linktarget. This allows using a PCH even for linktargets
that are small and creating their own dedicated PCHs is not worth it.
The ultimate goal is having some default PCH that will be used if no
explicit PCH is set.
Change-Id: I4d72acdba7181bb5c7c1cdead776f548be36ba33
Reviewed-on: https://gerrit.libreoffice.org/79362
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
GCC/Clang do not bother with warning about overriding e.g. -O2
with -O0, AFAICT it's quite a common practice, and I really don't
see any good reason for the warning, and even less so for not even
being able to disable it. Without this, enabling SSE2/AVX2
would warn about overriding the default -arch:SSE (that's hardcoded
by configure to be part of the compiler command).
Change-Id: I9f9109b77de90085486bc2a98f1b453a41755e60
Reviewed-on: https://gerrit.libreoffice.org/80123
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ia4001a4a3a0ac8490ab7104a25ccd688d18b8aa1
Reviewed-on: https://gerrit.libreoffice.org/80122
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
All the various gb_CppunitTest_add_cxxobjects variants actually
allow passing additional CXXFLAGS. However, currently that would
abort the build if PCH is used, because PCH requires the same
CXXFLAGS. But if those extra CXXFLAGS are set explicitly, just
skip using the PCH for that one file, as the mismatch is intentional.
Change-Id: Iec4eed6d5f94c3e97ee461241203a84d21e8113c
Reviewed-on: https://gerrit.libreoffice.org/80120
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
E.g. gb_LinkTarget_add_exception_object adds it explicitly, but
gb_LinkTarget_add_cxxobject itself does not, even though other variants
(c,objc,objcxx) do it.
This means that when compiling tools/qa/cppunit/test_cpuid.cxx it
doesn't get the correct -O/-g flags, because CppunitTest_tools_test.mk
uses gb_CppunitTest_add_cxxobjects to add $(INTRINSICS_CXXFLAGS).
And that in its own actually should use the add_exception_objects variant,
it didn't presumably because that one used to have cxxflags passing broken
until I fixed it in 4bbdab901eb3c7d32d28910fb830f4b0422eee91. The usage
in Library_cpp_uno.mk even explicitly works around the lack of debug symbols.
Change-Id: Idc794e95bb817cd2ba2942b8e1f04f80d6722f97
Reviewed-on: https://gerrit.libreoffice.org/80119
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: If95d78746eff3ae5343e7d4c6bb2433537ccb84d
Reviewed-on: https://gerrit.libreoffice.org/80099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2028f921e78611698e82e50a652b67dba1ece909
Reviewed-on: https://gerrit.libreoffice.org/80054
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id4adbe484f88be74f45dab8e7ef426c66e5cbc8b
Reviewed-on: https://gerrit.libreoffice.org/80002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
look for places where we can replace sequential additions to
OUString/OString with one concatentation (i.e. +) expression, which is
more efficient
Change-Id: I64d91328bf64828d8328b1cad9e90953c0a75663
Reviewed-on: https://gerrit.libreoffice.org/79406
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...which is built with MSVC after all. 0a99b5a1b7325454fe3d1174d44354888aa22012
"When building with clang-cl on Windows, build CLR code with MSVC" had happened
to get away with passing a bogus -Xclang -std=... (which cl then ignores)
instead of /std:c++17, but nowadays the build fails with things like
> [build CLR] cli_ure/source/climaker/climaker_app.cxx
[...]
> cl : Command line warning D9002 : ignoring unknown option '-Xclang'
> cl : Command line warning D9002 : ignoring unknown option '-std=gnu++2a'
> string_view is only available with C++17 or later.
> include\rtl/stringconcat.hxx(232): error C2429: attribute 'nodiscard' requires compiler flag '/std:c++17'
[...]
This is a bit of a hack, using hardcoded values for now. Ideally we would
capture MSVC's CXXFLAGS_CXX11 in an additional variable in configure.ac, and do
a subst from CXXFLAGS_CXX11 to MSVC's CXXFLAGS_CXX11 here.
Change-Id: Ifde367c7d1c3db57e75a6ccadc82d534bcb13d0a
Reviewed-on: https://gerrit.libreoffice.org/79961
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I069fc594c32d2f1ea7fe4cc04be00a9a574054f8
Reviewed-on: https://gerrit.libreoffice.org/79898
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7bc83277503b7981b05fd358b0fd68e19d8232ae
Reviewed-on: https://gerrit.libreoffice.org/79819
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie838cabfecfef7e3225c1555536d5c9cf3b43f15
Reviewed-on: https://gerrit.libreoffice.org/77405
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5fe97c0bea6d386c4b39d8bf9341c844ccb792ae
Reviewed-on: https://gerrit.libreoffice.org/79745
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Apply the constmethod plugin, but only to accessor-type methods, e.g.
IsFoo(), GetBar(), etc, where we can be sure of that
constifying is a reasonable thing to do.
Change-Id: Ibc97f5f359a0992dd1ce2d66f0189f8a0a43d98a
Reviewed-on: https://gerrit.libreoffice.org/74269
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
See tdf#74608 for motivation.
Change-Id: Ib63744f720a886cd67b4158399e6bf91c6efb128
Reviewed-on: https://gerrit.libreoffice.org/79660
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I15c0745d387e491dd05e14949d744d0a27a8dd49
Reviewed-on: https://gerrit.libreoffice.org/79600
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8b59140d2e2b0892f17159282a1aeb1a47008ba0
Reviewed-on: https://gerrit.libreoffice.org/79561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I64fc2b503f76b61ea8c2f26c8170c72611935131
Reviewed-on: https://gerrit.libreoffice.org/79533
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Something like auto str = "string" + OUString::number( 10 ); will
not be OUString but actually rtl::OUStringConcat (which gets implicitly
converted to OUString, but not with auto). Since those refer to temporaries
from the expression, they should not outlive the expression.
Change-Id: Ib4cde4b38befb3d49927d0cf01c52ebb2d36df89
Reviewed-on: https://gerrit.libreoffice.org/78830
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Because the timestamp says that the LinkTarget's PCH dependencies
are ready.
Change-Id: I5c9b965bf6d5a62b16972d5b0ea84a97f771e14f
Reviewed-on: https://gerrit.libreoffice.org/79361
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
gb_CxxObject__set_pchflags just sets a variable, which is not used here.
It should have been removed in 66a0713dc9c676182fcd7aa1e21f8dc25c05be5e,
but even back then the removed function didn't depend on it, so this
should have been removed even sooner.
Change-Id: I629d6337d0aa4066bd3141b22aed84dfeeac5b7f
Reviewed-on: https://gerrit.libreoffice.org/79315
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|