Age | Commit message (Collapse) | Author |
|
Change-Id: I45d45513b102f4fdcb55e8de20b95b37f66ea463
Reviewed-on: https://gerrit.libreoffice.org/30658
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
from other than icon-themes folder
Change-Id: Iba1808e642fde8d0370b59550c7bdac1a3e4ac79
Reviewed-on: https://gerrit.libreoffice.org/28513
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
|
|
Change-Id: I630fd447992ada459190acd1ee310bd2d38820b9
|
|
Change-Id: Ib5eb4fece2bae3e04089f2389198df800620e6f8
Reviewed-on: https://gerrit.libreoffice.org/30483
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
- This should unbreak vcl when configured with KDE/TDE CustomTargets
Change-Id: I239e97b90174f3daef39e4a806a126cafba9d8e0
Reviewed-on: https://gerrit.libreoffice.org/30436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
the test environment clears LD_LIBRARY_PATH as it seems to cause trouble for
make in ASAN. "make gbuildtoide" only runs the gbuildtojson exe, so make sure
it gets the LD_LIBRARY_PATH that was filtered out from the make that starts it.
Change-Id: I69ee0024232092aebcd1e8e11b002d6f7eb55c84
Reviewed-on: https://gerrit.libreoffice.org/30433
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I06f77d8aa0a82bd3bb065095a64849d07d11c6a3
Reviewed-on: https://gerrit.libreoffice.org/30311
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
- do concat for json in C++, everything else seems fragile on Windows
- have APPEND vars separately
- check that gbuildtoide work on modules without a full build (modulo
some blacklisted "creative" ones)
Change-Id: I6fe267fee7d1b77d758072303729387dfeb8e6c8
Reviewed-on: https://gerrit.libreoffice.org/30293
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Bunch of these were setting C++ or Make modes and icky tabs...
Also, reportedly Emacs can figure out to enable python-mode
automatically.
Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
|
|
Change-Id: Id767a98be85a7f3f4abb28891d0a5cac2057b0e0
|
|
Change-Id: Iff27ff4a01dc8c20b01a6247554b6cc7195a2306
|
|
Traceback (most recent call last):
File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32solenvqapythongbuildtoide.py", line 32, in test_gbuildtoide
del(os.environ['LD_LIBRARY_PATH']) # built with ASAN; prevent that
File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32instdirprogram\python-core-3.3.0libos.py", line 692, in __delitem__
raise KeyError(key) from None
KeyError: 'LD_LIBRARY_PATH'
Change-Id: I1575caf90cafffd71dd28fedc46b5e3570848be8
Reviewed-on: https://gerrit.libreoffice.org/30304
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
In a build with -fsanitize=address, this fails with:
Change-Id: Ida0d4445d7f829545b493e9dd4c2c4ef33960850
make: symbol lookup error: instdir/program/libfreebl3.so: undefined symbol: __asan_option_detect_stack_use_after_return
|
|
...after 475e4b477c6d7ae114c3ae51ba4872882af67a68 "Move i18nlangtag lib to
URELIB"?
Change-Id: I45c5d997ed30757157109c67f30b91c4073c6b0a
|
|
Change-Id: Ic6ba34e1ea6aff49f308f41e5692e08edc5b77c2
Reviewed-on: https://gerrit.libreoffice.org/30270
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Possibly mis-matching make binaries could be the reason behind failures
that have been observed on Jenkins:
make[3]: Entering directory '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/windows_msc_dbgutil_32/solenv/qa/python/selftest'
make[3]: *** internal error: invalid --jobserver-fds string 'gmake_semaphore_5488'. Stop.
Also, to enable this: Revert "Revert "prep WinResTarget for WNT in testdir""
This reverts commit 6e261cb19e5751eb0553ad0c5b357b1a5747518c.
Change-Id: Idb858b5eeced91f19c9dd5600c4fdc5370b73cc5
Reviewed-on: https://gerrit.libreoffice.org/30226
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4
Reviewed-on: https://gerrit.libreoffice.org/30040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
Still random failures in Gerrit Windows builds.
This reverts commit f5c54089b50718abf7c35aa81b150c509809d5c4.
Change-Id: Iec48d2388691577ccd675b9a73941cedceebd527
Reviewed-on: https://gerrit.libreoffice.org/30103
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
|
|
Change-Id: I04c050dca1212d247c9b11a996ba8f37c0a6492f
Reviewed-on: https://gerrit.libreoffice.org/29825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
configure.ac doesn’t check for the version of Perl at all
so you can’t suppose that it is guaranteed to be 5.12 or beyond
before this patch
in the case you use perl < 5.12 at build time
you would get
Can't locate object method "newdir" via package "File::Temp"
at solenv/bin/packimages.pl
the commit 4e3dc8c141c2efd037c1f214b5edff071812b6a8
introduced such incompatibility
Change-Id: Icd9281e0065ed67d69d07ac921b054deed052764
Reviewed-on: https://gerrit.libreoffice.org/29907
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I0a1075b92e787fc8bab7cfab5c3f24ad918a9181
Reviewed-on: https://gerrit.libreoffice.org/29850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...causes all gerrit/jenkins Windows builds to fail in test_gbuildtoide; Björn
to investigate...
Change-Id: I90f95e4a91f40835d2b2d9c67a6473b95fb81597
|
|
Change-Id: I2fc5497b0aeadbc43e967f338a3b8718995f2a5c
|
|
Change-Id: Icf1818fb894d039eeb4e7f1306a53ac4322fa075
|
|
Change-Id: I320ee341651dd0c92de5176c10aa5290afea1d38
|
|
Change-Id: I71a2e87279611a1a8f65ec86c47d26bbd5bd5f3b
Reviewed-on: https://gerrit.libreoffice.org/29800
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: Ie218f87dc2f1c1b6031cc08f2027cfcf392c6c21
|
|
Change-Id: I806b8f445fad02e7dceff6263828fe9d8667341e
|
|
Change-Id: Ie76dd70a6a0960ee49df6e31a171761fdaf88f53
|
|
Change-Id: Idf11c19d861a95e0f4a0a2d9c7c7cd8739e71282
Reviewed-on: https://gerrit.libreoffice.org/29745
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
- also add gbuild selftest to test this (and possibly more later)
Change-Id: Ia4ef41095613e596f39d107df700e929579ba45f
Reviewed-on: https://gerrit.libreoffice.org/29744
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: Ie6e54c291f92dfede113a1d0fa20771482d93605
Reviewed-on: https://gerrit.libreoffice.org/29743
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Currently LFS_CFLAGS are only used in a handful of libraries but there's
no obvious reason why it can't just be set everywhere.
Also set it in windows.mk, i have no idea if it's needed for MinGW
(certainly not for MSVC).
Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
|
|
signedness and long vs int corrections
Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48
Reviewed-on: https://gerrit.libreoffice.org/29355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9
Reviewed-on: https://gerrit.libreoffice.org/29436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Commit b078e0d638514b298616838fae090b8294bac32f introduced the problem
that gdb will load via LD_LIBRARY_PATH the libpython3.5m.so.1.0 from
INSTDIR instead of the one from the system, which makes it unhappy (at
least on Fedora 24).
Try to hack around that by detecting that the user wants to run gdb, and
passing in a command "set environment LD_LIBRARY_PATH ..." so that "run"
inside gdb uses the custom LD_LIBRARY_PATH but gdb itself does not.
Change-Id: I1d29d2af1a77ffab3e718a876c17c29de444c6d9
Reviewed-on: https://gerrit.libreoffice.org/29349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I8574c0b731efecb174370d09cfea2c89c27ab974
|
|
Change-Id: Iaf77d03d8116273054ae3efca88f44fd926bf211
|
|
Change-Id: Ic7515c1d43737fb6864228d37be1b356acecfdc3
Reviewed-on: https://gerrit.libreoffice.org/29253
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This did not take effect anyway because unxgcc.mk unconditionally
overwrites it; see
https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html
Nobody knows why it was added so just remove it.
Change-Id: Ib1a6d06ed8e380e63c588a72b6a65bfbeaacb924
|
|
This did not take effect anyway because unxgcc.mk unconditionally
overwrites it; see
https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html
Change-Id: I33a2ae9aae44d974d6b5466a2d7dae61ae5cc92c
|
|
... since commit 8541943b8d08f62217e99c9d47a5f222e1fba86e
Change-Id: I56b12ebd59b8387878f20d625381d3f743558a43
|
|
Removes 220 warnings from build log (at least under Windows).
Requires Python 2.5+
Change-Id: I06b18b14a08f2c27528fcb009faddff081ffd54e
Reviewed-on: https://gerrit.libreoffice.org/29172
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iec52b93746b2fd9bbd6ad67667092717f39222d7
|
|
...after ecd5d49dc30d11845ccc1a14e26bf37d73959463 "liblangtag: prevent libtool
from adding annoying stuff to RPATH". "Outsmarting" libtool in the way
described in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1 "Fix Linux RPATH of
various external modules" only works if there's no utility applications in the
outsmarted module, that are run while building the outsmarted module (cf. the
redland case in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1). To work around that,
pass in an LD_LIBRARY_PATH (or equivalent) that finds the relevant libs as built
in that module.
(And gb_Helper_extend_ld_path was until now only available in com_GCC_defs.mk.
There, it accepts any number of paths separated by ":". When used in a
platform-independend way like it is used here, it will only support a single
path.)
Change-Id: Ic615e436b19b8b9aa7daa019c8f5287de90c3abc
|
|
The check for broken -fvisiblity-inlines-hidden doesn't mention a specific bug.
Its roots date back to 072e89cf68dcf9b6713945e402dd7a9fe5cea48d "INTEGRATION:
CWS newportstl" of the --with(out)-stlport area. Lets assume whatever failure
is long since fixed.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I7c64c2e8b9bd342beec9b84ff71f5712a6155b7d
Reviewed-on: https://gerrit.libreoffice.org/29075
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* GCC documents -fvisibility at least as far back as the GCC 4.0 online
documentation at
<https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>.
* For external code, odk/settings/settings.mk unconditionally set
HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112
Reviewed-on: https://gerrit.libreoffice.org/29073
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Already with Xcode 7.3.1 some unit tests crash when the code is built
with full optimisation. Xcode 8 did not help. So use -O1. Yeah, this
sucks. Don't have time to investigate in detail.
Change-Id: I0cffad1a3ee3ee86b61eca3c856476133125049b
|
|
...at least with both gcc-6.1.1-3.fc24.x86_64 and a recent GCC 7 trunk build it
produces lots of incomprehensible (potentially false positive) occurrences in a
--disable-debug build, like
> [CXX] store/source/stordir.cxx
> In file included from /home/sbergman/lo/core/store/source/stordir.hxx:30:0,
> from /home/sbergman/lo/core/store/source/stordir.cxx:20:
> /home/sbergman/lo/core/store/source/storbase.hxx: In member function ‘storeError store::OStoreDirectory_Impl::create(store::OStorePageManager*, rtl_String*, rtl_String*, storeAccessMode)’:
> /home/sbergman/lo/core/store/source/storbase.hxx:237:23: error: potential null pointer dereference [-Werror=null-dereference]
> m_nUsed = rhs.m_nUsed;
> ~~~~^~~~~~~
> /home/sbergman/lo/core/store/source/storbase.hxx:236:23: error: potential null pointer dereference [-Werror=null-dereference]
> m_nSize = rhs.m_nSize;
> ~~~~^~~~~~~
> /home/sbergman/lo/core/store/source/storbase.hxx:235:23: error: potential null pointer dereference [-Werror=null-dereference]
> m_nAddr = rhs.m_nAddr;
> ~~~~^~~~~~~
> [...]
> [CXX] store/source/storlckb.cxx
> In file included from /home/sbergman/lo/core/store/source/storlckb.hxx:29:0,
> from /home/sbergman/lo/core/store/source/storlckb.cxx:20:
> /home/sbergman/lo/core/store/source/storbase.hxx: In member function ‘storeError store::OStoreLockBytes::readAt(sal_uInt32, void*, sal_uInt32, sal_uInt32&)’:
> /home/sbergman/lo/core/store/source/storbase.hxx:595:26: error: potential null pointer dereference [-Werror=null-dereference]
> return isA<U>(p) ? static_cast<U*>(p) : 0;
> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351> "NULL dereference warnings"
looks like this is a known problem.
Change-Id: I5eb0c9def7dd12e3a440d280e3fa2331317031b4
|
|
Since there's hardly any 'deliver' going on anymore...
Change-Id: Id349958d299c9742382d37deab2125bc09930c14
Reviewed-on: https://gerrit.libreoffice.org/28655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|