summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2024-06-04windows packaging: reduce parallelism further to threeChristian Lohmaier
Some jenkins daily builders still run into issues from time to time, and even at a reduced parallelism of three it doesn't affect overall buildtime when building with just two or three languages and also not when building with all languages. There might be a number of languages where this has a penalty, but probably not a significant one. Change-Id: I778b5fe21fe8f9bb1fcca1da3c4c0eeeda6c29d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168403 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-06-04Fix typoAndrea Gelmini
Change-Id: I2c8899e5ab779dbd94c5096c72e2fbb09e40d4ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168377 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-03disable MSVC -analyse when run in CI - build time penalty is too muchChristian Lohmaier
times went from 55min to 88min when doing a single build Change-Id: I9304eae9f2326c206bd571e7b8a3ef861206282f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168362 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-02allow low-translation-completion-langs for dev-builds (e.g.: Sundanese)Christian Lohmaier
will be included when using --with-lang=ALL in non-release configuration (i.e. tinderbox provided daily builds), but not when using --enable-release-build. Change the way how configure fetches the list of all supported languages from a fancy sed call to running make with a dummy-recipe. Change-Id: I8bbea5fd95d37eac5bbce2e55ae34830b0ab4ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168334 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-05-31wsl-as-helper: enable gb_COLOR by default when using git-bashChristian Lohmaier
Change-Id: I3c24e8b3049e9bd669952ac3b24678bb3c5e1014
2024-05-29Emscripten: Unconditional --enable-wasm-exceptionsStephan Bergmann
(...which will be beneficial, in turn, to implement exception handling in the work-in-progress bridges/source/cpp_uno/gcc3_wasm UNO bridge). As per <https://developer.mozilla.org/en-US/docs/WebAssembly#browser_compatibility>, Wasm exceptions appear to be supported by most if not all relevant engines by now. * Lets see whether the "Note that to really use WASM exceptions everywhere" for external libraries in solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk does have any practical consequences (but ignoring it for now). * This change depends on the preceding 77129fbb74bcefde4551d494f029169e7c6026e3 "Emscripten: Add hack to prepare for --enable-wasm-exceptions" to work around the issue that was mentioned in static/README.wasm.md. * In unotest/source/embindtest/embindtest.js, getExceptionMessage started to work now, no longer exhibiting the RuntimeError that had been documented there for non-Wasm-based exceptions. Change-Id: Ifa2165b62208cc927844684911ddf21a4a2b624f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168169 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-05-18tdf#115357: Set Start Menu folder under Windows to \LibreOffice\kubak
Enhancement request. Change-Id: I128520432d33bd900d4385395f28a32d181485cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167141 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-17introduce SAL_RET_MAYBENULLCaolán McNamara
which for debug builds and MSVC uses _Ret_maybenull_ and -analyze to enforce null checking Change-Id: Id7f0ad854be7841819fdbdcd56c862d1a2df86c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166734 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-16MSI: Adds the missing ExtendedType column in the CustomAction tablekubak
ICE06 WARNING Column: ExtendedType of Table: CustomAction is not defined in database. https: //learn.microsoft.com/en-us/windows/win32/msi/ice06 https: //learn.microsoft.com/en-us/windows/win32/msi/customaction-table Change-Id: I5f9368fedf421b23a397f5dcd77f383cb9f42ac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166951 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-14drop some unused suppressionsCaolán McNamara
Change-Id: I09c0f9740fea3e42ab0bfd00ce839bc5849241ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167611 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-14annot: move TextAPI to svx and adapt the codeTomaž Vajngerl
TextApiObject is derived from SvxUnoText and holds and handles the text in the annotation. This functionality is changed to get rid of sd module specifics and moved to svx module. This now allows to move the most improtant parts of the Annotation object to svx. Change-Id: I34e238616e7fac973e75e79bb60a8d093c493258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166497 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2024-05-10gbuild: don't create empty services.rdb on "make postprocess"Michael Stahl
Since commit db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3 "make postprocess.clea; make postprocess" will result in an empty services.rdb, because the components are added in makefiles in other modules. Detect the problem and tell the user to run top-level make. Change-Id: Iab1a15efa5a4c9bb3e90e44f82a9510dff724c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167354 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-05-08Emscripten: Towards a working C++ UNO bridgeStephan Bergmann
...by making the general UNO -> C++ function call case work (modulo handling exceptions, which I'll look into later). Wasm call_indirect unfortunately needs to statically know the call target's signature, so we statically need to know all possible signatures. So introduce wasmcallgen helper to scan the existing UNOIDL API upfront and generate the relevant callvirtualfunction-wrapper.cxx and callvirtualfunction-inst.s code. (The good thing is that the number of different signatures is somewhat limited, each parameter can only be one of i32, i64, f32, or f64. So even if 3rd-party extensions bring along new UNOIDL interface methods, chances are relatively high that the signatures needed for them would already be covered by the existing ones.) Testing this can nicely be done in unotest/source/embindtest/embindtest.js via css.script.Invocation (which internally exercises the relevant code). (Instead of adding individual org.libreoffice.embindtest.StructLong/String etc., it would be nicer to introduce some polymorphic StructOne<T>, but the Emind UNO binding does not support polymorphic structs, so the embindtest.js code would not work.) Change-Id: If829c9e3772bfd27561f3ad743d38a71d11545b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167308 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-05-07Add gb_Library_add_generated_asmobjectsStephan Bergmann
...to be used by a follow up commit in EMSCRIPTEN's bridges/Library_cpp_uno.mk Change-Id: Iaebc18d40241d9b7918061100b25cca8a8bc4e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-05-07Revert "make skia into static library"Noel Grandin
This reverts commit 6517ce70e50e61441484e7ee7a4be0e265020175. Reason for revert: <_rene__> noelgrandin: ping? <_rene__> noelgrandin: /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/LinkTarget/StaticLibrary/libskia.a: error adding symbols: archive has no index; run ranlib to add one <_rene__> noelgrandin: caused by your skia static library change. I think I pointed that out once already... <_rene__> $ ld -v <_rene__> GNU ld (GNU Binutils for Debian) 2.42 <noelgrandin> hmm, it's not an ld version issue, because I have ld 2.41 <_rene__> gcc version 13.2.0 (Debian 13.2.0-24) <_rene__> and <_rene__> Debian clang version 16.0.6 (27) <_rene__> fwiw, too <noelgrandin> is that a mergelibs build, or a regular build? <_rene__> mergelibs <_rene__> (the "normal" one, not =more) <_rene__> noelgrandin: ... and LTO <_rene__> noelgrandin: (saying because googling gives me https://github.com/mesonbuild/meson/issues/8371. and yes, .a is built with clang and the rest with gcc "of course") <_rene__> noelgrandin: but the Linux release builds _do_ that: <_rene__> $ grep -E "(lto|merge)" distro-configs/LibreOfficeLinux.conf <_rene__> --enable-mergelibs <_rene__> --enable-lto <_rene__> $ <loircbot> LibreOffice (core) [libreoffice-7-6-7] lohmaier+LibreOffice · readlicense_oo/license/CREDITS.fodt · update credits <noelgrandin> oh yeah, good spotting <noelgrandin> yes, LTO is going to be a problem because skia is built with clang Change-Id: I96c63109d2856c6e4cb22cf9ac945d4cfa9848c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167227 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org> Tested-by: Jenkins
2024-05-07make skia into static libraryNoel Grandin
(1) we only use it from inside vcl (2) it exports a boatload of symbols (3) its a performance hotspot so lets link it inside and give the optimiser as much room as possible. Change-Id: If19d5556e3b45f40ef09d1e9225d12ef5f1ec32a Change-Id: I3d5edca20f5a15e8981f17fe9fcb9a338006eaff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167273 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-07fix Windows incremental buildNoel Grandin
after commit 4c86718e78c6b18c84774e48ca025694364c251a Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Date: Thu Apr 18 12:45:01 2024 +0200 initial support for running autogen.sh inside wsl from git-bash otherwise we end up with mixed cygwin/windows paths in our .d files, which the make executable we use will not like. Change-Id: Ia1325793f47657a23774c216df319ae6afd6d638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167269 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-06makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo)Christian Lohmaier
…by a simple/static $(gb_UnpackedTarball_workdir)/foo see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Change-Id: I8e6aa55c85534c4446556548910c950ddbe7c6fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167163 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-05-04turn gb_HelpTranslatePartTarget_get_workdir into errorChristian Lohmaier
separate commit since that macro is used in helpcontent submodule Change-Id: I2525b03eadf75b108499701f7f576634619cbf1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167123 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-04makefile simplification: replace $(call ↵Christian Lohmaier
gb_HelpTranslatePartTarget_get_workdir,foo) …by a simple/static $(gb_HelpTranslatePartTarget_workdir)/foo see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Change-Id: I2525b03eadf75b108499701f7f576634619ccf1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167122 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-04makefile simplification: replace $(call gb_HelpTarget_get_workdir,foo)Christian Lohmaier
…by a simple/static $(gb_HelpTarget_workdir)/foo see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Change-Id: Ibe4ce564b021158f3b1800fad96bdeee88792a97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167121 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-04makefile simplification: replace $(call gb_Galley_get_workdir,foo)Christian Lohmaier
…by a simple/static $(gb_Gallery_workdir)/foo see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Change-Id: Iaa2ab218b329a15c7bf2ea528e2612a3a6b44f6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167120 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-05-04makefile simplification: replace $(call gb_Extension_get_workdir,foo)Christian Lohmaier
…by a simple/static $(gb_Extension_workdir)/foo see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Change-Id: Id0184717f2cc30af792266b233eec957b99e7e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167119 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-03turn gb_CustomTarget_get_workdir into error and remove old _repo_targetsChristian Lohmaier
separate commit since help submodule also uses the macro. actually turn it into make error to prevent reintroducing it the repo_target ones are from way back when the whole repo was split up in many different ones and not used for many years, no point in having those as errors Change-Id: I9fd42529d08ea7859b33f8570936f06039cfa184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167006 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-03makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)Christian Lohmaier
…by a simple/static $(gb_CustomTarget_workdir)/foo The build system has a lot of overly complicated leftovers from when it was introduced and had not only deal with split repositories but also had to coexist with another buildsystem. Along with lots of copy'n'paste along the years the makefiles became hard to grasp for newcomers with all our calls and evals. As a first step to streamline that, the macros from TargetLocations that simply prefix a static path to the argument (and similar of the same kind) are a natural pick before simplifying the rules themselves/getting rid of a bunch of eval statements. Change-Id: Ia06dbbcd5d1994755a2ff05b84f72ccbc4e3cab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167005 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-02Prepare to run (select) tests during Emscripten buildStephan Bergmann
...by e.g. executing generated Wasm code with node. This requires check targets to not be skipped unconditionally, unlike for other CROSS_COMPILING builds, so introduce gb_CAN_EXECUTE_HOST_CODE to distinguish these cases. Which revealed that some CppunitTest targets unconditionally used artefacts that are covered by some ENABLE_WASM_STRIP_*, so made those uses conditional accordingly (even though the resulting binaries might actually be dysfunctional, lacking relevant parts; we'll fix that if and when we actually build and run them). Change-Id: I7144eeb908ede25358a3c8186198ac532de4d9f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166931 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-30Emscripten: Only add the --pre-js code to the soffice executableStephan Bergmann
...so that e.g. executing `echo test | node instdir/program/uri-encode.js` doesn't fail with > instdir/program/uri-encode.js:460 > throw ex; > ^ > > ReferenceError: XMLHttpRequest is not defined > at runMetaWithFS (instdir/program/uri-encode.js:312:15) > at callRuntimeCallbacks (instdir/program/uri-encode.js:1882:26) > at preRun (instdir/program/uri-encode.js:913:3) > at run (instdir/program/uri-encode.js:6854:3) > at runCaller (instdir/program/uri-encode.js:6802:19) > at removeRunDependency (instdir/program/uri-encode.js:1060:7) > at receiveInstance (instdir/program/uri-encode.js:1265:5) > at receiveInstantiationResult (instdir/program/uri-encode.js:1281:5) (There's nothing special about uri-encode here, it just happens to be the only other executable that is built into instdir/program/ by the Emscripten build, even if it is probably not even useful there. It expects to read something from stdin, hence the echo part.) (The generic solenv/gbuild/Executable.mk no longer depends on soffice.data.js.link, but it still depends on soffice.data and soffice.data.js.metadata for some cp instructions in solenv/gbuild/platform/unxgcc.mk, so make those dependencies explicit. That can probably be cleaned up further in a next step.) Change-Id: I993878a5f6d19d13728d17e803ae7d773946a1d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166930 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-04-29ofz#68265 fix oss-fuzz build failureCaolán McNamara
Change-Id: I73087235d87253f4c8375fa0c0492c6258701571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166827 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-04-28Drop CacheConfiguration in favor of officecfgGabor Kelemen
Also the key path was wrong in SlsCacheConfiguration.cxx: MultiPaneGUI/SlideSorter/PreviewCache but in Impress.xcs we have MultiPaneGUI/SlideSorterBar/PreviewCache hierarchy so this may actually now start to work :) Change-Id: I4b552be713e6e157edb45692ba78101429aa1c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166755 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-27fix mergelibs buildNoel Grandin
since commit 828c1999e08c5bfad0a1d0e6e5ab07ee8bbc427e Author: Noel Grandin <noelgrandin@gmail.com> Date: Wed Apr 10 16:50:51 2024 +0100 move writerfilter inside sw Change-Id: I1c8b37510ccdd640937669f36c8086f5f65183f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166782 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-04-27solenv, gdb fix error while loading the sw_writerfilter pretty printerMiklos Vajna
Fixes: Traceback (most recent call last): File "/home/vmiklos/git/libreoffice/core-clang/instdir/program/libsw_writerfilterlo.so-gdb.py", line 23, in <module> module = importlib.import_module('libreoffice.' + mod) File "/usr/lib64/python3.6/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 994, in _gcd_import File "<frozen importlib._bootstrap>", line 971, in _find_and_load File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked ModuleNotFoundError: No module named 'libreoffice.sw_writerfilter' When loading a DOCX file while gdb is attached to the soffice process. Change-Id: I383cadfe6afcd3673adecf46388376a6341dbc93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-26gbuild trace: disable flock for wsl-as-helper caseChristian Lohmaier
Change-Id: Ie5db3fcc6fccedb214aec472852d8d82813fb984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166744 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26run bison, flex and nasm via wsl in wsl-as-helper caseChristian Lohmaier
Change-Id: Ic3e82b72605cd0b5458bd31ab5ff5285adb3db75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166340 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26run gperf via wsl in wsl-as-helper caseChristian Lohmaier
also split up the gperf commands when generating sw/generated/tokens.cxx wsl has trouble appending using shell redirects, so use separate targets and use cat in the final processing step for tokens.cxx see also https://github.com/microsoft/WSL/issues/4400 Change-Id: Id7a24d060e9be71113ec2827a389d347456f6522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166338 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-04-26run zip via wsl in wsl-as-helper caseChristian Lohmaier
Change-Id: I0c5b75c39c211aba08ae6d56f02bcc93ca11e2bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166337 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26extracting tarballs that call helpers to uncompress require unix-style pathsChristian Lohmaier
Change-Id: I528e343fb5b22194b4639649fbfc04c0583f77c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166336 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26initial support for running autogen.sh inside wsl from git-bashChristian Lohmaier
Change-Id: I4272ea817a48880fd4206d6c73add7ccb8c4f6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166335 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26simplify some sed rules/statements and use proper quotingChristian Lohmaier
make removes partially built targets in case the rule exits with non-zero status, so creating a temp file and moving it is not necessary also use single quotes for cases where characters might be interpreted by the shell Also combine multiple sed calls into a single call of sed with multiple expressions and replace additional "grep -v foo" with corresponding sed delete command Change-Id: Iff7e3b962175e347e5ed100a87c96fbaeef39985 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166410 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26don't throw away command output when packaging installsetsChristian Lohmaier
and adjust installer to work with MSWin-style perl (like strawberry perl) Change-Id: I9305c7cb6ef72560bbf77626f113f3ee439b3ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166331 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26drop some unused suppressionsCaolán McNamara
Change-Id: Ifc15ca8a9e9d25df1a0da12b8139d063f5d2e91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-26MSI: Fix use of illegal character "@"kubak
ICE03 ERROR Invalid identifier; Example: flt14.mo gid_file_res_flt_lang__libreoffice_program_resource_ca@valen_dcb80460e flt.mo 55482 2051 16384 13967 We use the illegal "@" sign. Changing to underscore "_". https: //learn.microsoft.com/en-us/windows/win32/msi/identifier Change-Id: I50c40a3cde3f4b57b71ddda9876f27db08aa0970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166580 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-26MSI: Fix use of illegal character in table Binarykubak
ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows61-KB2999226-x64msu ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows81-KB2999226-x64msu ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows8-RT-KB2999226-x64msu We use the illegal "-" character. https: //learn.microsoft.com/en-us/windows/win32/msi/binary-table https: //learn.microsoft.com/en-us/windows/win32/msi/identifier Change-Id: I44aea358964c085599ab42f134535fa97840dd26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166567 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-26Drop now unused sdiocmpt.cxxGabor Kelemen
Change-Id: Ibba331a536bbd6f228df005c3488a722a3631d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166634 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-24windows: set CONFIG_SHELL for external configure runsChristian Lohmaier
Change-Id: I9cb03692524eced35935ad1979027f7b196e5ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166329 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22add undefining FORTIFY_SOURCE to the gcc no-opt flagsCaolán McNamara
We build non-optimized files by adding the no-opt flags to the compiler options that include the optimized flags, so add undefining FORTIFY_SOURCE to the -O0 line motivation here to have --enable-hardening-flags not add unhelpful extra warnings to the build for the parts built with -O0 Change-Id: Ib5416ad7f9f5ef907d7c767a5ebff6343b035cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166458 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-22add generic %/.dir target that can be used in order-only prerequisitesChristian Lohmaier
Change-Id: I7a919004100ff6319806bbdf016fda6a3a39661a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166327 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22avoid exceeding command-line length limits when using zipChristian Lohmaier
to package an Extension. With all languages enabled one can reach the limit with longish buildpaths Change-Id: I8943d6570ded57761350311fb34a0cf469d3ce83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166326 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22com_MSC_class: set MAKE=nmake in gb_NMAKE_VARSChristian Lohmaier
Change-Id: I485a486efba39c12c52d7461f4b235163f009042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166325 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22help: don't use clean targets as .PHONY targetsChristian Lohmaier
Change-Id: Ic86270980823efb8dafd9d00ce33f986203cd975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166323 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22configure already sets TMPDIR to mixed pathChristian Lohmaier
Change-Id: I72070b054fb505c25f03ff46e7e663d1c1733ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166322 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>