summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2022-06-13loplugin:mergeclasses sd::TitledDockingWindow with sd::PaneDockingWindowNoel Grandin
Change-Id: I77314048173ebba0dc0e03f710607b74e73f0bde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-11[API CHANGE] Deprecate css.registry.XSimpleRegistry::mergeKeyStephan Bergmann
...and let its implementations just throw a RuntimeException, now that regmerge has been removed in "[API CHANGE] Remove deprecated idlc and regmerge from the SDK". Deprecate css.registry.MergeConflictException along with it (though stoc/source/implementationregistration/ still uses it internally). And remove the previously unused include/registry/writer.hxx along with the newly unused include/registry/writer.h, RegistryTypeWriter, and RegistryTypeReader. Change-Id: I10fd286617975dc0ef9f74460a3a3eab8060939d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123615 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-10[API CHANGE] Remove deprecated idlc and regmerge from the SDKStephan Bergmann
* Client code must replace uses of idlc and regmerge with uses of unoidl-write, see the changes to odk/examples/ and ure/source/uretext/ in 40f2aee6584eafcf4cd1d95fcf1f775e5435440d "Provide unoidl-write also for the SDK" for examples. * The new types.rdb format is not compatible with LibreOffice < 4.1. Clients generating extensions containing such files are advised to use appropriate LibreOffice-minimal-version elements. * For compatibility with old extensions, reading the legacy types.rdb format is still supported. * The SDK no longer ships an idl/ sub-directory containing the udkap and offapi .idl files (as, unlike idlc, unoidl-write does not need them). odk/config/cfgWin.js had to be adapted to look (somewhat arbitrarily) for an examples/ sub-directory instead of idl/ when checking for "an sdk folder". gb_UnoApi_package_idlfiles became unused and has been removed. * The idlc and regmerge executables have been removed. Module idlc has been removed except for idlc/test/parser/, which is also used by CustomTarget_unoidl/unoidl-write_test, and which may eventually be moved into module unoidl. Module external/ucpp and the corresponding configure options have also been removed. Change-Id: I42a0231699b863b5ebe2bee63bc32c8f79278cc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122363 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-10new loplugin:moveitNoel Grandin
look for local variables that can be std::move'd to parameters off by default, since it doesn't do proper data flow analysis Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-08drop two unused suppressionsCaolán McNamara
Change-Id: I0bf5bed7fbfb3b46c1c9a48969f492b5745b1fb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135511 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-08VCL add vcl::WindowPosSize abstract classJan-Marek Glogowski
... and use it to remove a duplicate and simplify code. Should mostly be a refactoring, which was mainly done by some larger sed calls, except for the new API calls, which helped shrinking some LOC. All data is also now private. Originally two of the "replaced" "classes" had unsigned width and height and one had signed. Noel pointed out, that during calculations, the value might get negative temporarly, so this now settles with signed values. Still the set size should never be negative and this is enforced this way. Not sure that is what Noel had in mind. This also includes: - rename WindowState => WindowData - rename WindowStateMask => WindowDataMask - rename WindowStateState => WindowState - move WindowState and WindowDataMask to vcl/windowstate.hxx - move WindowData(Mask) and WindowState into vcl namespace - readability: replace or'ed WindowState enums with "meta" enums + add "meta" WindowState enums PosSize and PosSizeState Change-Id: Icd16cfb498531aa7238ddbde83fcb0ed6d9e4f77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135426 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-08it is not our job to tell GCC whether to colorize its outputLuboš Luňák
GCC's -fdiagnostics-color option is complex (read: brain-damaged), since it depends on how the compiler was configured during building it (https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Message-Formatting-Options.html). So while with Clang coloring works out of the box and the option can be used for force it in special cases, GCC depending on how it's been built may (or may not) require the option explicitly just to do the sane default. 13b52f50e52d226c935dcb94fac641c59a77f13f added an explicitly =auto to handle that, and then 9ab2703d5c212746c961dcb238a4c3025d3a2587 changed it to =always depending on gb_COLOR to prevent it from overriding explicitly used option. This results in a possible massive rebuild when redirecting build output (because e.g. PCHs get rebuilt if build flags change, and ccache I think cannot use cached compilations either). It should not be gbuild's job to go out of its way to handle broken tooling, so just revert both of those. If somebody uses such a lame GCC build, either don't do that, add those explicit flags to CXX/ENVCFLAGSCXX, or create a clean way to add flags to CXXFLAGS or something. Change-Id: Ieac6ac7dd198639529aba8f47983587771772349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135467 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-07Resolves tdf#146928 - Redesign charnamedialogHeiko Tietze
Dialog was changed in d73602dc51aa8829fc88e5e67e2b0c4da6b8f715 to fit vertical size on small screens by placing Western/CJK/CTL into a notebook. But for CJK and CTL it's required to have Western fonts visible in parallel. * dual solution for western with nocjk and cjk dropped western scales to the dialog width if no CJK nor CTL is enabled * CJK and CTL placed in a notebook, Western as well for proper alignment * font names are presented in lists but size and style per simple dropdowns * info text sized at 80% * variables renamed to keep track of controls (old names kept in l10n descriotion) * UITests adjusted for variable names and tab positioning Change-Id: I45b40e9bc37565f6364f1dfc1b5d837270fe4644 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134666 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-05-26use at least assertions mode if libc++ debug mode is not usableLuboš Luňák
This way at least e.g. std::vector::operator[] will still check bounds even though things like iterator debugging will not work. Change-Id: If3c550cfec68eee9a19050fc8e60fca07148b4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134946 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-25Advanced Diagram support: Isolated IDiagramHelper, selection visualizationArmin Le Grand (Allotropia)
Moved and isolated IDiagramHelper to own file to get SdrObjGroup smaller and less dependent again, all places adapted. isDiagram() now available at SdrObject directly, adapted and have less places which need to cast for SdrObjGroup for check. Started to add SdrHdl/selection visualization to seleced Diagram. Only as a start, will need to be extended to look good/better, plus evtl. functionality in handles/UI. Corrected error(s) found by failing UnitTests More clang-notes (static, namespace) I nneeded to follow Change-Id: If4675b3270d3ee30259fce49deb017dbbaf5c0c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134825 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-05-23instantiate Title directly in chartNoel Grandin
which simplifies some code Change-Id: I0c9aa212334a3dedd8a54f8deda6100d93b0be70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134743 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-22Get make_installer calls to run in parallelThorsten Behrens
If available, use GNU parallel to run N make_installer.pl scripts in parallel, to scale packaging LibreOffice up with the rest of gbuild. * fallback if no GNU parallel found - run make_installer sequentially as before * push most of the make_installer.pl input param tweaks from gbuild down into a shared call_installer.sh script * call gnu parallel with generated number of "templ:lang:prodname:ext:pkgfmt:strip-flag" tuples, one for each package to build (empty templ for non-windows, to save on cmd line length) * such that we can run all those in parallel (taking into account the build's PARALLELISM parameter) * there's still the main package build running epm sequentially for umpteen sub-packages from within _one_ make_installer.pl instance, but that's much harder to parallelize from inside Perl (so we punt on that here) Change-Id: Ie7d3084ed60d003d587c5e64dc9fb1809b23e409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133957 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-21drop unused hxx filesCaolán McNamara
Change-Id: I68ea314f20b599c181f2ae9f264037918419d15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134715 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-20new loplugin:unnecessary lockingNoel Grandin
off by default, since each warning needs careful inspection Change-Id: I805c1d1cdde531a1afdc76e87b22f879fc3c9753 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-19add a static role to minlenft messageCaolán McNamara
Change-Id: I175c2f13908dd0e4fa40f73f8ef4349cfd9737d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134525 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-18tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actionsSamuel Mehrbrodt
This duplicates MSI functionality - if a folder cannot be written, MSI should request a reboot automatically. See https://bugs.documentfoundation.org/show_bug.cgi?id=149106#c17 for details. Change-Id: I65f295ff6e3bb22afc616feb2ba529413f3e24c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134513 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2022-05-18Adapt flatpak build to recently introduced dependenciesStephan Bergmann
Change-Id: I48ffef665514378740b4146e2368f65930f74270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134502 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-16enable libc++ debug mode again if availableLuboš Luňák
Now includes a configure check for the std::to_string() crash. Change-Id: I45c3b804b7a1ff5f6520f7bdf772497f72ddee47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134338 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-13officecfg,stoc: allow running JVM UNO components out-of-processMichael Stahl
The problem is that 32-bit Win32 applications have very little VM, and soffice.bin can run out, so try to move the JVM to a separate process (uno.bin) and connect to it via pipe. Add a new config to enable this: "org.openoffice.Office.Java/VirtualMachine/RunUnoComponentsOutOfProcess" If enabled, ServiceManager instantiates *all* JVM components out-of-process, by instantiating "com.sun.star.java.theJavaVirtualMachine" out-of-process. To ensure that the remote connection is disconnected at shutdown (and thereby prevent crashes with remote calls during late shutdown), JavaComponentLoader is now a "single-instance" service; this change should be harmless for the default in-process configuration case. Tested with these extensions: Wiki Publisher smoketest TestExtension.oxt odk CalcAddins.oxt Inspector.oxt ToDo.oxt Also passed "make check" on Linux when enabled, if the variable URE_BIN_DIR is set properly for CppunitTest_services. Change-Id: I76bf17a9512414b67dbd20daee25a6d29c05f9d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133218 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-12Create a visualizer for OUStringLiteralMike Kaganski
... and adjust _rtl_uString visualizer to use 'u' prefix, not 'L' Change-Id: Ie3b5de9c69fea8588503f22d1d367a28148d7f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134178 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-09remove HAVE_LIBCPP_DEBUG (libc++ debug mode)Luboš Luňák
It's currently too broken (https://reviews.llvm.org/D125184), but they're working on fixing it, so hopefully somewhen later. Change-Id: I3ca243a57d41bd9d8c4cdbdc4a6a3b5fdc49e4c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134023 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-04Drop --with-iwyu optionGabor Kelemen
Nowadays the bin/find-unneeded-includes script is a better solution for this problem This essentially reverts the commits: c716b3888e7e8150d1c1053ee6550afb56438b1f 096c7e889f3b9bd42a81fb0216e2a68fb27159fc 40e7eecb7efeeb9af59206d7a9c82ac55adf5279 Change-Id: I404a4b34176efaacf961605559af9de6d6cba10a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133540 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-03Resolves tdf#148568 - Rework the Sparklines dialogHeiko Tietze
* controls rearranged and variables renamed * radiobuttons changed into comboboxes Change-Id: Ifda426b5fa9596c2b23c335165785c0cb341433f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133636 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2022-05-03Keep passing LDFLAGS into external proejct buildsStephan Bergmann
...which had been broken with 1ffd6897ddf15624e70585ab08e8af713114c938 "try to use also proper debug LDFLAGS for externals libraries", and e.g. one of my macOS builds uses a non-standard Clang compiler and libc++ library, and thus needs LDFLAGS=-L/Users/stephan/llvm/inst/lib in autogen.input Change-Id: Iae67a4a13603b0241e5cd6c0d01a07ac898ffb58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133746 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-01improve support for using libc++ on Linux and for libc++ debug modeLuboš Luňák
It seems to run slightly faster in --enable-dbgutil mode and also builds a bit faster (at least with Clang). But libc++ on Mac isn't built with debug mode support. Change-Id: Idf5dba9c4a56aba1f4163aa518a78d34b6837149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133664 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-01try to use also proper debug LDFLAGS for externals librariesLuboš Luňák
This is basically ea68de2968c0dbcd8e7549435e829db06795c16d but for LDFLAGS. A number of external libs cannot use this because their libtool mishandles -fuse-ld. Change-Id: Idee379eb0a3afb475b536519ee3de064b4e218f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133639 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-30new loplugin:stringviewdangleNoel Grandin
to find places where string_view is pointing into a temporary String Change-Id: Ib530b36f441e95d83d8f687d40a97516a0806721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133656 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-29gbuild: Drop obsolete checks for make version 3.81Michael Weghorn
make 3.81 is no more suppoprted, see commit 4688e74bcf0c58ab1bbf60e9c19331d25ebfe95b Date: Fri Apr 8 11:22:27 2022 +0200 configure: require GNU make 3.82 Change-Id: I0f820512df96fa1712374d3308d15591799222fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133592 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-27tdf#126658 UI improvements to Arrow Styles tab in Line dialogSeth Chaiklin
* label "Organize Arrow Styles -> "Manage Arrow Styles" * label "Title" -> "Style _name" * button label "_Modify" -> "_Rename" + Add a tooltip for "Rename" - Remove label "Add..." (which was inadequate) + Add tooltip and extended tooltip for "Add" button Change-Id: I0226b32158c3bb9ae2600f8bfce3739f2ddbe5c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26natvis: some extra patterns for SvRefs<...> and writerfilterVasily Melenchuk
Change-Id: I077232d641fee38da0f50cb838091c0fd0787189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133416 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2022-04-22move query-related iterators to a new separate fileLuboš Luňák
dociter.cxx/hxx are already quite big as it is, and the query iterators are more about queries than about iterating the document. Change-Id: I49e3a5636e4f366efb8b4968f54567d2716ade35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133323 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-19new loplugin:stringviewvar looks for OUString vars that can beNoel Grandin
... that can be string_view Change-Id: I0ddf66725e08b58e866a764f57200dd188b9f639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-13tdf#148553 liblo-native-code: Add services for numeric controlsMichael Weghorn
Change-Id: I67727b8ced6c501f0e220fa2024976640ca7028a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132950 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-12use gb_DEBUGINFO_FLAGS consistently in gbuild ExternalProject'sLuboš Luňák
A number of them didn't use it at all, others had it hand-written in various ways. Change-Id: Iaf86325f9cdc032926bac917dc3eef4e34661544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132818 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12Delete tempfile when doneStephan Bergmann
Change-Id: Ide7acab1ab8eae760f9818248ce44d07ca92a6f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-06Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/e7cb9cff2cf5db044195a7626327bd29b4b00c44> "Merge pull request #184 from xlejo/adding-gvfsd: Adding xdg-run/gvfsd" Change-Id: I1b700c1e7170e67abf3fb1351be9f8c11cc15f8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132617 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-31Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/1ad91b85a5bb60f38a505756a0b5c338a8cb49fb> "Merge pull request #183 from ourigen/fallback-x11: Change socket to fallback-x11 to fix 'Unsafe' warning" Change-Id: I9613d15cd74ac28e2d55eeed4a801a65062d5ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132362 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-30WASM fix native EH build since Emscripten 3.1.6Jan-Marek Glogowski
Building LO with WASM native EH and Emscripten 3.1.6+, the link fails with a missing "emscripten_longjmp" symbol. Actually the old build was simply wrong, because the emscripten_longjmp function is just used for the Emscripten SjLj and not the native WASM SjLj implementation. Linking just worked, because the used libcompiler_rt-wasm-sjlj-mt.a lib was incorrectly providing that symbol, which 3.1.6 removed. But since running the NEH build still fails early in the same way then before in FF nightly 100 and Chrome (= failure in the LO job scheduler calling Task::UpdateMinPeriod for the "desktop::Desktop m_firstRunTimer" timer, resulting in a WASM VM "RuntimeError: indirect call signature mismatch"), there is still no way to know, if nothing else it missing. The Emscripten / JS EH build still works without any code changes. And it's not the first call on a job object that fails... And unfortunatly, because Qt itself also uses libpng, it also uses SjLj for error handling, like LO in the image import, so the Qt build must also be patched to build with "-s SUPPORT_LONGJMP=wasm". Simply enough to do (see README.wasm.md). LO's configure now detects that symbol and will bail out on incompatible Qt and LO build setup. See https://github.com/emscripten-core/emscripten/issues/16572 Change-Id: I3a1877f3aeb77873906176b9d3cd1ea92973f1f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132139 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-03-28Advanced Diagram support: Move data classes to svxArmin Le Grand (Allotropia)
As preparation for own im/export move data classes for which that is now possible to svx Made TypeConstant more safe, also sorted it. Corrected an error there. Secured TypeConstant usage by identifying usages (mnType -> mnXMLType). Had to convert from oox::OptValue to std::optional since 1st is not available in svx in datamodelcontext.cxx. That makes the test work and the test-file load corrrectly. Change-Id: Ifee008caf486ddb6b52a347dc08e7e053c49ef49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132195 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-03-28Drop support for OpenGL denylist on X11Stephan Bergmann
...which appears to have become even less relevant with db89f53c31af997b9bf422b0e784afba8d62a42e "remove OpenGL VCL backend code". And the vcl/unx/glxtest.cxx machinery that it is based on is (a) known to cause issues like <https://gitlab.freedesktop.org/mesa/mesa/-/issues/3957> "LibreOffice's OpenGL version detection code hangs when running inside a flatpak container with a different mesa version", and (b) is one of the two reasons why an soffice that uses Wayland nevertheless also requires Xwayland during startup (the other reason being oosplash). So getting rid of the glxtest machinery is beneficial. The remaining two potential uses of OpenGL on X11/Wayland are the obscure css.rendering.SpriteCanvas.OGL service implementation (about which db89f53c31af997b9bf422b0e784afba8d62a42e states that "it seems has never been finished or enabled (or so it most probably should be dumped too)") and some slideshow transitions. About the latter, Caolán stated on IRC: "I think we grew this set of stuff to check for dodgy opengl primarily for the case where vcl used opengl for ordinary UI optimizations; but I think that use is gone now so I wonder does it make sense to just drop all of that entirely; for just slide transitions we apparently survived fine without the denylist for ages". (And in any case there is still the WatchdogThread support with OpenGLZone::hardDisable in VCLExceptionSignal_impl, vcl/source/app/svmain.cxx, should any OpenGL code run into problems.) (The removal of gb_LinkTarget_use_glxtest from gb_LinkTarget_use_vclmain, which indirectly brought in gb_LinkTarget_use_libraries,*,vcl, revealed that an explicit use of vcl was missing from various Executables etc., which thus had to be added now.) Change-Id: Ifa5220fd09910a4459ca546d9655e479a2e38f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131943 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-19reduce down to the part and config we are using and move to toolsCaolán McNamara
Change-Id: Ifaddc59c3c7834808d368c138a5ec7c0b80db14c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-16Fix loplugin:trivialconstructor handling of ctor templatesStephan Bergmann
Change-Id: Ic8b2f26498099c77b834d8e152f06d2834dfee3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131658 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-15loplugin:trivialdestructor: Only warn about definitionsStephan Bergmann
Change-Id: I666e72a5c95b48cd5bc0cb775de3ec6a6c82fe39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131574 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-11loplugin:constparamsNoel Grandin
Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-09ofz#45373 and ofz#45362 fix ubsan issuesCaolán McNamara
replace the home grown 16.16 fixed math with an alternative Change-Id: If6fa4205aed62ff15157a8ab4dbf9b7c96e30216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131236 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08remove some member-of a11y relationsCaolán McNamara
In some cases the widgets are in frames now so that hierarchical relationship is captured already. In others labelled-by is a better match and/or is already labelled by the widget. Change-Id: Ifecd0eb96afecadbd66fcfdf843ce1590f5c5ff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131185 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08remove some member-of a11y relationsCaolán McNamara
In some cases the widgets are in frames now so that hierarchical relationship is captured already. In others labelled-by is a better match and/or is already labelled by the widget. Change-Id: I65cbeab514a443edd96c6f9353f892317ac5f775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-24Keep URE libraries out of Library_mergedStephan Bergmann
...to keep the (at least conceptional, but also reflected in how e.g. Linux distros split up LO into multiple packages) distinction between URE and LO proper. This partially reverts 424a7f404565e068995e2a9827d5bc6f76920ec8 "add some more libs to libmerged". Change-Id: I0bd435d9fe4dc4a4ad230990a999ad5e8c487cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130490 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-02-24Don't run ExternalExecutable_python with LD_LIBRARY_PATHStephan Bergmann
257bcb1a1140d3e070cfaef6fec0704740bc83b8 "get internal python invocations working" had made this use LD_LIBRARY_PATH or similar on the various platforms, but without giving any reason what it would actually be good for. 5d8f48c81eac8650315b936d0e89ad1d54b566fc "solver doesn't solve anything..." then (somewhat by chance?) removed it for solenv/gbuild/platform/macosx.mk, apparently without loss of functionality, but left it intact for other platforms. But at least in some Jenkins Linux build environments presence of LD_LIBRARY_PATH (pointing at instdir/program/) appears to cause subtle problems: Builds like <https://ci.libreoffice.org/job/lo_tb_master_linux/49844/> occasionally crashed with [...] > make -O [...] > [build PAT] python3 > [build PRJ] python3 [...] > [build PKG] python3 > [build EPK] python3 [...] > [build BIN] python3 [...] > [build MOD] python3 [...] > [build PRJ] nss [...] > make[1]: *** Deleting file '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors' > [build UIA] sfx > Suppression file: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr > False positive file: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.false > sfx2/uiconfig/ui/documentinfopage.ui: WARNING: 'GtkLabel' 'label8' does not specify what it labels within 'interface' > 1 new warning (64 suppressed by /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr, please fix them) > 0 new fatals (12 suppressed by /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr, please fix them) > Explanations are available on https://wiki.documentfoundation.org/Development/Accessibility > > /bin/sh: line 1: 31655 Segmentation fault (core dumped) LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program" PYTHONHOME="$I/program/python-core-3.8.12" PYTHONPATH="${PYPATH:+$PYPATH:}$I/program/python-core-3.8.12/lib:$I/program/python-core-3.8.12/lib/lib-dynload" $I/program/python.bin $S/bin/gla11y -P $S/ -f $S/solenv/sanitizers/ui/sfx.false -s $S/solenv/sanitizers/ui/sfx.suppr --widgets-suffixignored +ValueSet,HBox,VBox,ToolBox,Preview,PreviewWin,PreviewWindow,PrevWindow --widgets-button +svtlo-ManagedMenuButton --fatal-all --not-fatal-type duplicate-mnemonic --not-fatal-type labelled-by-and-mnemonic --not-fatal-type orphan-label -o $W/UIConfig/sfx.a11yerrors $S/sfx2/uiconfig/ui/alienwarndialog.ui $S/sfx2/uiconfig/ui/addtargetdialog.ui $S/sfx2/uiconfig/ui/autoredactdialog.ui $S/sfx2/uiconfig/ui/bookmarkdialog.ui $S/sfx2/uiconfig/ui/bookmarkmenu.ui $S/sfx2/uiconfig/ui/charmapcontrol.ui $S/sfx2/uiconfig/ui/charviewmenu.ui $S/sfx2/uiconfig/ui/checkin.ui $S/sfx2/uiconfig/ui/classificationbox.ui $S/sfx2/uiconfig/ui/cmisinfopage.ui $S/sfx2/uiconfig/ui/cmisline.ui $S/sfx2/uiconfig/ui/commandpopup.ui $S/sfx2/uiconfig/ui/custominfopage.ui $S/sfx2/uiconfig/ui/deck.ui $S/sfx2/uiconfig/ui/descriptioninfopage.ui $S/sfx2/uiconfig/ui/developmenttool.ui $S/sfx2/uiconfig/ui/devtoolsmenu.ui $S/sfx2/uiconfig/ui/documentfontspage.ui $S/sfx2/uiconfig/ui/documentinfopage.ui $S/sfx2/uiconfig/ui/documentpropertiesdialog.ui $S/sfx2/uiconfig/ui/editdocumentdialog.ui $S/sfx2/uiconfig/ui/editdurationdialog.ui $S/sfx2/uiconfig/ui/emojicontrol.ui $S/sfx2/uiconfig/ui/extrabutton.ui $S/sfx2/uiconfig/ui/errorfindemaildialog.ui $S/sfx2/uiconfig/ui/floatingrecord.ui $S/sfx2/uiconfig/ui/helpbookmarkpage.ui $S/sfx2/uiconfig/ui/helpcontrol.ui $S/sfx2/uiconfig/ui/helpcontentpage.ui $S/sfx2/uiconfig/ui/helpindexpage.ui $S/sfx2/uiconfig/ui/helpmanual.ui $S/sfx2/uiconfig/ui/helpsearchpage.ui $S/sfx2/uiconfig/ui/helpwindow.ui $S/sfx2/uiconfig/ui/infobar.ui $S/sfx2/uiconfig/ui/inputdialog.ui $S/sfx2/uiconfig/ui/licensedialog.ui $S/sfx2/uiconfig/ui/linefragment.ui $S/sfx2/uiconfig/ui/linkeditdialog.ui $S/sfx2/uiconfig/ui/loadtemplatedialog.ui $S/sfx2/uiconfig/ui/managestylepage.ui $S/sfx2/uiconfig/ui/navigator.ui $S/sfx2/uiconfig/ui/newstyle.ui $S/sfx2/uiconfig/ui/notebookbar.ui $S/sfx2/uiconfig/ui/optprintpage.ui $S/sfx2/uiconfig/ui/panel.ui $S/sfx2/uiconfig/ui/password.ui $S/sfx2/uiconfig/ui/notebookbarpopup.ui $S/sfx2/uiconfig/ui/printeroptionsdialog.ui $S/sfx2/uiconfig/ui/querysavedialog.ui $S/sfx2/uiconfig/ui/saveastemplatedlg.ui $S/sfx2/uiconfig/ui/safemodequerydialog.ui $S/sfx2/uiconfig/ui/searchdialog.ui $S/sfx2/uiconfig/ui/securityinfopage.ui $S/sfx2/uiconfig/ui/singletabdialog.ui $S/sfx2/uiconfig/ui/startcenter.ui $S/sfx2/uiconfig/ui/stylecontextmenu.ui $S/sfx2/uiconfig/ui/tabbar.ui $S/sfx2/uiconfig/ui/tabbarcontents.ui $S/sfx2/uiconfig/ui/tabbutton.ui $S/sfx2/uiconfig/ui/templatedlg.ui $S/sfx2/uiconfig/ui/templatecategorydlg.ui $S/sfx2/uiconfig/ui/templatepanel.ui $S/sfx2/uiconfig/ui/urlbox.ui $S/sfx2/uiconfig/ui/versionsofdialog.ui $S/sfx2/uiconfig/ui/versioncommentdialog.ui $S/sfx2/uiconfig/ui/versionscmis.ui > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/gbuild/UIConfig.mk:157: recipe for target '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors' failed > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors] Error 139 > make[1]: *** Waiting for unfinished jobs.... where the crashed instdir/program/python.bin is at > (gdb) thread apply all backtrace > > Thread 1 (Thread 0x2af0920e1a40 (LWP 30414)): > #0 0x0000000000000ae0 in ?? () > #1 0x00002af0920b008a in _dl_fini () from /lib64/ld-linux-x86-64.so.2 > #2 0x00002af093404ce9 in __run_exit_handlers () from /lib64/libc.so.6 > #3 0x00002af093404d37 in exit () from /lib64/libc.so.6 > #4 0x00002af0933ed55c in __libc_start_main () from /lib64/libc.so.6 > #5 0x000000000040068e in _start () with > (gdb) info sharedlibrary > From To Syms Read Shared Object Library > 0x00002af09232e2f0 0x00002af09253270c Yes /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/libpython3.8.so.1.0 > 0x00002af09286fe30 0x00002af092874cec Yes (*) /lib64/libcrypt.so.1 > 0x00002af092aab8f0 0x00002af092ab6db1 Yes (*) /lib64/libpthread.so.0 > 0x00002af092cc2e50 0x00002af092cc394e Yes (*) /lib64/libdl.so.2 > 0x00002af092ec6e90 0x00002af092ec77a4 Yes (*) /lib64/libutil.so.1 > 0x00002af0930ce350 0x00002af093139336 Yes (*) /lib64/libm.so.6 > 0x00002af0933ea9f0 0x00002af09353ab6f Yes (*) /lib64/libc.so.6 > 0x00002af093799a50 0x00002af09379a05a Yes (*) /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/libfreebl3.so > 0x00002af0920a0af0 0x00002af0920bc060 Yes (*) /lib64/ld-linux-x86-64.so.2 > 0x00002af09a0e3be0 0x00002af09a10aa53 Yes /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/python-core-3.8.12/lib/lib-dynload/pyexpat.cpython-3.8.so What is suspicious is that it uses instdir/program/libfreebl3.so when external/nss has been built ("[build PRJ] nss") but has not yet been fully delivered (no "[build PKG] nss"). It uses instdir/program/libfreebl3.so because on that machine instdir/program/python.bin has a DT_NEEDED of libcrypt.so.1 and /lib64/libcrypt.so.1 has a DT_NEEDED of libfreebl3.so, which the LD_LIBRARY_PATH then resolves with instdir/program/libfreebl3.so rather than with the expected /lib64/libfreebl3.so. So remove setting of LD_LIBRARY_PATH on all the platforms where it was still used, in the hope that it isn't actually necessary on any of them. Only on Windows, setting PATH is still needed (in line with how the Executable_python wrapper modifies it too) to avoid build failures like > instdir/program/python-core-3.8.12/bin/python.exe: error while loading shared libraries: python38_d.dll: cannot open shared object file: No such file or directory Change-Id: I398aa89166a6a7f3db58c4e65237840b73bec74b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130470 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22Advanced Diagram support: first additions/reorganizationsArmin Le Grand (Allotropia)
To allow advanced Diagram/SmartArt support in the future this is a first step to organize imported SmartArt Data in a way that will allow to re-layout loaded SmartArts, under re-usage of the oox::Theme (held available). It is designed to work without holding available the original XML snippets defining the imported Diagram in any way, also for performance reasons. It tries to re-use some of the already basically added functionality, including the systematic layouting using the generic layout algorithm, plus some already available text extraction. Before being sure that the former state can be completely replaced this is optoinal and used when SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff is already done but e.g. the redefined reLayout method will not (yet) be triggered. It works and reliably produces a re-layouted identical version, also preserving transformations. Change-Id: I08cfbae04afa663d0589530aae549216d853128d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
generated by cgit (git 2.34.1) at 2025-01-11 03:02:31 +0000