summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2022-03-09ofz#45373 and ofz#45362 fix ubsan issuesCaolán McNamara
replace the home grown 16.16 fixed math with an alternative Change-Id: If6fa4205aed62ff15157a8ab4dbf9b7c96e30216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131236 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08remove some member-of a11y relationsCaolán McNamara
In some cases the widgets are in frames now so that hierarchical relationship is captured already. In others labelled-by is a better match and/or is already labelled by the widget. Change-Id: Ifecd0eb96afecadbd66fcfdf843ce1590f5c5ff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131185 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08remove some member-of a11y relationsCaolán McNamara
In some cases the widgets are in frames now so that hierarchical relationship is captured already. In others labelled-by is a better match and/or is already labelled by the widget. Change-Id: I65cbeab514a443edd96c6f9353f892317ac5f775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-24Keep URE libraries out of Library_mergedStephan Bergmann
...to keep the (at least conceptional, but also reflected in how e.g. Linux distros split up LO into multiple packages) distinction between URE and LO proper. This partially reverts 424a7f404565e068995e2a9827d5bc6f76920ec8 "add some more libs to libmerged". Change-Id: I0bd435d9fe4dc4a4ad230990a999ad5e8c487cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130490 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-02-24Don't run ExternalExecutable_python with LD_LIBRARY_PATHStephan Bergmann
257bcb1a1140d3e070cfaef6fec0704740bc83b8 "get internal python invocations working" had made this use LD_LIBRARY_PATH or similar on the various platforms, but without giving any reason what it would actually be good for. 5d8f48c81eac8650315b936d0e89ad1d54b566fc "solver doesn't solve anything..." then (somewhat by chance?) removed it for solenv/gbuild/platform/macosx.mk, apparently without loss of functionality, but left it intact for other platforms. But at least in some Jenkins Linux build environments presence of LD_LIBRARY_PATH (pointing at instdir/program/) appears to cause subtle problems: Builds like <https://ci.libreoffice.org/job/lo_tb_master_linux/49844/> occasionally crashed with [...] > make -O [...] > [build PAT] python3 > [build PRJ] python3 [...] > [build PKG] python3 > [build EPK] python3 [...] > [build BIN] python3 [...] > [build MOD] python3 [...] > [build PRJ] nss [...] > make[1]: *** Deleting file '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors' > [build UIA] sfx > Suppression file: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr > False positive file: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.false > sfx2/uiconfig/ui/documentinfopage.ui: WARNING: 'GtkLabel' 'label8' does not specify what it labels within 'interface' > 1 new warning (64 suppressed by /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr, please fix them) > 0 new fatals (12 suppressed by /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr, please fix them) > Explanations are available on https://wiki.documentfoundation.org/Development/Accessibility > > /bin/sh: line 1: 31655 Segmentation fault (core dumped) LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program" PYTHONHOME="$I/program/python-core-3.8.12" PYTHONPATH="${PYPATH:+$PYPATH:}$I/program/python-core-3.8.12/lib:$I/program/python-core-3.8.12/lib/lib-dynload" $I/program/python.bin $S/bin/gla11y -P $S/ -f $S/solenv/sanitizers/ui/sfx.false -s $S/solenv/sanitizers/ui/sfx.suppr --widgets-suffixignored +ValueSet,HBox,VBox,ToolBox,Preview,PreviewWin,PreviewWindow,PrevWindow --widgets-button +svtlo-ManagedMenuButton --fatal-all --not-fatal-type duplicate-mnemonic --not-fatal-type labelled-by-and-mnemonic --not-fatal-type orphan-label -o $W/UIConfig/sfx.a11yerrors $S/sfx2/uiconfig/ui/alienwarndialog.ui $S/sfx2/uiconfig/ui/addtargetdialog.ui $S/sfx2/uiconfig/ui/autoredactdialog.ui $S/sfx2/uiconfig/ui/bookmarkdialog.ui $S/sfx2/uiconfig/ui/bookmarkmenu.ui $S/sfx2/uiconfig/ui/charmapcontrol.ui $S/sfx2/uiconfig/ui/charviewmenu.ui $S/sfx2/uiconfig/ui/checkin.ui $S/sfx2/uiconfig/ui/classificationbox.ui $S/sfx2/uiconfig/ui/cmisinfopage.ui $S/sfx2/uiconfig/ui/cmisline.ui $S/sfx2/uiconfig/ui/commandpopup.ui $S/sfx2/uiconfig/ui/custominfopage.ui $S/sfx2/uiconfig/ui/deck.ui $S/sfx2/uiconfig/ui/descriptioninfopage.ui $S/sfx2/uiconfig/ui/developmenttool.ui $S/sfx2/uiconfig/ui/devtoolsmenu.ui $S/sfx2/uiconfig/ui/documentfontspage.ui $S/sfx2/uiconfig/ui/documentinfopage.ui $S/sfx2/uiconfig/ui/documentpropertiesdialog.ui $S/sfx2/uiconfig/ui/editdocumentdialog.ui $S/sfx2/uiconfig/ui/editdurationdialog.ui $S/sfx2/uiconfig/ui/emojicontrol.ui $S/sfx2/uiconfig/ui/extrabutton.ui $S/sfx2/uiconfig/ui/errorfindemaildialog.ui $S/sfx2/uiconfig/ui/floatingrecord.ui $S/sfx2/uiconfig/ui/helpbookmarkpage.ui $S/sfx2/uiconfig/ui/helpcontrol.ui $S/sfx2/uiconfig/ui/helpcontentpage.ui $S/sfx2/uiconfig/ui/helpindexpage.ui $S/sfx2/uiconfig/ui/helpmanual.ui $S/sfx2/uiconfig/ui/helpsearchpage.ui $S/sfx2/uiconfig/ui/helpwindow.ui $S/sfx2/uiconfig/ui/infobar.ui $S/sfx2/uiconfig/ui/inputdialog.ui $S/sfx2/uiconfig/ui/licensedialog.ui $S/sfx2/uiconfig/ui/linefragment.ui $S/sfx2/uiconfig/ui/linkeditdialog.ui $S/sfx2/uiconfig/ui/loadtemplatedialog.ui $S/sfx2/uiconfig/ui/managestylepage.ui $S/sfx2/uiconfig/ui/navigator.ui $S/sfx2/uiconfig/ui/newstyle.ui $S/sfx2/uiconfig/ui/notebookbar.ui $S/sfx2/uiconfig/ui/optprintpage.ui $S/sfx2/uiconfig/ui/panel.ui $S/sfx2/uiconfig/ui/password.ui $S/sfx2/uiconfig/ui/notebookbarpopup.ui $S/sfx2/uiconfig/ui/printeroptionsdialog.ui $S/sfx2/uiconfig/ui/querysavedialog.ui $S/sfx2/uiconfig/ui/saveastemplatedlg.ui $S/sfx2/uiconfig/ui/safemodequerydialog.ui $S/sfx2/uiconfig/ui/searchdialog.ui $S/sfx2/uiconfig/ui/securityinfopage.ui $S/sfx2/uiconfig/ui/singletabdialog.ui $S/sfx2/uiconfig/ui/startcenter.ui $S/sfx2/uiconfig/ui/stylecontextmenu.ui $S/sfx2/uiconfig/ui/tabbar.ui $S/sfx2/uiconfig/ui/tabbarcontents.ui $S/sfx2/uiconfig/ui/tabbutton.ui $S/sfx2/uiconfig/ui/templatedlg.ui $S/sfx2/uiconfig/ui/templatecategorydlg.ui $S/sfx2/uiconfig/ui/templatepanel.ui $S/sfx2/uiconfig/ui/urlbox.ui $S/sfx2/uiconfig/ui/versionsofdialog.ui $S/sfx2/uiconfig/ui/versioncommentdialog.ui $S/sfx2/uiconfig/ui/versionscmis.ui > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/gbuild/UIConfig.mk:157: recipe for target '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors' failed > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors] Error 139 > make[1]: *** Waiting for unfinished jobs.... where the crashed instdir/program/python.bin is at > (gdb) thread apply all backtrace > > Thread 1 (Thread 0x2af0920e1a40 (LWP 30414)): > #0 0x0000000000000ae0 in ?? () > #1 0x00002af0920b008a in _dl_fini () from /lib64/ld-linux-x86-64.so.2 > #2 0x00002af093404ce9 in __run_exit_handlers () from /lib64/libc.so.6 > #3 0x00002af093404d37 in exit () from /lib64/libc.so.6 > #4 0x00002af0933ed55c in __libc_start_main () from /lib64/libc.so.6 > #5 0x000000000040068e in _start () with > (gdb) info sharedlibrary > From To Syms Read Shared Object Library > 0x00002af09232e2f0 0x00002af09253270c Yes /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/libpython3.8.so.1.0 > 0x00002af09286fe30 0x00002af092874cec Yes (*) /lib64/libcrypt.so.1 > 0x00002af092aab8f0 0x00002af092ab6db1 Yes (*) /lib64/libpthread.so.0 > 0x00002af092cc2e50 0x00002af092cc394e Yes (*) /lib64/libdl.so.2 > 0x00002af092ec6e90 0x00002af092ec77a4 Yes (*) /lib64/libutil.so.1 > 0x00002af0930ce350 0x00002af093139336 Yes (*) /lib64/libm.so.6 > 0x00002af0933ea9f0 0x00002af09353ab6f Yes (*) /lib64/libc.so.6 > 0x00002af093799a50 0x00002af09379a05a Yes (*) /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/libfreebl3.so > 0x00002af0920a0af0 0x00002af0920bc060 Yes (*) /lib64/ld-linux-x86-64.so.2 > 0x00002af09a0e3be0 0x00002af09a10aa53 Yes /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/python-core-3.8.12/lib/lib-dynload/pyexpat.cpython-3.8.so What is suspicious is that it uses instdir/program/libfreebl3.so when external/nss has been built ("[build PRJ] nss") but has not yet been fully delivered (no "[build PKG] nss"). It uses instdir/program/libfreebl3.so because on that machine instdir/program/python.bin has a DT_NEEDED of libcrypt.so.1 and /lib64/libcrypt.so.1 has a DT_NEEDED of libfreebl3.so, which the LD_LIBRARY_PATH then resolves with instdir/program/libfreebl3.so rather than with the expected /lib64/libfreebl3.so. So remove setting of LD_LIBRARY_PATH on all the platforms where it was still used, in the hope that it isn't actually necessary on any of them. Only on Windows, setting PATH is still needed (in line with how the Executable_python wrapper modifies it too) to avoid build failures like > instdir/program/python-core-3.8.12/bin/python.exe: error while loading shared libraries: python38_d.dll: cannot open shared object file: No such file or directory Change-Id: I398aa89166a6a7f3db58c4e65237840b73bec74b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130470 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-22Advanced Diagram support: first additions/reorganizationsArmin Le Grand (Allotropia)
To allow advanced Diagram/SmartArt support in the future this is a first step to organize imported SmartArt Data in a way that will allow to re-layout loaded SmartArts, under re-usage of the oox::Theme (held available). It is designed to work without holding available the original XML snippets defining the imported Diagram in any way, also for performance reasons. It tries to re-use some of the already basically added functionality, including the systematic layouting using the generic layout algorithm, plus some already available text extraction. Before being sure that the former state can be completely replaced this is optoinal and used when SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff is already done but e.g. the redefined reLayout method will not (yet) be triggered. It works and reliably produces a re-layouted identical version, also preserving transformations. Change-Id: I08cfbae04afa663d0589530aae549216d853128d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-20WASM depend on Emscripten 3.1.3 for native EHJan-Marek Glogowski
This reverts the special SjLj handling introduced in commit ae22f7d06246ee21f9c8e9f35f4477e88843c58b ("WASM add option to build with native exceptions"). This is supposed to work now; at least it compiles. Change-Id: I5ebceea9c7fe3c982d7c9a8818fd79f2018f03cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130219 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-02-17Drop -Wdeclaration-after-statementStephan Bergmann
It was introduced, without a rationale, into unxgcc.mk in eb09adaa9a2accbdc3531bb96447c8e7fbb9f8a9 "Warn if declaration follows statement in C-files", then carried over to clang-cl (com_MSC_defs.mk) with 9055fb48402eaeb9ba876b7893e2f9a39fea06b1 "clang-cl: Enable more warnings etc. (like in the Clang/GCC case)", where it now started to cause > cppuhelper/source/findsofficepath.c(102,20): error: mixing declarations and code is incompatible with standards before C99 [-Werror,-Wdeclaration-after-statement] > const wchar_t* SUBKEYNAME = L"Software\\LibreOffice\\UNO\\InstallPath"; > ^ after <https://github.com/llvm/llvm-project/commit/118f966b46cfb60897b56a9878e1c68fd0e2afa4> "[clang][#51931] Enable -Wdeclaration-after-statement for all C versions". Lets remove it from all toolchain settings, there appears to be not much value anymore in such a warning about pre-C99 code. Change-Id: Id4669089e46c97aaa926e5bd202c36eb5984b837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130058 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-16Extend loplugin:stringview to OUStringBuffer::copyStephan Bergmann
(Somewhat oddly, there is no OStringBuffer::copy counterpart.) This required some modification to StringView::VisitCXXConstructExpr to avoid > In file included from odk/qa/checkapi/checkapi.cxx:29: > In file included from workdir/CustomTarget/odk/allheaders/allheaders.hxx:351: > In file included from instdir/sdk/include/rtl/math.hxx:31: > instdir/sdk/include/rtl/ustrbuf.hxx:1687:16: error: rather than copy, pass with a view using subView() [loplugin:stringview] > return copy( beginIndex, getLength() - beginIndex ); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ while building CppunitTest_odk_checkapi as external C++03 code, where the returned value is wrapped in a CXXConstructExpr. And testing for that case required a new CompilerTest_compilerplugins_clang-c++03 that uses gb_CXX03FLAGS and needs to not set LIBO_INTERNAL_ONLY (via gb_CompilerTest_set_external_code), as compiling as C++03 would otherwise generate lots of errors like unknown char16_t at include/sal/types.h:118. (There was a choice whether to name the new test "-c++03" or "-external", but the issue it tests is caused more by the code being compiled with C++03 than by this being external code, see above.) Change-Id: I873a9c5a70d3ea949cf13a169d46920b71282712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130036 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-15revert component name changes to makefileNoel Grandin
This reverts commit 2483cd198b51bd5d0819cbebf40f211b2ef1236d Author: Jan-Marek Glogowski <glogow@fbihome.de> Date: Fri Feb 11 19:40:36 2022 +0100 Correctly depend on source component file and commit 17ec55c48082254e1f55bcfa00808e45a50a9801 Author: Jan-Marek Glogowski <glogow@fbihome.de> Date: Thu Jan 20 10:06:54 2022 +0100 Fail on non-optional, but filtered component names because they cause failures on Windows builds that look like: warning: failed to load external entity "C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows@2/workdir/ComponentTarget/binaryurp/source/binaryurp.component" cannot process C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows@2/workdir/ComponentTarget/binaryurp/source/binaryurp.component Change-Id: Ia34cdabd76b47a6a4686ebd0f96ceb774d3236f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-13set up gb_COMPILER_SETUP properly for gb_ExternalProject_runLuboš Luňák
If the command to run would be "cmd1 && cmd2", the old way would set up the variables only for the first command. Change-Id: I190bbf535eab4fb0191a87add2ec19e9a2f11e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129878 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-13may just as well use -Z7 if trying to avoid shared .pdb accessLuboš Luňák
-Z7 writes all debug info into the .obj file, so it avoids the .pdb altogether. Change-Id: I89265009782d0a901ba3583a7241da0daf83860e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129877 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-12Fix some tautological std::type_info (in-)equality comparisonsStephan Bergmann
...which could never succeed. I became aware of this when Clang 15 trunk -std=c++2b, implementing <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1328r1.html> "Making std::type_info::operator== constexpr", pointed at two of the broken comparisons with > sw/source/uibase/app/docsh2.cxx:478:25: error: code will never be executed [-Werror,-Wunreachable-code] > pTmpFrame->GetFrame().Appear(); > ^~~~~~~~~ > sw/source/uibase/app/docsh2.cxx:475:33: error: code will never be executed [-Werror,-Wunreachable-code] > bOnly = false; > ^~~~~ (It didn't emit warnings pointing at any of the other broken comparisons, though.) All of these broken comparisons were regressions introduced with 89d39bc100aabf5dccbe77c0b5c0c85736e85b39 "tdf#94559: 4th step to remove rtti.hxx", replacing uses of the IS_TYPE macro (from include/tools/rtti.hxx, meanwhile removed with d64e535fe9a00b671cf1be3eb5632c0d5f4b8bea "Remove unused rtti.hxx"). I now added loplugin:typeidcomparison to also find the other broken comparisons introduced by that commit. (The remaining cases where that commit replaced uses of TYPE_INFO with typeid comparisons were correct and/or have meanwhile been replaced with code not using typeid, see 553ee72041d6f66e26156eb1ad0d9e3c13457f7a "simplify some use of typeid" and d656da9bc4f2df0bb99c65a288847e3fdd43a37c "~SwModify: do not silently tolerate clients registered past death".) The original IS_TYPE macro made sure not to dereference null pointers, > #define IS_TYPE(T,pObj) \ > ( pObj && (pObj)->Type() == TYPE(T) ) I don't know if any of the pointers now dereferenced in those typeid expressions can legitimately be null. But to be on the safe side, I replicated that check in the newly introduced isType (sw/inc/istype.hxx). (It is interesting to note that none of the static analysis that we routinely employ seems to have noticed these broken comparisons.) Change-Id: I65baffdd27bac1abf744283ff98c2dc864fa63b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129865 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-11Correctly depend on source component fileJan-Marek Glogowski
Regression from commit 17ec55c48082254e1f55bcfa00808e45a50a9801 ("Fail on non-optional, but filtered component names"). Change-Id: Idab5b3dbf9658c03b0ec1af67d1d9b740111c6a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129849 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-02-11svx::PropertyChangeNotifier improvementsNoel Grandin
(*) rename the enum to make it's purpose more obvious (*) remove the enum header - it belongs to this class, no need to have it somewhere else (*) return property name by const&, no need to copy here (*) use a o3tl::enumarray instead of a std::unordered_map - there are only 3 entries here, and two of them are ALWAYS used, so just flatten the data structure. Change-Id: Ic496bd5220d55be1209a3243c095d461df0a02ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-09Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/36da4a90d90eef38f5d02beed427a6dd112b93bb> "Merge pull request #178 from JamesBelchamber/file-picker-bookmarks: Adding access to gtk-3.0 config" Change-Id: Ie491cfa4481251ac55b8ab38a5068272165c12de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129727 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-09gdb: fix SwXTextCursorPrinterMichael Stahl
m_pImpl was removed in commit cb0991e32987108d900ec7e8fcd4ce477ebc9fb4 Change-Id: I9ca0cdbca97242ace5243f140ac2e17055b3f718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129685 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-05use more concrete types in chart2, AxisNoel Grandin
Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-31support for the WebP image format (tdf#114532)Luboš Luňák
This commit implements a WebP reader and writer for both lossless and lossy WebP, export dialog options for selecting lossless/lossy and quality for lossy, and various internal support for the format. Since writing WebP to e.g. ODT documents would make those images unreadable by previous versions with no WebP support, support for that is explicitly disabled in GraphicFilter, to be enabled somewhen later. Change-Id: I9b10f6da6faa78a0bb74415a92e9f163c14685f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-31externals: always provide platform configure flagsJan-Marek Glogowski
No idea why we just provided the platform flags when cross- compiling. In the curious case, where the host platform is detected as x86_64-pc-mingw32 per default and we actually want to override it with x86_64-pc-cygwin, we don't do a cross compile, but must override the host platform. But there is additional special handling needed for the omitted cross-platform build in the special case of --host=i686-pc-cygwin and --build=x86_64-pc-cygwin, where we deliberatly ignore cross building; Windows is already a slow build, so try to keep this optimization (AMD64 can execute x86 binaries). There is the theoretical case, where the externals config.guess would have detected something else and that "magically" even worked, while the LO detected triplet would fail, but this should be fixed in the external in any way. Change-Id: Ib7a9719e0e406fe90334b7611dc3f01b51692bfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129153 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-30use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: Ida984d1701e2426958127845418365f6645a9043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-30use more concrete types in chart2, RegressionCurveModelNoel Grandin
Change-Id: Ib4a5198f425577307ba437c73c61408b88d83dc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129160 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29use more concrete types in chart2, LegendNoel Grandin
Change-Id: Ifbf8ddd92eacd4caaf6fdaa061821222e543a1a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-26gbuild: fix spurious rebuilds from gb_LinkTarget__use_librariesMichael Stahl
Apparently the eval inside of "ifeq" needs to be escaped, currently both branches of the "ifeq" are evaluated and generate makefile dependencies, which causes spurious rebuild of Library_salhelper with DISABLE_DYNLOADING unset from: make Library_salhelper && touch -c ../master/sal/osl/all/compat.cxx && make Library_salhelper (regression from ecc50f56b3282ec3b0364101d860f22fe8da9042) Change-Id: I8b5607b7a172c8b4b05abeaf4d5ff3a68d53cb14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-25lok: enable in-place editing of math equationsMike Kaganski
Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-24move titledockwin to the one place it's usedCaolán McNamara
Change-Id: Ia9a1e0f687de3f916d59f28112b7b00c0d4a6610 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-23tdf#97046 prefix gb_ to system variablesArjun
Change-Id: I8be2f55e3306d7ac34ea5819ab93fd537315b281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128804 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-01-23change rpm compression algorithm to multi threaded xzAndras Timar
Our baseline is CentOS 7, it's safe to switch to xz that is supported there. Here is my measurement on rpm package build time and package size on a 48 core machine, however 48 cores were never used (8-10 max). Compared to reference w9.gzdio which was used before the patch. Compression Build Package method time % size % w9.gzdio 100% 100% w7T.xzdio 69% 66% w6T.xzdio 62% 67% w5T.xzdio 55% 67% w4T.xzdio 41% 70% w3T.xzdio 31% 73% w2T.xzdio 26% 75% w1T.xzdio 24% 77% Conclusion: we'd like to optimize rather for the build time, therefore w1T.xzdio was picked. The package size was still smaller than the reference size, and the build time was 4x faster (in this measurement 18m16 -> 4m26). That makes a difference. Change-Id: Iabb532628d38a2d5091fa41fd08bfee69007d0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128800 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-23remove css::chart::XDataInterpreterNoel Grandin
these are purely internal interfaces, they cannot be used from outside chart2. Change-Id: I43c6d8aa96eb94e47767a4b16b89b4889f571579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-22use more concrete types in chart2, ChartTypeNoel Grandin
Change-Id: Ibd299e2e8d82169706d810af98c29d684809c320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-22Make installer compression tool configurableThorsten Behrens
So we can use pigz or other parallelizable tools if available. Shaves off noticeable build time when packaging install sets. - figure out if pigz is available (fallback to gzip otherwise) - pass compression tool down into make_installer - and handle as one of many global options there Change-Id: Ia9d1ea27a9f990874238b6f0be3e1fd30a662ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128469 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-20Sorting component implementations needs LC_ALL=CJan-Marek Glogowski
Change-Id: Ifba53b95fdefed59123a2e682e787119b6c67857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128689 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20Fail on non-optional, but filtered component namesJan-Marek Glogowski
If any of the optional component lists contain a non-optional component implementation, fail the component file generation and show a diff of the offending component implementation name. Change-Id: Ieac876e613f6945362186d4586dd2aacc5669920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128645 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19Let CppunitTest_odk_checkapi build against the SDK include directoryStephan Bergmann
...which contains only the URE include files, rather than against the SRCDIR one which contains many more. This would have prevented 148536afc9838398100ca2267b99ab349dcbb38c "Drop config_global.h from osl/module.h", where an URE include file had accidentally started to include a non-URE file. (The way $(INCLUDE) is now set up in odk/CppunitTest_odk_checkapi.mk is a bit hacky, and this change required teaching compilerplugins about SDKDIR to avoid false warnings. Another approach would be to make the test compile in the SDK build environment, similarly to CustomTarget_odk/build-examples, but setting up the SDK build environment from within gbuild is not supported at least on Windows for now. A smaller improvement would be to drop the need to include any CppUnit include directories, by turning the test into some kind of compile-only test similar to a gb_CompilerTest.) Change-Id: If79761909c67c3162d01f847dfb5d4f538f91ca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128591 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-19use more concrete types in chart2, BaseCoordinateSystemNoel Grandin
Change-Id: I1c246a3ea37595647ac254f492170a9e18540794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-19Fix typoAndrea Gelmini
emscripten.py is not in the LO source, but in the emscripten project. Guess they were referring that one. Change-Id: I3ad2b4ad90420a554871cfd1aba94b447c275127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128619 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19Decouple SRCDIR/include from SOLARINCStephan Bergmann
...turning the latter into "whatever include directories are needed for the given toolchain and platform, outside the scope of LibreOffice". This is a prerequisite for fixing <https://gerrit.libreoffice.org/c/core/+/128591/1> "Let CppunitTest_odk_checkapi build against the SDK include directory", which failed to find the C++ standard library headers (available via SOLARINC) on Windows. (In external/icu/ExternalProject_icu.mk, SRCDIR/include is needed for ANDROID to find <android/compatibility.hxx> in external/icu/icu4c-android.patch.1.) Change-Id: I960e31140b0839b2b6184a78d935042c3c558d5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128615 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-19Fix processing of first path in SOLARINCStephan Bergmann
...which does not have a space before the -I, so copying starting at pos+3 dropped the leading character from the path. This was apparently never a problem in practice, as the first path in SOLARINC happens to always be SRCDIR/include, which should not be needed anyway when building external projects with this GCC wrapper on Windows. (So this commit is a change in behavior, making SRCDIR/include available to those external project builds on Windows, but the follow-up commit <https://gerrit.libreoffice.org/c/core/+/128615> "Decouple SRCDIR/include from SOLARINC" will change the behavior back again.) Change-Id: I3f82a83683ed381b791d221fe1da78b9797aea94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-19WASM support external DWARF infoJan-Marek Glogowski
merged into the --enable-split-debug tests. Change-Id: Id0f25bec08bd45daebb0ccd30d17a4feeb08d02c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128601 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19WASM add option to build with native exceptionsJan-Marek Glogowski
Currently disabled, as literally no runtime has a working implementation. It also currently conflicts with LLVM's SjLj (AKA setjmp / longjump) when generating WASM bytecode, but the only offending code doesn't use exceptions, so this can be avoided in general. Change-Id: I2b338f3529e7350d54a7950772c6e7aae2282fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128600 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19WASM create and link the Emscripten FS imageJan-Marek Glogowski
There are three posibilites to add files to the image: - gb_emscripten_fs_image_files to add individual files - gb_emscripten_fs_image_autoinstall to add files from AutoInstall - gb_emscripten_fs_image_filelists to add files from a .filelist Change-Id: If6804e282a37a37ffae1d291d2af8430e60b59d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128598 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19WASM add strip flags to configure.acJan-Marek Glogowski
Doesn't include VCLplug flags and it should work with gtk3 too. But normally you want to use: --disable-gtk3 --enable-qt5 Change-Id: Ifea5e5b1e63633ff1fa709cdeb49afdb43fa0e8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128588 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19WASM gbuild: add --pre-js dependenciesJan-Marek Glogowski
Currently includes environment.js for general environment settings and soffice_args.js for soffice command line flags. Change-Id: I1166c5a9ae53c56a69b9223c865b4df525d07450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128590 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19WASM adapt link and debug flagsJan-Marek Glogowski
Changes the linker flags, so a debug build will not rewrite the WASM binary code for instrumentation, as this takes ages and more then 64GB of RAM, currently. For the same reason - long link times - prefer DWARF debugging to the external source maps. Initial memory and thread pool size are linker flags, so move them. Change-Id: I5cf39842e5091ef55b4fac719f881575e69fe8d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128589 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19WASM more initial bits and piecesJan-Marek Glogowski
All the small stuff, which is needed for the WASM build, but is not really worth an extra patch. * No soffice.sh script needed for WASM * WASM soffice.bin executable extension is html * Some small additional SAL_LOG output * Default to colibre icon theme * Test for qt5 even without X11 * Remove emconfigure artefacts at the end of the configure run * No oosplash for WASM * Disable the Office IPC thread * Suppress -Wno-enum-conversion for Cairo builds * Fix libnumbertext by using gb_EMSCRIPTEN_CPPFLAGS * Map EMSCRIPTEN to LINUX nls * No extra newlines for missing icon theme images * Print the missing dependency in some gbuild error messages * Copy Qt WASM loader, HTML template and SVG logo for binaries * Especially build the vcldemo for Emscripten Change-Id: I356370c72cc09357411e14d0c00762152877a800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128584 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19Keep intermediate *.component.filtered fileJan-Marek Glogowski
Makes debugging / understanding componentfile generation easier. Change-Id: I6c71d4d3787820320e95e3c075a08a0b9d756995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128582 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-19vcl: move eps functions to eps.cxxChris Sherlock
Change-Id: I0d61835d0964e18b578ec42b7002671310a8a36d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-18use more concrete types in chart2, ChartTypeTemplateNoel Grandin
Change-Id: Ife0be0fde2f8d273411cbdbbafa2173ac80f80f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-18use more concrete types in chart2, ChartTypeManagerNoel Grandin
Change-Id: If5055256c3e3a20ab1a30e9c8bf46f453785e80c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-17 00:05:58 +0000