Age | Commit message (Collapse) | Author |
|
Change-Id: I3da463ce2233512cb9b616fa75d7a07d9b32aeb5
|
|
Change-Id: Iaa594d85aad4b1ee3dd31029fc50c5a1d8997f57
|
|
Change-Id: Iac6f30dbb9173e2ccc38b236efc4715ba7f2b67f
Reviewed-on: https://gerrit.libreoffice.org/42289
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I1eb1efedb98979b692874ae0ec48120cb5a38188
|
|
Change-Id: I63fcebc36559c2698bbedd3501285a388ce8c257
Reviewed-on: https://gerrit.libreoffice.org/42291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I05df619848cde842a5cda79d20e013914ce882d4
|
|
...1c983335116a6f09cabf0b3eae7f51951111341e "upload poppler 0.59.0" and
1a2b33348e53a4c3262494cfc5bfa7cbd1bb4e36 "upload libwpg 0.3.2"
Change-Id: I8b6d5f6bb96a8bd668abebbdc6087cdb93226db6
|
|
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code
at the end of a switch statement, after the last case's "break".
-Wunreachable-code appears to work well on Clang, while it appears to have no
effect on GCC.
Most of the affected places are apparently temporary/TODO/FIXME cases of
disabling code via "if (false)", which can be written with an extra set of
parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus
needed loplugin:unnecessaryparen to be adapted accordingly). In some cases,
the controlling expression was more complex than just "false" and needed to be
rewritten by taking it out of the if statement to silence Clang.
One noteworthy case where the nature of the disabled code wasn't immediately
apparent:
Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in
ScExponentialSmoothingDialog::ApplyOutput
(sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in-
progress or dead code?
Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it
Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of
parentheses for now, to silence -Wunreachable-code (I wouldn't want to
remove it, as I have no idea whether I should then also remove the "Initial
value" comment preceding it)
Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the
"intital value"... so no
Another case where the nature of the dead code, following while (true) loops
without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx,
where I added TODO markers to the workarounds that silence the warnings for now.
basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic
storage duration, and without an initalizer at the top of a switch statement.
Clang warning about it is arguably a false positive.
Apart from that, this didn't find any cases of genuinely dead code in the
existing code base.
Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c
Reviewed-on: https://gerrit.libreoffice.org/42217
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
-glldb might be placebo switch like -ggdb2, but at last it won't hurt
:-)
increase java heap size for gradle to allow inprocess dex as well as
actually processing the huge files.
furthermore fix platform level in configure to match the minSDK value
from build.gradle
Change-Id: I57d7d4c67bc3e5ed8bfed1e592b85211b5b8905a
Reviewed-on: https://gerrit.libreoffice.org/42162
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Combine common parts for iOS files into one
Change-Id: Ibbc6cbb69d0521a5b35ac1817c74bff1dccaddf5
|
|
IOS => iOS
added iOS_ARM64
added iOS_X86_64 and iOS_I386 for simulator
Change-Id: Ia788765aab4ef51a7cc7c67d5faff1197e90696c
|
|
...0365ca351aac534d3fc09d22f6a91017525bfef8 "pdfium: update to 3196"
Change-Id: Ia291b30b79bb0873529e474164d24dcb8b491f40
|
|
...04d70c0999c716f5465631eca50945915ec607c4 "Upgrade to
language-subtag-registry-2017-08-15"
Change-Id: I4178545869a6d97cb1f90034f3944d9c72700bd6
|
|
Change-Id: Ia3551572269e1cf04b2a398cd08f718fd248c6e6
|
|
...GNOME Software reportedly is fine with that now.
Change-Id: I418fc60a3215078109d3d8e9f426f98fdf37322b
|
|
...from dev-tools' flatpak/build.sh, as the Flathub build plans to use that git
source, too
Change-Id: I5a23ad0eddd8b7d89e941217c66f5354936c10fc
|
|
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d
Reviewed-on: https://gerrit.libreoffice.org/41787
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...where at least <http://jdk.java.net/9/> "JDK 9 Early-Access Builds" 'java
-version' outputs a single-digit
java version "9"
Change-Id: I7807f56593e5436418b49950ca6c2a178d6721f5
|
|
Change-Id: I3eff2bdd5da3710bc130a5d9965a8c84c74ee55b
|
|
Change-Id: I5c07039e336de9362fdd92be29de516da0846998
|
|
...after 9a7d2d72cef7ff14a020c1024fbff8c00e4e4aff "tell msvc our source code is
written using utf-8" did the equivalent for MSVC. That should cause the C++
string literal u8"ßa" (in vcl/qa/cppunit/mnemonic.cxx) introduced with that
commit to reliably be interpreted as intended by all our toolchains.
Change-Id: Ibbda8588a3ca66d1c2764f70aa999fad243f1bb1
|
|
Apparently a sw unit test randomly read a partially written autotbl.fmt
that was written by another unit test, in particular the file
workdir/unittest/user/config/autotbl.fmt.
The tests are actually started with
-env:UserInstallation=$(call gb_Helper_make_url,$(call gb_CppunitTest_get_target,$*).user)
to prevent exactly this problem, but unfortunately it's then
overridden by a call to rtl::Bootstrap::set(), which overrides
even command line arguments, from test::BootstrapFixtureBase::setUp().
Change-Id: I618574e94755ea38caf9583f3dcf7715396bca48
Reviewed-on: https://gerrit.libreoffice.org/41432
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
...where its content can be kept in sync as necessary. The flatpak/build.sh
script in the dev-tools repo will be updated accordingly.
Change-Id: I6937a619dbf54686f8dcfd9b98200c14198dde8e
|
|
Change-Id: Ibb087fc9cd17e50accf78f805e0fec4f202334b1
|
|
The code in SvXMLExportItemMapper::exportXML was broken as far back as
its introduction in
commit 0c28e3c480a95c03b513c55f029b979bcd9c0401
"Move SvXMLAttrContainerItem to SVX, moved writer only code to sw"
Change-Id: I90043ce8b7263aa56fd0883d350e29b97eeaf99b
Reviewed-on: https://gerrit.libreoffice.org/41282
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3
Reviewed-on: https://gerrit.libreoffice.org/41194
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
... and hope that actually will be recognized..
Change-Id: Ib7a73eca63caeb8791a06fa26cd31a15407de065
|
|
makes writing nice code awkward sometimes.
Also split plugin into two different plugins, the logic was getting
tangled up.
Change-Id: I232e314d29c766c160c29373988dc37a466505be
|
|
an experiment to see if I can make the process of eliminating
sal_uIntPtr a little easier
Change-Id: I808185fbf18826cb9ab5612a7be4148d52045957
|
|
To more precisely get definitions of top-level entities;
particularly nice for interfaces where we don't want to find the
ubiqitous forward declarations.
Change-Id: I8e0e67506d5c67bfff351c4129c3e7eeda6e67a5
|
|
This supports the UNOIDL language constructs Enumeration, ElementName,
Structure, Interface, FunctioName, Service, and PropertyName.
The values are mapping to ctags as:
UNOIDL ctags
Enumeration e,enum
ElementName m,member
Structure s,struct
Interface i,interface
FunctioName f,function
Service g,service
PropertyName p,property
Change-Id: I4ca5dcb289360f7630a85bb3a62ec3b60a8a88e6
Reviewed-on: https://gerrit.libreoffice.org/40911
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
<sberg> noelgrandin, and is loplugin:deadclass even sound?
struct B { B(B const &) {} }; struct D: B { D(): B(*this) {} };
Change-Id: Idadd379b925aa6f9de6c625bffa8560ec4192ac7
|
|
Change-Id: I727d50ce4725f10efbeaedd70ed961e726f99a5e
Reviewed-on: https://gerrit.libreoffice.org/41190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
The types 'long' and 'unsigned long' are different sizes on different
platforms, making them wholy unsuitable for portable code.
And when I mean different sizes, I mean 64bit Linux and 64bit Windows
have different bit sizes.
Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d
Reviewed-on: https://gerrit.libreoffice.org/41130
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
look for classes which only have copy/move constructors, and so are
effectively dead
Change-Id: I0b844f301e2200c2b40031856bfdb0b0e2c8f77d
Reviewed-on: https://gerrit.libreoffice.org/41039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This was changed in d72aad218c9737fb19d1a835b03c13b7107a96c0
Change-Id: Ie93f603c82669ca612fbf9635a62c50e63702a85
|
|
mbDelete is gone, as we simply check for mpTask.
Change-Id: I9d451f2445fb6b978d177b45d75abde2595c5fac
|
|
had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis
Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Also visualisers for uno_Any and SwNode are tweaked.
Visualisers for uno::Reference, rtl::Reference and VclPtr added.
SwFrameFormats visualiser reimplemented to follow implementation
of boost::multi_index_container.
Minor reformatting.
Change-Id: I24ccb8bfccd7f7514697ca3f36490672ad549aef
Reviewed-on: https://gerrit.libreoffice.org/40466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
As reported at e.g.
<https://ask.libreoffice.org/en/question/90346/building-libreoffice-in-cygwin-leads-to-infinite-loop/>,
sometimes MSVC (seen with 2013 on libreoffice-5-2, but there is no
indication that 2015 on master would be different) emits CR characters
at the end of filenames, resulting in unnecessary rebuilds at per-module
builds, and actually to an infinite loop when doing toplevel make.
Given that CR characters are unexpected in any filenames, it should be
safe to just strip those away unconditionally.
Change-Id: I3d56670b4d930a32489f889085711bfd436de82a
Reviewed-on: https://gerrit.libreoffice.org/40452
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I4fb364ceb34e0851f2d04c403333bf428e8cfa98
Reviewed-on: https://gerrit.libreoffice.org/40305
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
It also doesn't work on WNT where python_shell does not exist, and on
OSX where python3 is not a Package but a GeneratedPackage.
Change-Id: Ia4004f56d9168a05b3bd49e66c30502962c07698
|
|
Change-Id: I5dcfe7c1eca2f6388d6606521722a5fe876a9f34
|
|
Change-Id: I5e8e4a9a31aa7c3ff54cc7ce137d08770ea297e1
Reviewed-on: https://gerrit.libreoffice.org/40279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2113f64bac9f1e7421416266d20004b35ddbc54b
|
|
Change-Id: I91d559596dcfbca603613bc4e9db7fe3348984c6
|
|
these are broken (from msgfmt's perspective anyway) already
in our translations and pootle warns about them
Change-Id: I9ce7c651273e334ecb92a592397886e2b95907da
|
|
Change-Id: I81af71041d8d9d0074c9585ced510d7daab07c20
|
|
Change-Id: Ia0c00f6f978428d68b3c53051e26e1913b207dbe
|
|
Change-Id: I19c27e524d2ad1e57fa3ca41b1bfaed17215bd76
|