summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2017-11-30Move loplugin:fpcomparison to store/Stephan Bergmann
...after bc4e8de8eea1ccebda479c8e2db2f3c6dfff60d2 "Silence new loplugin:fpcomparison for now": > Nov 30 08:33:16 <sberg> noelgrandin, thoughts on whether fpcomparison is actually worth it, seeing the loooooooong blacklist there? > Nov 30 08:34:11 <noelgrandin> sberg, that's wasn't my idea, can't remember who came up with it. vmiklos was that you? > Nov 30 08:34:36 <noelgrandin> sberg, the original commit message was "Find code that compares floating point values with == or != > Nov 30 08:34:36 <noelgrandin> It should rather use rtl::math::approxEqual" > Nov 30 08:34:45 <noelgrandin> so in theory the replacement should be fairly manual > Nov 30 08:34:48 <vmiklos> i don't think so :) > Nov 30 08:35:15 <noelgrandin> might have been moggi, but he's not around so.... just disable it > Nov 30 08:36:19 <sberg> noelgrandin, yeah, in theory; in practice, I guess there's also cases where x==1.0 is what you want exactly (given x tends not to be a computed value after all, but some literal that's being passed around) > Nov 30 08:36:33 <sberg> noelgrandin, yeah, I'll disable it then Change-Id: I35f5328efa0ec02d9be837c12efab2b03a3dae52 Reviewed-on: https://gerrit.libreoffice.org/45550 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30Detect also clang-format versions 5.0.0+Samuel Mehrbrodt
Change-Id: I651f078c20a1a51d636d359c1118f06b71083e8e Reviewed-on: https://gerrit.libreoffice.org/45561 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-29Add SfxEnumItem to NatvisMike Kaganski
Change-Id: I11177cd99a3d895c7ec94661fa677a0edfcdf9bf Reviewed-on: https://gerrit.libreoffice.org/45536 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-29clang-format: don't pick up non-existing binary from PATHMiklos Vajna
When /opt/lo/bin/clang-format was missing, we "found" clang-format in the last item of PATH, which doesn't make sense. (Fix a spelling error in a formatted file to trigger the hook as part of CI.) Change-Id: I3b56a8ad02b4a55dba58e07286e31436a2842cf6
2017-11-29etags: pass the "-e" flag directly to ctag binaryPranav Kant
'man ctags' says that emacs mode will be enabled if the ctags binary is renamed as etags or '-e' flag is provided to ctags binary. Before this patch, the script assumes that host system has an 'etags' binary renamed from 'ctags' program. This is not always the case in all hosts. Eg: In Fedora, 'etags' binary is provided by emacs-common package which doesn't understand the flags given later in the script. It is safe to just explicitly enable the emacs mode via '-e' flag to the ctags binary. Change-Id: Ic7ded56cff32683fc5e9d3fcc7405e79da4c23b7 Reviewed-on: https://gerrit.libreoffice.org/45358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-28DBus permissions missing from LO flatpakStephan Bergmann
...after 243d743dae127fe11ecd7f807121da8815af8f01 "solenv/flatpak-manifest.in: incorporate upstream sandboxing improvements", causing <https://github.com/flathub/org.libreoffice.LibreOffice/issues/3> "Doesn't open files in network shares". Change-Id: I15d7a170b3ffaf6092ff4d2fe4e93b1dcfd32b0b
2017-11-28Add wrongly formatted new file to blacklistStephan Bergmann
Change-Id: Ib4fd5372adac12b2effd30342a5f7af395b9aceb
2017-11-28upload libwps 0.4.8David Tardon
Change-Id: Ib285c227cd935987311be40df3745316943a54e0 Reviewed-on: https://gerrit.libreoffice.org/45331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-27Add int pool items to NatvisMike Kaganski
Change-Id: I5840baff5bd052f95233f13d89ee64a926a2dd93 Reviewed-on: https://gerrit.libreoffice.org/45348 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-27Turns out SdiTarget needs the extended SOLARINC after allStephan Bergmann
After fbfe55e58c4b14f86cbb2c7b822f727e5b2e4a66 "There appears to be no need for -I. in SOLARINC", on Windows, e.g. workdir/Dep/SdiTarget/basctl/sdi/basslots.d now contains basslots.sdi without a path, because the call to osl::File::searchFileURL in SvIdlParser::ReadInclude (idl/source/prj/parser.cxx) is done with rBase.GetPath() no longer containing the basctl/sdi/ source dir, so searchFileURL silently returns "basslots.sdi" unmodified. (The non-Windows implementation in sal/osl/unx/file_url.cxx appears to also check CWD, so doesn't suffer from this regression.) Change-Id: I51802192cfe112f810b193a77d14787d965c2761 Reviewed-on: https://gerrit.libreoffice.org/45323 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-24gbuild: handle GENCXXCLROBJECTS in gbuildtojsonMichael Stahl
Change-Id: Ib5808a715e4ba0e0a5d9eea8260ea72fd85ccda2
2017-11-24tdf#113787: gbuild: fix the version of cli_cppuhelper assemblyMichael Stahl
There is one usage of gb_Library_add_generated_cxxclrobjects in the entire repo, and regrettably generated C++/CLR objects weren't actually implemented in the new build system, so the assembly.cxx with its generated version number was simply ignored.
2017-11-24tdf#113787: always require version file with config for CLI assembliesMichael Stahl
The CliUnoApi_oootypes does not use the same version file as everything else, so pass that in as a parameter.
2017-11-24gbuild: CliAssembly: clean everythingMichael Stahl
Change-Id: Ieaef37a8af808c9b1b981b4363e4dabfb4816457
2017-11-23ios: blacklist newly pushed non-formatted filesMiklos Vajna
Commit ed885a3cdbfc4b4d194d40508a29334b9780858f (iOS, do not use different C compilers, 2017-11-23) was pushed directly and clang-format wasn't used locally, either -- so just blacklist these new files. Change-Id: Id6e39e68ac112494139e982ebcf7c32531184ec2
2017-11-23move preventduplicateinteraction from framework to sfx2 consumerCaolán McNamara
Change-Id: I1388a88ba20b5cde65cd1d88694775b071a0dff6 Reviewed-on: https://gerrit.libreoffice.org/45099 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22iOS, changed debugger from to lldbjan Iversen
gdb2 does not work well when using a swift based frontend. changing to default debugger but only for iOS. Change-Id: Iae0df85b9db4b3dfaf9fbc0e42848c52f3685a48
2017-11-22RTF filter: drop now redundant astyle.optionsMiklos Vajna
I (tried to) keep the RTF filter style consistent locally with astyle in the past, but now that's redundant when we have an enforcing clang-format mechanism in place. So drop the astyle config and switch to clang-format in the RTF filter case. To minimize backport pain, do this shortly before the libreoffice-6-0 branch-off. Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f
2017-11-21clang-format fixesMiklos Vajna
Hopefully the last such commit, now that the in-gerrit verification is in place and also a warning is printed locally for those who push directly. Change-Id: Ib80cbca0b29dc7f71cbb182a38ad6839a659ff41 Reviewed-on: https://gerrit.libreoffice.org/45002 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-21Fix typosAndrea Gelmini
Change-Id: Ifd95ada4477d7d21ffbadd355226f91f2a2371e1 Reviewed-on: https://gerrit.libreoffice.org/45004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-20Non-blacklisted file wasn't formatted according to clang-format rulesStephan Bergmann
...so blacklist it, as needed to push a change to it in a follow-up commit Change-Id: Ia43737fb92311d8461e1eb5f9b3862c1e9ca57bd
2017-11-20LibreOffice.natvis: a small correctionMike Kaganski
Change-Id: I6f9971bf3fc8eec996a19c0a56202947f65a07ae Reviewed-on: https://gerrit.libreoffice.org/44972 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20clang-format: enforce coding style via JenkinsMiklos Vajna
- factor out common code to a shared module, and quote path to the clang-format binary, just in case. - add a new check-last-commit script that is the CI equivalent of the exiting git pre-commit hook, but this one handles lack of clang-format as an error, not as a warning. - $LODE_HOME/opt/bin is supposed to be in PATH already, so not mentioning LODE_HOME in ClangFormat::find() explicitly. - if both COMPILER_PLUGINS and LODE_HOME is set, invoke solenv/clang-format/check-last-commit as part of 'make check' To test these changes as part of CI, fix a single style violation in an already committed, non-blacklisted file. This depends on the lode.git commit 496123bcae28e06c6d6aeda39a5afd1e1fb1fd98 (utils_Linux: install clang-format in the Jenkins case, 2017-11-16), otherwise erroring out on a not installed clang-format as part of the build would be a problem. Change-Id: Ib3110826194ff78a7f1bed1c3796147e92ccb3ba Reviewed-on: https://gerrit.libreoffice.org/44939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-18Update LibreOffice.natvisMike Kaganski
Change-Id: If9a0b5c185e828b5a1cf50fd42879aa3fa0f8635 Reviewed-on: https://gerrit.libreoffice.org/44910 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-18MSC: Embed Natvis to PDBs, to use in /DEBUGEXE debugsMike Kaganski
E.g., when a unit test is debugged using make CppunitTest_foo CPPUNITTRACE=TRUE then devenv.exe is launched with /DEBUGEXE switch, and it's impossible to add a .natvis file to the debug session (unless one adds the file to path where VS looks for visualizers). A natvis added to PDBs will be used in this case. See https://docs.microsoft.com/en-us/cpp/build/reference/natvis-add-natvis-to-pdb Change-Id: Icc31eb7c4fd063810e4074eaff774e8146b86877 Reviewed-on: https://gerrit.libreoffice.org/44595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-15drop now unused ToolPanelOptCaolán McNamara
Change-Id: I26c93567f58b7b459eedbad85b5f3bfe554c8557 Reviewed-on: https://gerrit.libreoffice.org/44769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15Make sure there is a org.libreoffice.LibreOffice.desktop again in the FlatpakStephan Bergmann
...after 1b85d725663a7d7546549e6b78ea43bea1cde7b9 "Include all .desktop files in the Flatpak". org.libreoffice.LibreOffice.appdata.xml references that in its <id>org.libreoffice.LibreOffice.desktop</id> which is at least used to find an icon for the AppData (see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/1> "No icon shown on flathub.org"). On #flatpak it was deemed impossible to change that id to point at the the LibreOffice-startcenter.desktop file, so rather change that one desktop file's name. Change-Id: I78c3ae131be213e41cc4fcdeddae1b6c9e6c29df
2017-11-14LibreOffice.natvis: update visualizersMike Kaganski
Change-Id: I48e13a16deb14869a2fb37822650f44ca7162406 Reviewed-on: https://gerrit.libreoffice.org/44727 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-14Adapt solenv/flatpak-manifest.in to recently added Noto fontsStephan Bergmann
b97e713e76c88141d26f6e19a74db80a105cb911 "tdf#103080 Add Noto fonts into default installation" Change-Id: I4e2bb52b533321dc2a9ca32ca548bda5a2ad9a02
2017-11-14Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: Id3b856cce8b6182dfcc433b2b633977b7445703d
2017-11-14Another workaround for "xargs: environment is too large for exec" errorsStephan Bergmann
...on Windows, similar to df9edbcd2883cec2d0596133131cfbc220dee91f "Work around 'xargs: environment is too large for exec' errors on Windows" Change-Id: Ibc23960bbe2b8001eb7e08ed4cff12e4726df01b
2017-11-13clang-format: standardize on 5.0.0Miklos Vajna
Restrict the git hook further to only enforce style in case the found clang-format binary's version matches to avoid output differences with different clang-format version. While at it, move the blacklist reading after the version check to speed up committing a bit when no local enforcement happens. Also add a simple script to list formatted files, since the blacklist is large enough that doing it naively from the shell is too slow. Change-Id: I0bc05961d262cc6bc91c6efdd1b91994ecfc6940 Reviewed-on: https://gerrit.libreoffice.org/44662 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-11use -encoding UTF8 in JavaClassSet.mkRene Engelhard
which works directly for javac, thanks Noel Change-Id: I7e8f5887fcba73da00ec018990ea620465614df1
2017-11-11set JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8 in JavaClassSet.mkRene Engelhard
.. to fix reportbuilder build with Java9. A direct -Dfile.encoding=UTF8 doesn't work... Change-Id: I231b2893df463d00eb514c0d50e02c8df41c5b20
2017-11-10Forgot to add compilerplugins/clang/test/unusedvariablecheck.cxxStephan Bergmann
...to CompilerTest_compilerplugins_clang in 871e420cbbd8afe064e7bbc0ed426db3b01fddfa "Fix loplugin::unusedvariablecheck check for std classes" Change-Id: I011d8ff73189dfa85adb4cbd50e556f25be9b79c Reviewed-on: https://gerrit.libreoffice.org/44592 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-09LibreOffice.natvis: add SfxItemSet visualizerMike Kaganski
Change-Id: I2d63cf73df945cc84fbfb93ad431f243caa238e1 Reviewed-on: https://gerrit.libreoffice.org/44542 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-09new loplugin simplifydynamiccastNoel Grandin
simplify dynamic_cast followed by static_cast Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279 Reviewed-on: https://gerrit.libreoffice.org/44460 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-08gdb pretty-printers: avoid segfauls in B2DPolygonPrinterMichael Stahl
gdb 8.0.1 tends to sefault while evaluating the getB2DPoint() calls; it passes some obviously wrong index instead of 0. Also, add a children method to B2DPolyPolygonPrinter. Change-Id: Ifbf52ad384d1f60b26ee95f87405eff2c6f2388a
2017-11-08Suppress loplugin:unnecessaryoverride...Stephan Bergmann
...when a class derives from multiple (non-virtual) instances of one base class, and the override disambiguates which of those instances' member to call. That was the case with SwXTextDocument::queryAdapter (sw/source/uibase/uno/unotxdoc.cxx), where SwXTextDocument derives from cppu::OWeakObject through both SwXTextDocumentBaseClass and SfxBaseModel, but calling queryAdapter through a pointer to SwXTextDocumentBaseClass apparently needs to call OWeakObject::queryAdapter on the second, SfxBaseModel-inherited OWeakObject base instance, or else CppunitTest_sw_macros_test fails. Who knows what other instances of similar non-unnecessary overrides have been removed with the help of broken loplugin:unnecessaryoverride, for which there were no tests that started to fail... Turns out .clang-format lacked "ReflowComments: false" to not break the special "// expected-error {{...}}" etc. comments in compilerplugins/clang/test/. Also, use a better location to report loplugin:unnecessaryoverride, to keep clang-format and loplugin:unnecessaryoverride from fighting over how to split lines and where to put the comment in compilerplugins/clang/test/unnecessaryoverride.cxx. Change-Id: I3b24df24369db12f8ec1080d6c9f7b70ff561a16 Reviewed-on: https://gerrit.libreoffice.org/44418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-07Why was this left out of unittest-failed-MACOSX.shStephan Bergmann
Change-Id: If32981329e79745d5497c3f63bfd227dc75f2ab3
2017-11-07Augment LibreOffice.natvisMike Kaganski
Change-Id: Id9c3e270db2ff8e36d18efe3221b8f1c01a2fcc1 Reviewed-on: https://gerrit.libreoffice.org/44419 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-07Adapt clang-format blacklist to recent renamesMiklos Vajna
Change-Id: I5e2e431900af9ea7de7dd9395af038ba2f8f7e0c
2017-11-07tdf#113550 RTF import: fix incorrect text indentMiklos Vajna
Left indent was set to non-zero in the style, but direct formatting set it back to zero. Teach deduplication to remove the NS_ooxml::LN_CT_PPrBase_ind SPRM itself in case the last attribute was removed. Change-Id: I01b202f0241b02816b2b392326737b1150caffc2 Reviewed-on: https://gerrit.libreoffice.org/44385 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-06QT5 rename from KF5Jan-Marek Glogowski
Move out of unx, as this will eventually compile on other OS platforms. At least currently it doesn't contain platform dependant code. Change-Id: Iea0bebf574201881ea158381fe7ba8af2a9a6488
2017-11-06KF5 seperate Qt5 detection from KF5Jan-Marek Glogowski
Splits the configure checks into a Qt5 and KF5 specific part. Change-Id: I0a616ba031e1f7fd0385219ac48179adb4bdaf14
2017-11-06Adapt flatpak-manifest.in to recent mdds updateStephan Bergmann
(666fd212e19af06c9fddb4a3c4a381847a0de402 "Update mdds to 1.3.0.") Change-Id: Ie1ffb199e7960e735584412b064cb0b1dcc0e3dd
2017-11-03-I$(dir $(3)) in gb_CObject__command_pattern is no longer neededStephan Bergmann
...in com_MSC_class.mk now, similar to ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 for com_GCC_class.mk. Three libraries built from external sources (for Windows only) needed adjustment. Change-Id: Id8976a30b80efff6119afb18ccaf6811fe27d2f8 Reviewed-on: https://gerrit.libreoffice.org/44270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-03Enforce coding style with clang-format for new codeMiklos Vajna
- The actual blacklist has to be generated with solenv/clang-format/generate-style-blacklist.sh in a separate commit. - .clang-format is from <https://lists.freedesktop.org/archives/libreoffice/2014-August/062802.html>, except: - the commented out lines are removed - Standard is Cpp11 instead of Cpp03 - explicitly avoid sorting includes (requested during ESC meeting 2017-10-11) - no indentation inside namespaces (lots of existing code in sc wants this) - The git hooks prints a diff when the style is violated, along with a command to fix up the violation automatically. It also enforces style only in new files and ignores all files listed in the blacklist. - To avoid introducing one more hard-to-setup build dependency for new developers, help them two ways: - if clang-format is not installed, provide pre-built binaries for Linux/Windows/macOS - download/install of these binaries are printed as cmdline instructions, similar to how we have our own 'make' on Windows - As per ESC call 2017-11-02, currently don't do any checks if clang-format is not installed (as a first step). Change-Id: Iaa139c396337e8734aa1853305d808438260c41a Reviewed-on: https://gerrit.libreoffice.org/43736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-03solenv: add list of existing C++ files for clang-format blacklist purposesMiklos Vajna
Generated with solenv/clang-format/generate-style-blacklist.sh from <https://gerrit.libreoffice.org/#/c/43736/>. Change-Id: I9ac621494450c42ef83e5cb7c1956124d17a8de6
generated by cgit (git 2.34.1) at 2025-01-13 11:41:24 +0000