summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)Author
2024-11-04move CryptTools from oox to comphelper so we can reuse itTomaž Vajngerl
Also move the relevant tests and clean-up the names a bit to make it mroe consistent. Change-Id: I929ef9c13b954fd6a506471231d1bc41e4ef9980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176027 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-04Add experimental support for Emscripten JSPIStephan Bergmann
...which I've seen fundamentally working when building with recent emsdk against recent Qt6 trunk (and including <https://github.com/qt/qtbase/pull/108> "Update the check for WebAssembly JSPI support") and running on recent Chrome (with JSPI enabled under <chrome://flags/>) Change-Id: I98c11c5ee7e95b135ddc33c95c95752055ecd4c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176031 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-30Adapt to generation of .worker.js files gone from 3.1.68Stephan Bergmann
...and just unused dummies since 3.1.58, so don't install them for >= 3.1.58, even if the dummies would still be available for < 3.1.68 Change-Id: Ida55be2fa3b75982bfd764b7b2676e63c092fe79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175822 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-10-25reason_pdf no longer existsCaolán McNamara
since: commit 2a40505d00fcd79bfa433c301ddc05a35287bfb1 CommitDate: Thu Jan 26 15:09:20 2023 +0000 remove option to toggle IsPDFAsStandardPrintJobFormat from UI Change-Id: Ib4797709396009a7c54c467d6b00bf9cd3b348cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-24Adapt flatpak build to upstream changesStephan Bergmann
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/b9c5a10b9c0cbac84e3e63ce3ec0e6a09aab8f8d> "gvfs: Update gvfs-1.56.0.tar.xz to 1.56.1" Change-Id: Iaf20b7bb5662cdcd54817f15fa366df17dab53e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175548 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-10-24Remove archaic xmergeCaolán McNamara
Formats like Aportisdoc can be opened via org.libreoffice.comp.Writer.EBookImportFilter instead. It doesn't look like there will be any support implemented for Nokia 9210 Communicator PsiWord. No particular burning demand for that anymore apparently. Removal of the filters that used xmerge took place at: commit a5783fe922b2419b5b662eb5f544a1f401341dbf CommitDate: Sun Mar 3 19:19:26 2013 +0100 remove stale javafilters Change-Id: I0a0087fb2ee015de42c1802b5e9bc6dc42a5efe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174563 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-23add Tagalog (tl) langauge- & helppackChristian Lohmaier
Change-Id: I9fdb30215f6b64ae025a7e8e468e84426044ff80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175503 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-10-22move vcl::DeleteOnDeinit to toolsNoel Grandin
so we can fix a shutdown use-after-free in sot. Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-18SW: extract transform charts (using dialog code)Attila Szűcs
Implemented chart data extraction, and transformation added insert/delete/modify row/column, and the ability to set resize data table setcolumndesc / setrowdesc .. for 1 descriptor, or with multiple descriptor to set set 1 cell value, or set the whole table cells values. it will resize the table, but you can still use partial arrays like "data": [ [ 1,2,3,4 ], [ 2,3,4,5 ], [ 3 ], [ 4,5,6,7 ], [ 2,2,1 ], [ 5,6,7,8 ] ], that means the 3. row 2,3,4th cell will not be overwritten. for insert column, it call codes from DataBrowserModel. (used by dialog code) added tests, fixed a contentcontrol date problem 2. commit (made by Caolan) squashed into 1. commit: WIP hack this to link move stuff from chartcontroller to chartcore and adjust visibility until it links at least Change-Id: I5529f4da33f046eef7e947d755e29486fa966274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172849 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175121 Tested-by: Jenkins
2024-10-17Adapt experimental Emscripten --enable-qt6 to recent Qt6 upstreamStephan Bergmann
At least when building against recent upstream dev branch, qtloader.js needs FS due to <https://github.com/qt/qtbase/commit/64007c749703090ebf7f9b1b49b4267bb9993b99> "wasm: add 'preload' qtloader config property" Change-Id: Ie505d531670649635774152032123389b6d106ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175085 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-16gtk3 a11y: Drop unused DocumentFocusListener classMichael Weghorn
Code calling the ctor was dropped in commit 4aa2cc878dae3b34b16ccacd9358fda5e6d6a197 Date: Thu Jun 20 10:46:59 2024 +0200 loplugin:unusedmethods which dropped GtkSalData::GetDocumentFocusListener unused since commit c45c64aeb57dce91965d7be54601128946455c90 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon May 6 14:44:36 2024 +0200 tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds Change-Id: Iee8134371fce26cb21481695ab8379d4fc61065c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174988 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-16On macOS the "cp" command does not have a "-T" optionPatrick Luby
Change-Id: Id7d81c23e79569a74c26e5a69890b3b41f4b2aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174982 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-10-10Make --disable-emscripten-proxy-to-pthread configurableStephan Bergmann
...as is convenient for some experiments Change-Id: I74aedb38ecc0f7b5a0d913799f649dce77dc7bba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174753 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-10-10Emscripten: For executables, only build .js files, not .html filesStephan Bergmann
...as for the by-default --enable-qt5 case we generate an additional qt_soffice.html anyway (and for a --disable-gui --disable-qt5 build, client code probably wants to embed the results into its own HTML document and wouldn't rely on an soffice.html); this simplifies the build infrastructure a little Change-Id: Ib50799b5dd2fcfeb680f257f46ff65775dcddd71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174725 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-07Emscripten: Silence -Wlimited-postlink-optimizationsStephan Bergmann
...when building with --enable-optimized --enable-symbols --enable-werror, > em++: error: running limited binaryen optimizations because DWARF info requested (or indirectly required) [-Wlimited-postlink-optimizations] [-Werror] > make[3]: *** [Makefile:506: spellout] Error 1 > make[2]: *** [Makefile:366: all] Error 2 > make[1]: *** [external/libnumbertext/ExternalProject_libnumbertext.mk:25: core/workdir/ExternalProject/libnumbertext/build] Error 1 etc. Change-Id: I62ff0a750d62d6bc50de670623e872beddfb4809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174642 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-05tdf#119931: cui a11y: Specify mnenomic-widget in "Alt Text" dialogMichael Weghorn
Specify that the mnemonic widget for the "Alt Text" label is the text view where the description can be entered. This e.g. ensures that the a11y labelled-by label-for relations get reported. Drop the corresponding suppression for gla11y. When using the Orca screen reader with the gtk3 VCL plugin, Orca now announces "Alt Text" when the text view gets focus, while that was not the case before. Dialog can be triggered by e.g. selecting a QR code in Writer, then opening the context menu and choosing the "Alt Text" menu entry. Change-Id: I5c8b06198a45cfbe5e1fc4a85ac568094b596819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174506 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-02Avoid C4847 with --with-latest-c++ when compiling CLRStephan Bergmann
> [build CLR] cli_ure/source/climaker/climaker_emit.cxx > c1xx: error C2220: the following warning is treated as an error > c1xx: warning C4857: C++/CLI mode does not support C++ versions newer than C++20; setting language to /std:c++20 etc., as seen now with at least VS2022 Preview 17.12.0 Preview 2.1 Change-Id: I34d5bca2a81e849ba24b8df5f41ebb12f08a75fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174389 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-09-25fix basegfx.pyNoel Grandin
after commit 3c82f49fcee3f1e4ddae8919993dde57e8bbab2d Author: Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> Date: Mon Sep 23 17:57:00 2024 +0200 Adapting basegfx.py due to blocking in some situations Change-Id: Ie266c7b5aeb5dccaae03c26b7cd73cd65841748c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173949 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-25Adapting basegfx.py due to blocking in some situationsArmin Le Grand (allotropia)
I have stumbled over the GDB integration in vscode hanging when there is a BP and *below* a declaration of e.g. a basegfx::B2DPolygon. This seems to happen due to the instance not yet being incarnated, but the variable view already listing it and triggering methods in basegfx.py to evalualte stuff. It just hangs/loops, I guess it's fetching the PointCount from a random mem ptr'ed Polygon, then tries to evaluate something with the Points. I do not really know about what to do here, but I figured out that testing 'if self.exists()' where the instance gets accessed (using gdb.parse_and_eval) helps. Thus this solves the problem for me and - after stepping over the incarnation of the object I can see it's true content. I hope someone who might have more knowledge about that GDB and python stuff can have a look and maybe tell if tis is OK or should be done in a different way. Change-Id: Ia844b0aded97220df7f4605fdcffeac5e2270db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173826 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2024-09-24Adapt flatpak build to upstream changesStephan Bergmann
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/fb1a63fc872e6ddc8c9ae4b0b366072253e58ddc> "gvfs: Update gvfs-1.54.2.tar.xz to 1.56.0 (#303)" <https://github.com/flathub/org.libreoffice.LibreOffice/commit/8b55ceec9bf4f3298672ad6685455b0bb035d470> "Update org.freedesktop.Platform to 24.08 (#302)" Change-Id: Ib0bffe9652ed3e9c4107c15dfff75a0f57f682c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173881 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-19Remaining GCC -Wcast-function-type issuesStephan Bergmann
As Clang supports that warning now too, lots of occurrences have meanwhile been cleaned up for good (0c29c417ef3f0b749042e5a461abae9c36cf655b "Avoid -Werror,-Wcast-function-type-mismatch", 1344e6261a1d856c71eca1e0cc29215a586bf335 "Avoid -Werror,-Wcast-function-type-mismatch", 85a2bb9f52a0d834b02681344ce56e0b091e1abd "Avoid -Werror,-Wcast-function-type-mismatch", etc.), so ce99754e9b5b954be4360f39356ed7198b298265 "Globally disable -Wcast-function-type new with upcoming GCC 8" in solenv/gbuild/platform/com_GCC_defs.mk should no longer be necessary. One remaining issue I encountered was dae7304df68493afcf6e9c9e490d65ea20d8211f "Silence Clang 19 trunk -Werror,-Wcast-function-type-mismatch", where GCC needs a different way for silencing the warnings in pyuno/source/module/ than had been used there for Clang. Change-Id: I5d0404b957d798114051209c31e022a898cf91f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173623 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-09-18remove OSubComponent from OStatementBaseNoel Grandin
which attempts to implement a very dodgy and almost but not actually thread-safe dispose function. Rather just hold a weak reference to the connection that created us. Change-Id: I01e4f5fc0a8aeb33adc14a2981ce09522a0306bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-17wina11y: clang-format CAccEditableText sourcesMichael Weghorn
This in particular ensures that try/catch blocks are indented by an additional level, improving readability. Change-Id: I7fd538434bd8edb5748bb551fdfd2d4966293bd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173526 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17Avoid -Werror,-Wcast-function-type-mismatchStephan Bergmann
...as seen when building LOWA (i.e., --disable-dynloading) with a recent Clang with <https://github.com/llvm/llvm-project/commit/999d4f840777bf8de26d45947192aa0728edc0fb> "Split -Wcast-function-type into a separate group (#86131)", where -Wcast-function-type-mismatch generally warns about casts between incompatible function types... > cppuhelper/source/shlib.cxx:294:23: error: cast from 'void *(*)(void *, void *)' to 'ImplementationConstructorFn *' (aka 'css::uno::XInterface *(*)(css::uno::XComponentContext *, const css::uno::Sequence<css::uno::Any> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch] > 294 | = reinterpret_cast<ImplementationConstructorFn *>( > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 295 | map[i].constructor_function); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...but not for the special case of casting from/to void(*)(void). (Using the correct function type > css::uno::XInterface * (*)(css::uno::XComponentContext *, css::uno::Sequence<css::uno::Any> const &) throughout would be even better, but doesn't easily fit into this C code that is included in low-level places that don't know those UNO types and is shared between LOWA and Android etc.) Change-Id: Ic4dbabbff0f772b34cf692db968c3ad257c37cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173463 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-09-17wina11y: clang-format AccComponent.hMichael Weghorn
... in preparation of merging `CAccComponent` and `CAccComponentBase`. Change-Id: Ic7f436ec1bf1d4cbebfe27e86a29710719a33785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173444 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-03Emscripten: Move -sEXPORT_EXCEPTION_HANDLING_HELPERS to gb_LinkTarget_LDFLAGSStephan Bergmann
...following up on 95e719730dc62cee3edc959bd9d96edfb992a642 "Emscripten: Explicitly set -sEXPORT_EXCEPTION_HANDLING_HELPERS". For one, it should indeed only be relevant for linking. For another, the previous change had caused at least ExternalProject_libtiff to fail with "checking whether the C compiler works... no" because of "emcc: error: EXPORT_EXCEPTION_HANDLING_HELPERS requires either of -fexceptions or -fwasm-exceptions". Change-Id: I477731c1cffd2b6ee895116043eda91fca44d08f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-03Emscripten: Explicitly set -sEXPORT_EXCEPTION_HANDLING_HELPERSStephan Bergmann
...so that getCppExceptionTag and getCppExceptionThrownObjectFromWebAssemblyException are available in static/emscripten/uno.js. Those apparently happen to already be available due to -sASSERTIONS=1, but better make that explicit (e.g., when we ever want to do -sASSERTIONS=0 builds). Change-Id: I3d94580930603eaf0f609d7878f97d12fb026714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172788 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-02scp2: simplifiy language snippet creation rulesChristian Lohmaier
get rid of some needless redirection/nesting for stuff that's only used a single time. Change-Id: Ie72c006ae1ad1839ae72a1eb19c67d2122798af2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172737 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-08-30wsl: avoid another case of redirection / pipingChristian Lohmaier
in high-parallelsim/high load case the issues with piping commands with wsl1 can result in an incomplete file being generated in b87da3e9402c8b56ce2a16213802224f9288de4d a similar problem when appending with wsl was addressed by splitting the targets, but in this case just separating the commands is more straightforward Change-Id: I92cc06bf489b2cb4f8ffd412a91656fb6ca48233 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172482 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-08-28Put back the mkdirStephan Bergmann
...that 1c84943890afea8eaa8fdaeabbd4394680d657f9 "run msguniq .. | msgfmt in a subshell to help out wsl1", and which caused all kinds of from-scratch builds to fail now with > [build MO ] accde > msgfmt: error while opening "/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/MoTarget/accde.mo" for writing: No such file or directory > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/AllLangMoTarget.mk:40: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/MoTarget/accde.mo] Error 1 etc. (<https://ci.libreoffice.org/job/lo_ubsan/3288/> Change-Id: I756ebdf68f09367d24181ed47b6b5735c45aebf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172484 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-27run msguniq .. | msgfmt in a subshell to help out wsl1Christian Lohmaier
handling stdout / pipe / redirections seems to be fragile when using wsl command1 | wsl command2 when multiple of those are run concurrently. So as a woraround make that a single invokation of wsl shell -c "command1 | command2" Change-Id: I9e67fddd6cf377aa0461515036ea7b709714153d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172468 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-08-22Emscripten: Experimental -sPROXY_POSIX_SOCKETS supportStephan Bergmann
...see <https://emscripten.org/docs/porting/networking.html#full-posix-sockets-over-websocket-proxy-server>. This requires <https://github.com/stbergmann/emscripten/commit/4aff1f28b88480791236adcc6d5cb2d919ad4bf3> "-sPROXY_POSIX_SOCKETS: Add websocket_proxy_poll". When configured with --disable-socketpair (which appears to have no negative consequences), external/curl appears to only call poll(2) with socket-related file descriptors, so we can use websocket_proxy_poll instead. The URL on which the websocket_to_posix_proxy process listens must be specified as Module.uno_websocket_to_posix_socket_url. Change-Id: I4ad23098b5bbc0646fa50859c0aeb9870d1cc92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172243 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-08-21wina11y: clang-format CAccRelationMichael Weghorn
This in particular ensures that try and catch blocks are indented by an additional indentation level as expected, increasing readability. Change-Id: Ic2c3c1500c07df75e3b606ab957a44b220f52194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172150 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-18Emscripten: Increase the main thread stack sizeStephan Bergmann
At least when LO tries to download a document and UUIInteractionHelper::handleErrorHandlerRequest wants to show a MessageDialog via Qt, the stack grows relatively large, and gray_convert_glyph (workdir/UnpackedTarball/freetype/src/smooth/ftgrays.c) alone allocates on the stack a buffer of size FT_MAX_GRAY_POOL * sizeof(TCell) = 1024 * 16 = 16K, which causes (silent, due to no -sSTACK_OVERFLOW_CHECK=2) stack overflow. So (somewhat randomly) double the size of the main thread stack to 128K; but, at least for now, keep the default value of 64K for other threads (which would otherwise inherit the explicitly set -sSTACK_SIZE value via the -sDEFUALT_PTHREAD_STACK_SIZE=0 default). Change-Id: I96583f4af93c84b15c67f310068c5631fb129d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172011 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-18Drop obsolete commentStephan Bergmann
...after 6e6451ce96f47e0ef5e8ecf1750f394ff3fb48e4 "Emscripten: Move the Qt event loop off the JS main thread" Change-Id: Iea9cb74fa2fc3dd036ee865e1bd8ede93fb33c78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172010 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-08-15merge CntUnencodedStringItem into SfxStringItemNoel Grandin
which simplifies the hierarhcy. We never allocate such a thing, we always allocate subclasses, and it has no real meaning by itself. Change-Id: Ie6b716c9ea6ca0efe0ae4f39ac345608c45534f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-14solenv/bin/uiex: more helpful error message for context issuesIlmari Lauhakangas
Change-Id: I82b092a18b2fa2bacef7a27ad4e79350b42bc1d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171711 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-08-13wina11y: clang-format CAccHypertextMichael Weghorn
This in particular ensures that try and catch blocks are indented by an additional indentation level as expected, increasing readability. Change-Id: I82af846dfe9707895d146406b6ed79b5a1f8a467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171798 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-13wina11y: clang-format CAccHyperLinkMichael Weghorn
This in particular ensures that try and catch blocks are indented by an additional indentation level as expected, increasing readability. Change-Id: I8cfe89e80b9d8713a69037f1f5bda9ee7eaf782a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171797 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-12Emscripten: Move the Qt event loop off the JS main threadStephan Bergmann
...so that spawning and joining new threads works now and we no longer need a hardcoded -sPTHREAD_POOL_SIZE of pre-spawned threads (see b84ef4d67eaf9f9fd7fd700ca05339cb0cdff742 "Adapt comphelper::ThreadPool to Emscripten's threading needs"; lets keep MAX_CONCURRENCY capped at 4, at least for now, though). This requires <https://github.com/allotropia/qtbase/commit/167b08844df06e3cea85c98161b26e97442ab242> "Minimal support for Emscripten -sPROXY_TO_PTHREAD=1" and <https://github.com/allotropia/qtbase/commit/c722a25630a5390f18a4d974aa942f6376fcb8e1> "Implement QWasmCursor::changeCursor for Emscripten PROXY_TO_PTHREAD case" (see TODOs there). Change-Id: I8cea827bd7786e3c9fd9401b4b2bef9d3ec00d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171758 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-08-09Avoid -Werror,-Wunused-command-line-argument in CompilerTestsStephan Bergmann
...after <https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef06842505353cf5600e9c> "[Driver] Don't claim -c/-S", > [CPT] sal/qa/rtl/strings/compile-oustring.cxx > clang++: error: argument unused during compilation: '-c' [-Werror,-Wunused-command-line-argument] etc. Change-Id: I2a128c21fdc8a8858981a359880cf1d92c60cd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171692 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-03.NET Bindings: Add DotnetTest class to gbuildRMZeroFour
This commit adds the DotnetTest gbuild class to build a unit test suite using the .NET SDK and the NUnit testing framework. Also adds a DotnetTest target for the net_ure module, with unit tests for the Any type, as well as some minor changes to the Any type that came about when writing the test cases. Change-Id: Idbc08ac8f0736dd7355092dd1e69a5f1b4137c4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168956 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-08-03.NET Bindings: Improve DotnetLibrary gbuild classRMZeroFour
This commit rewrites the DotnetLibrary gbuild class to build a .NET library. Logic for handling various .NET languages is now consolidated, while earlier there were separate functions for each language. Usage has been made much more similar to the Jar gbuild class. The CustomTargets used to build net_uretypes and net_oootypes have also been reworked, and a function has been added to DotnetLibrary to consume sources generated by a custom target, for cleaner usage. Change-Id: Ie494b2547d30c43f9bb0aedeac4d140f1f3a830b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170168 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-08-03.NET Bindings: Upgrade --enable-dotnet to --with-dotnetRMZeroFour
This commit changes the existing --enable-dotnet switch into --with-dotnet, allowing users to pass in a different dotnet executable than the one on their PATH, similar to --with-java. This is used to determine the variables DOTNET and DOTNET_ROOT. Change-Id: Ia4f02dfdbd33d7629a800a076f758b26bb186d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169656 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-08-01pyuno,unotest,xmlsecurity: copy GPG test files for UITtestMichael Stahl
The problem was that running UITest_xmlsecurity_gpg changed the files in test/signing-keys/ ... prevent that by copying the directory in that test, which is more complicated than initially expected. Change-Id: Ie3be922e0b2e9dae49f9a70e35ad5270c90b4fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171322 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-07-31Codesign *.jnilib files like *.dylib and remove $other_files variablePatrick Luby
*.jnilib files no longer need to be codesigned before *.dylib files so just codesign them at the same time as *.dylib files. Also, none of the files in the $other_files variable need to be explicitly codesigned since all of those files get codesigned elsewhere in the script. Change-Id: Ia6f22f6d849ca76c1bf8a491c43fc00fee2af4a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171129 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-07-28sfx2, solenv, sw: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: Iab375e8c8aa4c4915f3c70a9ef6aede268e4619f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171138 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-26Looks like Emscripten LO doesn't need explicit --norestore --nologoStephan Bergmann
...mostly because the relevant parts of the code are hard-disabled (even if you would --disable-wasm-strip) with ENABLE_WASM_STRIP_RECOVERYUI=TRUE and ENABLE_WASM_STRIP_SPLASH=TRUE. (And if there are places in the code that would need the equivalent of either --norestore or --nologo after all, we could probably better add explicit #if EMSCRIPTEN there instead.) This allows to get rid of hard-coding the Qt Emscripten LO command line arguments, which means that e.g. web applications embedding LO would now be able to specify them themselves. Change-Id: I8e2dcfd170cc32276bfb9007f098f6ae6a7f9ec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-07-25Enable start center in Emscripten buildStephan Bergmann
...and let it open with that instead of with a hard-coded example.odt. (But keep that example.odt in CustomTarget,static_emscripten_fs_image and adapt the example code in static/README.wasm.md to explicitly load it now.) Change-Id: Ie43e3795e44542acba5a8e755f65acc56fa753f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171019 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins