summaryrefslogtreecommitdiff
path: root/soltools/cpp
AgeCommit message (Collapse)Author
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19tdf#123936 Formatting files in module soltools with clang-formatPhilipp Hofer
Change-Id: I5aa4c38b33193f33f71516e347ef1a58d0c10ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105709 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-04-16cid#1462267 Infinite loopCaolán McNamara
since... commit a2362e0ff5a7cec16e888502a3c16fe2fa7ba0fe Date: Wed Apr 15 19:32:09 2020 +0200 loplugin:buriedassign in sfx2..sot Change-Id: Iabbef1b027cb6bd77b387142df926c5b37858517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15loplugin:buriedassign in sfx2..sotNoel Grandin
Change-Id: I917752edb50020f9acb203038ce65f1ea25afa64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in smoketest..sot"Noel Grandin
This reverts commit 1de7e818a417a412678013c100b4bf73fd8858ac. Change-Id: Ie1100fd1af636a0538f589845b9391ba40dbf12a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18cid#1448469 Out-of-bounds accessCaolán McNamara
add an annotation Change-Id: I70a431fecd8a87f2167bdce53ec2397d22436a9d Reviewed-on: https://gerrit.libreoffice.org/83025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21Avoid -fsanitize=nullptr-with-offsetStephan Bergmann
(new with recent Clang 10 trunk) during e.g. InstallModule_scp2/ooo: > [SPP] scp2/source/ooo/common_brand > soltools/cpp/_tokens.c:336:13: runtime error: applying zero offset to null pointer > #0 in copytokenrow at soltools/cpp/_tokens.c:336:13 > #1 in expand at soltools/cpp/_macro.c:325:5 > #2 in expandrow at soltools/cpp/_macro.c:292:13 > #3 in process at soltools/cpp/_cpp.c:106:17 > #4 in main at soltools/cpp/_cpp.c:60:5 Change-Id: Icbe1c105fbd0ff634f3e2966c27af1b89398be13 Reviewed-on: https://gerrit.libreoffice.org/81187 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ia44a9dd214b5b09ed6f9c39b8057c41ae03897f1 Reviewed-on: https://gerrit.libreoffice.org/77285 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-24cid#1448523 silence bogus Out-of-bounds readCaolán McNamara
Change-Id: I0911133287ace66454e741f7ea994f191d06931c Reviewed-on: https://gerrit.libreoffice.org/76232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48 Reviewed-on: https://gerrit.libreoffice.org/70017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-15loplugin:typedefparamStephan Bergmann
Change-Id: Id694376160986b74ef2bf6cacdd96c13669d5c32 Reviewed-on: https://gerrit.libreoffice.org/69291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-10loplugin:indentation in soltools..svlNoel Grandin
Change-Id: I270a12cdb68920b8fa23b82dd933724e30334485 Reviewed-on: https://gerrit.libreoffice.org/67565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-06loplugin:flatten in soltoolsNoel Grandin
Change-Id: I3df754c58c90978ef5fccc90518ad1af92516a9e Reviewed-on: https://gerrit.libreoffice.org/67404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-22remove some unused enum values and defines in soltoolsNoel Grandin
which led to a whole bunch of dead code Change-Id: If138a05cf7f09b3020e27489b90c32776b859bcf Reviewed-on: https://gerrit.libreoffice.org/63751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22remove unused toktype::IDENTNoel Grandin
Change-Id: I4222902d9ef93e92dfbcbd089d6aaf7d724fa0de Reviewed-on: https://gerrit.libreoffice.org/63750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-07loplugin:collapseif in sdext..svxNoel Grandin
Change-Id: I188d9e9b53e00acfbae3c7acd54de28f084c4b3f Reviewed-on: https://gerrit.libreoffice.org/62985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22loplugin:staticvar in soltools..svxNoel Grandin
Change-Id: Ie9f36eb0e00aaee34a27f136ed903f8f87e52dcc Reviewed-on: https://gerrit.libreoffice.org/61916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in smoketest..sotNoel Grandin
Change-Id: I59ceda8ff85cc7b348882a6e1c62491b74297801 Reviewed-on: https://gerrit.libreoffice.org/61549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Avoid -Werror=stringop-truncationStephan Bergmann
... "‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length", as reported at <https://lists.freedesktop.org/archives/libreoffice/2018-October/081109.html> "LO build fails -Werror=stringop-truncation in _lex.c". Not adding the terminating NUL appears to be intentional here, as the s->inp buffer is terminated (through s->inl) with EOB bytes after the if/else blocks. Change-Id: I5a8559e620b7e34ee27cbcd0f836432deb8cba90 Reviewed-on: https://gerrit.libreoffice.org/61355 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-18loplugin:external (in non-Linux code)Stephan Bergmann
Change-Id: I8cd9d278cfa9da9ceaab364a549d0e2c92d4be09 Reviewed-on: https://gerrit.libreoffice.org/60664 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-16loplugin:external in Executable_cppStephan Bergmann
...showing that tottok and tokkind are actually unused Change-Id: Ic70f4f1fd7b585b00e98b538d116599e395a43b9 Reviewed-on: https://gerrit.libreoffice.org/60536 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-27Related: rhbz#1602589 silence leaked_storageCaolán McNamara
Change-Id: Ib489ebf55d3a18d2af6f34b3f6128231d6d7758c Reviewed-on: https://gerrit.libreoffice.org/58090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25Fix typosAndrea Gelmini
Change-Id: Ieef0e3f21eb12cb5b72d39da4bc0a8c60dd0d5ce Reviewed-on: https://gerrit.libreoffice.org/48545 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-07loplugin:constparamsNoel Grandin
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24loplugin:includeform: soltools (macOS)Stephan Bergmann
Change-Id: I7e2a8d13e068f651bf6e8fbbb66363a4b2b5b0e7
2017-09-25Translate German comments and debug strings (leftovers)Johnny_M
Additionally: - A few grammatical fixes Change-Id: I15ba3809f6b4746be5a691ec2adc0ea17730fa4a Reviewed-on: https://gerrit.libreoffice.org/42690 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-21Make cpp cope with long source linesStephan Bergmann
under --with-lang=ALL it had started to crash during e.g. > LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}".../instdir/program:.../instdir/program" .../workdir/LinkTarget/Executable/cpp -+ -P -DWITH_POSTGRESQL_SDBC -DWITH_FIREBIRD_SDBC -DWITHOUT_EXTENSION_MEDIAWIKI -DWITHOUT_SCRIPTING_BEANSHELL -DWITHOUT_SCRIPTING_JAVASCRIPT -DWITH_HELPPACK_INTEGRATION -DWITH_EXTENSION_INTEGRATION -DENABLE_EXTENSION_UPDATE -DX86_64 -DLINUX -D_PTHREADS -DUNIX -DUNX -DCOMID=gcc3 -D_gcc3 -DWITH_LPSOLVER -I.../scp2/inc -I.../workdir -I.../config_host -I.../workdir/CustomTarget/scp2/macros -I.../workdir/ScpTemplateTarget/scp2/source/templates .../scp2/source/calc/file_calc.scp > .../workdir/ScpPreprocessTarget/scp2/source/calc/file_calc.pre because of > Syscall param read(buf) points to unaddressable byte(s) > at 0x4F31A80: __read_nocancel (syscall-template.S:84) > by 0x404F98: fillbuf (_lex.c:631) > by 0x404CCF: gettokens (_lex.c:479) > by 0x400F0A: process (_cpp.c:77) > by 0x400E80: main (_cpp.c:60) > Address 0x5278494 is 0 bytes after a block of size 32,772 alloc'd > at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) > by 0x402034: domalloc (_cpp.c:321) > by 0x40554F: setsource (_lex.c:679) > by 0x403E38: doinclude (_include.c:130) > by 0x401F9D: control (_cpp.c:297) > by 0x401002: process (_cpp.c:101) > by 0x400E80: main (_cpp.c:60) There appears to be no other check that fillbuf doesn't overflow the Source's input buffer, other than gettokens checking that the buffer isn't more than three quarters full ("if (ip >= s->inb + (3 * INS / 4)) ..."). That smells like cpp assumes input lines to be shorter than some maximum number of characters (like the C99 standard setting a minimum limit of "4095 characters in logical source lines"), and > #define README_TXT_ALL_LANG(key, name, ext) \ > key (af) = READMETXTFILENAME(name,_af,ext); \ > Name (am) = CONFIGLANGFILENAME(name,am,ext); \ > Name (ar) = CONFIGLANGFILENAME(name,ar,ext); \ [...] > Name (zh-CN) = CONFIGLANGFILENAME(name,zh-CN,ext); \ > Name (zh-TW) = CONFIGLANGFILENAME(name,zh-TW,ext); \ > key (zu) = READMETXTFILENAME(name,_zu,ext) in workdir/CustomTarget/scp2/macros/langmacros.inc (which appears to be the culprit here) exceeding that limit under --with-lang=ALL. So just bump the input buffer size. Change-Id: I5d863050fb772dc7e691a604009ff8702dc718e3
2017-08-14new loplugin:droplongNoel Grandin
The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholy unsuitable for portable code. And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different bit sizes. Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d Reviewed-on: https://gerrit.libreoffice.org/41130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-10tdf#39468: Translate some german commentsChristian Barth
Change-Id: Ie9062738de26b44394d4c91b31fab99a7777813f Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/40994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-21loplugin:constparams in soltools and variousNoel Grandin
Change-Id: I5e8e4a9a31aa7c3ff54cc7ce137d08770ea297e1 Reviewed-on: https://gerrit.libreoffice.org/40279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06Translate German comments/debug strings (leftovers in dirs sdext to soltools)Johnny_M
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - Translation of someone's attempts at Spanish in the .java file Change-Id: Ie3a761bc1a8e302247d5dd6e93a6bc4cb3e85a9f Reviewed-on: https://gerrit.libreoffice.org/39609 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-03loplugin:unusedfields in slideshow..svtoolsNoel Grandin
Change-Id: I74d5a4b8cfc4b18267f99648a3112b163c91fd8c Reviewed-on: https://gerrit.libreoffice.org/39474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22Fix passing plain char into ctype.h is* functionsStephan Bergmann
Change-Id: I4de56462e1fe5bba3035fec691feda91be88b434
2017-03-19fix typo/grammar: "the the" --> thedennisroczek
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26-Werror=implicit-fallthrough= (GCC 7)Stephan Bergmann
Change-Id: I2e9ab956fc1e59d09b7409333f18230e34b6a9b7
2017-01-09loplugin:externvarStephan Bergmann
Change-Id: I304144c0ae6b51656ad326a77e9402cc34d5aa18
2016-03-04-Werror,-Wunused-macrosStephan Bergmann
Whatever those _POSIX_ for _MSV_VER were supposed to be good for (have been in there at least ever since 4f4b74153d27a9579c49b225b2690e7f9416fe78 "Moved cpp from cpp to soltools"), but cause -Wunused-macros at least when building with clang-cl. Change-Id: I356bf663cd1e86298ba72a179f46bb9d0c10016b
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann
Change-Id: Ib52f7fb846886dd970ddd51475f890cd81c8f2b5
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I3ae78d781e686bfe9b0513183da7fc8edd81024b
2015-10-02loplugin:unusedmethodsNoel Grandin
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c Reviewed-on: https://gerrit.libreoffice.org/18977 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-07-04Fix typosAndrea Gelmini
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222 Reviewed-on: https://gerrit.libreoffice.org/16711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-16-fsanitize=nonnull-attributeStephan Bergmann
Change-Id: Id214fb1f0decd4d39684a846c06ff97d8baa209d
2014-11-06coverity#1000834 Use of untrusted string valueCaolán McNamara
and coverity#706196 Use of untrusted string value coverity#1244947 Use of untrusted string value Change-Id: I5083aba2eff9e852a24513db431585922302b279
2014-10-02coverity#1233618 Overlapping buffer in memory copyCaolán McNamara
Change-Id: I062dd96bfc4abf2bdaec2c17d1cf57d853d655d8
generated by cgit (git 2.34.1) at 2024-12-28 10:35:00 +0000