Age | Commit message (Collapse) | Author |
|
Found with coccinelle: http://coccinelle.lip6.fr/
Currently only applied to C code.
(cherry picked from commit aaf15142bcbc44f0e06a3357d2b21ecf9c673d21)
Change-Id: I7d43b024752ebd47e84e2e51028f8fd132410800
|
|
Change-Id: I3df7e42b69e3900eae8d10d28a97d776fabd9f4b
|
|
Change-Id: Ifa0efa673cd60eb7bd668b72b4550da6025ffd1e
|
|
For MSVC/clang-cl: "__STDC__: Indicates conformance with the ANSI/ISO C99
tandard. Defined as the integer literal constant 1 only if the /Za compiler
option is given and you are not compiling C++ code; otherwise is undefined."
(<https://msdn.microsoft.com/en-us/library/b0084kay.aspx>)
Presumably fine to just replace #if with #ifdef here (as is used in all the
other cases surrounding it), and not care whether it actually expands to true.
Change-Id: Ie58c76d7e72321b06a11a370fd28221e85fcf871
|
|
Whatever those _POSIX_ for _MSV_VER were supposed to be good for (have been in
there at least ever since 4f4b74153d27a9579c49b225b2690e7f9416fe78 "Moved cpp
from cpp to soltools"), but cause -Wunused-macros at least when building with
clang-cl.
Change-Id: I356bf663cd1e86298ba72a179f46bb9d0c10016b
|
|
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
|
|
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro
In this stage we focus on replacing usage of the WIN macro
Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
stage 1 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro
Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f
Reviewed-on: https://gerrit.libreoffice.org/22390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I1ac58714e04b995ef5229888f0c427104c001318
|
|
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
Change-Id: I895a487b4c7be27fe81a2c4c122adb2aba37c638
|
|
Change-Id: Ib52f7fb846886dd970ddd51475f890cd81c8f2b5
|
|
Change-Id: I3ae78d781e686bfe9b0513183da7fc8edd81024b
|
|
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c
Reviewed-on: https://gerrit.libreoffice.org/19072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c
Reviewed-on: https://gerrit.libreoffice.org/18977
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222
Reviewed-on: https://gerrit.libreoffice.org/16711
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
Change-Id: Id214fb1f0decd4d39684a846c06ff97d8baa209d
|
|
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
|
|
Change-Id: I6430442cc407e02810d849cf60833abe7c7d2830
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
|
|
Change-Id: Ife7d223f5e751e246c537561d3ce24395b4c9f3b
|
|
Change-Id: I2fa40ebe467a65b0d6023883a14c79ff4303bb2f
|
|
and
coverity#706196 Use of untrusted string value
coverity#1244947 Use of untrusted string value
Change-Id: I5083aba2eff9e852a24513db431585922302b279
|
|
and
coverity#982184 Unchecked return value from library
Change-Id: I4b4ba39abc4c008b68cfc1498ee56ac9c4934c98
|
|
Change-Id: I5d540e6e3a21b0563febb70696882439a10b9b86
|
|
Change-Id: I062dd96bfc4abf2bdaec2c17d1cf57d853d655d8
|
|
Change-Id: I22b85cbfda1c1bd705b35095e03cfae4071d2fb7
|
|
to make it easier to read
Change-Id: Iff0fe055c12358edc1be335ec83d0855cc32f03c
Reviewed-on: https://gerrit.libreoffice.org/9877
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
C compilers have been ignoring it for the last decade
Change-Id: I42918263121dd189bab9d27077798b779b9e8da1
Reviewed-on: https://gerrit.libreoffice.org/9873
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...no reason to not have it enabled for URE C include files and what
little real C code is still left. (But note that Clang ignores that
warning.)
Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6
|
|
Change-Id: I19e8e6aa08dc879f273f2a0177b40435c0ac553d
|
|
Change-Id: I8065789618f806d01cdb69a18502dfafd962b9f3
|
|
Change-Id: I1f8c9aa6c7b4403346ee43501a3555abbccf1cfb
|
|
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifa318214079eeb2f903b3e0c4a27c1a807787fd4
|
|
...though many more remain, as the design appears to be let heap grow
until exit.
Change-Id: I3e5cc95a0896c8add33a767209ab0ff60d6a4b52
|
|
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I92c54f61fe8608d788cc236956f4a5a58e20a7df
|
|
Change-Id: I90c093c704609429f9997f3ffed6a9a79c8956a6
|
|
Change-Id: I95d4dc2a3364172e8917d0a029564e9114943148
|
|
Change-Id: I153e34d24493bbbebf37422fb6382969153506a8
|
|
I don´t know why it doesn´t work anymore, but the fix is trivial
may be related of using the Windows 8.0 SDK.
Change-Id: Ia09109b53d4f022a732ea781c98ddd4eb0c721d9
|
|
With MSVC, the third parameter to read() is unsigned int.
Change-Id: I607089fb2a9e6bf794293187be48e910ac40158f
|
|
Clang -fsanitize=undefined
Change-Id: I2b3f1bd28e098d5eb57892d2c7438c18c5c3b357
|
|
Change-Id: I1f221533f5ea684d113bdc45c04bf84405140f9f
Reviewed-on: https://gerrit.libreoffice.org/5539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0bf93f1293fb08b8b558fcac0cb496ed99ad13d9
|
|
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
|
|
Change-Id: Ib03b6d3af9909c971245314bbde2085d8c3c73b2
|
|
The only thing that processdeps.awk does that is actually useful is to
be able to set the target name freely, but that is only important for
the default resource file which was just renamed.
Instead hack makedepend to provide the required functionality directly:
- write dummy rules for included files so builds don't break on
rename/removal
- format deps one per line like concat-deps expects
- concat-deps expects standard POSIX line ends, so open in binary mode
(also disable that awful backup copying nonsense)
Though in retrospect it would perhaps be a better investment of time to
try to replace makedepend...
Change-Id: I54fafdcdcf1a52692e62b8f1f4b96fb9a93d4421
|