summaryrefslogtreecommitdiff
path: root/sot
AgeCommit message (Collapse)Author
2015-08-31sot: don't leak uninitialized memory into temp fileMichael Stahl
Both valgrind and drmemory complain about this in SdExportTest::testSwappedOutImageExport() via SfxOleThumbnailProperty::ImplSave(). Syscall param pwrite64(buf) points to uninitialised byte(s) UNINITIALIZED READ: reading 0x0455b1b4-0x0455b1c8 20 byte(s) within... It appears that the stream writes out everything up to the seek position anyway (otherwise the size check wouldn't work, with sparse files) so make sure it's all zeroed. Also fix SvMemoryStream::ReAllocateMemory() to zero it. Change-Id: Id86dfa65ef6f7d1bba4810f121e01473c5fcf4c7
2015-08-29Formatting and bail-out early (to not re-format too much)Matteo Casalin
Change-Id: If4c55fe669f7bb861baca0ae224675ca74004de5
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I1d88744207f7fa7c8230f8b29d9cc123f488dfaa
2015-08-07cppcheck:noExplicitConstructorNoel Grandin
Change-Id: I2717d3d120df8af5b7e9af8d147a57b9f5b5ecbe
2015-08-06remove some unnecessary casts and local varsNoel Grandin
Change-Id: I6070421b2275b7fdd698fdc87cc349fc87846513
2015-08-06tdf#93018 - Copying forms not working anymore (part2)Noel Grandin
I missed a similar bug lower down Change-Id: I673c69dd1d36cc1b502a7de7821a05d859313aac
2015-08-06tdf#93018 - Copying forms not working anymoreNoel Grandin
Bug introduced by commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f "create new 'enum class' SotClipboardFormatId to unify types" Change-Id: I3febb927f658ac27d2b864869775db3b71940a5c
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I59979f84602276c9a8aa1ffc1d145c1ef8f0a31f
2015-07-31tools: prefix members of SvStreamMichael Stahl
Change-Id: Iba845749d645bc1cf9eb6d6c41829717831bc487
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22limit storage entry max size to size of underlying streamCaolán McNamara
Change-Id: Ie3772338009c07fea40b637621b1170863830e14 Reviewed-on: https://gerrit.libreoffice.org/17296 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Ifb229db31ba6d97c4ec9ca586210c1f3c4b89521
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-08i#107734 Support for Math Input Panel in Windows 7Regina Henschel
The patch introduces a new command .uno:ImportMathClipboard to module Math. It imports MathML content from clipboard and transforms it to Starmath It handles clipboard MIME type 'application/mathml+xml' and plain text, which can be interpreted as MathML segment. It partly solves issues #i14252, #i34781, and #i53509 too. Review by: Hanya <hanya.runo@gmail.com> (cherry picked from commit 9ec2148653436be8612273439180749e71e2ce58) Conflicts: dtrans/source/win32/ftransl/ftransl.cxx officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu sot/inc/sot/formats.hxx sot/source/base/exchange.cxx starmath/sdi/smath.sdi starmath/source/view.cxx Change-Id: I6cb5e8f737ee2e39f9ce96aba841db347a8806e4
2015-07-08Fix typosAndrea Gelmini
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-06loplugin:unusedmethods sotNoel Grandin
Change-Id: I14e8bb3e4e38ade1044ce1c50c9676a65152724c Reviewed-on: https://gerrit.libreoffice.org/16733 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03expand out some sot macrosNoel Grandin
Change-Id: Ic583fe767e5f85628f8270ec740ce3e72fe56ded Reviewed-on: https://gerrit.libreoffice.org/16722 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-02loplugin:unusedmethods toolsNoel Grandin
Change-Id: I45f5489233879126d4f9ee3d01db504d950bb597 Reviewed-on: https://gerrit.libreoffice.org/16656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-29remove custom RTTI from SotFactoryNoel Grandin
unused Change-Id: I22f55aa403cd97ce2c5bf6a521c14a693e4373a7
2015-06-29remove custom RTTI from SvDataCopyStreamNoel Grandin
nothing is using it, except perhaps for XFillExchangeData, which was using it incorrectly :-( Change-Id: Ib9246a20bc97ad91d3e3e97fa642217686fc8c46
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-22tdf#92037 fix dragging DataSources field into documentNoel Grandin
Bug introduced by my commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f "create new 'enum class' SotClipboardFormatId to unify types" Change-Id: I7347fb9e653077205476e2b0c2b8107dc9caae0e Reviewed-on: https://gerrit.libreoffice.org/16396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I82142b0a0fabf9492ce4c4b9ebf4fded4af5a82d
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I773ac633fb3f7de25c62b1e802ddce4ca2cc31c3
2015-05-28new clang plugin: loopvartoosmallNoel Grandin
Idea from bubli - look for loops where the index variable is of such size that it cannot cover the range revealed by examining the length part of the condition. So far, I have only run the plugin up till the VCL module. Also the plugin deliberately excludes anything more complicated than a straightforward incrementing for loop. Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-19Update Apache Bugzilla’s URLAdolfo Jayme Barrientos
Change-Id: I6ef4ae530b7fb4e615100803ae6e3972d9b4545f
2015-05-08callcatcher: update unused codeCaolán McNamara
Change-Id: I8563922204d3ec93bf138cbd1aaba620c0215bf7
2015-05-07Reduce enum class StorageMode to bool transactedStephan Bergmann
Change-Id: I04e53d7de9f2f26e9338a82f7d5ae5dab1682712
2015-05-07StorageMode::DiskspannedMode is effectively unusedStephan Bergmann
Change-Id: I977b0a51a609d3cbc30abd308715f91cad2cfdfa
2015-05-07StorageMode::CreateUnpacked is never usedStephan Bergmann
Change-Id: I7285c90c82b04e3ebb2db371b675689de9c183d7
2015-05-07SotStorage ctor nStorageMode param is effectively only used as bool transactedStephan Bergmann
Change-Id: I3458ae46c256206e31ad268f47e8b92a30f3738e
2015-05-07Remove unused SotStorage ctor nStorageMode paramStephan Bergmann
Change-Id: I6af399ef26d3f3ee97a49592cf97c590c0781eb0
2015-05-07Remove unused SotStorage::OpenSotStream nStorageMode paramStephan Bergmann
Change-Id: Ieda14d984f1614056c701a50ce637ea6fe9620f3
2015-05-07Remove unused SotStorageStream ctor nStorageMode paramStephan Bergmann
Change-Id: I5f114f4ca92d991d17ad871d11a78a5306191f9c
2015-05-07Unwind SotStorageStreamRef typedefStephan Bergmann
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07Unwind SotStorageRef typedefStephan Bergmann
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07Turn StorageMode into a scoped enumStephan Bergmann
Change-Id: I481c153815fff793e9334153d863f26982b879cb
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: If2d2970160803bcaa1feabb8274f83bba0ba722c
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-17loplugin:implicitboolconversion clean-upStephan Bergmann
Change-Id: I10d50f76dff5d5e456b28393c48b4de21201779b
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07Remove dead INetProtocol::VimStephan Bergmann
...which removes the need to abstract over the standard URI '%' escape prefix vs. the silly vim '=' special case invention. Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
generated by cgit (git 2.34.1) at 2024-07-30 03:13:22 +0000