summaryrefslogtreecommitdiff
path: root/sot
AgeCommit message (Collapse)Author
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: If2d2970160803bcaa1feabb8274f83bba0ba722c
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-17loplugin:implicitboolconversion clean-upStephan Bergmann
Change-Id: I10d50f76dff5d5e456b28393c48b4de21201779b
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07Remove dead INetProtocol::VimStephan Bergmann
...which removes the need to abstract over the standard URI '%' escape prefix vs. the silly vim '=' special case invention. Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: I3ae555fd9f0dc3c11ea301ee1cb2c799fbec820d
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: I07d6cd7191c4ac1eeca4bba5edf8f86dd9d9467e
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: I413b3716b3c5bda204619e8b1ff2b724f95a5c38
2015-03-30drop rather awkward debugging hunkCaolán McNamara
Change-Id: Ia0441caec222227f173a9508530d7c4cefd7892e
2015-03-30loplugin:staticfunctionNoel Grandin
Change-Id: I4b7b04031fa74956379c5a1b21abe10b0717f3e9
2015-03-29Clean up remaining C-style casts among void pointersStephan Bergmann
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I1d157bfc82f09f2438e59eca4fcd92931ca38723
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: Ib6842b6215ff70a31299d1410ed66c3ea34e7c78
2015-03-19loplugin:constantfunction: sotNoel Grandin
this appears to be completely unused Change-Id: I74dad8b0c478a1aed035ce9cc663a74de157816e
2015-03-19convert SFX_FILTER_ constants to enum classNoel Grandin
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-18SotClipboardFormatId::FILE->SotClipboardFormatId::SIMPLE_FILECaolán McNamara
Change-Id: Ice4963da8a856b1d2ada13e5b699157a0217e06c
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-02-25convert EXCHG_DEST_ constants to enum classNoel Grandin
Change-Id: I8484b985e46ad34fa45b02aa07130d3259336082
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-05try to avoid overflows in some compare functionsMichael Stahl
Change-Id: I6144d7d6527dc401b7f1b577d1a227361e39e7bb
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-20Some more loplugin:cstylecast: sotStephan Bergmann
Change-Id: I7192a4d29937fc6222457a4a0f53db11e620fcdc
2015-01-16remove unnecessary parenthesesNoel Grandin
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fix windows buildNoel Grandin
and a handful of other currently uncompiled spots, after my commit 7f8f277b94704a289fbbd1b836e4e5d66311580d "fdo#84938: convert STREAM_ #defines to 'enum class'" Change-Id: I550f6fb850e1d71a6f08767eeb222a18071b89d5
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2014-12-30fdo#84229 - don't set error when seeking beyond end of valid data.Michael Meeks
XclImpStream and elsewhere does an initial seek to the end, then a tell to work out the true length of the stream. In order to let us attempt to rescue data from the beginning of otherwise corrupt / truncated streams, we should avoid setting an error here. Interestingly, we also (probably) don't want to return the true length of the valid data - as this is how SotStorage has worked historically. Change-Id: Ie0ff0e183220b81871ae3bf83980a24b57ac8694
2014-12-30fdo#84229 - add sot storage unit test.Michael Meeks
Change-Id: Ic11c397984602bf8a2e292bc901cd7bf71ad555d
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-18sot: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Id787ebbfaa95c29b3f6337286fa78b089038258e
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove some comment noiseNoel Grandin
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13 Reviewed-on: https://gerrit.libreoffice.org/13405 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-01coverity#1247614 Unchecked return valueCaolán McNamara
Change-Id: I658a7f6c8410cfa38512bb45651e5332fbde3194
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-15sot: stop leaking temp files from StgTmpStrmMichael Stahl
The problem is that "aName" is stored as a file path, but osl_removeFile only works with URLs. Change-Id: I6929efc89a9e1a2292f038482b88d38946e6e4e8
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: I28443b688f8ab752162846e5cea661f26d269cad
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
generated by cgit (git 2.34.1) at 2025-01-04 12:15:56 +0000