Age | Commit message (Collapse) | Author |
|
This spares a pair of push and pop of the stack.
Change-Id: Ic5f1ee0ee158779f2f231dab9f7059ce6618bdcb
Reviewed-on: https://gerrit.libreoffice.org/35245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
for incoming refactoring.
Change-Id: I74355dbd1d7a5822cbf67e828ddc31bd76be79f2
Reviewed-on: https://gerrit.libreoffice.org/35171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
found with the attached bin/find-unused-rid.py script
Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf
Reviewed-on: https://gerrit.libreoffice.org/35136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
to skip a push to the stack immediately followed by a pop.
Change-Id: I97eb48db2521d640acec4d8080cceb56561eb901
Reviewed-on: https://gerrit.libreoffice.org/35129
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
instead of pushing it to the stack. This spares some pops.
Change-Id: I9fc987ebf851ff6387e347a2878ff01f482d8f7f
Reviewed-on: https://gerrit.libreoffice.org/35029
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
and kill the unhelpful "unknown" one.
Change-Id: I3137f7e363caeb64d285aacd2e56446148d85353
Reviewed-on: https://gerrit.libreoffice.org/34977
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I1449b3e58f319c67f3a921f74ceab283a6fc4f12
Reviewed-on: https://gerrit.libreoffice.org/34962
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
instead of pushing it to the stack. This saves extra pops.
Change-Id: I2fcf9b86eab9ade45db4351b34bafbcbc42ef056
Reviewed-on: https://gerrit.libreoffice.org/34944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
...from function definitions occurring within class definitions. Done with
a rewriting Clang plugin (to be pushed later).
Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I7d1089fd615ac09a6e59c06c094f79364510b290
Reviewed-on: https://gerrit.libreoffice.org/34800
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
because it cannot happen unless the invariant about TG::UnOper is
broken.
Change-Id: I2250c785c278d77e991be04353cf34b5c1c45a21
Reviewed-on: https://gerrit.libreoffice.org/34735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I46b84ab4cb9cc5d25b6cb60241fcc8a65e449886
|
|
Change-Id: Iaf7a7c65109864f429ab5cc6848a12a37421afa1
|
|
Change-Id: Ie7a8230dcc5b8576aea44c6e62eedaf971241be7
|
|
Change-Id: Ifc6f4788bb285e28451df9c98a72b454b7685160
|
|
Change-Id: Ia2663a768c424ea6f03bd0933a3c2fd608c239d8
Reviewed-on: https://gerrit.libreoffice.org/34422
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
and drop unused enumerators
Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
|
|
Change-Id: I83f5c5664aca925f874be8ac939356228697d05f
Reviewed-on: https://gerrit.libreoffice.org/33850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I7b1c9722e300585603ce54610d7ef20425a4e634
Reviewed-on: https://gerrit.libreoffice.org/33797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: Ic1192a2fca86833e9efd954c7625fb4f84f46b7c
Reviewed-on: https://gerrit.libreoffice.org/33618
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
instead of storing both a raw pointer and an uno::Reference
Change-Id: Ib84809bee35c01fb590439174740d92bf4cd54bd
|
|
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf
Reviewed-on: https://gerrit.libreoffice.org/33514
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
because a ctor was its only client.
Change-Id: I31cce925231210930576bf93396f9d7aa44a5a71
Reviewed-on: https://gerrit.libreoffice.org/33414
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:
1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
2. split the inheritance of Idle from Timer again to maintain
different Link<>s and move all common code into a TimerBase.
While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.
And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.
It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).
Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
|
|
Instead, keep them as SmParser's members.
Change-Id: I8a2aad7ba8baaad9a761f42f62d51fc67cadec07
Reviewed-on: https://gerrit.libreoffice.org/32348
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
and remove all traces of boost/checked_delete.hpp
Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2
Reviewed-on: https://gerrit.libreoffice.org/33182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
No need to define its copy ctor manually nor to use
placement new for assignment operator.
Change-Id: I679a19c1d1a87072d818cdfa4a9347edb6f4cea1
Reviewed-on: https://gerrit.libreoffice.org/33202
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I03f76aada322a7222795795d32553ae2425092c3
Reviewed-on: https://gerrit.libreoffice.org/32962
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I256b251b6aaad487ab0afeb56ee67a4a33769e8f
Reviewed-on: https://gerrit.libreoffice.org/32777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I889da35c24919157e5b01225df10947c790ebf66
Reviewed-on: https://gerrit.libreoffice.org/32547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I21511074a4dd2d0bf410401dfce7c43437824979
Reviewed-on: https://gerrit.libreoffice.org/32526
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I69a2fc0c9ccaa76a0d93127ac6a1544fe9924605
Reviewed-on: https://gerrit.libreoffice.org/32444
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: Ie1647d8143c4c38ebcf5111bffc291c26704c4c0
Reviewed-on: https://gerrit.libreoffice.org/32428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I5dc6a1b1fa42a4fd76af398c2fb56461574900ee
Reviewed-on: https://gerrit.libreoffice.org/31980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Notes
(*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a
dynamic_cast check.
(*) In SC, removed the hint id field from ScIndexHint, no point in
storing the hint id twice
(*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no
point in storing two different hint ids
(*) In some cases, multiple #define's used to map to the same SFX_HINT
value (notably the SFX_HINT_USER* values). I made all of those separate
values.
Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5
Reviewed-on: https://gerrit.libreoffice.org/31751
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I91440e8582108b9121ac6525c8ac88ad6f218a60
Reviewed-on: https://gerrit.libreoffice.org/31721
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I58f6ca7585ef726d4ac3f555118832a4434f4e3c
Reviewed-on: https://gerrit.libreoffice.org/31629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I6fa81689e14e605cd7449526e44245d4fdebb298
Reviewed-on: https://gerrit.libreoffice.org/31536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: Ic2509e7ee4040fec8173861f319bce61804837cf
Reviewed-on: https://gerrit.libreoffice.org/31468
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
...when merely toggling the edit mode of a Calc document embedded in another
document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet").
Interestingly, none of the other document kinds seem to have this problem.
(Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls
SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange
information down there.
Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe
|
|
Change-Id: I7a1ac67f5fb3066b16b59a3a8277952d66572fb6
Reviewed-on: https://gerrit.libreoffice.org/31353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I5babffab846a9f17cd14cbf8ffd3b34b6bb27abd
Reviewed-on: https://gerrit.libreoffice.org/31322
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: Icd863b23cfca635f901a0aea65fa26dace0aa8f9
Reviewed-on: https://gerrit.libreoffice.org/31188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Also, make SmFontSize::GetSizeType() return value, not reference.
Change-Id: Ifec68cfbdd5f05396fb0d913ddd6888749fdcfbd
Reviewed-on: https://gerrit.libreoffice.org/31157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
|
|
Change-Id: I76c7e34878b9d2bc74d2499cf65448f0dd3a17b3
Reviewed-on: https://gerrit.libreoffice.org/31034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
|
|
as possibly multiple "~" and/or "`" by honoring its width attribute.
Change-Id: I17e361c3f8f5d061c856b72266332369497d16b9
Reviewed-on: https://gerrit.libreoffice.org/30809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Change-Id: I20b9fa14d42549a3c5be8a7d4f52c85fcef52cf5
|
|
of Elements window.
Change-Id: I221dacad297c7713f9cdde6d8ffdecf3caa2c3bd
Reviewed-on: https://gerrit.libreoffice.org/30714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|