summaryrefslogtreecommitdiff
path: root/starmath/inc
AgeCommit message (Collapse)Author
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18loplugin:unusedmethodsNoel Grandin
Change-Id: I1c50d176e793397a1f9625f797a3750cf191a61c Reviewed-on: https://gerrit.libreoffice.org/37679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08tdf#106479 Make edit context menu dispatcher basedMaxim Monastirsky
This allows us to add there any .uno command and also get the icon and keyboard shortcut for it. Use this to add clipboard commands. Change-Id: Ic42c28add7771f322491e8e7d6df052e3c2c8d75 Reviewed-on: https://gerrit.libreoffice.org/37353 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-05starmath: Convert SmHorAlign to scoped enumTakeshi Abe
Change-Id: Ie75749ebbea2ec74e2f16b1c42a55fbcd71845c3 Reviewed-on: https://gerrit.libreoffice.org/37270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-05-05Drop premature mode lineTakeshi Abe
Change-Id: I718184564eee226a72e4db5e804a99257d278db5
2017-05-04loplugin:checkunusedparams in starmathNoel Grandin
Change-Id: I1a2299f66e077879863ac0e694e42196c9432458 Reviewed-on: https://gerrit.libreoffice.org/37192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02untranslated strings are just stringsCaolán McNamara
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28loplugin:salunicodeliteral: starmathStephan Bergmann
Change-Id: Ic02e71ccb2d5fe2e3505853c6e164f17e26361b2
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27starmath: Convert SmScaleMode to scoped enumTakeshi Abe
Change-Id: I88024e9cc1147cc44a087315968c3462ab5baf73 Reviewed-on: https://gerrit.libreoffice.org/36978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18convert starmath context menu to .uiCaolán McNamara
Change-Id: I0ab984aac0103a0d2bbb3c7a7c0bbd797eba7454
2017-04-18starmath: Convert SmNodeType to scoped enumTakeshi Abe
Change-Id: I30921f9426e0e50ab8c6dfb1e86400847176b707 Reviewed-on: https://gerrit.libreoffice.org/36613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-14starmath: size() > 0 -> !empty()Takeshi Abe
Change-Id: Id7c73870f58ebf04c2703cdf8b3d0ffe258b2c0d Reviewed-on: https://gerrit.libreoffice.org/36545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-07starmath: Move SmNodeStack to mathmlimport.hxxTakeshi Abe
which is the only place using it. Change-Id: I87d5a1f0d0993f7585c9767fc32eb46158503dfb Reviewed-on: https://gerrit.libreoffice.org/36197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-05starmath: Kill newly unused m_aNodeStackTakeshi Abe
which now has been replaced naturally with the call stack of SmParser functions. Change-Id: I970a350aae6927c6d13ed4917aa29bce3888a3fe Reviewed-on: https://gerrit.libreoffice.org/36136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-04starmath: Simplify code parsing nospaceTakeshi Abe
This also comes with its unit test. Change-Id: I1478bf48c5522691978e3534c9c8a9c0ddfc1e59 Reviewed-on: https://gerrit.libreoffice.org/35985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28remove some more unused SID constants and commandsNoel Grandin
Change-Id: Ibf2bb58ca687c18798328ed86cd549d64f3621b4 Reviewed-on: https://gerrit.libreoffice.org/35792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27create SfxInterfaceId o3tl::strong_intNoel Grandin
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6 Reviewed-on: https://gerrit.libreoffice.org/35722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I4eda687db6ad8d41e6a28430c76b288510da605d Reviewed-on: https://gerrit.libreoffice.org/35645 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24starmath: Make SmParser::DoAlign() return SmNodeTakeshi Abe
instead of pushing it to the stack, for later refactoring. Change-Id: I61760fbfe95771dede62f90f82df3e9961efdcd6 Reviewed-on: https://gerrit.libreoffice.org/35609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-24remove unhandled SID commands in starmathNoel Grandin
checked that none of these are present in any .xcu files. Change-Id: Ife5ac45ca4e71fed9515941c20853b9ab811e057 Reviewed-on: https://gerrit.libreoffice.org/35619 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23starmath: Make DoProduct()/DoSum()/DoRelation() return SmNodeTakeshi Abe
to reduce an excessive number of stack operations. Change-Id: Ia4ef08dce76d318c56bf7d112f686e13d1b2660e Reviewed-on: https://gerrit.libreoffice.org/35551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22starmath: Make SmParser::DoPower() return SmNodeTakeshi Abe
instead of pushing it to the stack. Change-Id: I7b1640e1b3f835c06726941adfe6d212853f3af6 Reviewed-on: https://gerrit.libreoffice.org/35537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22starmath: Make DoOpSubSup() return SmNodeTakeshi Abe
This spares a pair of push and pop of the stack. Change-Id: I046402c2e975a6b5f4148960a9daffa15cc55ff3 Reviewed-on: https://gerrit.libreoffice.org/35532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22starmath: Make DoSubSup() return SmNode by taking another nodeTakeshi Abe
as an argument, not from the top of the stack. Because no token belongs to groups TG::Limit and TG::Power at the same time, we can replace TokenInGroup() with direct comparison with each group. Change-Id: I44882ab40f59c4de1c0e2cbbdc354e43de926ab1 Reviewed-on: https://gerrit.libreoffice.org/35500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-19starmath: Make DoTerm() return the top of the stackTakeshi Abe
without pushing it. Client code do it instead, so no logic changes. Change-Id: I7ea95b4bddc4e1ef7270cfe02d4f8ad3dc1f19d0 Reviewed-on: https://gerrit.libreoffice.org/35400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-17starmath: Add missing commands and tooltips to the Element windowTakeshi Abe
This partially reverts f645294d3959ab204ac0efb6619e74b5ba85efa6 thankfully, which told me which help entries were broken or lost. Change-Id: Id5a4e064aef32d32aed94fbccb0190d514f03c85 Reviewed-on: https://gerrit.libreoffice.org/35318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-16remove unused defines from HRC files in starmathNoel Grandin
Change-Id: I6c4aa070eac55d7ca9a4bdc404087d32a079dc2c Reviewed-on: https://gerrit.libreoffice.org/35254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16starmath: Return SmStructureNode from DoAttribut()/DoFontAttribut()Takeshi Abe
This spares a pair of push and pop of the stack. Change-Id: Ic5f1ee0ee158779f2f231dab9f7059ce6618bdcb Reviewed-on: https://gerrit.libreoffice.org/35245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-15starmath: Separate SmParser::DoError() from Error()Takeshi Abe
for incoming refactoring. Change-Id: I74355dbd1d7a5822cbf67e828ddc31bd76be79f2 Reviewed-on: https://gerrit.libreoffice.org/35171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14starmath: Return SmBracebodyNode from DoBracebody()Takeshi Abe
to skip a push to the stack immediately followed by a pop. Change-Id: I97eb48db2521d640acec4d8080cceb56561eb901 Reviewed-on: https://gerrit.libreoffice.org/35129 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-10starmath: Return SmGlyphSpecialNode from DoGlyphSpecial()Takeshi Abe
instead of pushing it to the stack. This spares some pops. Change-Id: I9fc987ebf851ff6387e347a2878ff01f482d8f7f Reviewed-on: https://gerrit.libreoffice.org/35029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-09starmath: Prepare messsages for all parsing errorsTakeshi Abe
and kill the unhelpful "unknown" one. Change-Id: I3137f7e363caeb64d285aacd2e56446148d85353 Reviewed-on: https://gerrit.libreoffice.org/34977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-08starmath: Drop unused RIDsTakeshi Abe
Change-Id: I1449b3e58f319c67f3a921f74ceab283a6fc4f12 Reviewed-on: https://gerrit.libreoffice.org/34962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-08starmath: Return the expression node from DoExpression()Takeshi Abe
instead of pushing it to the stack. This saves extra pops. Change-Id: I2fcf9b86eab9ade45db4351b34bafbcbc42ef056 Reviewed-on: https://gerrit.libreoffice.org/34944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03starmath: Replace SmParseError::FuncExpected with assertionTakeshi Abe
Change-Id: I7d1089fd615ac09a6e59c06c094f79364510b290 Reviewed-on: https://gerrit.libreoffice.org/34800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-02starmath: Drop SmParseError::UnoperExpectedTakeshi Abe
because it cannot happen unless the invariant about TG::UnOper is broken. Change-Id: I2250c785c278d77e991be04353cf34b5c1c45a21 Reviewed-on: https://gerrit.libreoffice.org/34735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-01move SvtLinguOptions into SmDocShellCaolán McNamara
Change-Id: I46b84ab4cb9cc5d25b6cb60241fcc8a65e449886
2017-03-01unroll SmEditWindow::GetEditEngineItemPoolCaolán McNamara
Change-Id: Iaf7a7c65109864f429ab5cc6848a12a37421afa1
2017-03-01GetEditEngineItemPool can be privateCaolán McNamara
Change-Id: Ie7a8230dcc5b8576aea44c6e62eedaf971241be7
2017-02-21loplugin:subtlezeroinit: starmathStephan Bergmann
Change-Id: Ifc6f4788bb285e28451df9c98a72b454b7685160
2017-02-19starmath: Convert SmParseError to scoped enumTakeshi Abe
Change-Id: Ia2663a768c424ea6f03bd0933a3c2fd608c239d8 Reviewed-on: https://gerrit.libreoffice.org/34422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-15convert SmBracketType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
2017-02-03starmath: Prefix member of SmNodeToTextVisitorTakeshi Abe
Change-Id: I83f5c5664aca925f874be8ac939356228697d05f Reviewed-on: https://gerrit.libreoffice.org/33850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>