Age | Commit message (Collapse) | Author |
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
This renames it to popOrZero() in node.hxx. Also one more call site
found in mathmlimport.hxx.
Change-Id: I3f0281315146347280d0836ceadcfdf9c80fa166
Reviewed-on: https://gerrit.libreoffice.org/12310
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
... so that node.hxx no longer needs to include parse.hxx.
Change-Id: Iac1e21c208e3f0e3fd8ece16eee345e81574a0aa
|
|
Regine add new colors to Math in fe5840aab17e366749c373e4f8683e06e40b4b05 and
this commit just take those new colors and show in the Math Sidebar.
Change-Id: Idd67cf4a04b2855970b115aac8d15d6506f73298
Reviewed-on: https://gerrit.libreoffice.org/12239
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
|
|
Change-Id: Ic464974087f9f8fb161aaffde232668ba01c2f62
|
|
Change-Id: Ia6784bf95d9d0c57b79bdf7373f4836709563b7a
|
|
Change-Id: I9fcbdcd54978ccaffa5359c0afb0a1990356c218
Reviewed-on: https://gerrit.libreoffice.org/12205
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Enable Math to use 16 basic HTML colors
Patch by: Regina Henschel <rb.henschel@t-online.de>
Found by: <lapsap7+ooo@gmail.com
(cherry picked from commit 529e59d90037748d0030191b93252e597935243e)
Conflicts:
starmath/inc/parse.hxx
starmath/source/mathmlimport.cxx
starmath/source/parse.cxx
Change-Id: I08de0ce33928ead3635a3a87c81671b4cc4112ac
|
|
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
|
|
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
|
|
Change-Id: Id6596945d51a1b9f8750aa0f46f6a061cb2e80c3
|
|
Change-Id: Ic7ffc47fd84f89029c140d68601971a5a2d58d0a
|
|
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
...as at least during CppunitTest_starmath_qa_cppunit, during ~SmViewShell,
aGraphic's code calls back into SmViewShell's code calls into pImpl:
SmViewShell::IsInlineEditEnabled() const starmath/source/view.cxx:2057:12
SmGraphicWindow::IsInlineEditEnabled() const starmath/source/view.cxx:227:12
SmGraphicWindow::CaretBlinkStop() starmath/source/view.cxx:297:10
SmGraphicWindow::~SmGraphicWindow() starmath/source/view.cxx:126:5
SmViewShell::~SmViewShell() starmath/source/view.cxx:1976:1
[...]
This is somewhat symmetric to 0e263d61811480f3a9dbc6ad7c752f6cfae4e3fc "order
pImpl before aGraphic because aGraphic deferences pImpl in ctor."
Change-Id: I97494bebaf5747205a690e6d65fd05ba8fb61cab
|
|
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
|
|
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
|
|
Change-Id: Id3f1afa21dccb0a30ae230accb5229a2be2c6b50
|
|
Change-Id: I2705bbb4db52779e0065400f09604384fd9cf151
|
|
well the dialog itself and the top toolbar, the
other toolbars remain as resources as now
Change-Id: If2bc5b2c108af0efb88fb018896806531cdafe60
|
|
Change-Id: I07c457a49646703af5d13f83ba033340309ee655
|
|
- Remove includes from files where they are not needed.
- Update pch files
Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
and
coverity#1038320 Unintended sign extension
coverity#1038319 Unintended sign extension
coverity#1038318 Unintended sign extension
coverity#1038317 Unintended sign extension
coverity#1038316 Unintended sign extension
coverity#1038315 Unintended sign extension
coverity#1038314 Unintended sign extension
Change-Id: Ib8015baf8ffec48e1b2d6ce1e7ce284fb36303b0
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)
Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
|
|
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)
Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
|
|
Change-Id: I5316693452427ed76a7738b090de023b110caa40
|
|
Based on the patch on Bugzilla by
Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Change-Id: I215b83894f228b1cc8908f98858b85c8d5378ddb
|
|
Change-Id: Ibfe57b366207550b0f3c0e9cb7e8da1078531742
|
|
Change-Id: I4ff6cdf0f7d48318a948865784c66f992fe52e3d
|
|
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
|
|
Change-Id: I09e833765294937a75feb5cdd92cce4aa8373c24
|
|
Change-Id: Id8925dd1ef73ad0fa18ff3f103441f30ba7bb5c0
|
|
Change-Id: I742c2eeaa539b9e8557821e15910d0c739e51891
|
|
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
|
|
Change-Id: I099bff66a7796a5cf18e37e445467bdfb33de602
|
|
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
|
|
Change-Id: I96c7d101d4bb6efbd9a93ea8ef4b8e5bd878c6ea
|
|
Change-Id: I7c8e9f33e8b36cb36a0e0e4f4be4241b23df270b
|
|
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
and other cleanups
Change-Id: I1f6a57a6cb7c06a37e9c845fa93815d31008e6e1
|
|
Change-Id: I03e2518c66fef4e40f95a9b68d68f9bb19a947b1
Reviewed-on: https://gerrit.libreoffice.org/8807
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|