summaryrefslogtreecommitdiff
path: root/starmath/source/cfgitem.cxx
AgeCommit message (Collapse)Author
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27loplugin:expandablemethods in sot..starmathNoel Grandin
Change-Id: I5b718bbda9ceca5bbfd1e6482ebd215e15884956 Reviewed-on: https://gerrit.libreoffice.org/30318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-03starmath: Avoid C-style castTakeshi Abe
Change-Id: If8fdb9def831ea9720c3cad1379be47aba7dec30 Reviewed-on: https://gerrit.libreoffice.org/24584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-24starmath: Drop inline wrapper functionsTakeshi Abe
Use corresponding static functions instead. Change-Id: I362744878d9c88de858cb957106c7a70a45122bb Reviewed-on: https://gerrit.libreoffice.org/23369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-22starmath: Use initialization list for some ctorsTakeshi Abe
Change-Id: I51b5df153574a2dfba96106a6268ccdf9715934d Reviewed-on: https://gerrit.libreoffice.org/23423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-19starmath: Avoid C-style castTakeshi Abe
Change-Id: I96efea344dc4ec5c1f20060bb51ea5e853113c9c Reviewed-on: https://gerrit.libreoffice.org/22497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-02starmath: Avoid C-style castTakeshi Abe
Change-Id: Ie8ae44e1b90796033847a892474f4de64e7f9328 Reviewed-on: https://gerrit.libreoffice.org/21984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-27starmath: Stop using unnecessary namespaceTakeshi Abe
Change-Id: I3848e61eac69a2b3cacc3cf1f66534f4508151cd Reviewed-on: https://gerrit.libreoffice.org/21837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-18vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5 Reviewed-on: https://gerrit.libreoffice.org/21560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc Reviewed-on: https://gerrit.libreoffice.org/21510 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-11-10tdf#43090: Add option to disable auto close bracketsMarcos Paulo de Souza
As many users asked, now there is a checkbox inside Tools->Math called "Auto close brackets, parentheses and braces". This option is enabled by default, but can be turned off now. Change-Id: I6f96201c0720fb62fc2dce99222f97194e930fbe Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/19750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Ife1eef04d905f12308b64b971176c2f045a1b268
2015-10-29com::sun::star->css in starmath,stoc,svgio,svlNoel Grandin
Change-Id: If4308b358a55351f6e951ebf055df076ce4ad4ce Reviewed-on: https://gerrit.libreoffice.org/19667 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-26loplugin:unnecessarysuperclass, merge SmMathConfig with SmConfigNoel Grandin
Change-Id: I2c431e9f72f5dee14cf1b603b11972a2e9d88725 Reviewed-on: https://gerrit.libreoffice.org/15902 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-11Adapt std::unique_ptr to SmMathConfigTakeshi Abe
Change-Id: I89c03719c1727aa70d187fcb6ba4630694549301 Reviewed-on: https://gerrit.libreoffice.org/14833 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-03-11utl::ConfigItem::Commit() should call ClearModified()Michael Stahl
Rename the virtual function, and add a new non-virtual Commit() to do that. Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
2015-03-02cppcheck: cstyleCastCaolán McNamara
Change-Id: Iad1307f5362606bf911caed73aea2fd09bf7b004
2015-02-12Math: Make use of officecfg API and remove unneeded codeMarcos Paulo de Souza
Change-Id: I8b747588ebde70e322b8e6719fb7e2cf789e8a99 Reviewed-on: https://gerrit.libreoffice.org/14347 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-06coverity#1267644 Logically dead codeCaolán McNamara
Change-Id: Ida19552cd9163507bea36a189811fdf8c152cae6
2015-02-03starmath: Refactor common code inside cfgitemMarcos Paulo de Souza
using initializer_lists with Sequences Change-Id: Ic6177f99b6c083710135348039958d72a6faf327 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-12-18starmath: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I474eef1f76e171c5a016dd0b1fe225dcaeeb0eda
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-08-12-Werror,-Wundefined-bool-conversionStephan Bergmann
Change-Id: I44327db80a923c2ee8e762b3ba5f5de771b8610e
2014-05-09coverity#705478 Dereference null return valueCaolán McNamara
Change-Id: I3dc6ed508992bc952f1cf34e6d9e26354895bc27
2014-04-30starmath: sal_Bool->boolNoel Grandin
Change-Id: I09e833765294937a75feb5cdd92cce4aa8373c24
2014-02-26Remove visual noise from starmathAlexander Wilms
Change-Id: I45a716abba68521c5ebc203eed205e717efead7b Reviewed-on: https://gerrit.libreoffice.org/8315 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-17remove unnecessary double calls to OUString constructorNoel Grandin
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-10-18random OUString to String conversionsNoel Grandin
Change-Id: I9cfb8e7183b9cce7c690f3a43a64b61a2aa8c754
2013-09-09Math: OSL_FAIL -> SAL_WARNThomas Arnhold
And some cleanup. Change-Id: I2e5239a6f7d0dca5855b80752deae6be27c21af6
2013-09-04String to OUStringThomas Arnhold
Change-Id: I8c51db8fce8c5eea1ac7bd5751aa7f3212ef1166 Reviewed-on: https://gerrit.libreoffice.org/5790 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-04-10remove commented out codeThomas Arnhold
Change-Id: I754a34a88a7f976714827bd8e8986b854d5da692
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2012-11-22AllSettings with LanguageTagEike Rathke
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-10-12XubString->OUStringCaolán McNamara
Change-Id: Ib5f39e099d238b739e0d6b3d92d3f04ee50022fb
2012-07-06re-base on ALv2 code. Includes:Michael Meeks
mingwport35: i#117796: MinGW fix to VistaFilePickerImpl.cxx Patch contributed by Takashi Ono http://svn.apache.org/viewvc?view=revision&revision=1172092
2012-07-03ditch String::CreateFromAsciiCaolán McNamara
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
2012-06-09Remove superfluous empty lines on topThomas Arnhold
More than two lines are removed for readability. Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
2012-05-31targetted SAL_N_ELEMENTS revert.Michael Meeks
Change-Id: Idd43d44dd7fc4bb33be2de5b855a7741de88ec51
2012-04-05UniString::CreateFromInt32 -> rtl::OUString::valueOfCaolán McNamara
2012-03-12use string literal OUString overloadsLuboš Luňák
generated by cgit (git 2.34.1) at 2025-01-02 15:51:36 +0000