summaryrefslogtreecommitdiff
path: root/starmath/source
AgeCommit message (Collapse)Author
2017-04-04starmath: Simplify code parsing nospaceTakeshi Abe
This also comes with its unit test. Change-Id: I1478bf48c5522691978e3534c9c8a9c0ddfc1e59 Reviewed-on: https://gerrit.libreoffice.org/35985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-03tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in UnoControls/, editeng/, filter/, odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/, tools/, writerfilter/, and xmloff/. Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1 Reviewed-on: https://gerrit.libreoffice.org/35992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-02starmath: Fix wrong help messages for lim inf/supTakeshi Abe
Change-Id: I83e1cea1b2f51cc63d032880e12181de25577d92 Reviewed-on: https://gerrit.libreoffice.org/35986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30starmath: Stop using the stack to parse consective identifiersTakeshi Abe
and numbers. Change-Id: I7e898cd437ec314a0d07a16e13d3044480d2e057 Reviewed-on: https://gerrit.libreoffice.org/35903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-30starmath: Hold error nodes as subnodes of SmBracebodyNodeTakeshi Abe
so that the resulting tree aligns them in a straightforward way. Change-Id: Ica86be557c5d462425f5e88930dbdec29947e5d7 Reviewed-on: https://gerrit.libreoffice.org/35882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-29starmath: Refrain from skipping an extra token at missing "}"Takeshi Abe
which requires closing "matrix {". Change-Id: I40cad5a29862d29cd2eda7f5641e732620bac217 Reviewed-on: https://gerrit.libreoffice.org/35785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-29expand vis to visible; fix typosdennisroczek
* translate German source code comments * remove bogus surce code comments * remove ascii art * removed old StarOffice/Sun internal bug tracker references * remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad Reviewed-on: https://gerrit.libreoffice.org/35404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28starmath: Refrain from skipping an extra token at missing "}"Takeshi Abe
which is for closing "stack {". Change-Id: I2161507634fdb33583053168acfcb87754765652 Reviewed-on: https://gerrit.libreoffice.org/35784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-27create SfxInterfaceId o3tl::strong_intNoel Grandin
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6 Reviewed-on: https://gerrit.libreoffice.org/35722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I4eda687db6ad8d41e6a28430c76b288510da605d Reviewed-on: https://gerrit.libreoffice.org/35645 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24starmath: Make SmParser::DoAlign() return SmNodeTakeshi Abe
instead of pushing it to the stack, for later refactoring. Change-Id: I61760fbfe95771dede62f90f82df3e9961efdcd6 Reviewed-on: https://gerrit.libreoffice.org/35609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-23starmath: Fix memory leak at double sub/superscriptsTakeshi Abe
and avoid skipping following tokens too much. This also saves unnecessary stack operations. Change-Id: I4f30be73a615341b2b3de70f2c8f3dd5c2f85910 Reviewed-on: https://gerrit.libreoffice.org/35583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23starmath: Make DoProduct()/DoSum()/DoRelation() return SmNodeTakeshi Abe
to reduce an excessive number of stack operations. Change-Id: Ia4ef08dce76d318c56bf7d112f686e13d1b2660e Reviewed-on: https://gerrit.libreoffice.org/35551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22starmath: Make SmParser::DoPower() return SmNodeTakeshi Abe
instead of pushing it to the stack. Change-Id: I7b1640e1b3f835c06726941adfe6d212853f3af6 Reviewed-on: https://gerrit.libreoffice.org/35537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22starmath: Make DoOpSubSup() return SmNodeTakeshi Abe
This spares a pair of push and pop of the stack. Change-Id: I046402c2e975a6b5f4148960a9daffa15cc55ff3 Reviewed-on: https://gerrit.libreoffice.org/35532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22starmath: Make DoSubSup() return SmNode by taking another nodeTakeshi Abe
as an argument, not from the top of the stack. Because no token belongs to groups TG::Limit and TG::Power at the same time, we can replace TokenInGroup() with direct comparison with each group. Change-Id: I44882ab40f59c4de1c0e2cbbdc354e43de926ab1 Reviewed-on: https://gerrit.libreoffice.org/35500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-20starmath: Assert a precondition of DoBlank()Takeshi Abe
Change-Id: I9e2d7dc5d209559b9cacb4315610431ebd1df717 Reviewed-on: https://gerrit.libreoffice.org/35419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-19starmath: Make DoTerm() return the top of the stackTakeshi Abe
without pushing it. Client code do it instead, so no logic changes. Change-Id: I7ea95b4bddc4e1ef7270cfe02d4f8ad3dc1f19d0 Reviewed-on: https://gerrit.libreoffice.org/35400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-19fix grammar/typo: defunctional --> nonfunctionaldennisroczek
Change-Id: I672ac5d22c79e63cafc6f9f9f31f69e82dedf342 Reviewed-on: https://gerrit.libreoffice.org/35405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17starmath: Add missing commands and tooltips to the Element windowTakeshi Abe
This partially reverts f645294d3959ab204ac0efb6619e74b5ba85efa6 thankfully, which told me which help entries were broken or lost. Change-Id: Id5a4e064aef32d32aed94fbccb0190d514f03c85 Reviewed-on: https://gerrit.libreoffice.org/35318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-16remove unused defines from HRC files in starmathNoel Grandin
Change-Id: I6c4aa070eac55d7ca9a4bdc404087d32a079dc2c Reviewed-on: https://gerrit.libreoffice.org/35254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16starmath: Return SmStructureNode from DoAttribut()/DoFontAttribut()Takeshi Abe
This spares a pair of push and pop of the stack. Change-Id: Ic5f1ee0ee158779f2f231dab9f7059ce6618bdcb Reviewed-on: https://gerrit.libreoffice.org/35245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-15starmath: Separate SmParser::DoError() from Error()Takeshi Abe
for incoming refactoring. Change-Id: I74355dbd1d7a5822cbf67e828ddc31bd76be79f2 Reviewed-on: https://gerrit.libreoffice.org/35171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14starmath: Return SmBracebodyNode from DoBracebody()Takeshi Abe
to skip a push to the stack immediately followed by a pop. Change-Id: I97eb48db2521d640acec4d8080cceb56561eb901 Reviewed-on: https://gerrit.libreoffice.org/35129 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-10starmath: Return SmGlyphSpecialNode from DoGlyphSpecial()Takeshi Abe
instead of pushing it to the stack. This spares some pops. Change-Id: I9fc987ebf851ff6387e347a2878ff01f482d8f7f Reviewed-on: https://gerrit.libreoffice.org/35029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-09starmath: Prepare messsages for all parsing errorsTakeshi Abe
and kill the unhelpful "unknown" one. Change-Id: I3137f7e363caeb64d285aacd2e56446148d85353 Reviewed-on: https://gerrit.libreoffice.org/34977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-08loplugin:loopvartoosmallStephan Bergmann
Change-Id: I394c1e291ef4fb637d871d9cb8cc563e6e787ddb
2017-03-08starmath: Drop unused RIDsTakeshi Abe
Change-Id: I1449b3e58f319c67f3a921f74ceab283a6fc4f12 Reviewed-on: https://gerrit.libreoffice.org/34962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-08starmath: Return the expression node from DoExpression()Takeshi Abe
instead of pushing it to the stack. This saves extra pops. Change-Id: I2fcf9b86eab9ade45db4351b34bafbcbc42ef056 Reviewed-on: https://gerrit.libreoffice.org/34944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-07starmath: Avoid creating SmFontNode with a default tokenTakeshi Abe
when an unexpected token is found. Change-Id: I1a11c08ce54c55bb32289498fbb26af019396b83 Reviewed-on: https://gerrit.libreoffice.org/34918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-06remove some unnecessary use of OUString constructorNoel Grandin
found with git grep -nP '<<= OUString\(\w*[A-Za-z]+' Change-Id: I43354842f1e0418fb292f2e8e0cb30f1229d1c67 Reviewed-on: https://gerrit.libreoffice.org/34864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06starmath: Push next token to escape only in a valid caseTakeshi Abe
Change-Id: I935e7d2992a93ff451bcc5689f2dc59fe7afff40 Reviewed-on: https://gerrit.libreoffice.org/34875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03starmath: Replace SmParseError::FuncExpected with assertionTakeshi Abe
Change-Id: I7d1089fd615ac09a6e59c06c094f79364510b290 Reviewed-on: https://gerrit.libreoffice.org/34800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-02starmath: Drop SmParseError::UnoperExpectedTakeshi Abe
because it cannot happen unless the invariant about TG::UnOper is broken. Change-Id: I2250c785c278d77e991be04353cf34b5c1c45a21 Reviewed-on: https://gerrit.libreoffice.org/34735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-01move SvtLinguOptions into SmDocShellCaolán McNamara
Change-Id: I46b84ab4cb9cc5d25b6cb60241fcc8a65e449886
2017-03-01fix indentCaolán McNamara
Change-Id: Ib5679684c899a7362b71ab8688fd37d276176fef
2017-03-01unroll SmEditWindow::GetEditEngineItemPoolCaolán McNamara
Change-Id: Iaf7a7c65109864f429ab5cc6848a12a37421afa1
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21tdf#106116 "Previous Marker" changes selection only when neededTakeshi Abe
This fixes a hang caused by repeated Shift+F4. Although it seems a regression from 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8, the original code of SmEditWindow::SelPrevMark() had been doomed due to conditional loop depending on obscure signed/unsigned conversion. Change-Id: I61f630eec44b285dc1f1c27097acde4b48ed2991 Reviewed-on: https://gerrit.libreoffice.org/34503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-21loplugin:subtlezeroinit: starmathStephan Bergmann
Change-Id: Ifc6f4788bb285e28451df9c98a72b454b7685160
2017-02-19starmath: Convert SmParseError to scoped enumTakeshi Abe
Change-Id: Ia2663a768c424ea6f03bd0933a3c2fd608c239d8 Reviewed-on: https://gerrit.libreoffice.org/34422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-16convert EditEngineAttribs to scoped enumNoel Grandin
and drop unused EditEngineAttribs_HardAndPara enumerator Change-Id: Ic1fcddc6adeb5317f96bcef9b6f715b26d901a8d
2017-02-15convert SmBracketType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
2017-02-15starmath: Avoid unnecessary stack operations in parsingTakeshi Abe
unless the top is "nospace". Change-Id: I03cfa2b8223298370d9d82ce5e149d61e8793737 Reviewed-on: https://gerrit.libreoffice.org/34249 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-14starmath: This condition always holdsTakeshi Abe
Change-Id: I6d47676dc71644766fdaea7033c53efa0bf9b549 Reviewed-on: https://gerrit.libreoffice.org/34212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-12Various typos on accessibleJulien Nabet
Change-Id: Id28a4a2cbbcec10a7cc9cb40ad208d575352039b Reviewed-on: https://gerrit.libreoffice.org/34161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>