summaryrefslogtreecommitdiff
path: root/starmath/source
AgeCommit message (Collapse)Author
2019-09-24support O(U)String::number() for fast string concatenationLuboš Luňák
When I did the fast string concatenation, I didn't add any support for number(), which simply returned a O(U)String, and so it did the extra allocation/deallocation, although that could be avoided. In order to support this, number() now returns a special temporary return type, similarly to O(U)StringConcat, which allows delaying the concatenation the same way. Also similarly, the change of the return type in some cases requires explicit cast to the actual string type. Usage of OString::getStr() is so extensive in the codebase that I actually added it to the helper class, after that it's only relatively few cases. Change-Id: Iba6e158010e1e458089698c426803052b6f46031 Reviewed-on: https://gerrit.libreoffice.org/78873 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23tdf#39593 use getUnoTunnelImplementationArkadiy Illarionov
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd Reviewed-on: https://gerrit.libreoffice.org/79350 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-16dont define PROPERTY_NONE multiple timesBjoern Michaelsen
Change-Id: Ia4af4a281058131d41c2a65abbce58bf5f7a38b6 Reviewed-on: https://gerrit.libreoffice.org/78866 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-16tdf#74702: remove GetOutDevType() from SmTmpDeviceChris Sherlock
Adds in logic to OutputDevice that takes a font color and the font's background color - if the font and background is dark then return the stock white color, if the font and background are bright, then return the stock black color, otherwise just return the font color. Also added a unit test to ensure that SmTmpDevice restores font and test color correctly. Change-Id: Id805682778d82826c644e7a27017c8d30b1ff5eb Reviewed-on: https://gerrit.libreoffice.org/75524 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-03indicate that SmEditAccessible is editableCaolán McNamara
and use TEXT_FRAME like calc and other similar users of of an EditEngine as a frame do. Change-Id: I9d73362aa44273f87b283fcfc508d27abb50cb40 Reviewed-on: https://gerrit.libreoffice.org/78420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id4b7074e696507fc06c1d4c7f670f9f301b5ca54 Reviewed-on: https://gerrit.libreoffice.org/78249 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-24loplugin:returnconstval in sd..starmathNoel Grandin
Change-Id: Ib14f0ebef1c48a00ed09be70cb5885ccd07db762 Reviewed-on: https://gerrit.libreoffice.org/78060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#39593 extract UnoTunnelId comparison to template functionArkadiy Illarionov
Change-Id: Ia2b5dea273c8de7b8c54e74780193a8d4cba7b45 Reviewed-on: https://gerrit.libreoffice.org/73874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-20loplugin:constvars in solenv..svtoolsNoel Grandin
Change-Id: Ieb0116321bbddd804db6d1789ea3521c5b220840 Reviewed-on: https://gerrit.libreoffice.org/77807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20Fix typosAndrea Gelmini
Change-Id: I77393d6329ef6f2cfc38825791b44d23e8c3af3e Reviewed-on: https://gerrit.libreoffice.org/77764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini
Change-Id: Id8c879b81cde8da6119ac08d9d9028221486dc6a Reviewed-on: https://gerrit.libreoffice.org/76764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini
Split from https://gerrit.libreoffice.org/#/c/76764/ Change-Id: I19f11f80f08ce0d5b4ffda20449f1cddea980b7d Reviewed-on: https://gerrit.libreoffice.org/77596 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-15loplugin:sequenceloop in starmath..svlNoel Grandin
Change-Id: I473a8eec9cbf6d44b55ffd6f2233bf39cf6217da Reviewed-on: https://gerrit.libreoffice.org/77528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15replace ".get->" with "->"Noel Grandin
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I4bd004af206813b9dc01c50ab20f2e8b954b8dca Reviewed-on: https://gerrit.libreoffice.org/77323 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-11revert some consts to placate coverity Uncaught exceptionsCaolán McNamara
Change-Id: I4d8cccd98a60efd928409514944d60d6ee5532d1 Reviewed-on: https://gerrit.libreoffice.org/77251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-08tdf#74702: use OutputDevice::GetBackgroundColor()Chris Sherlock
Apply the Liskov substitution principle to OutputDevice::GetBackgroundColor(). This helps in SmTmpDevice::Impl_GetColor() because it no longer needs to know about what type of OutputDevice it is calling to get the background color. This forced a rename of basctl::ModulWindowLayout::GetBackgroundColor() to be GetSyntaxBackgroundColor(), but this is a happy coincidence as it makes the function intent clearer anyway. Change-Id: I11298a63cb01c187f3a8a4a2c9e90eacda6c3e6b Reviewed-on: https://gerrit.libreoffice.org/75521 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): starmathStephan Bergmann
Change-Id: I12c7978be638fb875be1b183c70a8eb08bedf778 Reviewed-on: https://gerrit.libreoffice.org/76645 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-23Optimize names transformingArkadiy Illarionov
Remove lambda and one extra begin() call. 6ffdc88e79904882e319bdd0b901e7491abae0b3 follow-up Change-Id: Ieb427704112f4d52c044147a5162921448f0590d Reviewed-on: https://gerrit.libreoffice.org/76205 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-23dispose() methods should clear their smart pointersNoel Grandin
especiall the ref-counted ones Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7 Reviewed-on: https://gerrit.libreoffice.org/76102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-22Simplify Sequence iterations in shell..svgioArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I612d36abcc09a91c60f7212de6747a1a1bdcfc69 Reviewed-on: https://gerrit.libreoffice.org/76056 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-21loplugin:referencecasting in slideshow..svtoolsNoel Grandin
Change-Id: Id0f0332d5d66c0bce309643bf42059b9bdc7d448 Reviewed-on: https://gerrit.libreoffice.org/75997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-20cid#1448322 try silence Splice iterator mismatchCaolán McNamara
Change-Id: If419d66811e5a60d50575f7b984811a29785459a Reviewed-on: https://gerrit.libreoffice.org/76019 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-21simplify some getSupportedServiceNamesNoel Grandin
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588 Reviewed-on: https://gerrit.libreoffice.org/74497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in starmath..svgioNoel Grandin
Change-Id: I356e574e28338f6fddc6932b4e41a461d851406d Reviewed-on: https://gerrit.libreoffice.org/74141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-13tdf#120047 Support attribute harpoon/wideharpoon in MathTakeshi Abe
... for an alternative style of vectors. They are vec/widevec analogs but with COMBINING RIGHT HARPOON ABOVE (U+20D1). The new attribute names are deliberately long in order to make fewer accidental collisions with variable names in formulae of exising documents. This also adds a glyph uni20D1 to OpenSymbol. Change-Id: I31666e57808aa0e0327500916d3b862549891886 Reviewed-on: https://gerrit.libreoffice.org/72987 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2019-06-09loplugin:constantparamNoel Grandin
Change-Id: I7bbc4e1546acf58f1ca24bfec5e465bad5ca90de Reviewed-on: https://gerrit.libreoffice.org/73732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:unusedmethodsNoel Grandin
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03SM add a border to the editor and the element listJan-Marek Glogowski
Change-Id: I708476919ce7750df6a691d75fe594c3f44d9126 Reviewed-on: https://gerrit.libreoffice.org/73173 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-29SM disable localized characters on element parsingJan-Marek Glogowski
The special character tokens are localized character names! This means that at least in German the %mu wasn't replaced in the example, as the parser expected %my. So tell the parser to expect non-localized input. And share it for all the parsing. Change-Id: I4c3c0f35eb61c37a2101b51b445e7cc888a1f429 Reviewed-on: https://gerrit.libreoffice.org/73172 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-29tdf#65587 SM implement ElementControl accessibilityJan-Marek Glogowski
This took me ages to implement. I'm still not 100% sure, it works correct. One main problem was the loop where the ATK listener will rebuild the list of children based on the current child count. Then there is the "broken" SPI bridge behaviour. I could actually test this with the gtk3 backend just fine, if I started LO *after* the accerciser. Otherwise the displayed tree will be really broken and the add and remove child events won't be correctly processed, because some Windows in the hierarchy will return a negative parent index. And generally the accerciser has various problems, with most result in Python backtraces an inconsistent app state, but even SIGSEGV happened a few time. Already have some patches for the easy reproducible ones. No idea what will happen on any other setup then Linux with ATK. Change-Id: I3280fd8622966be74e3833621952d95a2671d214 Reviewed-on: https://gerrit.libreoffice.org/73077 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-29SM add some help to the examplesJan-Marek Glogowski
This way the example buttons will have a name for better accessibility, instead of being blank. Change-Id: Ib8a509bc7a9895297eecd8a0db9455f367d93159 Reviewed-on: https://gerrit.libreoffice.org/73171 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-28SM move categories into SmElementsControl...Jan-Marek Glogowski
... and drop the special examples handling. All these lists are already static. The only "drawback" are the previously range-based for loops in SmElementsDockingWindow. Change-Id: I7a6cfbe74c29fcc14557aef1d5ef31d599b33fc0 Reviewed-on: https://gerrit.libreoffice.org/73076 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-28tdf#125454 SM use theming for element listJan-Marek Glogowski
This uses the same background color then the edit entries and changes the focus from the gray filled rectangle to a non-filled rectangle using the general highlight color. Change-Id: I4b44811e768266ccd2081a8e3ef61483a803da3b Reviewed-on: https://gerrit.libreoffice.org/72795 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-23tdf#65587 SM handle page keys in the ElementControlJan-Marek Glogowski
The page handling implementation is a little bit tricky, because the elemnt list is not handled like a grid but a list. Normally one would keep the horizontal cell and just scroll vertically. Instead this implements a kind of circle. Vertical offset is consistet, so you have the same amount of steps for up and down, but up runs left and down runs right. Change-Id: I296a46e98f7e00a59fd0a0ba358c981b49ac86cd Reviewed-on: https://gerrit.libreoffice.org/72793 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-23tdf#65587 SM add key navigation to ElementControlJan-Marek Glogowski
This adds arrows + home + end key navigation. The grid is handled like a list. For convenience Left + Up and Right + Down keys work in the same way. Change-Id: I757184e5161f2c7ac9b241294a5edc304c882497 Reviewed-on: https://gerrit.libreoffice.org/72792 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-22SM fix vertical ElementsControl modeJan-Marek Glogowski
Switches the ScrollBar to horizontal in vertical mode and adapts the scrolling. Change-Id: I35370d74175ccd1f117b17f7d7ffa25119f2e612 Reviewed-on: https://gerrit.libreoffice.org/72791 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15SM fix element control scrollbarJan-Marek Glogowski
The element layouting must always be done without a scrollbar, so it can be decided, if a scrollbar is needed. If it's needed the first paint will update the scrollbar accordingly. This also sets the scrollbar's page size to the control height, so clicking in an empty area will correctly scroll the widget not just a single pixel. Change-Id: Ib9a0eb1952bc0355f683cd8d116c61f9c9d462c4 Reviewed-on: https://gerrit.libreoffice.org/72315 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15tdf#90297 set default SmEditWindow backgroundJan-Marek Glogowski
This implements ApplySetting for the proper background of the undocked SfxDockingWindow. In addition, like all other code, this sets the text color via the EditEngine font objects and therefore reverts the uneeded EditEngine interface from the original commit ea191cf9807d ("tdf#90297 use field colors for math's edit engine"). Change-Id: Ib7df4ce730da92a1e41f58b8348a5aec18208166 Reviewed-on: https://gerrit.libreoffice.org/72312 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15SM handle background theme changesJan-Marek Glogowski
Replaces ApplyColorConfigValues with standard ApplySettings. I also opted to use COL_WHITE for the elements list, as the highlight color is also hard-coded to some light gray. Change-Id: I8be9d5897bf1dda4078b91d4df34a3339ac6cf31 Reviewed-on: https://gerrit.libreoffice.org/72314 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15SM constify SmElementJan-Marek Glogowski
Change-Id: I6334a6c87cb548c434f0dae05e7cb2cc6e6fd66a Reviewed-on: https://gerrit.libreoffice.org/72316 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-14tdf#90297 use field colors for math's edit engineJan-Marek Glogowski
This adds a maTextColor to the EditEngine, which will override the default AutoColor. There is also a NOCOLORS mode and I thought about using it instead, but it defaults to COL_BLACK and overriding this seems wrong. Since the EditEngine does the whole drawing and now has the explicit FieldColor() and FieldTextColor() for background and text, my guess is we don't need an ApplySettings implementation. Change-Id: I6c2ecc843a3e07de98f97c86fc00a3b83cb78d97 Reviewed-on: https://gerrit.libreoffice.org/72197 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-10handle empty tools::Rectangle in SmDocShell::SetVisAreaNoel Grandin
Change-Id: Iccea3b686b02e03552fa5c836ee5a29103930d04 Reviewed-on: https://gerrit.libreoffice.org/72056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-08crashtesting: many asserts in SmTextNode::PrepareCaolán McNamara
e.g fdo58094-1.mml since... commit 13894996601daf10d133f4a71eb0b26794d782bc Date: Sat May 4 21:46:31 2019 +0200 handle empty Rectangle better in starmath Change-Id: I01d11352b8bc9f6dcf6d6565fa41b84d549f620f Reviewed-on: https://gerrit.libreoffice.org/71963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-05handle empty Rectangle better in starmathNoel Grandin
which required fixing a unit test to call Prepare, otherwise the nodes are not ready for layout Change-Id: I763c1b05d4dfafa73ebaee55d080876848de94f6 Reviewed-on: https://gerrit.libreoffice.org/71800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03Use hasElements to check Sequence emptiness in sfx2..svxArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: Icabd773f3b924d465b33e8581175f1fcf70c282e Reviewed-on: https://gerrit.libreoffice.org/71704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-15 08:27:41 +0000