summaryrefslogtreecommitdiff
path: root/starmath/source
AgeCommit message (Collapse)Author
2025-04-11tdf#130857 math: Ensure focus handler in "Spacing" dlg gets calledMichael Weghorn
As mentioned for Math's "Format" -> "Spacing" dialog in previous commit Change-Id: I3018c5a76cd863332ac8560a926105ae76327a38 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Apr 11 10:31:09 2025 +0200 tdf#130857 qt weld: Support Math's "Spacing" dialog for the case of using native widgets with the qt6 VCL plugin: > Currently, the image isn't always updated when choosing > a different category via "Category" menu button. This > will be addressed in a separate commit. For some reason (not further analyzed so far), no QApplication::focusChanged signal gets emitted (that would then trigger the slot in QtInstanceWidget::applicationFocusChanged) for the following scenario: * start Math with the qt6 VCL plugin and environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set * open the "Format" -> "Spacing" dialog * while the focus is still on the "Spacing" spinbox, click the "Category" menu button and select another category, e.g. "Operators" The problem cannot be observed when first moving focus away from the "Spacing" spinbox. To make sure the image gets updated, explicitly call the SmDistanceDialog::SetCategory Call the `GetFocusHdl` handler in SmDistanceDialog::SetCategory after setting focus to the spinbutton which makes this work for the case of using native widgets with qt6 as well. Change-Id: Ia4a1389a014f22c9c1665093321b231838ad1215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184026 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-04-10a11y: Drop unused includesMichael Weghorn
Change-Id: Ib0e4fe99d35c7b5735dc6cbe61705588ee8c84b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183982 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-03-21GetView() seen as null in crash reportCaolán McNamara
Change-Id: I3597bc22a3e36f11b74f3d0925d765625811fa2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183198 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-03-19Rename con-const vcl::Font property getters for clarityMike Kaganski
There are two sets of getters there; and the non-const ones may copy the COW mpImplFont, and may call its AskConfig. The name overload is unfortunate. It is not obvious at the call site, which of the two will be called; and what is different. IMO, the way to fix it would be to keep only one set of getters (the const one), and make the call to AskConfig explicit (in the places that set font name, and know that resolution of other properties will be needed). But in this change, I only rename the non-const getters, making sure to keep the behavior unchanged (at least the intention is to have a non-functional change, meaning that the places that called non-const overload, now use the renamed functions), to make it clear where we actually may copy and initialize it. Change-Id: I9a5cd91d5c1c0de7ff8577b9b982d165e4cdd2c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183116 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-03-13tdf#147021 avoid use of SAL_N_ELEMENTS macroSimon Chenery
Replaced loops with std::find_if calls to avoid use of the SAL_N_ELEMENTS macro in smmod.cxx. Change-Id: I561d8a4ae66dc5ad342009ee8af3c9db87688d97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182194 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2025-03-12WASM enable Impress for WASM buildsMoritz Duge
Change-Id: Ib0e8f073f9fb74bd0fd3b00e8f31f620f8aa9f39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182750 Tested-by: Jenkins Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>
2025-03-10use more concrete UNO classesNoel Grandin
Change-Id: Id10786bbf7985adbb251224b45f9dabcc84d0a3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-28Fix typoAndrea Gelmini
Change-Id: I706c13611ffc7ef8d8cad48366afe4665514e9c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182342 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2025-02-27tdf#162070: enclose delimiters in in formula inside quotesPranam Lashkari
problem: 1. some characters were not correctly interpreted inside formulas casuing them to appear as inverted question mark. 2. when some special symbols like 'abs' were inserted as normal string were replaced with symbols and sometimes also causing to invalidate formula and add inverted question mark Note: So in MSO if you use operator with spaces on either size it will be treated as literal and when you use them without space in either side it will be operator. This same thing goes for all operators. In libre office you will be able to see visual difference in operator and literal one is slightly bold than other. Change-Id: Id1b0cda36727c1749619adc858b27212057b37e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176421 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-02-26use more concrete UNO types in some local varsNoel Grandin
found by a little plugin I created. Plugin parked into store/ folder because it needs hand-holding when run. Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-13math a11y: Set a11y names for items in Elements sidebar deckMichael Weghorn
Similar to how Change-Id: I59275d8020d0ebd46256bdc1531849cf5be5a353 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Feb 13 13:48:35 2025 +0100 svx a11y: Set accessible name for Fontwork Gallery items did for the Fontwork Gallery, set a11y names for the items in Maths "Elements" sidebar deck (e.g. the mathematical operators,...). Use the text also used for the help text/tooltip (e.g. "+ Sign"), s. `QueryTooltipHandler`. Change-Id: I74d1aa41896b70f6025fdc7e4784a2b6539ec6f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181635 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-13Fix typoAndrea Gelmini
Change-Id: I315c6b4b596b7f6ba3d93cd780d9f371d46be6f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181523 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2025-02-12math a11y: Drop SmGraphicAccessible::getAccessibleIndexInParentMichael Weghorn
The base class implementation in OCommonAccessibleComponent::getAccessibleIndexInParent already implements the same logic. Change-Id: I47ca934da330c90a68dc0060a68121fe34a5ce01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181504 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-12math a11y: Use comphelper::OAccessibleComponentHelperMichael Weghorn
Turn SmGraphicAccessible into a comphelper::OAccessibleComponentHelper subclass. comphelper::OAccessibleComponentHelper already implements the logic for event handling and most of the location/bounds handling, so avoid reimplementing it. Move the SmGraphicAccessible::ClearWin logic into SmGraphicAccessible::disposing and call SmGraphicAccessible::dispose from the SmGraphicWidget dtor instead. Change-Id: I0fa3e6e5a73a8318be730e8165a0e0f149b771ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181503 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-12math a11y: Don't return self in SmGraphicAccessible::getAccessibleAtPointMichael Weghorn
As the XAccessibleComponent::getAccessibleAtPoint doc says, the purpose of this method is: > Returns the Accessible child that is rendered under the given point. Returning a reference to self is incorrect and bad. It e.g. triggers an infinite loop when using Accerciser's "Inspect object under mouse" feature when the mouse is over the formula in Math, because it recursively queries for the child at the position until null is returned. Change-Id: I1aefd6fe69df32bb766351fe068d1c8b151156ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181496 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-12math a11y: Simplify SmGraphicAccessible::getBoundsMichael Weghorn
`aOutPos` is a default-constructed Point. Simply use 0 for x and y coordinate directly instead. Change-Id: I52d0d3648558c6f0fc0b43b4ab5710952dfe7cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181495 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-12math a11y: OSL_ENSURE -> assertMichael Weghorn
Change-Id: If4eaf8f7805289eea8b67df435014bd25db7fb46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181494 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-16math: store main viewshell id in math view shellPranam Lashkari
problem: when we enter to edit a formula a new view shell is created. In LOK all the JSwidgets would be mapped to this window id. But when LOK requests widgets we get the requests from the main viewshell and we can't find any widgets mapped to the main viewshell which means LOK can't load any widgets. Currently there's no mechanism to find the sub viewshell Change-Id: I4f9ce161101ef6815f4d9e712d9bd42f0dc83ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180038 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180287 Tested-by: Jenkins
2024-12-03crashtesting: fix failure of forum-en-13617.odt to reload from .docCaolán McNamara
Change-Id: I907e282c9e7b75abca9a4c91ba12a2c57fc45f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177733 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-27starmath: fix deref nullptrXisco Fauli
Change-Id: I84ad6d24d850857949bbae403cb6f640cd31b16e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177374 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-26Resolves tdf#163685 - Save user-defined formulaHeiko Tietze
Change-Id: I88a1c40d3e97d77c289c8b670b52dca50dea126f Co-authored-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176788 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-20starmath: Use field color for SmEditTextWindow backgroundIlmari Lauhakangas
With same reasoning as commit 8bb38e1b3f1ba1d9c563598d161230fdf27e4685 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Oct 14 12:22:32 2024 +0200 tdf#163397 svx: Use field color for WeldEditView bg Change-Id: Iac0c6b934946b6755ce53ac312c1e637678f966d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176856 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-20tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 1209, 1218 Change-Id: I9f2fe51a0b7d4514ff6a82d24be940ed50d39e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175221 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-15tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 830, 840, 850 V1037 Two or more case-branches perform the same actions. Check lines: 960, 1148 Change-Id: Ifff7612b44d2a3bc0ea573077104b460fed8cf76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175222 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-14Turn a macro to a functionMike Kaganski
Change-Id: I39cfbe43e7f27ada9999daf93aa6ccfd38fb0c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176561 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-12loplugin:reftotemp in sot..svlNoel Grandin
Change-Id: I4c15b3443f411e81eaf7ea0e8c98e8728ab4ca02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-06tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 241, 445 V1037 Two or more case-branches perform the same actions. Check lines: 283, 485 V1037 Two or more case-branches perform the same actions. Check lines: 323, 439 Change-Id: I3540ee8b2d545dcd3bea1443f0d0c43419ae7721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175223 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 574, 577 V1037 Two or more case-branches perform the same actions. Check lines: 738, 752, 759 V1037 Two or more case-branches perform the same actions. Check lines: 1949, 1953 Change-Id: I2a6b6cc16ff58d432e5a7b14a6a1d7fa4f1a15b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175313 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-27tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 2335, 2338 V1037 Two or more case-branches perform the same actions. Check lines: 2464, 2533 V1037 Two or more case-branches perform the same actions. Check lines: 2503, 2506 Change-Id: I71c1149ce64bcfdfd6b4af72fdf65a8f19b8a892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175393 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-23tdf#163486: PVS: Expression is always falseXisco Fauli
V547 Expression 'pDocShell == nullptr' is always false. Change-Id: I0f79864cb5fbfe209cb0c2441665027355aced3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175463 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23tdf#163486: PVS: Expression is always trueXisco Fauli
V547 Expression 'pWin' is always true. Change-Id: Ib7f302c06f1bbfded89d97767197447788ffdd71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175462 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-21starmath: prefix members of SmSymbolDialogXisco Fauli
Change-Id: I36430aa29665fea575633be6ab9e05aeede0c70a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175333 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21tdf#163486 sw: PVS: identical sub-expressionsXisco Fauli
Since commit 47889e229cd51dd8a019d41dace6572e84771d18 Author: Thomas Lange <tl@openoffice.org> Date: Mon Sep 28 10:46:54 2009 +0000 158766 avoid duplicating symbols in the catalog V501 There are identical sub-expressions to the left and to the right of the '==' operator: aSymSetName == aSymSetName Change-Id: If204238eb0fca958e075ebb2ff4f3ad13a55630f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175332 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-06cid#1608598 silence Overflowed constantCaolán McNamara
and cid#1607946 Overflowed constant cid#1608526 Overflowed integer argument cid#1608611 Overflowed integer argument Change-Id: Iec21df2f3d7dc8fba3872c6a70466ae12026a49d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174557 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-28tdf#114441 change width,height to tools::Long in starmathDeepanshu Sharma
Change-Id: I69e0968643c5c30fbe7f67dfb392d176ab796fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174000 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-08-26Related tdf#160226 - Math inline editing Off by defaultHeiko Tietze
Introduced per I63672c054d1ead269863079e7f9c118a44b3ba19 Ib2ca942c537e466f6ff100be7f95adaead99f1d5 Change-Id: Iff2bd250c004e57800c84287483965ec3ae49187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172241 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-08-17tdf#160459 embedded starmath doesn't fit inside allocated areaCaolán McNamara
much to and fro with MapModes and rounding issue obscured that fundmentally that the 'etched-out' GtkScrolledWindow frame requires space which eats into what is available to show the formula, and in embedded mode we want the editing area to be equal in size to the area used for the preview. Change-Id: I1d126ddcc953131cf4add7da58ccd89e7fa86b66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171964 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06cid#1555415 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555497 COPY_INSTEAD_OF_MOVE cid#1555542 COPY_INSTEAD_OF_MOVE cid#1555543 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555693 COPY_INSTEAD_OF_MOVE cid#1555719 COPY_INSTEAD_OF_MOVE cid#1555757 COPY_INSTEAD_OF_MOVE cid#1555795 COPY_INSTEAD_OF_MOVE cid#1555826 COPY_INSTEAD_OF_MOVE cid#1555847 COPY_INSTEAD_OF_MOVE cid#1555851 COPY_INSTEAD_OF_MOVE cid#1555863 COPY_INSTEAD_OF_MOVE cid#1555865 COPY_INSTEAD_OF_MOVE cid#1555867 COPY_INSTEAD_OF_MOVE cid#1555869 COPY_INSTEAD_OF_MOVE cid#1555879 COPY_INSTEAD_OF_MOVE cid#1555890 COPY_INSTEAD_OF_MOVE cid#1555893 COPY_INSTEAD_OF_MOVE cid#1555900 COPY_INSTEAD_OF_MOVE cid#1555922 COPY_INSTEAD_OF_MOVE cid#1555925 COPY_INSTEAD_OF_MOVE Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-04cid#1556583 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556585 COPY_INSTEAD_OF_MOVE cid#1556588 COPY_INSTEAD_OF_MOVE cid#1556593 COPY_INSTEAD_OF_MOVE cid#1556597 COPY_INSTEAD_OF_MOVE cid#1556605 COPY_INSTEAD_OF_MOVE cid#1556617 COPY_INSTEAD_OF_MOVE cid#1556635 COPY_INSTEAD_OF_MOVE cid#1556790 COPY_INSTEAD_OF_MOVE cid#1556792 COPY_INSTEAD_OF_MOVE cid#1556796 COPY_INSTEAD_OF_MOVE cid#1556799 COPY_INSTEAD_OF_MOVE cid#1556815 COPY_INSTEAD_OF_MOVE cid#1556836 COPY_INSTEAD_OF_MOVE cid#1556840 COPY_INSTEAD_OF_MOVE cid#1556842 COPY_INSTEAD_OF_MOVE cid#1556859 COPY_INSTEAD_OF_MOVE cid#1556860 COPY_INSTEAD_OF_MOVE cid#1556866 COPY_INSTEAD_OF_MOVE cid#1556869 COPY_INSTEAD_OF_MOVE cid#1556870 COPY_INSTEAD_OF_MOVE Change-Id: I3df8698a4aecbb03999c084517e37e12ff46ee97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-21cid#1556239 Use of auto that causes a copyCaolán McNamara
and cid#1557287 Use of auto that causes a copy cid#1558003 Use of auto that causes a copy cid#1557568 Use of auto that causes a copy cid#1556546 Use of auto that causes a copy cid#1557377 Use of auto that causes a copy cid#1608325 Use of auto that causes a copy Change-Id: I84e59d2b14bb1e5856f9cac521ad6542b1784243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170821 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-20cid#1607830 Use of auto that causes a copyCaolán McNamara
and cid#1607722 Use of auto that causes a copy cid#1557606 Use of auto that causes a copy cid#1557569 Use of auto that causes a copy cid#1556239 Use of auto that causes a copy cid#1556043 Use of auto that causes a copy cid#1554961 Use of auto that causes a copy cid#1554818 Use of auto that causes a copy Change-Id: I9f74c7bc4da2c6b1df80d0fb4504dd4d03eb1053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-18make some single-arg constructors in starmath explicitNoel Grandin
Change-Id: I4b9a010a2cf42076b02c80732c8e35686482f9e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-12cid#1555962 Use of auto that causes a copyCaolán McNamara
and cid#1556100 Use of auto that causes a copy cid#1556199 Use of auto that causes a copy cid#1556239 Use of auto that causes a copy cid#1556313 Use of auto that causes a copy cid#1556373 Use of auto that causes a copy cid#1556680 Use of auto that causes a copy cid#1557020 Use of auto that causes a copy cid#1557099 Use of auto that causes a copy cid#1557251 Use of auto that causes a copy cid#1557334 Use of auto that causes a copy cid#1557468 Use of auto that causes a copy Change-Id: Ib5ab5b33eabcac3d18899ceaaa9119e13b0139f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-26tdf#161786: fix Math crash when typing "oper"Julien Nabet
Change-Id: I8332e87e703f9138b8d13985b8697ad4b9f2191e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169539 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-05-14loplugin:ostr in starmathNoel Grandin
Change-Id: Ied15eb71ae3ae2d80ba839a6c99ea3cf620ca52f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167598 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-04-09tdf#146619 Drop unused 'using namespace' in: starmath/Gabor Kelemen
Change-Id: I382ca117484b0928580f4bed765799e915e7b8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165693 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-12Revert "add sm to --enable-mergelibs=more"Noel Grandin
This reverts commit 87d3f768f3ecded1e1392442181edb287aed9e2e. The unit test at starmath/CppunitTest_starmath_qa_cppunit.mk is doing $(eval $(call gb_CppunitTest_use_library_objects,starmath_qa_cppunit,\ sm \ )) which it is using to access to all the internal functions of starmath. Unfortunately that linking trick is just not compatible with the mergelib linking. Change-Id: Ie3c81a0eeea5bed192de18981463497f251531a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-11Use weak reference to SfxObjectShell in SfxEventHint to avoid use-after-freeMike Kaganski
The events may be processed after the shell has been destroyed. This is happening reliably after commit e2bfc34d146806a8f96be0cd2323d716f12cba4e (Reimplement OleComponentNative_Impl to use IGlobalInterfaceTable, 2024-03-11) when controlling LibreOffice from external Java scripts; but obviously, it could happen before as well. Now SotObject inherits from cppu::OWeakObject, instead of SvRefBase. Change-Id: I73a3531499a3068c801c98f40de39bdf8ad90b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164458 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-04-29 10:07:32 +0000