summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2016-03-10starmath: no need to override SmFontPickList::Update/RemoveTakeshi Abe
Just use them instead. Change-Id: Ic82d2c3edc1d0ccd2551f8cf208f108168148786 Reviewed-on: https://gerrit.libreoffice.org/23111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09starmath: Drop SmNode::FindIndexTakeshi Abe
Its sole usage can be replaced with SmNode::IndexOfSubNode. Change-Id: Icfd4a3fe846b585c5fa3f47e0768729aba66d73e Reviewed-on: https://gerrit.libreoffice.org/23064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09toolbox.src in starmath is all unused resourcesCaolán McNamara
since commit 3dfe2fc394ca1e168e800ffcc3ac0f69b4eeb173 Author: Julien Nabet <serval2412@yahoo.fr> Date: Sat May 2 19:03:21 2015 +0200 tdf#68871: Remove the old Elements panel from Math Change-Id: I61ceb2e3b8dfb0a402db061cf08930f2cf2c7d32
2016-03-08starmath: Use assert for impossible null-dereferenceTakeshi Abe
Change-Id: I3a0e78985470f210dd093dce3e87671980e647f4 Reviewed-on: https://gerrit.libreoffice.org/23016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07drop now-needless depsDavid Tardon
Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e
2016-03-07remove remaining uses of gb_SrsTemplateTarget_get_targetDavid Tardon
Change-Id: I5ddf0ba5fc289a124b39b9c14b7f5fdd3d7b54a4
2016-03-07expand src templatesDavid Tardon
Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352
2016-03-07these ResIds are used solely for their number by nowCaolán McNamara
so cut out the middle-man ResId Change-Id: Ic83db355cc1a0c7dc70958bca79b466baadaedd0
2016-03-07starmath: Make SmNode abstract and noncopyableTakeshi Abe
... and remove unused SmStructureNode's copy ctor/assignment operator. This seems desirable according to the old comment in SmNode::Accept(). Change-Id: Ifb51c64ca784f1295374d31cc210cbe3e45aa2f8 Reviewed-on: https://gerrit.libreoffice.org/22801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-03-04tdf#96505 Remove long integer literal specifier when not neededAleksas Pantechovskis
Remove L from integer literals if it does not produce warnings and does not change semantics Change-Id: I9573a47d3e3401993a1f0fbcf7df4be20f9e6eba Reviewed-on: https://gerrit.libreoffice.org/22867 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03starmath: Drop ENABLE_DEBUG_DUMPASDOT featureTakeshi Abe
The feature for debugging seems unused so long that defining ENABLE_DEBUG_DUMPASDOT breaks the build but no one complains. So let's ditch it. Change-Id: I0b472cd1acbcfd0c2550c3bd36661c91bc2e2986 Reviewed-on: https://gerrit.libreoffice.org/22608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-03-01loplugin:unuseddefaultparam in starmathNoel Grandin
Change-Id: I740d931c0236c1a4d40013b458f249692695d6e5
2016-02-29starmath: Use member initializer list for SmRectTakeshi Abe
Change-Id: Iac3df1fe7d189c2e78e585b9ac3642b05b0f1472 Reviewed-on: https://gerrit.libreoffice.org/22761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-27tdf#98088: prevent access to invalid sub nodeOliver Specht
Change-Id: I73bd77682bfb60474ba18ca85bc5d008c70a7f97 Reviewed-on: https://gerrit.libreoffice.org/22715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-26starmath: Remove forgotten SmFormat's versionTakeshi Abe
Its last usage was gone with 26bdb10a52f441b4026d651ec50189b88391319e. Change-Id: I3a58a5596eaa930e9d7034b87fe05cbe8a902c41 Reviewed-on: https://gerrit.libreoffice.org/22690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-26starmath: Drop unused variable declarationTakeshi Abe
Change-Id: Ibc2a5930e516628cfe5fb7986c4ba814533dbf25 Reviewed-on: https://gerrit.libreoffice.org/22692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-19starmath: Avoid C-style castTakeshi Abe
Change-Id: I96efea344dc4ec5c1f20060bb51ea5e853113c9c Reviewed-on: https://gerrit.libreoffice.org/22497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-18move from boost::signal to typed LinkCaolán McNamara
it doesn't really gain us much to have a handful of boost::signal use in a sea of Links This also fixes a regression in commit 051b29e1025253f35f87a04e297760aa8b40611f Author: Luboš Luňák <l.lunak@collabora.com> Date: Sun Sep 14 15:45:02 2014 +0200 convert Edit autocomplete Hdl to boost signals2 where the conversion was... - if ( maAutocompleteHdl.IsSet() ) + if ( autocompleteSignal.empty() ) instead of the correct + if ( !autocompleteSignal.empty() ) Change-Id: I27270d94c782485c0a7e929bc4980af4527fe82b
2016-02-18starmath: Avoid C-style castTakeshi Abe
Change-Id: Id54997718a61b1b5a488922f05374c559f1e4454 Reviewed-on: https://gerrit.libreoffice.org/22460 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-17starmath: Drop unused RID_COLORXTakeshi Abe
Change-Id: I99e66067deb314c48347e18ebb5942501de19d17 Reviewed-on: https://gerrit.libreoffice.org/22415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-16starmath: Convert RectCopyMBL to scoped enumTakeshi Abe
Change-Id: I44e4f3086f642adccdff8dcf82298e5f4e9cb282 Reviewed-on: https://gerrit.libreoffice.org/22305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-15starmath: Replace OSL_ENSURE with assertTakeshi Abe
These pointers must be non-null, or deferencing null can happen. Change-Id: I3ced1204abb70cf7c525ea9d50c6a3a295728ab5 Reviewed-on: https://gerrit.libreoffice.org/22365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-10tdf#53472 Integral Symbols too small for some integrandsmelikeyurtoglu
Change-Id: I1ab550821f0b254a7414246fd72f3882b7140c90 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/21482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08starmath: Convert RectVerAlign to scoped enumTakeshi Abe
Change-Id: I6c9a7e1527cf2083f567397eb41db7ae3437c25e Reviewed-on: https://gerrit.libreoffice.org/22141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-08starmath: Replace SAL_WARN_IF with assertTakeshi Abe
These assertions must hold, otherwise the following code would dereference null pointer. Change-Id: I2b3887aad7116a7ea5176630a015975b8fc087f9 Reviewed-on: https://gerrit.libreoffice.org/22140 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-08remove unused HelpText attribute from *.sdi filesNoel Grandin
Change-Id: I21bcf66c552cd38eaae1bdc85626aa9bd1782ebd
2016-02-08remove unnecessary module GUIDs in *.sdi filesNoel Grandin
Change-Id: I78784abc1031027d69bbe31d150bc78c8bfbfcf4
2016-02-08remove some unnecessary declarations from *.sdi fileNoel Grandin
found with a bunch of grepping Change-Id: I920609fb7df5a5e55ecbf5c2bf4880ff972cfbed
2016-02-06vcl: split exception types from input typesChris Sherlock
Having them in the file apptypes.hxx isn't necessary helpful, IMO so I've split the types into inputtypes.hxx and exceptiontypes.hxx Change-Id: I89a1ff168c3ae276b2f5486669d4ec2dda062d57
2016-02-05remove unnecessary comments from .SDI filesNoel Grandin
Change-Id: Ic78ae8ce5bf396f55fdc847d6b70476c9dab4ee9
2016-02-05remove unused UUID and VERSION from .SDI filesNoel Grandin
Change-Id: Ieb3e47c10c497a6f642f28a6741ac0fd2ecfd419
2016-02-05remove unused Readonly from .SDI filesNoel Grandin
Change-Id: I179200ad65492c517ef5e986fd05758896d38813
2016-02-05remove unused Automation from .SDI filesNoel Grandin
Change-Id: I65e1ca6e022dc76ac96ed75da2c5e78e9356a3e9 Reviewed-on: https://gerrit.libreoffice.org/22107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused GET/SET/STATUSBARCONFIG in .SDI filesNoel Grandin
Change-Id: I74404d72e9146950a9881d2a59323c2bf08c9742 Reviewed-on: https://gerrit.libreoffice.org/22100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04starmath: Convert RectHorAlign to scoped enumTakeshi Abe
Change-Id: Ia5b43083e9675ef2664e5147e80237a7d947e138 Reviewed-on: https://gerrit.libreoffice.org/21859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-04remove unused HasDialog from SDI filesNoel Grandin
Change-Id: I26f2cef48fcc7a6c4a6b93668b836879254f3eb0 Reviewed-on: https://gerrit.libreoffice.org/22098 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused Synchron from SDI filesNoel Grandin
Change-Id: I0b8c63a97bfa4a49ac87869e164ab22d2aa99de3 Reviewed-on: https://gerrit.libreoffice.org/22097 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04remove unused Cachable keyword from SDI filesNoel Grandin
Change-Id: I60c423b799f34f79f58bc39cf7ea616ec4f5d16a Reviewed-on: https://gerrit.libreoffice.org/22096 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-03starmath: Avoid C-style castTakeshi Abe
Change-Id: I1599c7d62f9b5ff43eecf9f11bbb173c4faeeb15 Reviewed-on: https://gerrit.libreoffice.org/22067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-02-03starmath: tdf#97190: don't assert on missing base URLMichael Stahl
There are valid scenarios where we don't have a URL at all, such as when importing MathML from the clipboard. Also there probably isn't much of a problem caused by missing base URLs in Math anyway since RDF import is currently not implemented and i'm not sure if hyperlinks in Math documents are possible at all. Change-Id: I13b70ac62542364f329875e292c574883255af5e
2016-02-03remove unused HasCoreId from SDI filesNoel Grandin
Change-Id: I4aca4b8a79ce92d64ce004ccdb7e9a0f408dc768
2016-02-02starmath: Avoid C-style castTakeshi Abe
Change-Id: Ie8ae44e1b90796033847a892474f4de64e7f9328 Reviewed-on: https://gerrit.libreoffice.org/21984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-02Resolves: tdf#97495 fix SmElementsControl tooltipsCaolán McNamara
instead of setting a single tooltip for the whole panel area, wait for a tooltip request and specify the area to which it applies. Which is what other widgets that have different tooltip areas do, and maps much better to the gtk3 tooltip system which functions like that too. Change-Id: I56f452562c3c4d9dcec4109a8ee6168f34619472
2016-02-02tdf#84843 Stop using PseudoSlots for drawing slotsMaxim Monastirsky
Instead of fighting with this obsolete thing, let's just kill it. This fixes disabling in read-only doc, as well as pressed/unpressed states. Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115 Reviewed-on: https://gerrit.libreoffice.org/22010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31sequence->vector in PrinterOptionsHelperNoel Grandin
Change-Id: I643519397a4e714e3407ec0c3a10d329654b9f7d Reviewed-on: https://gerrit.libreoffice.org/21887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-29WaE: calling static member function through member call syntaxTor Lillqvist
Change-Id: I71c1ae0c5f34e17ab11cd6726d6845255224044d