summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2016-01-14loplugin:unusedmethods unused return value in starmathNoel Grandin
Change-Id: Ic70c3d727ecadd082f7e5d293fc2b279b1287b8f
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-12tdf#87118 LibreOffice should not claim to use version 1.01 of MathMLTakeshi Abe
Call it MathML 2.0 instead. Change-Id: Ifecd52cfcded680bbddf680f2600a42b1c7568d9 Reviewed-on: https://gerrit.libreoffice.org/21304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-12starmath: Assert that SmRootNode always has three childrenTakeshi Abe
Change-Id: I9d1b47fc7fc26254f331967dd58f60d88bd2112f Reviewed-on: https://gerrit.libreoffice.org/21036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-11loplugin:privatebase: Make various derivations publicStephan Bergmann
...assuming they were implicitly made private by accident rather than by design. (And private derivation can cause unexpected failure of dynamic_cast, cf. 63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove then-unnecessary downcasts.") Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10Cleanup FontCharMapPtr variable prefixesChris Sherlock
Change-Id: Ib106b91ab71ee45d5ad469d0beaf4ebaef8b57e1 Reviewed-on: https://gerrit.libreoffice.org/21306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-07starmath: Remove unused resource itemsTakeshi Abe
Change-Id: Ia64d33a6a755f6a0c1418c7230f4734a06febed4 Reviewed-on: https://gerrit.libreoffice.org/21187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-06starmath: Remove toolbox.hrcTakeshi Abe
Usage of NUM_TBX_CATEGORIES was gone at 3dfe2fc394ca1e168e800ffcc3ac0f69b4eeb173. Change-Id: Ic0fea85ad143de02102e3745f310966a8b94192e Reviewed-on: https://gerrit.libreoffice.org/21153 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-06starmath: Fix bogus warningTakeshi Abe
RID_PRINTUIOPTIONS has 9 items. Change-Id: Ie7aee00e0219151b1573217ca670a93925de67cc Reviewed-on: https://gerrit.libreoffice.org/21154 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-06tdf#90341 Clean up excessive const_cast'ingTakeshi Abe
RequestApplyChanges()'s call sites do not require its constness. Change-Id: Iaf9108375db7503fe1a3bd8275e13dbdddf95ab5 Reviewed-on: https://gerrit.libreoffice.org/21068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-05Make SotFactory private to sot/ and clean a bitMatúš Kukan
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2016-01-05starmath: Drop nonexistent friendTakeshi Abe
SmClipboardChangeListener was gone at 5ed3fa4c39a67b2b12b4206bef6680fb757e1b75. Change-Id: Ia826ecbeb53eb1d5cb41bd39fe250cdaf60268cd Reviewed-on: https://gerrit.libreoffice.org/20987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-04vcl: split classes out of metric.hxxChris Sherlock
Change-Id: Id3b155abec7b7a2ff43d0a35e98709f5ee51c6b9 Reviewed-on: https://gerrit.libreoffice.org/21069 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-04Cleanup after removing vcl::FontInfo classChris Sherlock
Change-Id: I544eac439cb7277e47a23a90c6fbc45496161c3b
2016-01-03vcl: Excise vcl::FontInfo classChris Sherlock
This may sound crazy, but literally vcl::FontInfo serves no purpose that I can see. The inheritance chain is like this: ┌────────────────────────┐ │ │ │ vcl::Font │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ vcl::FontInfo │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ FontMetric │ │ │ └────────────────────────┘ vcl::FontInfo (which, incidentally, needs to be put into the vcl namespace due to collisions with poppler!) literally does nothing and is acting as a bridge between FontMetric and vcl::Font. Unlike a bridge though, this bridge doesn't actually *do* anything. So I'm removing it, which means one less class to deal with in the vcl fonts world. Change-Id: I32725669c9bca7fbb0846b6a062135464046e4f6 Reviewed-on: https://gerrit.libreoffice.org/21058 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-31starmath: Manage SmDocShell's pCursor via std::unique_ptrTakeshi Abe
Change-Id: Id9c67638e5c2e535cc06e9566c9a169471f55da8 Reviewed-on: https://gerrit.libreoffice.org/20856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-29tdf#32062: Add testMarcos Paulo de Souza
Change-Id: I0af72c436c2eca6741bfaa6e6570ce74f486c112 Reviewed-on: https://gerrit.libreoffice.org/20996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-12-24Fix tdf#32062: Math overwrites selected area when click on elementMarcos Paulo de Souza
Change-Id: I42ce83d1647d054419dbf664dfbfb2bc1cd01338 Reviewed-on: https://gerrit.libreoffice.org/20729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-12-23starmath: Avoid warning C4819Takeshi Abe
Change-Id: I051b2058e7c7f0424faf49f027330b1bbc93c2d9 Reviewed-on: https://gerrit.libreoffice.org/20869 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-23starmath: Manage SmEditAccessible's pTextHelper via std::unique_ptrTakeshi Abe
Change-Id: Iefd4314823efec28a8497b5a993fdd01ed12811e Reviewed-on: https://gerrit.libreoffice.org/20849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-23starmath: Assert that a parent always finds its childTakeshi Abe
Change-Id: I6cb75e0d62141dba2809aaec62761cedd8c3257a Reviewed-on: https://gerrit.libreoffice.org/20733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-22Indentation fixesMiklos Vajna
Change-Id: Idcb2b7e01a84d49c3b0cf53f6d53265111e68fdd
2015-12-21loplugin:unusedfields in sfx2,slideshow,starmath,stocNoel Grandin
Change-Id: If3622b23c45dd3a2a4e9869452142d1f6b47919e
2015-12-17This probably should be a referenceStephan Bergmann
...ever since SmXMLContext_Helper was introduced in a0c8015b88b16a4192000bd841eeff594dae9c65 "#81141# MathML->StarMath editable text display" Change-Id: Ida4a4022159138a49c7c94ccb0ed90a8a149b796
2015-12-17Remove unused ToolPanel (aka TaskPane)Samuel Mehrbrodt
Superseded by the Sidebar Change-Id: I54970d71cd9d42de4f47b223e50dd9474b40632a Reviewed-on: https://gerrit.libreoffice.org/20724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-17starmath: Drop const modifier of SmNode::Arrange's 1st argumentTakeshi Abe
as well as SmNode::AdaptToX / AdaptToY's. It was pointless because the client code in the functions always cast it off. Change-Id: I00c690bd98a566fb167708216d766a2894de669f Reviewed-on: https://gerrit.libreoffice.org/20710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-16assert that no ODF import happens without a BaseURLMichael Stahl
Change-Id: I4520a9d0350349cb083ed627a19264a3a97e090f
2015-12-10starmath: SmElementPointer is not shared actuallyTakeshi Abe
... rather, it's owned by maElementList. So, use just std::unique_ptr<SmElement> instead. Change-Id: Id18466083535677e0f7d07f8c523b433c5e2a9ec Reviewed-on: https://gerrit.libreoffice.org/20490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-10starmath: Prefix members of SmDrawingVisitorTakeshi Abe
Change-Id: Ia7efb3db2d1e76aad8873cf5822107b4666249de Reviewed-on: https://gerrit.libreoffice.org/20281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-10Drop unused typedefTakeshi Abe
Change-Id: I2bc18d48ebf4401d9af576fb1b98b69ff44ab334 Reviewed-on: https://gerrit.libreoffice.org/20485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-09starmath: Pass by const referenceTakeshi Abe
Change-Id: I703bedf5bcf2f2ea3b54eb0fc3a641ff246f4568 Reviewed-on: https://gerrit.libreoffice.org/20486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-08consolidate MSO format ClassID magic numbers in msfilter/classids.hxxMichael Stahl
Change-Id: I673eeaa4168f769cb002995c43d986ee5f2030b2
2015-12-01Fix typo in commentTakeshi Abe
Change-Id: I62c80cb0aa25374b41dcfde2ff6e03bd3c465bf5
2015-11-28Remove unused codeNicola Povoleri
Found by scanbuild. Change-Id: Ie46c056327747bbcb3a9eb0890cf74be7179ea24 Reviewed-on: https://gerrit.libreoffice.org/20257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2015-11-27starmath: Kill unnecessary castTakeshi Abe
Change-Id: I714c11941cfed207f10a5048a14b4cf72b4f255c Reviewed-on: https://gerrit.libreoffice.org/20222 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-26starmath: Prefix members of SmCaretDrawingVisitorTakeshi Abe
Change-Id: I9d033a67f6073f3da368f8241ac48c7d391b89c9 Reviewed-on: https://gerrit.libreoffice.org/20080 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-23starmath: Prefix members of SmCaretPos2LineVisitorTakeshi Abe
Change-Id: I277a66d32af51af7e28fd424dedd7980619e9d6e Reviewed-on: https://gerrit.libreoffice.org/20104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-22cppcheck: redundantAssignmentTakeshi Abe
Change-Id: Iad347c2575cdbd6ee117461ea89f16234ecdd49e
2015-11-20Remove last redundant toolbar:style propertiesSamuel Mehrbrodt
Change-Id: I42fa834464fd4cd7f0c1f11e310c1145fb1f071b
2015-11-20starmath: Use std::unique_ptr for exception safetyTakeshi Abe
Change-Id: Idc71dc410000b88463440dd18f41ff945b7616d7
2015-11-19Remove redundant toolbar:style attributesSamuel Mehrbrodt
These have been defined in the widgets Change-Id: If46a6862872286a454804846128bd8658f60af9b
2015-11-17Toolbar: Remove empty attributesSamuel Mehrbrodt
Change-Id: Id78cae55eb89520bd87713f9ea6c009c922f2870
2015-11-17Add SvStream::ReadUtf16 (don't assume sal_Unicode is unsigned short)Stephan Bergmann
Change-Id: I74f34e3389582617fa83f8f4a3d6867cf87189e1
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10starmath: Assert FindIndex()'s preconditionTakeshi Abe
by using std::assert rather thatn DBG_ASSERT. Change-Id: I8fca2b82f8d86a843c024556a0a29c7848b1e602 Reviewed-on: https://gerrit.libreoffice.org/19294 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10tdf#43090: Add option to disable auto close bracketsMarcos Paulo de Souza
As many users asked, now there is a checkbox inside Tools->Math called "Auto close brackets, parentheses and braces". This option is enabled by default, but can be turned off now. Change-Id: I6f96201c0720fb62fc2dce99222f97194e930fbe Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/19750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Ife1eef04d905f12308b64b971176c2f045a1b268