summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2017-12-28ofz#4765: Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: Ic8a4fd6cc62c7257f714e2ce2f155f60aa04aa2f Reviewed-on: https://gerrit.libreoffice.org/47157 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-28ofz#4733: align size typesCaolán McNamara
Change-Id: I43d136b131ba43401871a6afa455386f050d6c1e
2017-12-24coverity#1426873 Unintended sign extensionCaolán McNamara
and a bunch of others Change-Id: I110545b74bfc71b17e2e10edc95bc4bb5aa5651c Reviewed-on: https://gerrit.libreoffice.org/46957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-22Revert "unused SID command in starmath"Noel Grandin
This reverts commit b9c6f2de8bdcdcb95fb4f0457ee2fd0e1c42eb5b. Change-Id: Ice33baa738c025de72ceb11cf6746e017fb27484 Reviewed-on: https://gerrit.libreoffice.org/46964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-22tdf#42949 Fix some Include What You Use warningsMiklos Vajna
Change-Id: I30121764303579a7cb4ded0f0f48cc1f8fff6c33 Reviewed-on: https://gerrit.libreoffice.org/46946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-21unused SID command in starmathNoel Grandin
Change-Id: I08c09814a6a29286342fd7dc6a30ca0b6395463e Reviewed-on: https://gerrit.libreoffice.org/46909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21ofz#4703 Direct-leakCaolán McNamara
Change-Id: I5f3385d87aa5a48a8df3b6774dd1166cec60ebf8 Reviewed-on: https://gerrit.libreoffice.org/46893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19ofz: recognize invalid and negative fractionsCaolán McNamara
Change-Id: Ie00a608a60a35bf333d63be54f21085ecf44347b Reviewed-on: https://gerrit.libreoffice.org/46725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17ofz#4677 Indirect-leakCaolán McNamara
Change-Id: Ifffcd229db10de933f34367f3b283227634a358a Reviewed-on: https://gerrit.libreoffice.org/46640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15ofz#4649 don't care about exceptions for testingCaolán McNamara
Change-Id: I955460276c3bf98457eff6bc9503edd238a5650c Reviewed-on: https://gerrit.libreoffice.org/46506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15ofz#4643 Direct-leakCaolán McNamara
Change-Id: Ie4fff1a113916c7a3344959cfb4ee14c3fda2073 Reviewed-on: https://gerrit.libreoffice.org/46512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-14Related: tdf#114434 Enable ExtLeading by default for starmath edit windowCaolán McNamara
Change-Id: Icfeed667ce23b4b2ecac2c3ff67e95b4e2714442 Reviewed-on: https://gerrit.libreoffice.org/46410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-14ofz#4641 fix leaks with exceptionsCaolán McNamara
Change-Id: I5326240fe79a5752e19d4be3032c5ced70845437 Reviewed-on: https://gerrit.libreoffice.org/46459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-14more leaks with exceptionsCaolán McNamara
Change-Id: I9ace65832d4f8b9a531fddb45a6cea4ad83153ea Reviewed-on: https://gerrit.libreoffice.org/46464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-14No need to keep these whitelisted functions decorated with SAL_CALLStephan Bergmann
The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13ofz: fix leaks by exceptionsCaolán McNamara
Change-Id: Iad0987e9935ff02c80fea9dd7ebd4fdbe9fe2a9c Reviewed-on: https://gerrit.libreoffice.org/46317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-11ofz#4594 Integer-overflowCaolán McNamara
Change-Id: I6d73f514536e5b3e69573e24fd8b9f4b84e315c5 Reviewed-on: https://gerrit.libreoffice.org/46248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10ofz#4578 Integer-overflowCaolán McNamara
Change-Id: I2fcd530b3217c72385301b8f3456557c8c8cec13 Reviewed-on: https://gerrit.libreoffice.org/46183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-10ofz#4571 more Direct-leaksCaolán McNamara
Change-Id: If845238c3c107a9edc95dc3663bf4c178e65ebc7 Reviewed-on: https://gerrit.libreoffice.org/46180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-10ofz#4570 depth protect mathtype parsingCaolán McNamara
Change-Id: I1d8ca1704c057e154aa1d3aa57d722c24609cc48 Reviewed-on: https://gerrit.libreoffice.org/46181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-09tdf#113715 Fix .uno: names appearing in the customization dialogMaxim Monastirsky
Change-Id: Ia4a4231acf2f15ebf58f2acd02b7fc0ab5a88072 Reviewed-on: https://gerrit.libreoffice.org/46062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06ofz: reset sPush and sMainTerm once 'popped'Caolán McNamara
Change-Id: Ib63dd132cb2055b76492f5d53e45c2a86dd8a131 Reviewed-on: https://gerrit.libreoffice.org/45940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06ofz#4539 depth protect mathtype parserCaolán McNamara
Change-Id: I46e12f52d56e7802b676309207904b4d1894d236 Reviewed-on: https://gerrit.libreoffice.org/45928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06ofz: oom, variation 0 and 1 have one argumentCaolán McNamara
while variation 2 has two arguments Change-Id: Ia2a9bd5e33b589b6e002da78d1a5b45d703565ef Reviewed-on: https://gerrit.libreoffice.org/45926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06ofz: tmRoot variation 1 has two argumentsCaolán McNamara
Change-Id: I75ad9bcbc35ee2a0b9b7941cadc9b4bee79fb6c0 Reviewed-on: https://gerrit.libreoffice.org/45905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06ofz: avoid oom, tmLDIV has only two slotsCaolán McNamara
Change-Id: I6df2ec0790e94008eba6a7d97256440db5a26ac7 Reviewed-on: https://gerrit.libreoffice.org/45870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05ofz#4533 max 10 digits after decimal pointCaolán McNamara
Change-Id: I85e88269ce9148d1d9deca0b22dd8e8d2129d1b3 Reviewed-on: https://gerrit.libreoffice.org/45898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05extend enum with missing entries and use those insteadCaolán McNamara
of raw numbers Change-Id: I5a10716fd30a469d25e50a3dea6e9dd50602a457 Reviewed-on: https://gerrit.libreoffice.org/45871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05ofz#4531 Bad-castCaolán McNamara
Change-Id: I152c2e7fa09fc637b176482de9718cf03880c23e Reviewed-on: https://gerrit.libreoffice.org/45875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05ofz: infinite loopCaolán McNamara
Change-Id: Ie2148fd0048c6894e1b317dd2a4f2533ff2e1814 Reviewed-on: https://gerrit.libreoffice.org/45827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-04ofz: allow std::out_of_rangeCaolán McNamara
Change-Id: I4d63214e3691e56816d66162660c243a7454e114
2017-12-03survive without config for fuzzingCaolán McNamara
Change-Id: I7fd64d984c7796c5260ec94c50b158278f55763d
2017-12-03Add mathtype to fftesterCaolán McNamara
Change-Id: If082fc85d943c5b2537800456dcebbce3cb10791 Reviewed-on: https://gerrit.libreoffice.org/45730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-03SotStorageStream->SvStreamCaolán McNamara
Change-Id: Id9b74f7c0dc2c688c1489960ba71a8c7c5675dba Reviewed-on: https://gerrit.libreoffice.org/45728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-03let mathtype import take a SvStream of the contentsCaolán McNamara
Change-Id: I3c02dbee53554aa644b78f8a425b6a4333f2b95d Reviewed-on: https://gerrit.libreoffice.org/45729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02try to hide the evidenceCaolán McNamara
of my involvement with starmath Change-Id: I072d1c6cee1e20a70afac43022658b6878028f18
2017-12-02ofz: fix leakCaolán McNamara
null out the transferred one and delete the remainder Change-Id: Iacf2ab46c76234ea558588114e1bcdea370577d0 Reviewed-on: https://gerrit.libreoffice.org/45716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02ofz: mem leakCaolán McNamara
Change-Id: I4dc4ff6b2c4bdbcc2c705651a85886441ad90e64 Reviewed-on: https://gerrit.libreoffice.org/45692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30xmloff: turn SvXMLImportContext into a no-op base classMichael Stahl
Fix the non-obvious and potentially dangerous recursion that is implicit in xmloff's context code. SvXMLImportContext::CreateChildContext() now always creates a SvXMLImportContext, does not delegate to SvXMLImport. Rename CreateContext to CreateDocumentContext, to make its purpose of creating only the top-level context more obvious. With the previous changes to CreateContext overrides in sw, reportdesign and dbaccess, this hopefully shouldn't break anything. Change-Id: I9e147bf6297bbac9e8470454881da73f6e39db0a
2017-11-30add mml support to fftesterCaolán McNamara
Change-Id: Ie0c3dd5eddb274cf04b335af6fdcb32b3445d02c
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22tdf#112689 Replace chained O(U)StringBuffer::append with operator+qzheng
Change OUStringBuffer::append() to operator+. Change-Id: I13232cb69b1d62acfcf15d5ba5a2d72e5ab5d253 Reviewed-on: https://gerrit.libreoffice.org/44703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22RTF filter: drop now redundant astyle.optionsMiklos Vajna
I (tried to) keep the RTF filter style consistent locally with astyle in the past, but now that's redundant when we have an enforcing clang-format mechanism in place. So drop the astyle config and switch to clang-format in the RTF filter case. To minimize backport pain, do this shortly before the libreoffice-6-0 branch-off. Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>