summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2017-09-18valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x4C3535E: strstr (vg_replace_strmem.c:1623) by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (smdetect.cxx:102) by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038) Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d Reviewed-on: https://gerrit.libreoffice.org/42381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 64aa36e8b999ea4dcad69904da941705effad618) Reviewed-on: https://gerrit.libreoffice.org/42387 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 256a405d4b1feeafd8a09e98bce9fb0c9125ee3d)
2017-07-31tdf#109304: Seems infobar child window wasn't registered in MathKatarina Behrens
thus no signature status infobar appeared (I wonder if read-only bar ever worked too) Change-Id: I8829b2b6a17fb8d38e3ea79b87d544e3fb29f1c1 Reviewed-on: https://gerrit.libreoffice.org/40377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit a542fe8d38811dff152b69796380e1feec7daa28) Reviewed-on: https://gerrit.libreoffice.org/40387 (cherry picked from commit ef4f47e27477f32f022f3d5f93475a58dc06f5e1)
2017-05-07tdf#107644: Crash on inserting formulaJulien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=133085 Accessibility related Change-Id: I87063e50a59b06f4f5a974764de9aa34e111b4fb Reviewed-on: https://gerrit.libreoffice.org/37315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 3d4938d2d8dc18c7b741efe90686f55f524fcfe2) Reviewed-on: https://gerrit.libreoffice.org/37337 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2e20df6eb9fe206b89d5eecbf88eea54d0719268)
2017-05-07Collabora Office: remove Safe Mode from menus and Windows start menuAndras Timar
Change-Id: I9eaf6ef76597be6bc35462308f1cee61cb9bae5a
2017-02-24tdf#106116 "Previous Marker" changes selection only when neededTakeshi Abe
This fixes a hang caused by repeated Shift+F4. Although it seems a regression from 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8, the original code of SmEditWindow::SelPrevMark() had been doomed due to conditional loop depending on obscure signed/unsigned conversion. Change-Id: I61f630eec44b285dc1f1c27097acde4b48ed2991 Reviewed-on: https://gerrit.libreoffice.org/34503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 3efdd925e0ae1c080fbef3f1f79865eb6e172c68) Reviewed-on: https://gerrit.libreoffice.org/34504 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit eac1221ff124186887b23a2f7e7b57038bd08a43)
2016-12-14tdf#91767 Read SfxItemSet before disposing its AbstractSvxZoomDialogTakeshi Abe
Change-Id: I5dc6a1b1fa42a4fd76af398c2fb56461574900ee Reviewed-on: https://gerrit.libreoffice.org/31980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 77eac365c179e1a1cad3e0d8ebe3fe5bafa65720) Reviewed-on: https://gerrit.libreoffice.org/32000
2016-11-30ScTabViewShell::InnerResizePixel must not mark document as modified...Stephan Bergmann
...when merely toggling the edit mode of a Calc document embedded in another document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet"). Interestingly, none of the other document kinds seem to have this problem. (Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange information down there. Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe (cherry picked from commit 424d17e62e0d670aa79a890f85bb98c19169f9f5) Reviewed-on: https://gerrit.libreoffice.org/31428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-28starmath: Separate color name and operand by spaceTakeshi Abe
Otherwise, errors happen at MathML import. Change-Id: I17037b430710ea4d26340e7ce13c7972a76f614f Reviewed-on: https://gerrit.libreoffice.org/31249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-23starmath: Prefix members of SmNodeMatrixTakeshi Abe
Change-Id: I76c7e34878b9d2bc74d2499cf65448f0dd3a17b3 Reviewed-on: https://gerrit.libreoffice.org/31034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-21tdf#79645 Add line spacing only between rows of SmMatrixNodeTakeshi Abe
Change-Id: Icb785aff47de434fd8a99d1841dcbe4464df039f Reviewed-on: https://gerrit.libreoffice.org/31007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-19tdf#103500 Import stretchy integral symbol from MathMLTakeshi Abe
as "intd". Change-Id: Ic8a4feef7a3a19c8ed5bca2f09f80901e2b6d343 Reviewed-on: https://gerrit.libreoffice.org/30953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-18includes should be at the top of the fileNoel Grandin
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18starmath: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I49bddc1e51550c1696a1e93ce22e6b85bb663cd6 Reviewed-on: https://gerrit.libreoffice.org/30949 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18tdf#84650 Fix X-coordinate of SmMatrixNode's elementsTakeshi Abe
which are aligned to left or right against the column. Change-Id: Ie2b6944bc0dddb0e1589842472298f787fabf596 Reviewed-on: https://gerrit.libreoffice.org/30929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-16tdf#101472 Prompt repaint of Elements window when mouse leavesTakeshi Abe
This also reduces some cycles in SmElementsControl::MouseMove(). Change-Id: I1dd5f9cd37e4a78010ebb719b4726f9b061d8ff2 Reviewed-on: https://gerrit.libreoffice.org/30897 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15tdf#76296 Import MathML's <mspace>Takeshi Abe
as possibly multiple "~" and/or "`" by honoring its width attribute. Change-Id: I17e361c3f8f5d061c856b72266332369497d16b9 Reviewed-on: https://gerrit.libreoffice.org/30809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-14tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I29a8ca55d1d9f319cd57e5e30fa7e58e4d91dc5c Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30810 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-12starmath: Prefix member of SmBlankNodeTakeshi Abe
Change-Id: I20b9fa14d42549a3c5be8a7d4f52c85fcef52cf5
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09tdf#44839 Add an "Evaluated At" command in "Brackets" sectionTakeshi Abe
of Elements window. Change-Id: I221dacad297c7713f9cdde6d8ffdecf3caa2c3bd Reviewed-on: https://gerrit.libreoffice.org/30714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-05tdf#102008 Drop whitespace between "fact" and braceTakeshi Abe
for consistency with "abs{<?>}", "sqrt{<?>}", etc. Change-Id: I53106d6daf99f72f1a064bc6f5e0fe4dab55cc02 Reviewed-on: https://gerrit.libreoffice.org/30556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-05tdf#102007 Surround widebslash's placeholders with bracesTakeshi Abe
like wideslash's. Change-Id: Icddd563ee64510c0df8bfa8d4a5274a00f60162a Reviewed-on: https://gerrit.libreoffice.org/30555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-03Use a single method of converting between points and 100th mm in starmathStephan Bergmann
The SmFormat ctor (starmath/source/format.cxx) uses SmPtsTo100th_mm(12) to initialize aBaseSize, resulting in a height of 422 100th mm. Getting that value (and writing it out to a file) through SmModel::_getPropertyValues mapped back to 12 point, but in turn setting that value (as read from a file) through SmModel::_setPropertyValues resulted in a height of 423 100th mm. That, in turn, caused SmDocShell::GetSize (starmath/source/document.cxx) to compute diverging sizes, so e.g. clicking into an OLE-embedded formula in a Writer document caused the Writer document to be marked as modified (as the embedded formula's size had changed). Change-Id: Ia90654aeaaf779690997b5c3bb868b193eaf46c6
2016-11-03starmath: Remove unnecessary overridingTakeshi Abe
Change-Id: If64c3a1dbb27e85e2562cca78b608250b7e90c6d Reviewed-on: https://gerrit.libreoffice.org/30480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-27loplugin:expandablemethods in sot..starmathNoel Grandin
Change-Id: I5b718bbda9ceca5bbfd1e6482ebd215e15884956 Reviewed-on: https://gerrit.libreoffice.org/30318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26svl: the compiler can generate the same SfxGrabBagItem copy ctor itselfMiklos Vajna
Change-Id: I54f94e8ec710ca117ecdf33ebe97a0e5f07c59ec Reviewed-on: https://gerrit.libreoffice.org/30283 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-24tdf#103452: add missing xPopupMenu.disposeAndClear();Julien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=128226 Change-Id: If6641531b96f33b2864f69bd4195c92548fce148 Reviewed-on: https://gerrit.libreoffice.org/30234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-24remove unused SfxListener subclassingNoel Grandin
where the Notify method is doing nothing Change-Id: I834aa40a9bcb0dd8d7335a5688acc5da6f40b0a2
2016-10-20loplugin:expandablemethodds in sfx2..starmathNoel Grandin
Change-Id: Ia4c411f5a9a68c2f344188ce6b6bc1815c89f993 Reviewed-on: https://gerrit.libreoffice.org/30055 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot
Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-19starmath: clean up redundant virtual keywords in unofilterMiklos Vajna
Change-Id: I97af23d22c0b4eb416172e9ebea9544541621cb0 Reviewed-on: https://gerrit.libreoffice.org/30031 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-18tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek
Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-10-13flatten RID_LOCALIZED_NAMES by a levelCaolán McNamara
Change-Id: I5e6fe76d01b82ff6d9f7fde06f4349d54493bf1b
2016-10-10safemode: Add uno command and menu entrySamuel Mehrbrodt
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-07starmath: Simplify code with std::unique_ptrTakeshi Abe
Change-Id: I2f6f993b92ae7f2f89b2d9d6c89b51d827226a3d Reviewed-on: https://gerrit.libreoffice.org/29554 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-05loplugin:unnecessaryoverride in sd/starmathNoel Grandin
Change-Id: I5a9d776af761fcaed7a6961e151feb38fc6353ed
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05starmath: Assert the precondition for OUString#replaceAt()Takeshi Abe
Change-Id: I56ee95f9196eb2b2b3cc71203251b98ff1dba951 Reviewed-on: https://gerrit.libreoffice.org/29464 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-03starmath: Add comments on indexingTakeshi Abe
Change-Id: Ic87d04f65f8272832c8742f99821876cc28bb514
2016-10-02starmath: Prefix members of SmParserTakeshi Abe
Change-Id: Ib39bf2a9b8c37d9f2ac4ed3db602c3b0a82a506b Reviewed-on: https://gerrit.libreoffice.org/29397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-30tdf#97164 Add text for visualition of percent symbol.Gulsah Kose
Change-Id: I31dc1a7a4ed0bc0e760e10c1a2ff52660a258e12 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29299 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>