summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2016-04-04loplugin:constantparam in svtoolsNoel Grandin
Change-Id: Iceb1b57997e0369946150ef0764b71da59a6b7a6 Reviewed-on: https://gerrit.libreoffice.org/23725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04Use std::size_tMiklos Vajna
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-01starmath: Reduce scope of variablesTakeshi Abe
Change-Id: I6f69752177ee5e3044aa99c1bbe55fc4f8c85c24 Reviewed-on: https://gerrit.libreoffice.org/23703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-29Avoid reserved identifiersStephan Bergmann
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-24starmath: Drop inline wrapper functionsTakeshi Abe
Use corresponding static functions instead. Change-Id: I362744878d9c88de858cb957106c7a70a45122bb Reviewed-on: https://gerrit.libreoffice.org/23369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-24starmath: Drop unnecessary check of loop invariantTakeshi Abe
Change-Id: I7f5f2b7e9fda1d788e8f92ffda619c46523a91d5 Reviewed-on: https://gerrit.libreoffice.org/23485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-24starmath: nCount == aVector.size()Takeshi Abe
Change-Id: I9ea654292718ebd9f1769ca8accf4e39def7f959 Reviewed-on: https://gerrit.libreoffice.org/23460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-23loplugin:constantparam in starmathNoel Grandin
Change-Id: I7a1b83ec51565f56b07ae77177e064c04f703d5f
2016-03-22starmath: Use initialization list for some ctorsTakeshi Abe
Change-Id: I51b5df153574a2dfba96106a6268ccdf9715934d Reviewed-on: https://gerrit.libreoffice.org/23423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-21Make aDelimiterTable a local varStephan Bergmann
Change-Id: Ie551a52310d4723643433973bf7ecf024068e4d5
2016-03-21loplugin:staticmethodsStephan Bergmann
Change-Id: Id40b00234f78afc238d6b3af1283e0429587ee49
2016-03-21loplugin:staticcallStephan Bergmann
Change-Id: I2ff2d5a2a1423b39f960f9bdc8893cf2bb69b88b
2016-03-21tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed all the OSL_DEBUG_LEVEL > 1 conditionals and also made SAL_WARN open to production code which was earlier under OSL_DEBUG_LEVEL > 0 Change-Id: Ibe71defed9a7191ec8e4a934e746ef0f3ebd8b3a Reviewed-on: https://gerrit.libreoffice.org/23065 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-19starmath: Replace lt_SmSymPtr with a lambdaTakeshi Abe
... as std::binary_function is deprecated in C++11. Change-Id: Idf73bcd832fa80addf46e3545de3b6787d3b3de6 Reviewed-on: https://gerrit.libreoffice.org/23370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-18loplugin:constantfunction in editengNoel Grandin
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in sfx2Noel Grandin
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15starmath: odd number of columns is fineTakeshi Abe
This can save horizontal spaces in every row but last. Change-Id: I092d24f311517cd9d31e3f72bd51f5b1040d43f3 Reviewed-on: https://gerrit.libreoffice.org/23236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-11Resolves tdf#88485: Allow to select rightmost symbols in the dialogTakeshi Abe
by adjusting target area with proper offsets. Change-Id: I66100c898354909623991c3af3e78287d6f5a9a0 Reviewed-on: https://gerrit.libreoffice.org/23147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-11loplugin:redundantcastTor Lillqvist
Change-Id: I08d68a1ff4e798d1cace56fa18c7f70a48eb6231
2016-03-11starmath: Make examples of exponential function consistentTakeshi Abe
... by prefixing "func" so that it is the same as Exponential Function in Functions of the Elements window (RID_EX in commands.src). Change-Id: I823c345a0f376f0679930aa7975bdeb03575cd43 Reviewed-on: https://gerrit.libreoffice.org/22389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10starmath: no need to override SmFontPickList::Update/RemoveTakeshi Abe
Just use them instead. Change-Id: Ic82d2c3edc1d0ccd2551f8cf208f108168148786 Reviewed-on: https://gerrit.libreoffice.org/23111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09starmath: Drop SmNode::FindIndexTakeshi Abe
Its sole usage can be replaced with SmNode::IndexOfSubNode. Change-Id: Icfd4a3fe846b585c5fa3f47e0768729aba66d73e Reviewed-on: https://gerrit.libreoffice.org/23064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09toolbox.src in starmath is all unused resourcesCaolán McNamara
since commit 3dfe2fc394ca1e168e800ffcc3ac0f69b4eeb173 Author: Julien Nabet <serval2412@yahoo.fr> Date: Sat May 2 19:03:21 2015 +0200 tdf#68871: Remove the old Elements panel from Math Change-Id: I61ceb2e3b8dfb0a402db061cf08930f2cf2c7d32
2016-03-08starmath: Use assert for impossible null-dereferenceTakeshi Abe
Change-Id: I3a0e78985470f210dd093dce3e87671980e647f4 Reviewed-on: https://gerrit.libreoffice.org/23016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07drop now-needless depsDavid Tardon
Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e
2016-03-07remove remaining uses of gb_SrsTemplateTarget_get_targetDavid Tardon
Change-Id: I5ddf0ba5fc289a124b39b9c14b7f5fdd3d7b54a4
2016-03-07expand src templatesDavid Tardon
Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352
2016-03-07these ResIds are used solely for their number by nowCaolán McNamara
so cut out the middle-man ResId Change-Id: Ic83db355cc1a0c7dc70958bca79b466baadaedd0
2016-03-07starmath: Make SmNode abstract and noncopyableTakeshi Abe
... and remove unused SmStructureNode's copy ctor/assignment operator. This seems desirable according to the old comment in SmNode::Accept(). Change-Id: Ifb51c64ca784f1295374d31cc210cbe3e45aa2f8 Reviewed-on: https://gerrit.libreoffice.org/22801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-03-04tdf#96505 Remove long integer literal specifier when not neededAleksas Pantechovskis
Remove L from integer literals if it does not produce warnings and does not change semantics Change-Id: I9573a47d3e3401993a1f0fbcf7df4be20f9e6eba Reviewed-on: https://gerrit.libreoffice.org/22867 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03starmath: Drop ENABLE_DEBUG_DUMPASDOT featureTakeshi Abe
The feature for debugging seems unused so long that defining ENABLE_DEBUG_DUMPASDOT breaks the build but no one complains. So let's ditch it. Change-Id: I0b472cd1acbcfd0c2550c3bd36661c91bc2e2986 Reviewed-on: https://gerrit.libreoffice.org/22608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-03-01loplugin:unuseddefaultparam in starmathNoel Grandin
Change-Id: I740d931c0236c1a4d40013b458f249692695d6e5
2016-02-29starmath: Use member initializer list for SmRectTakeshi Abe
Change-Id: Iac3df1fe7d189c2e78e585b9ac3642b05b0f1472 Reviewed-on: https://gerrit.libreoffice.org/22761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-27tdf#98088: prevent access to invalid sub nodeOliver Specht
Change-Id: I73bd77682bfb60474ba18ca85bc5d008c70a7f97 Reviewed-on: https://gerrit.libreoffice.org/22715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-26starmath: Remove forgotten SmFormat's versionTakeshi Abe
Its last usage was gone with 26bdb10a52f441b4026d651ec50189b88391319e. Change-Id: I3a58a5596eaa930e9d7034b87fe05cbe8a902c41 Reviewed-on: https://gerrit.libreoffice.org/22690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-26starmath: Drop unused variable declarationTakeshi Abe
Change-Id: Ibc2a5930e516628cfe5fb7986c4ba814533dbf25 Reviewed-on: https://gerrit.libreoffice.org/22692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-19starmath: Avoid C-style castTakeshi Abe
Change-Id: I96efea344dc4ec5c1f20060bb51ea5e853113c9c Reviewed-on: https://gerrit.libreoffice.org/22497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-18move from boost::signal to typed LinkCaolán McNamara
it doesn't really gain us much to have a handful of boost::signal use in a sea of Links This also fixes a regression in commit 051b29e1025253f35f87a04e297760aa8b40611f Author: Luboš Luňák <l.lunak@collabora.com> Date: Sun Sep 14 15:45:02 2014 +0200 convert Edit autocomplete Hdl to boost signals2 where the conversion was... - if ( maAutocompleteHdl.IsSet() ) + if ( autocompleteSignal.empty() ) instead of the correct + if ( !autocompleteSignal.empty() ) Change-Id: I27270d94c782485c0a7e929bc4980af4527fe82b
2016-02-18starmath: Avoid C-style castTakeshi Abe
Change-Id: Id54997718a61b1b5a488922f05374c559f1e4454 Reviewed-on: https://gerrit.libreoffice.org/22460 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-17starmath: Drop unused RID_COLORXTakeshi Abe
Change-Id: I99e66067deb314c48347e18ebb5942501de19d17 Reviewed-on: https://gerrit.libreoffice.org/22415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-16starmath: Convert RectCopyMBL to scoped enumTakeshi Abe
Change-Id: I44e4f3086f642adccdff8dcf82298e5f4e9cb282 Reviewed-on: https://gerrit.libreoffice.org/22305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-15starmath: Replace OSL_ENSURE with assertTakeshi Abe
These pointers must be non-null, or deferencing null can happen. Change-Id: I3ced1204abb70cf7c525ea9d50c6a3a295728ab5 Reviewed-on: https://gerrit.libreoffice.org/22365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-10tdf#53472 Integral Symbols too small for some integrandsmelikeyurtoglu
Change-Id: I1ab550821f0b254a7414246fd72f3882b7140c90 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/21482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08starmath: Convert RectVerAlign to scoped enumTakeshi Abe
Change-Id: I6c9a7e1527cf2083f567397eb41db7ae3437c25e Reviewed-on: https://gerrit.libreoffice.org/22141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-08starmath: Replace SAL_WARN_IF with assertTakeshi Abe
These assertions must hold, otherwise the following code would dereference null pointer. Change-Id: I2b3887aad7116a7ea5176630a015975b8fc087f9 Reviewed-on: https://gerrit.libreoffice.org/22140 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-08remove unused HelpText attribute from *.sdi filesNoel Grandin
Change-Id: I21bcf66c552cd38eaae1bdc85626aa9bd1782ebd