summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-24starmath: Fix missing call of AnnotationSelection() for SmCursor::CopyTakeshi Abe
... with unit tests of Copy/Cut/Paste. Change-Id: I74dd6f235b52ef2c1388ea0d15d32af0fb30b2c8 Reviewed-on: https://gerrit.libreoffice.org/25362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-23tdf#99984 render inferred mrow as group {}Regina Henschel
In case an element has no content, but has got an SmXMLRowContext, an empty group {} is inserted. The result is, that empty table cells are rendered without error, so that files, which use a mtable element to arrange things, no longer break on import. Change-Id: Iae158226e6478f2f9f397b8485044860ee8767c2 Reviewed-on: https://gerrit.libreoffice.org/25273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-23starmath: This should be an assert()Takeshi Abe
Change-Id: Ia8dd75512168fd0775a8019fc514627a7353b056 Reviewed-on: https://gerrit.libreoffice.org/25231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-21starmath: These functions are used in local onlyTakeshi Abe
Change-Id: I603be0a0890844019700f402ae79203ddc86c952 Reviewed-on: https://gerrit.libreoffice.org/25186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-19starmath: Assign the proper token to SmTableNodeTakeshi Abe
... for a similar motivation with b43b79648f4fbcd815092268d1b7a5af9e278f52. Change-Id: I9fc42fc8e34958295eeec5759c072c8259fc38b6 Reviewed-on: https://gerrit.libreoffice.org/25122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18starmath: Remove obsolete TG::DiscardedTakeshi Abe
which was originally TGDISCARDED until cc1a0ba927ad6f85103059aa8e6108017f436304, and its usage was gone with 9adcd261054a0e99ae032be5e7428e28a6663975. Change-Id: Idb01f30b7b140b17deead7c5a83128fa1f3bdf4c Reviewed-on: https://gerrit.libreoffice.org/25074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-18Convert ATTR_* to scoped enumTakeshi Abe
Change-Id: Icbf19ca281c260ba0795c7a8e5745d1e603ac8a5 Reviewed-on: https://gerrit.libreoffice.org/25050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-17convert TG constants to scoped enumNoel Grandin
Change-Id: Ide719e8bb0d5aacc8d5da18f385b6373c7e48184 Reviewed-on: https://gerrit.libreoffice.org/24973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-16tdf#98238, tdf#99591 reverted old commitJan Iversen
Revert "tdf#53472 Integral Symbols too small for some integrands" This reverts commit 746633bd0315939fd5e0b50c90692d356d2ed678. Revert on request from regina, since this commit caused 2 new bugs. The code of the reverted patch is kept in the file for further investigation, once it has been confirmed that it works. The file had 3 commits later, these are not affected by this commit Change-Id: I5b24a9b88ac909c83115e8c8a430dc768c9effd4 Reviewed-on: https://gerrit.libreoffice.org/24898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-16Avoid C-style castTakeshi Abe
Change-Id: I777920cb2e9dcc3f2b20f5a96c88bf48fcb94895 Reviewed-on: https://gerrit.libreoffice.org/25024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-14Fix bogus nGroup for SmMatrixNode's tokenTakeshi Abe
It was an obvious mistake because TRGROUP's type is SmTokenType. Change-Id: Ib3b932482c61bd9568aa579d94f742d0dd0b5462 Reviewed-on: https://gerrit.libreoffice.org/24948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-13Resolves: tdf#99556 if the num of arguments is not 1 infer a rawCaolán McNamara
not just if the num of arguments is > 1 Change-Id: If0cae16cc52685315708ac3b2b8456ede7c1a6ce
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13starmath: SmMatrixNode should have the node TMATRIXTakeshi Abe
... rather than the one after its closing brace. So far having an arbitrary node is OK for SmMatrixNode because existing code does not refer to it, but it is saner to keep relevant nodes in the syntax tree. Change-Id: Ia5412454c996eedde1545cd8a2f323eb95593eb9 Reviewed-on: https://gerrit.libreoffice.org/24909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-12Convert FLG_* to scoped enumTakeshi Abe
Change-Id: If767fff10a0bb28735578b4ec3dcf7b9e2d326a2 Reviewed-on: https://gerrit.libreoffice.org/24872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11starmath: Drop unused non-const variant of GetLeftMostTakeshi Abe
... resulting in one less const_cast. Change-Id: I3dad339f25524fc22e7a02b08ee7ec01b341e991 Reviewed-on: https://gerrit.libreoffice.org/24810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Simplify code with ForEachNonNullTakeshi Abe
Change-Id: Id149ecee4fa7737b529f3a3a19bb4bb9ed778dcd Reviewed-on: https://gerrit.libreoffice.org/24778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-09modernize loopsJochen Nitschke
use one style (reverse_iterators) for reverse loops and use range base loops if possible Change-Id: I231572bc5923e450d7a54bb88c7d8ef63d04f41d Reviewed-on: https://gerrit.libreoffice.org/24758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-08starmath: Drop useless last entry of aTokenTableTakeshi Abe
Change-Id: I3189c875cc8b2046f5a0353fb641a7d6ea9fdd9a Reviewed-on: https://gerrit.libreoffice.org/24692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03starmath: Avoid C-style castTakeshi Abe
Change-Id: If8fdb9def831ea9720c3cad1379be47aba7dec30 Reviewed-on: https://gerrit.libreoffice.org/24584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-02Fix typoTakeshi Abe
Change-Id: Ib8e891f3af7a9de87c54bc65be98d94a16545d71
2016-05-02Reduce scope of variablesTakeshi Abe
Change-Id: I0018a6601f48f32736d10fd1eab58e926d97f91b Reviewed-on: https://gerrit.libreoffice.org/24458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-28tdf#97087 Give comprehensible, unique names to idlesMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101 Reviewed-on: https://gerrit.libreoffice.org/24388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-27Resolves: tdf#88320 parsing fails with a subscript numberTakeshi Abe
... ending with comma and followed by non-space. Change-Id: Ia00c662e31940270690c64e1840417436565a6c7 Reviewed-on: https://gerrit.libreoffice.org/24260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-27starmath: Drop unnecessary castTakeshi Abe
Change-Id: Ia892100507de7365bcecfa0708f76931f84d797b Reviewed-on: https://gerrit.libreoffice.org/24389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22starmath: Simplify SmParser::DoTable()Takeshi Abe
yet doing the same. Change-Id: I2ebdcb96179830eb02af8ed12dd27c69a78ed276 Reviewed-on: https://gerrit.libreoffice.org/24240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-22starmath: Drop member variable set but not usedTakeshi Abe
Its usage was gone with 9adcd261054a0e99ae032be5e7428e28a6663975. Change-Id: Ibd322531365c2e0ccad85d553781611dfe96d54e Reviewed-on: https://gerrit.libreoffice.org/24277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-22starmath: Make coUserDefinedCharContFlags more readableTakeshi Abe
No bits changed because: ((KParseTokens::ANY_LETTER_OR_NUMBER | KParseTokens::IGNORE_LEADING_WS | KParseTokens::ASC_DOT) & ~KParseTokens::IGNORE_LEADING_WS) == KParseTokens::ANY_LETTER_OR_NUMBER | KParseTokens::ASC_DOT Change-Id: I1e00d0cdb07a1450f98655ec3cc8483e4d348b74 Reviewed-on: https://gerrit.libreoffice.org/24122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Iae070e04800fec430f630dad1cd4265c1717a59d
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15starmath: Fix bounds checkingTakeshi Abe
Change-Id: I6b7eae01838eaf8138f777c0a9e84a3ad9f97082 Reviewed-on: https://gerrit.libreoffice.org/24078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13Stop assigning null to intrusive_ptrTakeshi Abe
which added at f6d61562d41b8a49449d881da66a3d8fa519487f. But they seems unnecessay because, even without them, soon the intrusive_ptr goes out of scope then its dtor decrements refcount. Change-Id: I6e35ecb7d5a0b5ccaef6ea9b7507300dcb589801 Reviewed-on: https://gerrit.libreoffice.org/24013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I31b50e58e3bce9448ae8de127171c0a1f25fa1af
2016-04-12starmath: Drop unused #includeTakeshi Abe
Change-Id: I3ca3f7732583111c8f49cc6fc71ba9fcada08f96 Reviewed-on: https://gerrit.libreoffice.org/23990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12clang-tidy performance-unnecessary-value-param in starmathNoel Grandin
Change-Id: Ic8d319dac1d18f548d47ac84e489c04412a38d1a
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-07starmath: Assert that SmAlignNode must have only one childTakeshi Abe
Change-Id: Ia59e453040b121c27a1326ee4bdc8a7ccaa4074d Reviewed-on: https://gerrit.libreoffice.org/23588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-06starmath: Drop unnecessary forward declarationTakeshi Abe
Change-Id: I0f8893f6aa34a9738aad1e1a96f779bc77672f68 Reviewed-on: https://gerrit.libreoffice.org/23848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-05loplugin:constantparam in editengNoel Grandin
Change-Id: If8342112e0657014266133954269b9396085a27d Reviewed-on: https://gerrit.libreoffice.org/23807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04loplugin:constantparam in svtoolsNoel Grandin
Change-Id: Iceb1b57997e0369946150ef0764b71da59a6b7a6 Reviewed-on: https://gerrit.libreoffice.org/23725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-06-28 06:02:29 +0000