Age | Commit message (Collapse) | Author |
|
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
|
|
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
|
|
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants
Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
|
|
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.
Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
|
|
- Remove includes from files where they are not needed.
- Update pch files
Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I652dc63cc0e8fb04d7c3115d66d60dabda60f0f4
|
|
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
|
|
and
coverity#1038320 Unintended sign extension
coverity#1038319 Unintended sign extension
coverity#1038318 Unintended sign extension
coverity#1038317 Unintended sign extension
coverity#1038316 Unintended sign extension
coverity#1038315 Unintended sign extension
coverity#1038314 Unintended sign extension
Change-Id: Ib8015baf8ffec48e1b2d6ce1e7ce284fb36303b0
|
|
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Description:
- If the equation ends with two dots(.) then file get crash.
- In SmParser::NextToken()
the file get crash because string index is out of bound.
Change-Id: I5f25814220d556d53c10d4ca33a38b4d0d451438
Reviewed-on: https://gerrit.libreoffice.org/9840
Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
|
|
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
|
|
Change-Id: I4f42040c7e12507365f12d09f80d3641b4d5ca02
|
|
Change-Id: Idaec46756ef22bcec1335c219fdc3ebf64c43fc3
|
|
Change-Id: I96e3054de033c550a54c8393c82d0efbe6f2e08d
|
|
Change-Id: I7639df64242e5b30f9857363b3be33d61bf28594
|
|
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
|
|
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)
Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
|
|
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)
Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
|
|
Change-Id: I6ccd4c2ab97237806652059d6ae2cd23a6dc1625
|
|
This required some changes to the framework:
* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
the exisiting unobootstrapprotector). CppunitTests that need VCL now need to
declare gb_CppunitTest_use_vcl.
* For things to work properly, the UNO component context needs to be disposed
from within DeInitVCL (cf. Desktop's Application::DeInit called from
DeInitVCL). The easiest solution was to introduce an
Application::setDeInitHook (where the hook is called from DeInitVCL)
specifically for vclbootstrapprotector to call.
* PythonTests don't (yet) call DeInitVCL; they still hook into
BootstrapFixture's original test_init functionality (to call InitVCL), and do
not make use of the vclbootstrapprotector.
Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
|
|
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
|
|
Change-Id: Ic11f6640b6c60feed06ee988796823aaada76739
|
|
Change-Id: I5316693452427ed76a7738b090de023b110caa40
|
|
Change-Id: I58dad585c5de24ebd06ce9bcc64e49e8973850bb
|
|
Change-Id: I9c57de1179d7db19f1fa2b104017dd379f854749
|
|
This fixes:
warn:rtl.string:14867:1:sal/rtl/strtmpl.cxx:1269: rtl_uString_newFromLiteral - Found char > 127
Change-Id: I1f868406501c83918fc3c06dd0b68eb1f6604f26
|
|
Change-Id: Ife149baf15d6f38a2a316e124b78bdb7e1b64967
|
|
BaseSize has to be set in 100th mm, otherwise the scalable
brackets are far too thin.
See starmath/source/cfgitem.cxx:
pFormat->SetBaseSize( Size(0, SmPtsTo100th_mm( nTmp16 )) );
nTmp16 is 12pt -> 422 100th mm (at least for me). Let's reuse that.
Change-Id: I69571ae002f790199ab423955b1635eda42096eb
|
|
Change-Id: I2255be738aa2230b4102030891026f1f9ad2c38f
|
|
Based on the patch on Bugzilla by
Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Change-Id: I215b83894f228b1cc8908f98858b85c8d5378ddb
|
|
Change-Id: I3b0e4ecd5def28c6b9f4639b8df16a2a0ea0008c
|
|
Change-Id: Iebae064986ad722d445c8d654e39e338e104f021
|
|
Change-Id: Ibfe57b366207550b0f3c0e9cb7e8da1078531742
|
|
Change-Id: I4ff6cdf0f7d48318a948865784c66f992fe52e3d
|
|
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I9e067659dea49683ceda9553b3d35254576079db
|
|
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
|
|
Change-Id: Ic39102eaa8f0f5f6ea58173103ca8c5dc5c55185
|
|
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
|
|
Change-Id: Iff4125e108df535d90afd940a9787eb8e011c9bd
|
|
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
|
|
Change-Id: Iae6dbc367f1ff9cbeb5329bd9b96489b2d4252ec
|
|
Change-Id: Ia5cf36b64841f2d465c922da40008a540cc6caf7
|
|
Change-Id: I6fec141e19de921128365da7cbd17e0a0bc0b9a9
|
|
Change-Id: I3f915ff949fa00357599e8cfc59c01c6eb04e9fd
|
|
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
|
|
Change-Id: I3dc6ed508992bc952f1cf34e6d9e26354895bc27
|
|
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
|