summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2021-05-09cid#1401328 silence Uncaught exceptionCaolán McNamara
Change-Id: I7cd29462586b1dfe6fb7268ec3225317c1d2d782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-08cid#1482285 silence Uncaught exceptionCaolán McNamara
Change-Id: I0550dadd2990cb0d93b51570b2cc3136afb50907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-08ref-count SfxItemPoolNoel Grandin
so we can remove SfxItemPoolUser, which is a right performance hog when we have large calc spreadsheets Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115247 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-07remove an intermediate layer of widgetsCaolán McNamara
Change-Id: I4fe23f87d997057a2cb061110c8e325c8322b95e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06release mouse before showing context menuCaolán McNamara
otherwise math loses focus due to the mouse release Change-Id: Ie50cfde6a9f13d87efba2f6ec4830b9730f6e938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06add SfxItemPoolDeleter utilityNoel Grandin
add use so we can hold the pool with std::unique_ptr Change-Id: I685fbc37c0ae145a5b48a66a88eab9fb29a0fc0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-06use Widget::get_clipboardCaolán McNamara
there's no different from GetSystemClipboard except potentially for the libreofficekit case where per-frame clipboards are possible Change-Id: I3173e39f81a03a7cbe114ebca6020d5ed36a659a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Iedb9586fcf34dc172b93f0a246b1c1e1c9033376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04tdf#141930 document set as unmodified if editengine didn't modify on keyeventCaolán McNamara
this appears to have always happened for cursor keys, and since commit 0154f04e8c64df937b793c73ac58d553637f324f Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Feb 24 14:32:21 2021 +0000 Resolves: rhbz#1931423 start update timer in IM events as well as keyevents also happens on Input Engine events which don't cause changes Change-Id: Ic5cdd9ef4f1bed1cc2b2c17fc847f196a9c6e23a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115055 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-03There's no longer a purpose to the math horizontal scrollbarCaolán McNamara
since... commit f89860807baaa901629ce2a814b7a6c994318fe5 Date: Sat Feb 13 16:43:01 2021 +0100 Resolves tdf#140221 auto-adjust Formula Editor width so remove that. And merge the starmath Resize logic into the baseclass, and emit EditViewScrollStateChange from there. The goal is that resizing the starmath window does not visually horizontally scroll content negatively outside the widget Change-Id: I1a79a0d5a194e8cfb0d2d2cb07b0b80172f1f66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115012 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-30drop DropTargetHelper from SmEditWindowCaolán McNamara
dnd into its child always worked while the inheritence from DropTargetHelper began in commit daf3e2909104fcb4c0a36d6e1fd6f44e1b61c980 Author: jp <jp@openoffice.org> Date: Thu Jul 5 09:58:51 2001 +0000 Changes for TFD636 but always returned DND_ACTION_NONE for the parent window Change-Id: Ida1ae0f8e68ba04452ed952c4eca3ac66f240132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29reuse SmEditWindow already present in SmCmdBoxWindow in testsCaolán McNamara
Change-Id: I48f15d584e15269336b289c8204588384f2f6998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27Correct some c/c++ licensesdante
The affected files where added from scratch in commit 565bbd2e46e57117eb401344689858c3d749dc5c. In consequence instead of the ASF license; the correct license is the pure MPLv2 found here: TEMPLATE.SOURCECODE.HEADER Change-Id: Ie2fa275a6a986fff026a5096a10f79ab3c6ea85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114670 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-23consume context menu eventCaolán McNamara
Change-Id: Ic7d819775f59b7303dea1a381a20ca3ea1ac8d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23cid#1477316 Uninitialized scalar fieldCaolán McNamara
Change-Id: I11ad5375e5fee35065bb855fb0db0b0c00d75fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23Related: tdf#140659 designate which widget to get default focusCaolán McNamara
Change-Id: I8c8200756a7120db9a9c946889a30f6c549fd617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23designate which widget to get default focusCaolán McNamara
Change-Id: Ie5968b80583f8c560b145463a60e2e86992fdb96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22Fix typosAndrea Gelmini
Change-Id: Id06dc8750b735ecdba26ac607394c6e7dee16db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114470 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Dante DM <dante19031999@gmail.com> Tested-by: Jenkins
2021-04-21Related: tdf#140659 on control get/lose focus call update custom a11yCaolán McNamara
Change-Id: Iab7df2c657da3386dc38db8a9d6427c60d8c1cc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21Related: tdf#140659 off by one indexes because scrollbar is now outsideCaolán McNamara
and not inside the control so it doesn't need to be accounted for as a child Change-Id: I77b55ec8d9b515850817417664df8944b4e44204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21weld SmGraphicWindowCaolán McNamara
Change-Id: Ie163640d6453f30d1cebdaf75ecd41374b2b9ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21cid#1476301 Dereference null return valueCaolán McNamara
Change-Id: I7dff59f18fdf08389e7f279001627da4e5e3baeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21simplify stripStart/End pairs into a single strip callNoel Grandin
Change-Id: I32b1b7d944a4ec49d7daa5b8fa9371b059380062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114393 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-21c-n-p of a different widgets accessibility descriptionCaolán McNamara
Change-Id: Ic6eab23ebba85ee9f5be7e16c7f794131ef819c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21Add mathml structuresdante
Change-Id: I8324456b9a6775842f39e984c569c068381dc952 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112593 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-20SID_GAPHIC_SM->SID_GRAPHIC_SMCaolán McNamara
Change-Id: Ie5446fc349778ad6dc50ac5f622ddb45ee18eefa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19remove apparently no longer necessary scrollbar hide/show hackCaolán McNamara
before using weldeditview a revert of: commit 67311738157bced7b49e94b24845091995edb142 Date: Thu Nov 7 02:53:09 2013 -0200 fdo#65588 - Elements Dock: Scrollbar moves into input window and inserting multiple copies of the Taylor series rapidly shows a glitch with the horizontal scrollbar as described in command #6 but after using weldeditview reverting this doesn't show the broken behaviour so I'll drop this hackaround Change-Id: I09e654cbd05b08d8e46fbf1986dbc4959687ea02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19weld SmEditTextWindowCaolán McNamara
reuse the WeldEditAccessible a11y impl and remove the then unused starmath equivalent. Change-Id: I2dc1e0436ffcd0b295e204c21bfcd365dae08bff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19use more string_view in comphelper::stringNoel Grandin
Change-Id: I5d27824694e38de540e5f1fcd8704f8777f65140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12update PCHsCaolán McNamara
Change-Id: Id3728ac0011d3deed7e56081e3a854c7fa5336f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07rtl::Static -> function local staticNoel Grandin
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26loplugin:flattenNoel
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-20OutputDevice view is sufficient hereCaolán McNamara
Change-Id: I9aa02ccadeb343c9a90ef23d44c5c5621d60c358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-18Use ESelection to locate code on node instead of SmTokendante
Will allow to use different input sources besides starmath code. Also, for adopting mathml standar the purpose is to make smnodes separate from the starmath code. Change-Id: Iefab5943cf59a8d2e31f5d59406c253fbe680ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-15Fix typosAndrea Gelmini
Change-Id: I1e962f882f0c1fbf6c919f2c9a97242eac9d69c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112508 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-15Fix typosAndrea Gelmini
Change-Id: Ic3218f9a66f4c37419195a96f4ee9f9d7d0ffb04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112142 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-03-15Correct text command on mathml importdante
Change-Id: Ie3c2433606d1994feaa349b7664fd7b3d07ffcd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-15Provide node type with more analysis capabilitiesdante
Change-Id: I3b3b866a9fdf0b5d0b9f40c0ce9bddbaf2c0b1ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-09Rename SmParser to SmParser5dante
Change-Id: I6983dd4c187fc7114546e87c66dc2c011fccd3e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-08Remove unused includedante
Change-Id: I1b1a94be7e68f58f8915cd8c970a223877130c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07Simplify the use of custom hmtl/mathml entities on matmlexportdante
This patch also serves as a base for further improvements. Change-Id: I72967e3c9739576fb74d16e656f41c440af3a4ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07Starmath now allows multiple parsers fourth partdante
Now smelementdockingwindow is version sensitible. Change-Id: I1ed172d03f0756f1603a9ff20aadcea59fe35e9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07loplugin:staticdynamic now with extra saltNoel
because it wasn't quite there yet - now checks for casts with and without const, because const doesn't really matter here. Change-Id: I319025b2095a803fcaad2a7a696d2730b7fd2f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-26 07:49:24 +0000