summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26SmDrawingVisitor does nothing for SmBlankNodeTakeshi Abe
Change-Id: Iea9139617d0a572f2577f31928d1a1e603b90ed6 Reviewed-on: https://gerrit.libreoffice.org/28392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-24SmCursor::FindTopMostNodeInLine() requires non-null argumentTakeshi Abe
Change-Id: I3643c8a299276d7f3568747e6428ced4c8a6e2bf Reviewed-on: https://gerrit.libreoffice.org/28345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-22starmath: Do SmCursor::MoveTo() more simplyTakeshi Abe
... without unnecessary copy and re-calculation of squared distances. Change-Id: I2900f8ef690cae750be036dcb3c4270c82286a4c
2016-08-18starmath: Use SmCaretPos::GetPosAfter()Takeshi Abe
Change-Id: Ie05354f9e359b9dbc10f9d8ee8a9579c67ec5e5f Reviewed-on: https://gerrit.libreoffice.org/28185 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-18screenshots: add new global make targetArmin Le Grand
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for starmathArmin Le Grand
All *.ui files create a screenshot, but not all look useful Change-Id: Iee511be3b1a94e036b289e55d77f690e10627706
2016-08-17starmath: Avoid assigned but unused valueTakeshi Abe
Change-Id: I3d8ede40e2231e3b88c43b17e353ea962e02acc7
2016-08-15starmath: Avoid temporary arraysTakeshi Abe
Change-Id: I5ebb0acd1e6a808f3341d9b18a4a8e87b0679c5d Reviewed-on: https://gerrit.libreoffice.org/28068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-11tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot
Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/forum/?&LOlang=<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: https://gerrit.libreoffice.org/27028 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-10Expect 3 subnodes for SmBinVerNode/SmBinHorNode/SmBinDiagonalNodeTakeshi Abe
Change-Id: Ib57b60f6b469b3018c5fb30a7a293089bd35e446 Reviewed-on: https://gerrit.libreoffice.org/28001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-08starmath: SmBraceNode always has 3 childrenTakeshi Abe
Change-Id: I53ef8c215866fc45ee82b6805c41c93da0e024b7 Reviewed-on: https://gerrit.libreoffice.org/27980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-07starmath: complete SmAttributNode has just 2 subnodesTakeshi Abe
Change-Id: Ifbecef188b314d599d7e97717934143b2aac8c09 Reviewed-on: https://gerrit.libreoffice.org/27912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-05loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05starmath: SmBinHorNode's symbol is not always an SmMathSymbolNodeTakeshi Abe
E.g. it is an SmGlyphSpecialNode in the "boper" case. Change-Id: I6311e0dca8e71c617d2c4c681b0b049217ec9867
2016-08-03starmath: SmDynIntegralNode always has a couple of subnodesTakeshi Abe
And the 0th subnode is SmDynIntegralSymbolNode. Change-Id: Icb15125abf1846204d0f9130ad1ec964c5172589 Reviewed-on: https://gerrit.libreoffice.org/27820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-03starmath: SmRootSymbolNode must have type NROOTSYMBOLTakeshi Abe
Change-Id: I1ce875fba10e0e84fc015cecdb5a36e48ee8ea0e
2016-08-02Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara
this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
2016-08-02starmath: SmVerticalBraceNode always has a triple of nodesTakeshi Abe
Moreover the middle ("Brace") node is a SmMathSymbolNode. Change-Id: Ia0e4f798b69a9a205269bbd3f6c63d2059e8c766 Reviewed-on: https://gerrit.libreoffice.org/27769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-01tdf#91665 l10n: Replace string list by separate strings in SmPrintUIOptionsMuhammet Kara
String lists are sometimes (mis)used to group unrelated items; the advantage(?) being that only one identifier needs to be defined for the whole group. The items are then referenced by index, which is rather fragile when they are used in different parts of UI. String lists like this one should be replaced by separate strings. Change-Id: I58c927790287b36c0cb204c815a2788bd7cf1e02 Reviewed-on: https://gerrit.libreoffice.org/27665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01loplugin:countusersofdefaultparams in shell..starmathNoel Grandin
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-31tdf#101022 Export Greek symbol to MathML with correct mathvariantTakeshi Abe
In StarMath notation "{ital %GAMMA}" is recognized as italic, and "{nitalic %iGAMMA}" is non-italic. That is, the ital/nitalic directive takes priority over special characters' flavor. On the other hand, in MathML a mathvariant attribute given in <mi> overwrites inherited value. This does not handle "bold-italic" case etc. yet. Change-Id: I9c72dc4472f8cec553417d516d9d82aebd43d15c Reviewed-on: https://gerrit.libreoffice.org/27604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-27add uui to starmath import filters testCaolán McNamara
Change-Id: I0482891fa628f810c42e6a780abdec35bc62ea7e
2016-07-27cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25starmath: Fix invalid static_castTakeshi Abe
which caused an undefined behavior by downcasting SmSpecialNode to SmMathSymbolNode. Change-Id: I00b6d2111733bddffa31d12c85fbb5bbdd675f76 Reviewed-on: https://gerrit.libreoffice.org/27531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-24starmath: Add unit test for tdf#52225Takeshi Abe
Change-Id: Id0e9cb3f2fb939bedc2f8e7a56d40a0f82c1e9ca Reviewed-on: https://gerrit.libreoffice.org/27469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-22starmath: Return early if the cursor locates after a text nodeTakeshi Abe
No longer create unnecessary copy of nodes. Change-Id: Icf8cdd3ce0f9ebbf7159e9e7eaea7abe52c05060 Reviewed-on: https://gerrit.libreoffice.org/27366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-17-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I56241813298f0c76dfbffd91e1090df326755cb6
2016-07-17uitest: add wrapper for element selectorMarkus Mohrhard
Change-Id: I641a290b3a9cf46ba484a9a851a27456cc68678c
2016-07-17remove wrong outdated commentMarkus Mohrhard
Change-Id: I3fe6957b73776152b90c34ac411167f6f4e9e4f5
2016-07-17uitest: annotate the math edit windowMarkus Mohrhard
Change-Id: Ic902ba191d632d6a9e399c6809a8e88fdfc26301
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15starmath: Make AdjustFontDesc() precede Prepare()Takeshi Abe
because what Prepare() does depends on both nFontDesc and token of the SmTextNode. Change-Id: Ib7f8c408eb8f95a10f27ccbd3d80cdd0d6ea6d56 Reviewed-on: https://gerrit.libreoffice.org/27210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-14starmath: Drop redundant SetLineColor() callTakeshi Abe
10 lines later the same code appears again. Change-Id: I06bccbb89e9bc3dd1339ca4f8c2482a2ee75c9f2 Reviewed-on: https://gerrit.libreoffice.org/27176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12starmath: no need to create temporary string for comparisonTakeshi Abe
Change-Id: I906ef285ec6164284924ca4771a6da758bd23fd6 Reviewed-on: https://gerrit.libreoffice.org/27140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-11starmath: Prefer assert to SAL_WARN hereTakeshi Abe
as defined enum cases are exhausted. Change-Id: I6564cc0cd64d593f6aa02f0651ecb490bf7845bd Reviewed-on: https://gerrit.libreoffice.org/27081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-08tdf#47813 Fix alignment for SmUnHorNodeTakeshi Abe
Originally SmUnHorNode::Arrange() was somewhat kludgy. This change implements a similar manner with SmBinHorNode::Arrange(). Change-Id: Ic18d2e7f70becfabb2c651719926e358a4585526 Reviewed-on: https://gerrit.libreoffice.org/26841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-08starmath: Fix missing negationTakeshi Abe
which was a regression from fa614231733800f4a961b77e36c86f8840d12251. Change-Id: Ia7bab72dbd6f82519024809cf6384e1442a02327 Reviewed-on: https://gerrit.libreoffice.org/27033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-07-07starmath: Remove a couple of unused error codesTakeshi Abe
Change-Id: Iae3118150cf9119e48b1740ea630dea0ebef895a Reviewed-on: https://gerrit.libreoffice.org/26998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-07starmath: Drop useless PE_BINOPER_EXPECTEDTakeshi Abe
as no code generates the error. Change-Id: I86f2db28030090e0a9284e7771f26821468bb685 Reviewed-on: https://gerrit.libreoffice.org/26974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-06starmath: Drop unused PE_UNEXPECTED_END_OF_INPUTTakeshi Abe
Change-Id: Ic5e6df6d332ef20dec22ac84544f53e0e79f5eb1 Reviewed-on: https://gerrit.libreoffice.org/26938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05starmath: Remove unused GetRect()Takeshi Abe
Change-Id: I8544520a920f5ba2863a9d1b74e73f5cf47238aa Reviewed-on: https://gerrit.libreoffice.org/26887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-04SfxModule to use initializer_list instead of variadic argumentsMark Page
The compiler can perform type checking with initializer lists Change-Id: I1d26b56a3a2b67fe719f33d758ca9b0c95ebd4d1 Reviewed-on: https://gerrit.libreoffice.org/26852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>