Age | Commit message (Collapse) | Author |
|
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.
Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.
(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)
Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
|
|
Change-Id: I8f2bc4ebd4d7c476495c5f1d92e8536c7be50c51
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
|
|
In theory, it should not be used, we use it now to mark duplicated
symbols from sdi slots as weak. See idl/source/objects/types.cxx.
Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
|
|
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I656df01fc38357de2073c36926c850eb87fed967
|
|
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
|
|
Change-Id: I5374e4427f800c4500818b97bfe6e94b303a8974
|
|
Change-Id: I87cd5cee9df31d2ff847d4c41978ae2b422bb71d
|
|
Change-Id: I1aa25c29c4e58b30d0fc29768af7c2025e39c1be
|
|
Change-Id: I03519a9ff6d3bde489e005ebc3affdce02eab8e4
|
|
Change-Id: Ie7507bb869006bc44ba4bec8ca85b1695164521a
|
|
in favour of ReadXXX methods.
Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I468b218635e10e04bb25150b6275e187ba8a8316
|
|
Change-Id: Ie477a46fae2b8c4deb55435f3769ba74037dd259
|
|
Change-Id: I0163fe1668d35b3b108f9b57653fa490ae174ee0
|
|
Change-Id: I402ceff13b2f081734151b8597c0d79ecebd6f52
|
|
Change-Id: I6797d11a09baa4f86826d8740301bb8d66bb247a
|
|
Change-Id: I7ae80079f4bd5fed1234753b521a680498ec43e1
|
|
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases
Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265
Reviewed-on: https://gerrit.libreoffice.org/7732
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3f0749caeae8a772e6fb668eefc9d8784e7f22b5
|
|
Change-Id: I8dddc52e5b9af2f97bb41aec6e666d0ae0fcbbb5
|
|
Change-Id: I51b25a89a6f5184516a17819673e9b52c781eb09
|
|
Change-Id: I9cc5df332b9bdff59e78a7779496575d44351319
|
|
Change-Id: I6449fcdfd12355713f07a751f2e95883c7c76bce
|
|
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
|
|
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
(cherry picked from commit 5c6ef989906c6aa51b2e3702bac0323ef97e9f2d)
Change-Id: Ida372f0558fd7e5cdb9c98384c21544e197f88a9
|
|
Seems to be merge artifacts in 260df50ae67e0d9f9d80e0686e6a12903c53c130.
Otherwise, I really like how Caolán implemented this in a proper,
per-locale way. Caolán, you rock!
Change-Id: I42e70b240fdf013316ad282e70b8e42eec8225a8
|
|
with percent CustomUnitText on metric fields
(cherry picked from commit 4f5b26a97dbaef964af1fe323f24109b987cb952)
Conflicts:
chart2/source/controller/dialogs/tp_3D_SceneGeometry.src
chart2/source/controller/dialogs/tp_SeriesToAxis.src
cui/source/dialogs/zoom.src
cui/source/options/optgdlg.src
cui/source/tabpages/autocdlg.src
cui/source/tabpages/backgrnd.src
cui/source/tabpages/chardlg.src
cui/source/tabpages/grfpage.src
cui/source/tabpages/numpages.src
cui/source/tabpages/paragrph.src
cui/source/tabpages/tabarea.src
cui/source/tabpages/tabline.src
cui/source/tabpages/tparea.cxx
cui/source/tabpages/tplnedef.cxx
sc/source/ui/pagedlg/pagedlg.src
sd/source/ui/animations/CustomAnimationDialog.src
starmath/source/dialog.cxx
starmath/source/smres.src
svx/source/dialog/fontwork.cxx
svx/source/sidebar/area/AreaPropertyPanel.src
svx/source/sidebar/graphic/GraphicPropertyPanel.src
svx/source/sidebar/line/LinePropertyPanel.src
svx/source/tbxctrls/fontworkgallery.src
sw/source/ui/frmdlg/column.src
sw/source/ui/misc/pgfnote.src
Change-Id: I8acc5f7fc80d4366750ad38fabbf49b02f013f7c
|
|
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
|
|
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
|
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
Change-Id: I7623fd53dd60fdfd9afb99135b79adfb434aa72a
|
|
Change-Id: I7e27b685f2e6e1e1b96aee907f4c634252b0e17b
Reviewed-on: https://gerrit.libreoffice.org/7270
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
|
|
Change-Id: Ie0756d882347912f4beb38dde25ff6d598766a7b
|
|
Change-Id: Ia27b17b39b2e69f1e397f7f38a2e7a81058dac2f
|
|
Change-Id: Ia30f9884bd95c14116bc52f0c4cf7107f2238653
|
|
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
|
|
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
Convert code like
aStrBuffer.append(OUString(" AS "));
to
aStrBuffer.append(" AS ");
Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
|
|
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
|
|
Change-Id: Ia9c168e52a99286910c9e63e0e052671c5259ba8
|
|
Change-Id: I8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06
|
|
Convert code like
if( !aStr.isEmpty() && aStr[0] == 'x' )
to
if( aStr.startsWith("x") )
Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
|
|
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it. Plus some const clean-up.
Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
|