summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2014-03-09coverity#1078822 Dereference before null checkCaolán McNamara
Change-Id: I6cc2ed1777a797c74b4a6d9618af6a62ad5ff247
2014-03-09we can move the pEditView delete inside the previous check for pEditViewCaolán McNamara
Change-Id: I612a4f8ee1e49b1468a2898678660bd66902fc96
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05remove unused code SmFontPickList::Contains(Font const&) constNoel Grandin
Change-Id: I07e6642bdf0db3b0f297e8ec01b614f880231aa7
2014-03-05remove unused code SmParser::Insert(rtl::OUString const&, int)Noel Grandin
Change-Id: Id14c393700135b511e520f75d19561667a7f5a51
2014-03-04Fix fdo#65585: Elements Dock: Operators have bad orderMarcos Paulo de Souza
Change-Id: Idf29f37032a851632760758d443d73f04bbbae69
2014-03-03editeng: sal_Bool->boolNoel Grandin
Change-Id: I4fc276e320294d57eb667b6db8e5eff078bc28b3
2014-03-03editeng: sal_Bool->boolNoel Grandin
this had to be done in conjunction with changing include/svx/unoshtxt.hxx because there are two virtual methods "bool IsValid" in two different base classes and some subclasses are overriding both base-class methods at once. Change-Id: Ib43fc5000b443057caaa513b4efeaa6fd16e4260
2014-02-28TestOutputDevice can't set meOutDevTypeChris Sherlock
One of the StarMath tests was very broken - the issue is in formula tester. It basically sets up its own derived TestOutputDevice. Because it doesn't set meOutDevType (and can't as that's a private member function - I note this whole design is *broken* but I digress) a few things can't get access to a SalGraphics instance. This is fixed by removing the class and changing it to a VirtualDevice - the test runs under headless mode anyway Change-Id: I3d6eba793386e6db3f053aa4e6aab9a4d1c63fc3 Reviewed-on: https://gerrit.libreoffice.org/8395 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27editeng: sal_Bool->boolNoel Grandin
Change-Id: Ic59e48341f69b8c6e6fe77b05eeebac56a2c53e7
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from starmathAlexander Wilms
Change-Id: I45a716abba68521c5ebc203eed205e717efead7b Reviewed-on: https://gerrit.libreoffice.org/8315 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25WaE: declaration shadows a local variableTor Lillqvist
Change-Id: If7ecddb059fb0fae5de01666a8f088caf36bc32f
2014-02-25Don't write compound header to zero length filesMaxim Monastirsky
Change-Id: Ie964ca8b870714d1c3e92469a771fab9a71f0633 Reviewed-on: https://gerrit.libreoffice.org/8220 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-23coverity#735495 logically dead codeCaolán McNamara
Change-Id: I8f2bc4ebd4d7c476495c5f1d92e8536c7be50c51
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21Add config option used when we try to link one huge object file.Matúš Kukan
In theory, it should not be used, we use it now to mark duplicated symbols from sdi slots as weak. See idl/source/objects/types.cxx. Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20cid#1078821 Dereference before null checkNoel Grandin
Change-Id: I656df01fc38357de2073c36926c850eb87fed967
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-19coverity#738849 Uninitialized scalar fieldCaolán McNamara
Change-Id: I5374e4427f800c4500818b97bfe6e94b303a8974
2014-02-19coverity#738850 Uninitialized scalar fieldCaolán McNamara
Change-Id: I87cd5cee9df31d2ff847d4c41978ae2b422bb71d
2014-02-19coverity#738851 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1aa25c29c4e58b30d0fc29768af7c2025e39c1be
2014-02-19coverity#738852 Uninitialized scalar fieldCaolán McNamara
Change-Id: I03519a9ff6d3bde489e005ebc3affdce02eab8e4
2014-02-13coverity#708230 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie7507bb869006bc44ba4bec8ca85b1695164521a
2014-02-12remove SvStream::operator>> methodsNoel Grandin
in favour of ReadXXX methods. Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3 Reviewed-on: https://gerrit.libreoffice.org/7915 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12coverity#1103660 Division or modulo by zeroCaolán McNamara
Change-Id: I468b218635e10e04bb25150b6275e187ba8a8316
2014-02-12sal_Bool->boolNoel Grandin
Change-Id: Ie477a46fae2b8c4deb55435f3769ba74037dd259
2014-02-09fix debug=2 buildCaolán McNamara
Change-Id: I0163fe1668d35b3b108f9b57653fa490ae174ee0
2014-02-09coverity#1169836 Dereference null return valueCaolán McNamara
Change-Id: I402ceff13b2f081734151b8597c0d79ecebd6f52
2014-02-07coverity#708822 unused pointer valueNoel Grandin
Change-Id: I6797d11a09baa4f86826d8740301bb8d66bb247a
2014-02-03fdo#74455 - hide direct printing button and replace with new print dialog.Michael Meeks
Change-Id: I7ae80079f4bd5fed1234753b521a680498ec43e1
2014-02-03xub_StrLen and tools/string.hxx final strawNorbert Thiebaud
Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: https://gerrit.libreoffice.org/7732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: I3f0749caeae8a772e6fb668eefc9d8784e7f22b5
2014-01-28coverity#705892 Dereference before null checkCaolán McNamara
Change-Id: I8dddc52e5b9af2f97bb41aec6e666d0ae0fcbbb5
2014-01-27coverity#1038499 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I51b25a89a6f5184516a17819673e9b52c781eb09
2014-01-27coverity#1038500 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I9cc5df332b9bdff59e78a7779496575d44351319
2014-01-27coverity#1038501 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I6449fcdfd12355713f07a751f2e95883c7c76bce
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Related: #i121289# printer options should have SID_SAVE_ONLY_USED_SYMBOLSTsutomu Uchino
(cherry picked from commit 5c6ef989906c6aa51b2e3702bac0323ef97e9f2d) Change-Id: Ida372f0558fd7e5cdb9c98384c21544e197f88a9
2014-01-20Remove space before percent signKhaled Hosny
Seems to be merge artifacts in 260df50ae67e0d9f9d80e0686e6a12903c53c130. Otherwise, I really like how Caolán implemented this in a proper, per-locale way. Caolán, you rock! Change-Id: I42e70b240fdf013316ad282e70b8e42eec8225a8
2014-01-20Related: #i56998# use FUNIT_PERCENT instead of FUNIT_CUSTOM...Tsutomu Uchino
with percent CustomUnitText on metric fields (cherry picked from commit 4f5b26a97dbaef964af1fe323f24109b987cb952) Conflicts: chart2/source/controller/dialogs/tp_3D_SceneGeometry.src chart2/source/controller/dialogs/tp_SeriesToAxis.src cui/source/dialogs/zoom.src cui/source/options/optgdlg.src cui/source/tabpages/autocdlg.src cui/source/tabpages/backgrnd.src cui/source/tabpages/chardlg.src cui/source/tabpages/grfpage.src cui/source/tabpages/numpages.src cui/source/tabpages/paragrph.src cui/source/tabpages/tabarea.src cui/source/tabpages/tabline.src cui/source/tabpages/tparea.cxx cui/source/tabpages/tplnedef.cxx sc/source/ui/pagedlg/pagedlg.src sd/source/ui/animations/CustomAnimationDialog.src starmath/source/dialog.cxx starmath/source/smres.src svx/source/dialog/fontwork.cxx svx/source/sidebar/area/AreaPropertyPanel.src svx/source/sidebar/graphic/GraphicPropertyPanel.src svx/source/sidebar/line/LinePropertyPanel.src svx/source/tbxctrls/fontworkgallery.src sw/source/ui/frmdlg/column.src sw/source/ui/misc/pgfnote.src Change-Id: I8acc5f7fc80d4366750ad38fabbf49b02f013f7c
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-09Consolidate XServiceInfo for classes derived from SvXMLImportStephan Bergmann
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
generated by cgit (git 2.34.1) at 2024-08-08 08:42:38 +0000