summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2016-10-03starmath: Add comments on indexingTakeshi Abe
Change-Id: Ic87d04f65f8272832c8742f99821876cc28bb514
2016-10-02starmath: Prefix members of SmParserTakeshi Abe
Change-Id: Ib39bf2a9b8c37d9f2ac4ed3db602c3b0a82a506b Reviewed-on: https://gerrit.libreoffice.org/29397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-30tdf#97164 Add text for visualition of percent symbol.Gulsah Kose
Change-Id: I31dc1a7a4ed0bc0e760e10c1a2ff52660a258e12 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29299 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-29tdf#53472, tdf#102268: Reimplement "intd"Takeshi Abe
This reverts its original implementation introduced with 93e6291c29d547c0c29c6e43b2ca4b36a3e8506f partially, and improves the patch proposed at 746633bd0315939fd5e0b50c90692d356d2ed678 (but reverted at e265ea36df02310881e959a031b74578b323bfa5). Change-Id: If0aa5b985cac45a1cd9ea87bae293243af9d12b2 Reviewed-on: https://gerrit.libreoffice.org/29271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-20tdf#97049 Export "intd" to MathMLTakeshi Abe
Change-Id: Ie1fc33e18958e73d4876b2b5daceec127011c3cc Reviewed-on: https://gerrit.libreoffice.org/29003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-09loplugin:constantparam in sot..svlNoel Grandin
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09loplugin:refcountingNoel Grandin
Change-Id: Ic2ab440e011502a1df3cd658fd8a86acc5d5c31c
2016-09-06starmath: Drop unused 1st argument of SmErrorNode's ctorTakeshi Abe
Change-Id: I01d8fa4bcfbfd4757230ff54902967f709216111 Reviewed-on: https://gerrit.libreoffice.org/28678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-05starmath: Pass offset by const refTakeshi Abe
Change-Id: Ideb32c7c5d43ff8d1ed9882c4c2654bec5239267 Reviewed-on: https://gerrit.libreoffice.org/28664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-02boost::intrusive_ptr->tools::SvRefCaolán McNamara
Change-Id: I4c913dc62efe3f3747e78670f4efb0216d95c4ad Reviewed-on: https://gerrit.libreoffice.org/28585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-02Replace SmNodeIterator with std::vector's iteratorTakeshi Abe
and drop obsolete comments in SmCaretPosGraphBuildingVisitor's ctor. Change-Id: Ibbe5a810ff265eb558906552bb560f9145eaf0cd Reviewed-on: https://gerrit.libreoffice.org/28571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-01convert RefDevMode to scoped enumNoel Grandin
and fix the bForceZeroExtleadBug TODO Change-Id: Iac9295c6ce31112d69a870e3a229823eb1e9a4f2
2016-08-31Replace use of our own SmNodeIterator with range-based for loopTakeshi Abe
in starmath/source/cursor.cxx and starmath/qa/cppunit/mock-visitor.hxx. Change-Id: I7733d5d17bb03532d6c4f1d6967c69d65bc3bede Reviewed-on: https://gerrit.libreoffice.org/28538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (starmath)Stephan Bergmann
Change-Id: Ic0a3a2ae6c0e2601cb415cba971620a71ded02a5
2016-08-30Every composite node is of type SmStructureNodeTakeshi Abe
Change-Id: Ie8e8b248dc8f08e612f640b2afd6639dfd3375ff Reviewed-on: https://gerrit.libreoffice.org/28474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-30VisitChildren() only for SmStructureNodeTakeshi Abe
Change-Id: I94167dd1b37198eab8e1f92049c094ac7a29e31f Reviewed-on: https://gerrit.libreoffice.org/28455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26SmDrawingVisitor does nothing for SmBlankNodeTakeshi Abe
Change-Id: Iea9139617d0a572f2577f31928d1a1e603b90ed6 Reviewed-on: https://gerrit.libreoffice.org/28392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-24SmCursor::FindTopMostNodeInLine() requires non-null argumentTakeshi Abe
Change-Id: I3643c8a299276d7f3568747e6428ced4c8a6e2bf Reviewed-on: https://gerrit.libreoffice.org/28345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-22starmath: Do SmCursor::MoveTo() more simplyTakeshi Abe
... without unnecessary copy and re-calculation of squared distances. Change-Id: I2900f8ef690cae750be036dcb3c4270c82286a4c
2016-08-18starmath: Use SmCaretPos::GetPosAfter()Takeshi Abe
Change-Id: Ie05354f9e359b9dbc10f9d8ee8a9579c67ec5e5f Reviewed-on: https://gerrit.libreoffice.org/28185 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-18screenshots: add new global make targetArmin Le Grand
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for starmathArmin Le Grand
All *.ui files create a screenshot, but not all look useful Change-Id: Iee511be3b1a94e036b289e55d77f690e10627706
2016-08-17starmath: Avoid assigned but unused valueTakeshi Abe
Change-Id: I3d8ede40e2231e3b88c43b17e353ea962e02acc7
2016-08-15starmath: Avoid temporary arraysTakeshi Abe
Change-Id: I5ebb0acd1e6a808f3341d9b18a4a8e87b0679c5d Reviewed-on: https://gerrit.libreoffice.org/28068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-11tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot
Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/forum/?&LOlang=<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: https://gerrit.libreoffice.org/27028 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-10Expect 3 subnodes for SmBinVerNode/SmBinHorNode/SmBinDiagonalNodeTakeshi Abe
Change-Id: Ib57b60f6b469b3018c5fb30a7a293089bd35e446 Reviewed-on: https://gerrit.libreoffice.org/28001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-08starmath: SmBraceNode always has 3 childrenTakeshi Abe
Change-Id: I53ef8c215866fc45ee82b6805c41c93da0e024b7 Reviewed-on: https://gerrit.libreoffice.org/27980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-07starmath: complete SmAttributNode has just 2 subnodesTakeshi Abe
Change-Id: Ifbecef188b314d599d7e97717934143b2aac8c09 Reviewed-on: https://gerrit.libreoffice.org/27912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-05loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05starmath: SmBinHorNode's symbol is not always an SmMathSymbolNodeTakeshi Abe
E.g. it is an SmGlyphSpecialNode in the "boper" case. Change-Id: I6311e0dca8e71c617d2c4c681b0b049217ec9867
2016-08-03starmath: SmDynIntegralNode always has a couple of subnodesTakeshi Abe
And the 0th subnode is SmDynIntegralSymbolNode. Change-Id: Icb15125abf1846204d0f9130ad1ec964c5172589 Reviewed-on: https://gerrit.libreoffice.org/27820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-03starmath: SmRootSymbolNode must have type NROOTSYMBOLTakeshi Abe
Change-Id: I1ce875fba10e0e84fc015cecdb5a36e48ee8ea0e
2016-08-02Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara
this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
2016-08-02starmath: SmVerticalBraceNode always has a triple of nodesTakeshi Abe
Moreover the middle ("Brace") node is a SmMathSymbolNode. Change-Id: Ia0e4f798b69a9a205269bbd3f6c63d2059e8c766 Reviewed-on: https://gerrit.libreoffice.org/27769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-01tdf#91665 l10n: Replace string list by separate strings in SmPrintUIOptionsMuhammet Kara
String lists are sometimes (mis)used to group unrelated items; the advantage(?) being that only one identifier needs to be defined for the whole group. The items are then referenced by index, which is rather fragile when they are used in different parts of UI. String lists like this one should be replaced by separate strings. Change-Id: I58c927790287b36c0cb204c815a2788bd7cf1e02 Reviewed-on: https://gerrit.libreoffice.org/27665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01loplugin:countusersofdefaultparams in shell..starmathNoel Grandin
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-31tdf#101022 Export Greek symbol to MathML with correct mathvariantTakeshi Abe
In StarMath notation "{ital %GAMMA}" is recognized as italic, and "{nitalic %iGAMMA}" is non-italic. That is, the ital/nitalic directive takes priority over special characters' flavor. On the other hand, in MathML a mathvariant attribute given in <mi> overwrites inherited value. This does not handle "bold-italic" case etc. yet. Change-Id: I9c72dc4472f8cec553417d516d9d82aebd43d15c Reviewed-on: https://gerrit.libreoffice.org/27604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-27add uui to starmath import filters testCaolán McNamara
Change-Id: I0482891fa628f810c42e6a780abdec35bc62ea7e
2016-07-27cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25starmath: Fix invalid static_castTakeshi Abe
which caused an undefined behavior by downcasting SmSpecialNode to SmMathSymbolNode. Change-Id: I00b6d2111733bddffa31d12c85fbb5bbdd675f76 Reviewed-on: https://gerrit.libreoffice.org/27531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-14 08:03:47 +0000