summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2017-02-22Test whether SmEditWindow::SelNextMark() keeps cursor positionTakeshi Abe
when there is no next placeholder marker. Change-Id: I9846b304074c39f49118710a758d44a43f926b25 Reviewed-on: https://gerrit.libreoffice.org/34531 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-21tdf#106116 "Previous Marker" changes selection only when neededTakeshi Abe
This fixes a hang caused by repeated Shift+F4. Although it seems a regression from 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8, the original code of SmEditWindow::SelPrevMark() had been doomed due to conditional loop depending on obscure signed/unsigned conversion. Change-Id: I61f630eec44b285dc1f1c27097acde4b48ed2991 Reviewed-on: https://gerrit.libreoffice.org/34503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-21loplugin:subtlezeroinit: starmathStephan Bergmann
Change-Id: Ifc6f4788bb285e28451df9c98a72b454b7685160
2017-02-19starmath: Convert SmParseError to scoped enumTakeshi Abe
Change-Id: Ia2663a768c424ea6f03bd0933a3c2fd608c239d8 Reviewed-on: https://gerrit.libreoffice.org/34422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-16convert EditEngineAttribs to scoped enumNoel Grandin
and drop unused EditEngineAttribs_HardAndPara enumerator Change-Id: Ic1fcddc6adeb5317f96bcef9b6f715b26d901a8d
2017-02-15convert SmBracketType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
2017-02-15starmath: Avoid unnecessary stack operations in parsingTakeshi Abe
unless the top is "nospace". Change-Id: I03cfa2b8223298370d9d82ce5e149d61e8793737 Reviewed-on: https://gerrit.libreoffice.org/34249 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-14starmath: This condition always holdsTakeshi Abe
Change-Id: I6d47676dc71644766fdaea7033c53efa0bf9b549 Reviewed-on: https://gerrit.libreoffice.org/34212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-12Various typos on accessibleJulien Nabet
Change-Id: Id28a4a2cbbcec10a7cc9cb40ad208d575352039b Reviewed-on: https://gerrit.libreoffice.org/34161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-11starmath: Make stricter assertion to prevent out of rangeTakeshi Abe
Change-Id: I3ce0712e5095ade35628bad026a91a11dc6b9967 Reviewed-on: https://gerrit.libreoffice.org/34146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-10starmath: Kill redundant checkTakeshi Abe
Change-Id: I45f873f3733800c43c36b38dcefb79eba46b9007 Reviewed-on: https://gerrit.libreoffice.org/34030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-05.uno:ScriptOrganizer should be menu:menuitemMaxim Monastirsky
... so it won't show as an empty submenu in the customization dialog, and allow accidentally overwriting it. Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
2017-02-03starmath: Prefix member of SmNodeToTextVisitorTakeshi Abe
Change-Id: I83f5c5664aca925f874be8ac939356228697d05f Reviewed-on: https://gerrit.libreoffice.org/33850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02starmath: these functions are localTakeshi Abe
Change-Id: I7b1c9722e300585603ce54610d7ef20425a4e634 Reviewed-on: https://gerrit.libreoffice.org/33797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01starmath: Simplify and micro-optimize lookup in SmIsMathAlpha()Takeshi Abe
Change-Id: Ica2e0d14141785b9e14c05179e517117afadc5e0 Reviewed-on: https://gerrit.libreoffice.org/33734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-31tdf#105571 Drop toolbar:helpid attribute from toolbar definitionsGabor Kelemen
These are no longer useful. Made with: git grep toolbar:helpid | cut -d : -f1 | sort -u | xargs sed -i -r -e 's/ toolbar:helpid="[0-9]*"//' git grep toolbar:helpid | cut -d : -f1 | sort -u | xargs sed -i -r -e 's/ toolbar:helpid=""//'1 Change-Id: If1bf04265f4e03b44b6a92529f6133aff1589526 Reviewed-on: https://gerrit.libreoffice.org/33642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30starmath: Make some functions private, instead of protectedTakeshi Abe
Change-Id: Ic1192a2fca86833e9efd954c7625fb4f84f46b7c Reviewed-on: https://gerrit.libreoffice.org/33618 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-26tdf#105483: let's put lowercase Greek letter in italicJulien Nabet
and let uppercase one in non italic See comments from tdf#52225 in addition to initial description of this one + adapt QA tests associated (keep on to test "0" case) Change-Id: Ia84685fc5d336dd96b97d02c0e81f92e7966a6f1 Reviewed-on: https://gerrit.libreoffice.org/33480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26use rtl::Reference in SmGraphicWindowNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ib84809bee35c01fb590439174740d92bf4cd54bd
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24starmath: Inline and remove SmRect::BuildRect()Takeshi Abe
because a ctor was its only client. Change-Id: I31cce925231210930576bf93396f9d7aa44a5a71 Reviewed-on: https://gerrit.libreoffice.org/33414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-20starmath: Avoid ad hoc LanguageTag and CharClass at tokenizationTakeshi Abe
Instead, keep them as SmParser's members. Change-Id: I8a2aad7ba8baaad9a761f42f62d51fc67cadec07 Reviewed-on: https://gerrit.libreoffice.org/32348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, starmathStephan Bergmann
Change-Id: I1181cd9fd50fc0307c4475abb8c59e3f16bade91
2017-01-17replace boost::checked_deleter with std::default_deleteJochen Nitschke
and remove all traces of boost/checked_delete.hpp Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2 Reviewed-on: https://gerrit.libreoffice.org/33182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17starmath: Rely on the default ctors for SmRectTakeshi Abe
No need to define its copy ctor manually nor to use placement new for assignment operator. Change-Id: I679a19c1d1a87072d818cdfa4a9347edb6f4cea1 Reviewed-on: https://gerrit.libreoffice.org/33202 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-11starmath: Kill unused forward declarationTakeshi Abe
Change-Id: I03f76aada322a7222795795d32553ae2425092c3 Reviewed-on: https://gerrit.libreoffice.org/32962 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-11starmath: Prefix members of SmViewShellTakeshi Abe
Change-Id: I256b251b6aaad487ab0afeb56ee67a4a33769e8f Reviewed-on: https://gerrit.libreoffice.org/32777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-10New loplugin:conststringvar: starmathStephan Bergmann
Change-Id: I23efecd90ee3e89afd0159ac2eaca78bb0a92685
2017-01-04starmath: SmGraphicWindow requires non-null pViewShellTakeshi Abe
Change-Id: Ic1e0f3f7aefb801cdda4709c3d43794ad9a21b02 Reviewed-on: https://gerrit.libreoffice.org/32722 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-04starmath: Reenable a test case for SmNodeToTextVisitorTakeshi Abe
by fixing a regression which seems introduced at 4f294a90877d2f91bb88c7d6cd5b74e8e546a025. Change-Id: If47f7528f5b5fd04432da134f345d69c25a1ca77 Reviewed-on: https://gerrit.libreoffice.org/32665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-02starmath: Assert that GetDoc() is non-null hereTakeshi Abe
Change-Id: I694f42a5bf2917e99bdf77d3cf7122cf1bb920ae Reviewed-on: https://gerrit.libreoffice.org/32596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-01starmath: Prefix members of SmSelectionDrawingVisitorTakeshi Abe
Change-Id: I889da35c24919157e5b01225df10947c790ebf66 Reviewed-on: https://gerrit.libreoffice.org/32547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-31starmath: Prefix member of SmCloningVisitorTakeshi Abe
Change-Id: I21511074a4dd2d0bf410401dfce7c43437824979 Reviewed-on: https://gerrit.libreoffice.org/32526 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-27starmath: SmCaretPos's index must be non-negativeTakeshi Abe
Change-Id: I69a2fc0c9ccaa76a0d93127ac6a1544fe9924605 Reviewed-on: https://gerrit.libreoffice.org/32444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-26starmath: Prefix n to SmCaretPos's IndexTakeshi Abe
Change-Id: Ie1647d8143c4c38ebcf5111bffc291c26704c4c0 Reviewed-on: https://gerrit.libreoffice.org/32428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-20convert SFX_EVENT constants to scoped enumNoel Grandin
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never generated, so remove them and delete the code that receives them Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00 Reviewed-on: https://gerrit.libreoffice.org/32168 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19make IOS hack a DISABLE_DYNLOADING hack and extend for basctl+starmathCaolán McNamara
Change-Id: I07057dec477051ddc96600f467ffbb0c8bd1da5f Reviewed-on: https://gerrit.libreoffice.org/32144 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-14tdf#91767 Read SfxItemSet before disposing its AbstractSvxZoomDialogTakeshi Abe
Change-Id: I5dc6a1b1fa42a4fd76af398c2fb56461574900ee Reviewed-on: https://gerrit.libreoffice.org/31980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12starmath: Omit empty dtorTakeshi Abe
Change-Id: I7c905255627fb5286378e077d52932e9b184f054 Reviewed-on: https://gerrit.libreoffice.org/31853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Monkey business: Fix typo in comments: et -> ed :)Mike Kaganski
Change-Id: I91440e8582108b9121ac6525c8ac88ad6f218a60 Reviewed-on: https://gerrit.libreoffice.org/31721 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-27 15:10:03 +0000