summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2017-01-11starmath: Kill unused forward declarationTakeshi Abe
Change-Id: I03f76aada322a7222795795d32553ae2425092c3 Reviewed-on: https://gerrit.libreoffice.org/32962 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-11starmath: Prefix members of SmViewShellTakeshi Abe
Change-Id: I256b251b6aaad487ab0afeb56ee67a4a33769e8f Reviewed-on: https://gerrit.libreoffice.org/32777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-10New loplugin:conststringvar: starmathStephan Bergmann
Change-Id: I23efecd90ee3e89afd0159ac2eaca78bb0a92685
2017-01-04starmath: SmGraphicWindow requires non-null pViewShellTakeshi Abe
Change-Id: Ic1e0f3f7aefb801cdda4709c3d43794ad9a21b02 Reviewed-on: https://gerrit.libreoffice.org/32722 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-04starmath: Reenable a test case for SmNodeToTextVisitorTakeshi Abe
by fixing a regression which seems introduced at 4f294a90877d2f91bb88c7d6cd5b74e8e546a025. Change-Id: If47f7528f5b5fd04432da134f345d69c25a1ca77 Reviewed-on: https://gerrit.libreoffice.org/32665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-02starmath: Assert that GetDoc() is non-null hereTakeshi Abe
Change-Id: I694f42a5bf2917e99bdf77d3cf7122cf1bb920ae Reviewed-on: https://gerrit.libreoffice.org/32596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-01starmath: Prefix members of SmSelectionDrawingVisitorTakeshi Abe
Change-Id: I889da35c24919157e5b01225df10947c790ebf66 Reviewed-on: https://gerrit.libreoffice.org/32547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-31starmath: Prefix member of SmCloningVisitorTakeshi Abe
Change-Id: I21511074a4dd2d0bf410401dfce7c43437824979 Reviewed-on: https://gerrit.libreoffice.org/32526 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-27starmath: SmCaretPos's index must be non-negativeTakeshi Abe
Change-Id: I69a2fc0c9ccaa76a0d93127ac6a1544fe9924605 Reviewed-on: https://gerrit.libreoffice.org/32444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-26starmath: Prefix n to SmCaretPos's IndexTakeshi Abe
Change-Id: Ie1647d8143c4c38ebcf5111bffc291c26704c4c0 Reviewed-on: https://gerrit.libreoffice.org/32428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-20convert SFX_EVENT constants to scoped enumNoel Grandin
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never generated, so remove them and delete the code that receives them Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00 Reviewed-on: https://gerrit.libreoffice.org/32168 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19make IOS hack a DISABLE_DYNLOADING hack and extend for basctl+starmathCaolán McNamara
Change-Id: I07057dec477051ddc96600f467ffbb0c8bd1da5f Reviewed-on: https://gerrit.libreoffice.org/32144 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-14tdf#91767 Read SfxItemSet before disposing its AbstractSvxZoomDialogTakeshi Abe
Change-Id: I5dc6a1b1fa42a4fd76af398c2fb56461574900ee Reviewed-on: https://gerrit.libreoffice.org/31980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12starmath: Omit empty dtorTakeshi Abe
Change-Id: I7c905255627fb5286378e077d52932e9b184f054 Reviewed-on: https://gerrit.libreoffice.org/31853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Monkey business: Fix typo in comments: et -> ed :)Mike Kaganski
Change-Id: I91440e8582108b9121ac6525c8ac88ad6f218a60 Reviewed-on: https://gerrit.libreoffice.org/31721 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-07starmath: Add unit test for importing MathML's mathcolorTakeshi Abe
Change-Id: I1e6378834889d6808a1aa724b2cc72c59b02435e Reviewed-on: https://gerrit.libreoffice.org/31671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-07starmath: Require that they are non-0 vectorsTakeshi Abe
Otherwise, division by zero would happen. Change-Id: I77fde7da87f32ba530482e80623bb449313cf986 Reviewed-on: https://gerrit.libreoffice.org/31670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05starmath: Prefix members of SmStructureNodeTakeshi Abe
Change-Id: I58f6ca7585ef726d4ac3f555118832a4434f4e3c Reviewed-on: https://gerrit.libreoffice.org/31629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-03starmath: Prefix members of SmPolyLineNode etc.Takeshi Abe
Change-Id: I6fa81689e14e605cd7449526e44245d4fdebb298 Reviewed-on: https://gerrit.libreoffice.org/31536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-02loplugin:unnecessaryoverride (dtors) in starmathStephan Bergmann
Change-Id: I7d987fdab23a708a75e7d2e8bd2aabdb96e53140
2016-12-02starmath: Prefix members of SmTextNodeTakeshi Abe
Change-Id: Ic2509e7ee4040fec8173861f319bce61804837cf Reviewed-on: https://gerrit.libreoffice.org/31468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-30ScTabViewShell::InnerResizePixel must not mark document as modified...Stephan Bergmann
...when merely toggling the edit mode of a Calc document embedded in another document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet"). Interestingly, none of the other document kinds seem to have this problem. (Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange information down there. Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe
2016-11-30sw: use auto when initializing with a cast to avoid duplicating the type nameMiklos Vajna
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d Reviewed-on: https://gerrit.libreoffice.org/31397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30starmath: Prefix members of SmSpecialNode etc.Takeshi Abe
Change-Id: I7a1ac67f5fb3066b16b59a3a8277952d66572fb6 Reviewed-on: https://gerrit.libreoffice.org/31353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: starmathStephan Bergmann
Change-Id: I7a7eaf1e99216d3985ff654e7c4df7e19dd0ae24
2016-11-29starmath: these static functions can be localTakeshi Abe
Change-Id: I5babffab846a9f17cd14cbf8ffd3b34b6bb27abd Reviewed-on: https://gerrit.libreoffice.org/31322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-29tdf#103430 Apply mathvariant attribute to <mi> and <mo>Takeshi Abe
by emulating it with SmFontNode. In case of <mo>, current implementation supports only the one named with an alphabet. Change-Id: I827a7e80f5aa94e243098a6e50eb758cf915c282 Reviewed-on: https://gerrit.libreoffice.org/31240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-28starmath: Separate color name and operand by spaceTakeshi Abe
Otherwise, errors happen at MathML import. Change-Id: I17037b430710ea4d26340e7ce13c7972a76f614f
2016-11-25starmath: Prefix members of SmBinDiagonalNode etc.Takeshi Abe
Change-Id: Icd863b23cfca635f901a0aea65fa26dace0aa8f9 Reviewed-on: https://gerrit.libreoffice.org/31188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-24starmath: Prefix members of SmFontNodeTakeshi Abe
Also, make SmFontSize::GetSizeType() return value, not reference. Change-Id: Ifec68cfbdd5f05396fb0d913ddd6888749fdcfbd Reviewed-on: https://gerrit.libreoffice.org/31157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-24use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-24convert SFX_VISIBILITY constants to scoped enumNoel Grandin
* split the position and the flags information * remove unused DESKTOP constant Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2
2016-11-23starmath: Prefix members of SmNodeMatrixTakeshi Abe
Change-Id: I76c7e34878b9d2bc74d2499cf65448f0dd3a17b3 Reviewed-on: https://gerrit.libreoffice.org/31034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-21tdf#79645 Add line spacing only between rows of SmMatrixNodeTakeshi Abe
Change-Id: Icb785aff47de434fd8a99d1841dcbe4464df039f Reviewed-on: https://gerrit.libreoffice.org/31007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-19tdf#103500 Import stretchy integral symbol from MathMLTakeshi Abe
as "intd". Change-Id: Ic8a4feef7a3a19c8ed5bca2f09f80901e2b6d343 Reviewed-on: https://gerrit.libreoffice.org/30953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-18includes should be at the top of the fileNoel Grandin
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18starmath: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I49bddc1e51550c1696a1e93ce22e6b85bb663cd6 Reviewed-on: https://gerrit.libreoffice.org/30949 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18tdf#84650 Fix X-coordinate of SmMatrixNode's elementsTakeshi Abe
which are aligned to left or right against the column. Change-Id: Ie2b6944bc0dddb0e1589842472298f787fabf596 Reviewed-on: https://gerrit.libreoffice.org/30929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-16tdf#101472 Prompt repaint of Elements window when mouse leavesTakeshi Abe
This also reduces some cycles in SmElementsControl::MouseMove(). Change-Id: I1dd5f9cd37e4a78010ebb719b4726f9b061d8ff2 Reviewed-on: https://gerrit.libreoffice.org/30897 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15tdf#76296 Import MathML's <mspace>Takeshi Abe
as possibly multiple "~" and/or "`" by honoring its width attribute. Change-Id: I17e361c3f8f5d061c856b72266332369497d16b9 Reviewed-on: https://gerrit.libreoffice.org/30809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-14tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I29a8ca55d1d9f319cd57e5e30fa7e58e4d91dc5c Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30810 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-12starmath: Prefix member of SmBlankNodeTakeshi Abe
Change-Id: I20b9fa14d42549a3c5be8a7d4f52c85fcef52cf5
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456