summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2021-08-13Include the starmath version inside the configurationdante
Change-Id: I4492fad6eb498e0c8c9a53b2096f538f2916d843 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120271 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13Export Math ML from new mathml nodesdante
Review tip: thanks for your help Code heavily based on: mathmlexport.cxx mathmlexport.hxx https://opengrok.libreoffice.org/xref/core/starmath/source/mathml/mathmlexport.cxx?r=e271fce8 https://opengrok.libreoffice.org/xref/core/starmath/inc/mathml/mathmlexport.hxx?r=10d29c39 Change-Id: I798d0e207b844240f4b25720ee37c394eb4c2e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-10Missing includeStephan Bergmann
(for std::unique_ptr, with recent libstdc++ 12 trunk) Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-09Add an iterator for the new starmath matml elementsdante
Change-Id: I7b57951795e8acd704f418d10e5fd0aded3f2b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-09Corrections to starmath mathml definitionsdante
Change-Id: I6f545ced857190ed4b0f4090c0d47611ff475b57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-02convert #defines to OUStringLiteralNoel Grandin
mostly by doing $ git grep -l '#define.*\"' -- *.cxx | xargs perl -pi -e 's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 = u\2;/g' Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-30convert TextAlign to scoped enumCaolán McNamara
Change-Id: Id2c466eacb44f0ea6adba75a0ac0be8be8e7ed4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-24use officecfg to retrieve PrettyPrintingNoel Grandin
Change-Id: Ia815acdb8050316293e23801d3ed5bfbeb3ab386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21can pass SfxItemSet around by value in SfxShellNoel Grandin
Change-Id: I80ee25c56da437d778e11f2dab3d07845ebd9597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-20Use some forward declarations in <editeng/editobj.hxx>Mike Kaganski
Change-Id: Ic6c36d4e0da53324ada9ff8a91e715d52ac24394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119292 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski
... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-06Fix extended tips text after translation review for starmathOlivier Hallot
Thanks to Tuomas Hietala. Change-Id: I6b031d83ae9afbecd70d9a6641a882ac6d81ac8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118445 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-17use string_view in the Translate APINoel Grandin
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-15vcl: outdevmap.hxx -> rendercontext/ImplMapRes.hxxChris Sherlock
Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-13Assert on valid order of which ids in ranges on SfxItemSet creationMike Kaganski
This allows to make sure we actually use sorted which ranges, and then it's safe to call SfxItemSet::MergeRange when needed. Also this change relaxes the previous requirement that ranges must be separated by at least one; this allows to have adjacent ranges, like in RES_FRMATR_BEGIN, RES_FRMATR_END-1, RES_GRFATR_BEGIN, RES_GRFATR_END-1, where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this makes possible to (1) self-document the ranges, so it's clear which ranges are included; and (2) be safe in case when these constants would change, so that the one merged range would not unexpectedly contain everything inserted between RES_FRMATR_END and RES_GRFATR_BEGIN. Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-04move unique use of secondary-icon-tooltip-text to tooltip-textCaolán McNamara
there are no "secondary" or "primary" icons for the tip to be relevant to. I imagine this should be for the whole widget. Change-Id: I6186499a9f981ab910e79970419e7cb5f0f02db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04swap orientation of container from vert to horiCaolán McNamara
we only show one child at a time so this should make no difference in theory, and that's the case in gen and gtk3. But tweak it because in gtk4 right now the height gets strangely too tall when vert while its width doesn't when hori. Change-Id: I6a35385bdfe73eb21f8c72085de3ca7408e0602d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116726 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04resave with latest gladeCaolán McNamara
Change-Id: I9f590dbe91bc69587e0a497eb2c0403c1dd02b3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-01no need to allocate these on the heapNoel Grandin
Change-Id: I6eb3853883c724b5cb28bbf4debf6f56a587ff88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31cid#1476301 Dereference null return valueCaolán McNamara
Change-Id: Ibbaa99c28bee97b5194f1a8d396730b7fcc02930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-28tdf#130654 editable smeditwindow zoom UIdante
Change-Id: Ibedf060ea838876e3598ff449e6f200119570cc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115605 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-05-23fix some starmath test leaksNoel Grandin
Change-Id: I99ad6330b7b727f6d5416afe466a8defacd14180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116013 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-17Fix typosAndrea Gelmini
Change-Id: I4be77bf074f93fc978e34e5ba4c4693896e4c467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-05-17split OutputDevice from WindowNoel Grandin
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-15tdf#130654 editable smeditwindow zoomdante
Setting only accessible from advanced configuration. Access: org.openoffice.Office.Math.smeditwindowzoom Note that the change won't take immediate effect. LibreOffice has to be restarted to the change to take effect. Math configuration entries are not synced correctly. More detailed explanation can be fond in tdf#132145. Change-Id: I0017ddda73ab2916c6ad1fa238265d57a2a3020e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114616 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-14Add extended tips to print dialogOlivier Hallot
The extended tips were not imported for the print dialog in the firts round. Change-Id: Ie4e5282720d927fec51a823bb43c1617349105bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115576 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-05-09cid#1401328 silence Uncaught exceptionCaolán McNamara
Change-Id: I7cd29462586b1dfe6fb7268ec3225317c1d2d782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-08cid#1482285 silence Uncaught exceptionCaolán McNamara
Change-Id: I0550dadd2990cb0d93b51570b2cc3136afb50907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-08ref-count SfxItemPoolNoel Grandin
so we can remove SfxItemPoolUser, which is a right performance hog when we have large calc spreadsheets Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115247 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-07remove an intermediate layer of widgetsCaolán McNamara
Change-Id: I4fe23f87d997057a2cb061110c8e325c8322b95e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06release mouse before showing context menuCaolán McNamara
otherwise math loses focus due to the mouse release Change-Id: Ie50cfde6a9f13d87efba2f6ec4830b9730f6e938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06add SfxItemPoolDeleter utilityNoel Grandin
add use so we can hold the pool with std::unique_ptr Change-Id: I685fbc37c0ae145a5b48a66a88eab9fb29a0fc0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-06use Widget::get_clipboardCaolán McNamara
there's no different from GetSystemClipboard except potentially for the libreofficekit case where per-frame clipboards are possible Change-Id: I3173e39f81a03a7cbe114ebca6020d5ed36a659a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Iedb9586fcf34dc172b93f0a246b1c1e1c9033376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04tdf#141930 document set as unmodified if editengine didn't modify on keyeventCaolán McNamara
this appears to have always happened for cursor keys, and since commit 0154f04e8c64df937b793c73ac58d553637f324f Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Feb 24 14:32:21 2021 +0000 Resolves: rhbz#1931423 start update timer in IM events as well as keyevents also happens on Input Engine events which don't cause changes Change-Id: Ic5cdd9ef4f1bed1cc2b2c17fc847f196a9c6e23a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115055 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-03There's no longer a purpose to the math horizontal scrollbarCaolán McNamara
since... commit f89860807baaa901629ce2a814b7a6c994318fe5 Date: Sat Feb 13 16:43:01 2021 +0100 Resolves tdf#140221 auto-adjust Formula Editor width so remove that. And merge the starmath Resize logic into the baseclass, and emit EditViewScrollStateChange from there. The goal is that resizing the starmath window does not visually horizontally scroll content negatively outside the widget Change-Id: I1a79a0d5a194e8cfb0d2d2cb07b0b80172f1f66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115012 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-30drop DropTargetHelper from SmEditWindowCaolán McNamara
dnd into its child always worked while the inheritence from DropTargetHelper began in commit daf3e2909104fcb4c0a36d6e1fd6f44e1b61c980 Author: jp <jp@openoffice.org> Date: Thu Jul 5 09:58:51 2001 +0000 Changes for TFD636 but always returned DND_ACTION_NONE for the parent window Change-Id: Ida1ae0f8e68ba04452ed952c4eca3ac66f240132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29reuse SmEditWindow already present in SmCmdBoxWindow in testsCaolán McNamara
Change-Id: I48f15d584e15269336b289c8204588384f2f6998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27Correct some c/c++ licensesdante
The affected files where added from scratch in commit 565bbd2e46e57117eb401344689858c3d749dc5c. In consequence instead of the ASF license; the correct license is the pure MPLv2 found here: TEMPLATE.SOURCECODE.HEADER Change-Id: Ie2fa275a6a986fff026a5096a10f79ab3c6ea85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114670 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-23consume context menu eventCaolán McNamara
Change-Id: Ic7d819775f59b7303dea1a381a20ca3ea1ac8d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23cid#1477316 Uninitialized scalar fieldCaolán McNamara
Change-Id: I11ad5375e5fee35065bb855fb0db0b0c00d75fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23Related: tdf#140659 designate which widget to get default focusCaolán McNamara
Change-Id: I8c8200756a7120db9a9c946889a30f6c549fd617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23designate which widget to get default focusCaolán McNamara
Change-Id: Ie5968b80583f8c560b145463a60e2e86992fdb96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22Fix typosAndrea Gelmini
Change-Id: Id06dc8750b735ecdba26ac607394c6e7dee16db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114470 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Dante DM <dante19031999@gmail.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-04 03:44:05 +0000