summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)Author
2023-09-28starmath: Add Arabic functionsKhaled Hosny
Change-Id: Ie7597cbde29c8b9cd53d591dc9a722e7df76048b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157361 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-28starmath: Arabic text should always be uprightKhaled Hosny
Change-Id: Ibe9f3092432ae4ffd81903df8672daf90947000c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157349 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-28tdf#142095: Render symbols in Math Symbols Catalogue using document settingsKhaled Hosny
Use the document format to resolve the font and style of the symbol. This makes the symbols use the current document font, as well as apply settings like GreekCharStyle. Change-Id: I668e582704b7e011e032f8b9e1dfb509e0d00d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157348 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-28starmath: Arabic symbols from Symbols Catalogue should not be italicKhaled Hosny
Arabic math symbols are not set in italic, so we need to unset the italic style if set. Change-Id: Id6db51a944236722a9724ad0d128ff6435a6bac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157346 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-25tdf#49895: search in Options: check if label exists (related to tdf#157266)Bayram Çiçek
- since ids in ui files can be changed or removed, we have to check if they are exits or not, to prevent any crash or misbehavior. - Proper solution will be iterating over the widget ids and collecting their strings without based on a list of identifiers. Change-Id: I2088af6842ad0acd00838a37295dc2e6140096f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157103 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-09-21starmath: No need for the OUString copy hereKhaled Hosny
Change-Id: I71e6fd6ff9f5420899ece59b97b81b5e837f919b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157142 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-21starmath: Rename SmSym::GetName() -> GetUiName()Khaled Hosny
To make it obvious this is the UI (localized) name. Change-Id: Id0dbffeaa9c331ce90dee3e7fbc88f93fab1b654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157138 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-21tdf#62174: Fix saving of localized iGreek symbolsKhaled Hosny
When saving symbols we use the non-localized name, but iGreek symbols are a bit of a hack since they are added at runtime and don’t have localizations of there own but use the Greek symbols names with an “i” prefix. Instead of looking directly for localized names, we now go through the symbol manager that already knows about iGreek and use the export name of the symbol. We have to also make sure the iGreek symbols has non-localized export name. Change-Id: Ia3e38579abba56ae12ade126f564f8c6f9c3229a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157137 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-20tdf#32418: Add Tools -> Special Character... to MathKhaled Hosny
Change-Id: I0f4e12f82a3b8e7be2459f4ccfa91f7d30d67f78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157095 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-20starmath: Don’t set empty font name when reading font format from fileKhaled Hosny
If a setting is missing, e.g. math font when reading old file, we would set it to an empty font instead of using the default. Regression from: commit 626d17a8ec270937575e9684a325eb0669327a25 Author: Khaled Hosny <khaled@libreoffice.org> Date: Thu Aug 31 14:54:52 2023 +0300 tdf#143213: Fix reading math font settings from file Change-Id: Ib8b3cede3d4bea7e03a146b7e5f39ad2c7dfa363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157094 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-19starmath: Improve glyph positioningKhaled Hosny
Using twips everywhere and not rounding to pixels seems to improve positioning (at least on hipdi displays). Hopefully the issue that required rounding is no longer relevant. Change-Id: I0ee4a4453b2a3d8e06be56d586761f7960a2d4d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157044 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-19starmath: Get the font from current format for special symbolsKhaled Hosny
We want to use the current format when using the symbol in a document, and fallback for stabdard format when rendering the symbol in symbols dialog. Fixup for the following two commits: commit f28b043b4eb40e90b330721fc43d19ae6c06951e Author: Khaled Hosny <khaled@libreoffice.org> Date: Mon Sep 18 19:00:02 2023 +0300 starmath: Fix editing symbols in the Symbols Catalogue commit 32d2e001bb056e7d98aa143b222f2721967337dc Author: Khaled Hosny <khaled@libreoffice.org> Date: Tue Sep 12 18:35:46 2023 +0300 tdf#101174: Don’t hard-code OpenSymbol font for predefined special symbols Change-Id: Id3730749a49015120ecf9719027f932fd90c605a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157043 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-18starmath: Fix editing symbols in the Symbols CatalogueKhaled Hosny
Fallout from: commit 32d2e001bb056e7d98aa143b222f2721967337dc Author: Khaled Hosny <khaled@libreoffice.org> Date: Tue Sep 12 18:35:46 2023 +0300 tdf#101174: Don’t hard-code OpenSymbol font for predefined special symbols Change-Id: I1f440dccc920b24010160dbeee58795ffd8f85ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157025 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-18tdf#111705: Add the new maj and hadd operators to the elements panelKhaled Hosny
Change-Id: Ib62592d86a1bf2e5d94348fca731473dba92be74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156996 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-18tdf#111705: Add support of Persian limits operator (U+1EEF1)Khaled Hosny
Change-Id: I9936a206b2ce6c8d195967d1e14596c5903c1ef5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156995 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-18tdf#111705: Add support of Arabic summation operator (U+1EEF0)Khaled Hosny
Needed to fix a punch of code to work with UTF-16 not just UCS-2 (in other words, handle surrogate pairs). Change-Id: Idd7aa823349a032f20f37abbb588856afbc548d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156994 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-15starmath: Improve root rendering for fonts other than OpenSymbolKhaled Hosny
The radical glyph in OpenSymbol is aligned to the font ascender, which is not essentially true for other fonts, so we now use the bounding rectangle of the glyph to get accurate positioning. Change-Id: I83c21cd21de25f23f96f819e168f43aa9ab22351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156926 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-13tdf#101174: Don’t hard-code OpenSymbol font for predefined special symbolsKhaled Hosny
Leave the format empty and use the variables font instead. Change-Id: I3e3cdf40dc285dee7375054e85b4a2bed352eb66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156855 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-13starmath: Hide editing window by default and add a menu item to showKhaled Hosny
We are enabling inline editing bu default, so this window is of no interest by default. Change-Id: I66fe988790fe4f174f6cb4f691af69888b0b05b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156852 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-13Fix typoAndrea Gelmini
Change-Id: Ib76e9bf09a607dc79bd9ae083927af6124471e1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156834 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-09-12starmath: Keep focus on math widget when inline editing is enabledKhaled Hosny
Since originally all editing happened in the edit window, it was made to grab focus instead of the math widget, but we don’t want that anymore when inline editing is enable as we want to edit everything in the math widget. This also removes ancient test that is now failing. We will eventually drop the edit window altogether. Change-Id: Ia1628a454bbbdd923ff582564eca1ab4ec830f38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156579 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-11starmath: Fix selection of surrogate pairs in inline editingKhaled Hosny
Don’t split nodes in the middle of surrogate pairs. Change-Id: I3ce8cf19d4c331e2ead73ed375745e8866b3d7a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156827 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-10using decls should come after #includeNoel Grandin
Change-Id: I058551e87bca42adede860f6f299b0f7ae2af3b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156798 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-09Fix typoAndrea Gelmini
Change-Id: Ifac298898f2d36bcbaffb111346d1e9fa71b2e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156758 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-09-08tdf#88744: Use real clipboard when inline editing is enabledKhaled Hosny
Instead of using a fake clipboard that works only inside the same formula. Change-Id: Ia1e97028e1aafa15912bc9b4397d66afb0d23ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156671 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-07starmath: Properly update the state to copy/cut/paste buttonsKhaled Hosny
Invalidate the slots explicitly instead of implicitly by updating the edit window. Followup to: commit 065609f86f730d4eedc6b7ae28382dc7daea11ac Author: Khaled Hosny <khaled@libreoffice.org> Date: Mon Sep 4 13:22:04 2023 +0300 starmath: Make cut/copy/paste buttons work with inline editing Change-Id: If0648c249d6145475202e1a48364d7fe142a5e35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156674 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-07tdf#130741: Insert brackets around horizontal binary nodes more generouslyKhaled Hosny
When converting node tree creating with visual editor back to text for the command editor, try to always insert brackets around binary expressions. It might look redundant at times but it is safer, and the code is not supposed to be edited by hand anymore so doesn’t have to look pretty. Change-Id: Ifff574494c9e8f8b948e432f6832d88c334aba00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156640 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-05starmath: Always insert using SmCursor when inline editing is enabledKhaled Hosny
Choosing which code path based on which widget has focus is not a very good idea, and leads to unreliable UI tests as each code path inserts the text slightly differently (one code path inserts plain text then parses the whole equation again, while the other parses the new text then inserts the parsed node directly). Change-Id: Ib2ca942c537e466f6ff100be7f95adaead99f1d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156578 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04starmath: Make cut/copy/paste buttons work with inline editingKhaled Hosny
Check for visual cursor selection when in inline editing mode, and update edit window when updating visual cursor. Change-Id: Id1a259b67db47eea0b36b55d08ef5dc5f8aa8246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156513 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04tdf#134193: Fix inline editing with RTL directionKhaled Hosny
Change-Id: I65d3ed0d7c56839ce3674318144269719b043ba5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156261 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04tdf#134193: Fix RTL selection and cursor handlingKhaled Hosny
Change-Id: Ib9d7dd56d884aaca9b88a8b9403aeef30a9917d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156167 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04tdf#134193: Allow setting math directionKhaled Hosny
Add LTR/RTL buttons to the toolbar and make them change the IsRightToLeft property. Change-Id: I8ae793a9899c50b6dfaf3563a7c22c1f1eab8c8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155739 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04tdf#134193: Support rendering math in RTL modeKhaled Hosny
Respect IsRightToLeft property and render accordingly. This also fixes math rendering in RTL UI, which was incorrectly rendered RTL. Change-Id: Id8520930f09a21daa1c70e40a765ac25572ea994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155738 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04tdf#134193: Add the ability to set RTL math directionKhaled Hosny
This adds a new IsRightToLeft document property, reads/writes it, and sets dir="rtl" on the top level MathML <math> element if set to true. Rendering will be handled in next commits. Change-Id: Ia3078b8a269fef7c3f037a2f1b7799744df2680b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155737 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-04Math: enable in-place editing on desktopKhaled Hosny
Move the code outside the else block as it doesn’t get hit for me on desktop otherwise, and use SmViewShell::IsInlineEditEnabled() instead of comphelper::LibreOfficeKit::isActive() (which is included in the former). Followup to: commit 737a270c61cd2038ede7911b7d7b4afcf020f53c Date: Mon Jan 17 17:15:46 2022 +0300 lok: enable in-place editing of math equations Change-Id: Ie604f152344b83479eaf6024b6d58e374abb39b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156331 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-03starmath: Disable formula cursor toolbar button when inline editing is enabledKhaled Hosny
It is ignore when inline editing is enable, so better disable it to make it clear. Change-Id: Ie79a1c16109109e213658d44a6ffc0bff2291c7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156487 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-03starmath: Graduate inline (visual) editing from experimental featuresKhaled Hosny
It has been experimental for as long as LibreOffice existed, lets make it non-experimental but add an option to disable it. If it turns to be a disaster, we can flip the option and disable it by default. Change-Id: I63672c054d1ead269863079e7f9c118a44b3ba19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156486 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-03starmath: Re-save smathsettings.ui with newer gladeKhaled Hosny
Change-Id: I2a2802eafa0d77e1a35131dbe7bd9ca003aa3c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156485 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-01Replace a macro with a functionStephan Bergmann
Such test code should generally be non-DRY, but using a macro rather than a function here didn't help much in that regard: For a failing test, it just traded reporting the line of the failing CPPUNIT_ASSERT for reporting the line of the failing CHECK_GREEK_SYMBOL call, neither of which by itself gives sufficient context. Change-Id: Icce6a68d67d36e8809bf96dcd36ceef6b7b7c9eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-08-31tdf#143213: Fix reading math font settings from fileKhaled Hosny
The order of reading the settings is significant, e.g. if font italic was read first then font name, font name would set a new font overriding the italic setting. We now collect all font settings and apply them at once. Change-Id: Idb32d7d416607011bc325eff0b73c03b2d12e7d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156352 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-29tdf#49895: Add search functionality to Options dialogBayram Çiçek
- Search field added. - Dialog names of all treeview nodes with their parent names were included in searching. - Strings of labels, check buttons, radio buttons, toggle buttons, link buttons and buttons were included in searching. Change-Id: Idf67c160519402ee390d94b1b3135b56324f3990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152519 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-08-28new loplugin:optionalboolNoel Grandin
which warns against using the 'operator bool' conversion of std::optional<bool> which can lead to interesting bugs The bugs that this plugin have been submitted independantly, so this change is just using has_value() in relevant places. Change-Id: I259b837feeecddcb8cd1d7e5db1e85bf505907cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155978 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-25tdf#101174: Add the ability to change math font in MathKhaled Hosny
The math font (default is OpenSymbol) can now be changed from the fonts dialog like other fonts (variables, numbers, etc). Change-Id: I57f416173abf7bef8bb66b5e5e393dd928e30652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156053 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-24starmath: Use OutputDevice::Push()/Pop() instead of doing it manuallyKhaled Hosny
Change-Id: I628385cd64f3d65a1a567590bce754693b4d0684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155795 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-18ITEM: preparations for more/easier changesArmin Le Grand (allotropia)
This change is not about speed improvements but diverse preparations to make changes/reading/understanding easier. It does not change speed AFAIK. Added a global static debug-only counter to allow getting an overview over number of all allocated SfxPoolItem's and the still alloated ones at office shutdown. The values are used in Application::~Application to make a short info statement. It allows to be able to quickly detect if an error in future changes may lead to memory losses - these would show in dramaitically higher numbers then (hopefully) immediately. Moved SfxVoidItem to own source/header. Added container library interface support to SfxItemSet, adapted already some methods to use it - not all possible, I will commit & get status from gerrit 1st if all still works and then continue. Changed INVALID_POOL_ITEM from -1 to use a global unique incarnation of an isolated derivation from SfxPoolItem. It allows to avoid the (-1) pointer hack. Since still just pointers are compared it's not worse. NOTE: That way, more 'special' SfxPoolItem's may be used for more States - a candidate is e.g. SfxVoidItem(0) which represents ::DISABLED state -- unfortunately not only, it is also used (mainly for UI stuff) with 'real' WhichIDs - hard to sort out, will have to stay that way for now AFAIK. Changed INVALID_POOL_ITEM stuff to use a static extern incarnated item in combination with a inline method to return it, called GetGlobalStaticInvalidItemInstance(). Isolated create/cleanup of a SfxPoolItem entry in SfxItemSet to further modularize/simplify that. It is currently from constructor & destructor but already shows that PoolDefaults are handled differently - probably an error. Still, for now, do no change in behaviour (yet). Got regular 'killed by the Kill-Wrapper' messages from gerrit, seems to have to do with UITest_sw_findReplace. That python/c++ scripting stuff is hard to debug, but finally I identified the problem has to do with the INVALID_POOL_ITEM change. It was in SfxItemSet::InvalidateAllItems() where still a (-1) was used -> chaos in detecting invalid items. Change-Id: I595e1f25ab660c35c4f2d19c233d1dfadfe25214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155675 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-08-14starmath: fix -Werror=unused-variableMiklos Vajna
Seen with gcc 7.5.0. Change-Id: I34940865f62ff397a3a6813fbabd0fb45a01d88f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155654 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-08-10tdf#32415: Always accept English symbol names in mathKhaled Hosny
If symbol name does not match localized names, try to find a match using English (export) names. Change-Id: Id668ee68b07c8431c2780b78e26e07d3aef043aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155553 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-10tdf#80467: Fix math rendering in elements dock with RTL UIKhaled Hosny
Make sure to disable RTL on the OutputDevice, otherwise the math will be rendered right-to-left without even mirroring the parenthesis. Change-Id: Iea43dbc0d7efe914120d5cc1605522254344b4fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155538 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I2869e115941b3e1f52911d58d54ec1b2831d0524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-28SfxMedium::GetItemSet never returns nullptrMike Kaganski
Change-Id: Ibfc98a49022aa09ebf5315e5d3328308c1e51d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154997 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-10 12:35:50 +0000