summaryrefslogtreecommitdiff
path: root/stoc/source
AgeCommit message (Collapse)Author
2017-01-27stoc: try to throw more informative exceptionsMichael Stahl
... from IdlInterfaceMethodImpl::invoke(), which is somewhere involved in BASIC calls. Change-Id: I739f70fec56ec9e4345511eefe41fd0f8df8bf6f Reviewed-on: https://gerrit.libreoffice.org/33593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-26-Werror=int-in-bool-context (GCC 7)Stephan Bergmann
Change-Id: Id97c3ec66c9c0f924951c44efa9f7dd95b184223
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-23use rtl::Reference in stocNoel Grandin
instead of manual acquire/release Change-Id: I626ad9875528fa76d8f781b07cc86e149032ecb1
2017-01-19New loplugin:dynexcspec: Add @throws documentation, stocStephan Bergmann
Change-Id: I8c7d5088aed055c3734165343189233b3124c9be
2017-01-19new loplugin: useuniqueptr: sot..toolsNoel Grandin
Change-Id: Ided435d016ae28e7c3f2726e41eedd981572ae10 Reviewed-on: https://gerrit.libreoffice.org/33263 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02loplugin:unnecessaryoverride (dtors) in stocStephan Bergmann
Change-Id: I60652dbac6a76eacdbb4e951a636e7a40e88a6a6
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02coverity#1375798 Uncaught exceptionCaolán McNamara
Change-Id: Id7e968170a038d9316503ee796cfd6a99e9fc3ae
2016-10-27coverity#1374309 Uncaught exceptionCaolán McNamara
Change-Id: I043236e45fbb110b6b3818f2b02dcf1f512623f6
2016-10-27loplugin:expandablemethods in stoc..svlNoel Grandin
Change-Id: I7dd701ef07a14f70589b87154bfeeda7530b628f Reviewed-on: https://gerrit.libreoffice.org/30316 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26Java 7 DISPLAY and FORMAT locale and script fieldEike Rathke
Change-Id: Ie62105c60a327f6e5cbcf1a801b341e988471d73 Reviewed-on: https://gerrit.libreoffice.org/30308 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-25Revert "Revert "Resolves: #i86470# Wrong Java locale when using "nl" and "fr"""Stephan Bergmann
This reverts commit 4c13c4da1616317555ed3470603ff786db772d64, after 475e4b477c6d7ae114c3ae51ba4872882af67a68 "Move i18nlangtag lib to URELIB". Change-Id: I61eb0c786b1fac8eb51db7b54156c906398dfb48 Reviewed-on: https://gerrit.libreoffice.org/30279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-25Revert "Resolves: #i86470# Wrong Java locale when using "nl" and "fr""Eike Rathke
This reverts commit 9b09a217c79e8a35fc4de54c89ef49fbf8f72752. Breaks MacOS build because "a URE lib cannot link against an OOO lib; breaks on macOS".
2016-10-25Resolves: #i86470# Wrong Java locale when using "nl" and "fr"Eike Rathke
Languages don't always have a country; if there is no "-" separating language and country in the ooLocale registry value, use the entire value as the language. Initial finding by Damjan Jovanovic. However, LibreOffice knows BCP47 language tags so that needs a different approach. (cherry picked from commit d61ab2b5a0e35d55cb001e139be791420245bf35) Change-Id: I69331951372bda1c1cec80cfd10d5839d8f4b823 Reviewed-on: https://gerrit.libreoffice.org/30154 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-14loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12loplugin:constantparam in package..stocNoel Grandin
Change-Id: I04b6d14d3dd8d55ccc4d4eb9313bc37959690672 Reviewed-on: https://gerrit.libreoffice.org/28824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09loplugin:constantparam in sot..svlNoel Grandin
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu
Improved readability of OUString concatanations. Also removed unused OUStrings "sColor" and "sEntry" from the code. Change-Id: Ie9792f499cd880be72229f8a8c71f05ff8e258b6 Reviewed-on: https://gerrit.libreoffice.org/28375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-05loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-18don't write past the end of the arrayMarkus Mohrhard
Found through http://crashreport.libreoffice.org/stats/crash_details/6ba2edbd-d268-4074-8b87-590a5694cc26 Change-Id: Ic95d472fd117c2d286fabb775ef49e287a2874fa
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I5ef89d0f0f97dace7dc15dc07b3328177aab462b
2016-07-04remove deprecated Link functions from RegistryNoel Grandin
Change-Id: Id678d4b6263df86993b289e8439faac847dd7c5f Reviewed-on: https://gerrit.libreoffice.org/26855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-21Clean up uses of Any::getValue() in stocStephan Bergmann
Change-Id: I455b708bfcc9d5aa71bb0ffc21efec205302169e
2016-06-19loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Some clean up of uses of css::uno::Any::setValueStephan Bergmann
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
2016-05-30Just use Any::operator <<= for sal_Unicode valuesStephan Bergmann
...now that sal_Unicode no longer clashes with sal_uInt16 on any platform (in LIBO_INTERNAL_ONLY code), after e16fa715c43dcdf836ce8c400b6d54eae87b627d "Handle wchar_t as native C++11 type on windows" Change-Id: Id423dd6235bf14823fa5611b804c0974edbe64b3
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-01tdf#97499 Fixed containers parameters clearing #9tymyjan
Change-Id: I097106e1887be283320fc518ddafda76608b46ee Reviewed-on: https://gerrit.libreoffice.org/24521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21loplugin:salbool: sal_Bool[] -> bool[]Stephan Bergmann
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I3a3295b538e79186914390b6da73cc8bc25419a5
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Remove stray spaces from start of log messages, reduxStephan Bergmann
Change-Id: I6d8e330665860d376629ff6df8897d3826d0883b
2016-04-12Remove stray spaces from start of log messagesStephan Bergmann
Change-Id: I0bf6945a030867b3575fcef81c0d32addb85b992
2016-04-12tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed all the OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFOs or OSL_DEBUG_LEVEL > 0 Change-Id: I261644a179e763612204bbb0e54a869fa1a62298 Reviewed-on: https://gerrit.libreoffice.org/23035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>