Age | Commit message (Collapse) | Author |
|
Change-Id: Ib9c8485590d939491c9bb2cf3f2b8a70200da231
|
|
Change-Id: Iecd03d0343b9b7c3a8b23b5a1e9654148b94d44c
|
|
Change-Id: Ib812a7cafabc4820946da67fb3f8896b6aad1461
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
|
|
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
|
|
since we no longer support the RG_LINKTYPE stuff
Change-Id: If388ecfa0c475471b99b26155ad554ec702ca734
|
|
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
|
|
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
|
|
Change-Id: I3ae555fd9f0dc3c11ea301ee1cb2c799fbec820d
|
|
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
|
|
Change-Id: I14b923990a012e8e85ca9170cdffd6b8e3626d89
|
|
found with
git grep -E '\* *\<reinterpret_cast\>[^>]+\<OUString\>'
Change-Id: I9306d4ad8e3b1664f54cb7df86f2d79bfd3c6cb9
|
|
Change-Id: Ib3610f9d244b15f8f752c0f781600f5c7e7a944f
|
|
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
|
|
Change-Id: I2ac79c757d9116d35436ae1adc0e11e7040e725d
|
|
Change-Id: Ifbe12a569a964203b07b47da5207ab0ffe00d4aa
|
|
Implementation::inspect() was crashing with a null reflection_ in
CppunitTest_libreofficekit_tiledrendering because another thread
was disposing it.
Actually, why are there 2 bools for this and not one enum with 3 values?
Change-Id: Icd27145d3203e1f48a9841ee6251a50cb73f7988
|
|
Change-Id: I40d7e0670539a86f01a539cf8acb10fa7bd27079
|
|
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
|
|
Change-Id: I5156318afde0f56cf3eb8d1c74c6db8d5e378600
|
|
Change-Id: I4c1c5e62de608738a91be4a234d9c160a18cbf8f
|
|
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
|
|
at least not to ensure that they are singletons anyway
Change-Id: I08176afa67ac5f8e4f479b70ca5d71c52d0bb9af
|
|
Change-Id: Icc0e9f028b393abb062a880519211be4fcd1d4b3
|
|
Change-Id: I8ec246416736bc0316c222d1b9435bd2747597b8
|
|
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
|
|
...in some places where it is obvious that it does not hurt that for an empty
vector the obtained pointer is not necessarily a nullptr.
Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
|
|
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
|
|
Change-Id: I3d820a1df3750d20e704a163f45c16ea29a1b4bd
|
|
This addresses some cppcheck warnings.
Change-Id: I46b9293eed0cba2ebca119cc1fb0a6334ea66308
Reviewed-on: https://gerrit.libreoffice.org/13844
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iadc5960ef22289c044a0c85accaefb4f60b6097f
|
|
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
|
|
Change-Id: I776bbe6077b33f22657141ca875743c67b793c48
|
|
Change-Id: If8c20c8a0958016c14007406244fc8ab9a742933
|
|
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
|
|
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I848505b1d4ff03779b89a08d4aeefd6ea0ff205b
|
|
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
that only call their superclass method
Change-Id: I9be2f69be132eec7918964f504c50df0ae8401a2
|
|
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
|
|
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
|
|
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
|