summaryrefslogtreecommitdiff
path: root/store/source
AgeCommit message (Collapse)Author
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: Ie38450a082dc840714051ad65c297886038e68f3
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Ibd23c1d96b093ae2670e7752691dad29c081639f
2015-03-24loplugin:constantfunction: storeNoel Grandin
Change-Id: I13284409404ef77eb16164b7ce2074259d2cad12
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I87b252d3d6e5322dbc4b6cc77b846766a0d35893
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-19Suppress 1 cppcheck warning arrayIndexOutOfBoundsJulien Nabet
See http://nabble.documentfoundation.org/cppcheck-arrayIndexOutOfBounds-report-in-stortree-cxx-store-module-td4136432.html Change-Id: I365befacf7d10bcbf0a159cfdcabd3eb1644d02b
2014-11-18More iwyu suggested headers removalRiccardo Magliocchetti
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-12coverity#1242813 Unused valueCaolán McNamara
and coverity#1242867 Unused value Change-Id: I8ad069a5a84b97e956cafcd925fd733fb5ed9b2e
2014-11-04coverity#1242933 unused valueDavid Tardon
Change-Id: I416144a4ccf2856ce85ab4b24a69958615276cb9
2014-11-04coverity#1242809 unused valueDavid Tardon
Change-Id: I16430567b3d57016458bd7877c36bc6e01197741
2014-08-14warning C4189: : local variable is initialized but not referencedThomas Arnhold
Change-Id: I650fab8227fd8b6aeb4fd4d420cb820aefd80271
2014-07-18cid#1226495 Uninitialized scalar fieldNoel Grandin
Change-Id: I5f05fc312032c50639f147f27353aa560a69f65a
2014-07-10use SimpleReferenceObject in stoc moduleNoel Grandin
to replace hand-rolled version Change-Id: I30635aec81313e4e0d1b67b30c8992fd63bb1f67
2014-07-08WaE: C4754Tor Lillqvist
VS 2013 warns: Conversion rules for arithmetic operations in the comparison mean that one branch cannot be executed. Change-Id: I85f6df16b0ced94677568441d87a588bed1bfb9b
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I2317522af91c8c60672c72a3b514767039930e22
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-12fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IFMichaël Lefèvre
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-19fixincludeguards.sh: some smaller dirsThomas Arnhold
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-04Clean up unreferenced functionsStephan Bergmann
Change-Id: I1dbb864d030b61417f6d137fc967f158e9243ed7
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-12No need for isKindOf to be SAL_CALLStephan Bergmann
Change-Id: Ia58af7d32904de01fdb5291203938c748cae94c6
2014-02-27Remove visual noise from storeAlexander Wilms
Change-Id: I6753eb480618af747ecf4a3ae3c666257761ce70 Reviewed-on: https://gerrit.libreoffice.org/8317 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-02-17store: sal_Bool -> boolStephan Bergmann
Change-Id: I7d108e7ae387f9c07cce182a0bb09b69a6608226
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ibc5e3084e4bec40005779854ce7552a2eb39a7ed
2013-07-09Remove warning by using the right printf commandsArnaud Versini
Change-Id: Id476a0eb1f5965098c8cc2e2847547b1d23387eb Reviewed-on: https://gerrit.libreoffice.org/4753 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-06-20-Werror,-Wdeprecated-registerStephan Bergmann
Change-Id: I1ec3d7845477cfb5bc6a3d7f70ddabef12583e1b
2013-06-10mingw64: use the sal formatting strings in storeFridrich Štrba
Change-Id: Id6b8f4ed6df14bd80a7937001ec1cfb98acd7f52
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-09Use BOOST_STATIC_ASSERTStephan Bergmann
Change-Id: Ib9dc2541c3bf72ddd6094331297a91352138e5af
2012-10-01Replace usage of rtl_*Memory with equivalent from string.hArnaud Versini
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159 Reviewed-on: https://gerrit.libreoffice.org/734 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-17migrate some of the biggest consumer of osl_*InterlockedCount to osl_atomicNorbert Thiebaud
Change-Id: I0e6992afbeffaf3b993e6630fb396d93012890e0 Reviewed-on: https://gerrit.libreoffice.org/632 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-14remove use of SAL_MIN() macroNorbert Thiebaud
Change-Id: Ia91118388240c9a54d010b94aef34ad528ce5761
2012-06-29Remove some more include guardsThomas Arnhold
Change-Id: I7c62d086cb593744785abecae7a107686a4d65ce
2012-06-27re-base on ALv2 code.Michael Meeks
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-05-07gbuild conversion: store moduleDavid Ostrovsky
Change-Id: Idbab17b87d042079a8fa6ded7a7424a745761b2f
2012-04-24WaE: MSVC2008 C4530 exception handler without unwind semanticsCaolán McNamara
2012-03-23Make default zero-initialization explicitStephan Bergmann
...to match style used for other data members.
2012-03-23Initialize m_hFile in FileMapping constructor.Catalin Iacob
GCC gives the following warning which breaks compilation when using --enable-werror: lockbyte.cxx: In function 'storeError store::FileLockBytes_createInstance(rtl::Reference<store::ILockBytes>&, rtl_uString*, storeAccessMode)': lockbyte.css:512:37: error: 'prephitmp.221' may be used uninitialized in this function [-Werror=uninitialized] lockbyte.cxx:906:1: note: 'prephitmp.221' was declared here It's not clear from GCC's message, but what it warns about is FileMapping::m_hFile. This is because of the following sequence: * xMapping.release() makes xMapping.m_value be a default constructed FileMapping * the xMapping local variable in store::FileLockBytes_createInstance gets destructed * ~ResourceHolder() calls ResourceHolder::reset * ResourceHolder::reset() calls FileMapping::UnmapFile::operator() passing m_value as rMapping * FileMapping::UnmapFile::operator() uses rMapping.m_hFile but rMapping is a default constructed FileMapping and therefore has m_hFile uninitialized Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: To me, this looks more like a compiler error. Also note that ResourceHolder::reset only calls FileMapping::UnmapFile::operator() if tmp != value, which is not the case here, as both tmp and value are default- constructed. And FileMapping::operator!= is carefule not to use the potentially uninitialized m_hFile. But always intiializing m_hFile is probably not a bad idea, anyway. And if it helps a certain compiler, all the better.
2012-03-14Enable -Wnon-virtual-dtor for GCC 4.6Stephan Bergmann
...which has the necessary features to support it. Change a lot of classes to either contain a protected non-virtual dtor (which is backwards compatible, so even works for cppumaker-generated UNO headers) or a public virtual one. cppuhelper/propertysetmixin.hxx still needs to disable the warning, as the relevant class has a non-virtual dtor but friends, which would still cause GCC to warn. Includes a patch for libcmis, intended to be upstreamed.
2012-01-31SimplificationStephan Bergmann
generated by cgit (git 2.34.1) at 2025-01-28 21:11:53 +0000