summaryrefslogtreecommitdiff
path: root/store/source
AgeCommit message (Collapse)Author
2014-08-14warning C4189: : local variable is initialized but not referencedThomas Arnhold
Change-Id: I650fab8227fd8b6aeb4fd4d420cb820aefd80271
2014-07-18cid#1226495 Uninitialized scalar fieldNoel Grandin
Change-Id: I5f05fc312032c50639f147f27353aa560a69f65a
2014-07-10use SimpleReferenceObject in stoc moduleNoel Grandin
to replace hand-rolled version Change-Id: I30635aec81313e4e0d1b67b30c8992fd63bb1f67
2014-07-08WaE: C4754Tor Lillqvist
VS 2013 warns: Conversion rules for arithmetic operations in the comparison mean that one branch cannot be executed. Change-Id: I85f6df16b0ced94677568441d87a588bed1bfb9b
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I2317522af91c8c60672c72a3b514767039930e22
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-12fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IFMichaël Lefèvre
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-19fixincludeguards.sh: some smaller dirsThomas Arnhold
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-04Clean up unreferenced functionsStephan Bergmann
Change-Id: I1dbb864d030b61417f6d137fc967f158e9243ed7
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-12No need for isKindOf to be SAL_CALLStephan Bergmann
Change-Id: Ia58af7d32904de01fdb5291203938c748cae94c6
2014-02-27Remove visual noise from storeAlexander Wilms
Change-Id: I6753eb480618af747ecf4a3ae3c666257761ce70 Reviewed-on: https://gerrit.libreoffice.org/8317 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-02-17store: sal_Bool -> boolStephan Bergmann
Change-Id: I7d108e7ae387f9c07cce182a0bb09b69a6608226
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ibc5e3084e4bec40005779854ce7552a2eb39a7ed
2013-07-09Remove warning by using the right printf commandsArnaud Versini
Change-Id: Id476a0eb1f5965098c8cc2e2847547b1d23387eb Reviewed-on: https://gerrit.libreoffice.org/4753 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-06-20-Werror,-Wdeprecated-registerStephan Bergmann
Change-Id: I1ec3d7845477cfb5bc6a3d7f70ddabef12583e1b
2013-06-10mingw64: use the sal formatting strings in storeFridrich Štrba
Change-Id: Id6b8f4ed6df14bd80a7937001ec1cfb98acd7f52
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-09Use BOOST_STATIC_ASSERTStephan Bergmann
Change-Id: Ib9dc2541c3bf72ddd6094331297a91352138e5af
2012-10-01Replace usage of rtl_*Memory with equivalent from string.hArnaud Versini
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159 Reviewed-on: https://gerrit.libreoffice.org/734 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-17migrate some of the biggest consumer of osl_*InterlockedCount to osl_atomicNorbert Thiebaud
Change-Id: I0e6992afbeffaf3b993e6630fb396d93012890e0 Reviewed-on: https://gerrit.libreoffice.org/632 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-14remove use of SAL_MIN() macroNorbert Thiebaud
Change-Id: Ia91118388240c9a54d010b94aef34ad528ce5761
2012-06-29Remove some more include guardsThomas Arnhold
Change-Id: I7c62d086cb593744785abecae7a107686a4d65ce
2012-06-27re-base on ALv2 code.Michael Meeks
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-05-07gbuild conversion: store moduleDavid Ostrovsky
Change-Id: Idbab17b87d042079a8fa6ded7a7424a745761b2f
2012-04-24WaE: MSVC2008 C4530 exception handler without unwind semanticsCaolán McNamara
2012-03-23Make default zero-initialization explicitStephan Bergmann
...to match style used for other data members.
2012-03-23Initialize m_hFile in FileMapping constructor.Catalin Iacob
GCC gives the following warning which breaks compilation when using --enable-werror: lockbyte.cxx: In function 'storeError store::FileLockBytes_createInstance(rtl::Reference<store::ILockBytes>&, rtl_uString*, storeAccessMode)': lockbyte.css:512:37: error: 'prephitmp.221' may be used uninitialized in this function [-Werror=uninitialized] lockbyte.cxx:906:1: note: 'prephitmp.221' was declared here It's not clear from GCC's message, but what it warns about is FileMapping::m_hFile. This is because of the following sequence: * xMapping.release() makes xMapping.m_value be a default constructed FileMapping * the xMapping local variable in store::FileLockBytes_createInstance gets destructed * ~ResourceHolder() calls ResourceHolder::reset * ResourceHolder::reset() calls FileMapping::UnmapFile::operator() passing m_value as rMapping * FileMapping::UnmapFile::operator() uses rMapping.m_hFile but rMapping is a default constructed FileMapping and therefore has m_hFile uninitialized Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: To me, this looks more like a compiler error. Also note that ResourceHolder::reset only calls FileMapping::UnmapFile::operator() if tmp != value, which is not the case here, as both tmp and value are default- constructed. And FileMapping::operator!= is carefule not to use the potentially uninitialized m_hFile. But always intiializing m_hFile is probably not a bad idea, anyway. And if it helps a certain compiler, all the better.
2012-03-14Enable -Wnon-virtual-dtor for GCC 4.6Stephan Bergmann
...which has the necessary features to support it. Change a lot of classes to either contain a protected non-virtual dtor (which is backwards compatible, so even works for cppumaker-generated UNO headers) or a public virtual one. cppuhelper/propertysetmixin.hxx still needs to disable the warning, as the relevant class has a non-virtual dtor but friends, which would still cause GCC to warn. Includes a patch for libcmis, intended to be upstreamed.
2012-01-31SimplificationStephan Bergmann
2012-01-21Removed some unused parameters; added SAL_UNUSED_PARAMETER.Stephan Bergmann
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC) is used to annotate legitimately unused parameters, so that static analysis tools can tell legitimately unused parameters from truly unnecessary ones. To that end, some patches for external modules are also added, that are only applied when compiling with GCC and add necessary __attribute__ ((unused)) in headers.
2012-01-10valgrind: have MappedLockBytes take complete ownership of the file handleCaolán McNamara
have MappedLockBytes take complete ownership of the file handle and unmap it and close it on release. Otherwise xFile will close it and MappedLockBytes will unmap it in that order, which breaks post android requirement to have a valid file handle in unmap
2011-12-21osl_unmapFile can't work for files bundled inside the .apk on AndroidTor Lillqvist
On Android, when an app is installed, arbitrary files bundled in the app won't be unpacked into actual separate files in the file system. They will exist only as archive entries in the .apk file (which is a zip archive). The SDK tooling puts such files under the /assets folder in the .apk. The LibreOffice bootstrapping code for Android maps the .apk file into memory. osl_openFile() knows about the /assets special case, and uses a separate abstraction for such memory-mapped files. Obviously, when producing an .apk, one needs to make sure these bundled files are not compressed, if one wants to be able to use them directly from the memory-mapped .apk file. We do that in our test and sample Android projects. When mapping such files under /assets , just return a pointer to the file's location inside the mapped .apk archive. We can't use the old osl_unmapFile() on such mapped files, as that would unexpectedly unmap fairly arbitrary pages of the .apk mapping, wreaking havoc on later use of the same pages. So, introduce a new osl_unmapMappedFile() function that takes also the oslFileHandle originally passed to osl_mapFile(). Use this instead in the few places where the code actually called osl_unmapFile(). Make sure osl_mapFile() is nonexistent on Android.
2011-11-27remove include of pch header from storeNorbert Thiebaud
2011-09-21OSL_TRACE: Remove trailing newlinesThomas Arnhold
Done with perl regex: s/(\n\s*OSL_TRACE\(\s*\"[^\n]+?)\s*(\\n)+(\"[^\n]*\)\;\n)/$1$3/gs; - removed trailing whitespaces and (multiple) newlines
2011-09-06[cppchecker] suppression of unread VariablePierre-André Jacquod
2011-03-23Merge commit 'ooo/DEV300_m103'Jan Holesovsky
Conflicts: codemaker/source/bonobowrappermaker/corbaoptions.cxx codemaker/source/cppumaker/cppuoptions.cxx codemaker/source/cunomaker/cunooptions.cxx codemaker/source/idlmaker/idloptions.cxx codemaker/source/javamaker/javaoptions.cxx cppu/source/typelib/typelib.cxx idlc/source/options.cxx offapi/com/sun/star/util/PathSubstitution.idl offapi/drafts/com/sun/star/form/ListEntryEvent.idl offapi/drafts/com/sun/star/form/XBindableValue.idl offapi/drafts/com/sun/star/form/XListEntryListener.idl offapi/drafts/com/sun/star/form/XListEntrySink.idl offapi/drafts/com/sun/star/form/XListEntrySource.idl offapi/drafts/com/sun/star/form/XValueBinding.idl registry/tools/checksingleton.cxx registry/tools/options.hxx registry/tools/regcompare.cxx registry/tools/regmerge.cxx sal/cppunittester/cppunittester.cxx sal/osl/unx/socket.c sal/osl/w32/diagnose.c sal/prj/d.lst sal/rtl/source/alloc_fini.cxx sal/rtl/source/alloc_global.c sal/rtl/source/makefile.mk
2011-02-01Remove RCS informationThomas Arnhold
2010-11-25Update from sibling repository.Matthias Huetsch [mhu]
2010-11-25#i115784# store: fix memory errors uncovered by valgrind and other tools.Matthias Huetsch [mhu]
2010-10-18remove non-compiled codePovilas Kanapickas
2010-10-17use SAL_N_ELEMENTS macroKenneth Venken
2010-10-14Add vim/emacs modelines to all source filesSebastian Spaeth
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-05more removed include guards using fixguard.pyPetr Mladek
2010-10-05remove include guards using fixguard.pyPetr Mladek
2010-04-09Update from master repository (DEV300_m76).Matthias Huetsch [mhu]
2010-03-22Update from master repository (DEV300_m75).Matthias Huetsch [mhu]
generated by cgit (git 2.34.1) at 2024-12-29 12:06:10 +0000