summaryrefslogtreecommitdiff
path: root/store
AgeCommit message (Collapse)Author
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-03-10Drop __store_ prefix from static entity (avoid reserved identifier)Stephan Bergmann
Change-Id: Ib03727f6b47d8f013f78a590d36d568ebc405bf3
2016-03-01loplugin:unuseddefaultparam in storeNoel Grandin
Change-Id: I825eb075b73daa5bf52e1d41c32cf2100abebe47
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-01-14loplugin:unusedmethods unused return value in store,svlNoel Grandin
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
2015-12-21loplugin:unusedfields in store,svtools,svxNoel Grandin
Change-Id: I9577c64e33950899c2e3467c7b481504e021d470
2015-12-10More loplugin:nullptr automatic rewrite (within templates)Stephan Bergmann
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-11-23loplugin:unusedfields in store/Noel Grandin
Change-Id: I0fae339e3736f98d5d534b8a01a3040c237c6621
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I2a4f84e8c36197a9d39a5bd36cb1e2401a956d87
2015-10-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22tdf#65108 use <> instead of "" in include lineFeyza Yavuz
Change-Id: Icc497610505d160ee7d0e3a129eb499fe4ba5c93 Reviewed-on: https://gerrit.libreoffice.org/19422 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-14coverity#1326107 Unchecked return valueCaolán McNamara
Change-Id: I6f2dc9c12349a5175ed34e22fa29d875d6b9bd0a
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I14985f98989861d74b3904ab79f3ced5a3d96f73
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I28d8bd79f266df7e9ea420f7238ed332ec4205a9
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I490f345d382b62001cf29a64ed732e854bdc5f7b
2015-10-01tdf#42949 remove unnecessary includes using iwyuNoel Grandin
Change-Id: I13960721b7e15b1761aff8497391e39ae5645b89 Reviewed-on: https://gerrit.libreoffice.org/18616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-21cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I19f02169a113b8c9bae634691e28cf9f9d6977b5
2015-09-13cppcheck: redundantPointerOpCaolán McNamara
Change-Id: Ifb32fc03b686aeb0835422764178e54650b183f5
2015-09-07cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I46f0e7c4cd45c7ac596dceae7ad28664b0cc2183
2015-08-29Avoid explicit casts of (sizeof) constants known at compile timeMatteo Casalin
Partially revert my previous commit eb4cbea657b9038c488f1b1bcf5107cc226a6681 "Silence some conversion warnings", since no warning was really raised for these obvious conversions. Change-Id: Ie035655cdc56ceeb12a6141b168f7e9a8b863fee
2015-08-21Silence some conversion warningsMatteo Casalin
Change-Id: I676ed010576f3a24b193ffc6c28a319bcc5ac968
2015-08-11new loplugin: defaultparamsNoel Grandin
find places where we do not need to be passing a parameter to a function, because that function has a default value which matches the value we are passing. Change-Id: I04d1fd6275204dd4925e6563282464f461123632
2015-08-10cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I0101893f5e8b65fb473a321e6169c3b610b33e60
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
2015-07-02loplugin:unusedmethods registry,storeNoel Grandin
Change-Id: Ie78eb881a7fc47d0cd7b9862bd0cd200153ce77d Reviewed-on: https://gerrit.libreoffice.org/16679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Iac7bb1008806efbef42ee1f9b32df0788a7c9915
2015-05-11Add back functionality erroneously removedStephan Bergmann
...with 09d5b31ebe187a4cd9f3efca5a7cb7f87e1e19f6 "loplugin:constantfunction: store," which apparently over-eagerly reduced functionality that happened to be constant in one specific implicit instantiation of a template, but not in others. (Plus, adapting the original code to silence false loplugin:staticmethods warnings.) Change-Id: I156df3aef1b3b0c9d36b2a54c57de29948749bde
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: Ie38450a082dc840714051ad65c297886038e68f3
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Ibd23c1d96b093ae2670e7752691dad29c081639f
2015-03-24loplugin:constantfunction: storeNoel Grandin
Change-Id: I13284409404ef77eb16164b7ce2074259d2cad12
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I87b252d3d6e5322dbc4b6cc77b846766a0d35893
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-19Suppress 1 cppcheck warning arrayIndexOutOfBoundsJulien Nabet
See http://nabble.documentfoundation.org/cppcheck-arrayIndexOutOfBounds-report-in-stortree-cxx-store-module-td4136432.html Change-Id: I365befacf7d10bcbf0a159cfdcabd3eb1644d02b
2014-11-21Remvoe store/workben/Stephan Bergmann
...probably not worth dragging that unused code around any more Change-Id: I4f22a704af862d8a1fe1f2202609f355ccee7c9c
2014-11-18More iwyu suggested headers removalRiccardo Magliocchetti
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-12coverity#1242813 Unused valueCaolán McNamara
and coverity#1242867 Unused value Change-Id: I8ad069a5a84b97e956cafcd925fd733fb5ed9b2e
2014-11-04coverity#1242933 unused valueDavid Tardon
Change-Id: I416144a4ccf2856ce85ab4b24a69958615276cb9
2014-11-04coverity#1242809 unused valueDavid Tardon
Change-Id: I16430567b3d57016458bd7877c36bc6e01197741