summaryrefslogtreecommitdiff
path: root/store
AgeCommit message (Collapse)Author
2016-10-14loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-10-07tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl
Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
2016-09-30cid#1371195, cide#1371212: Replace PageHolder with shared_ptrStephan Bergmann
...removing the need for SharedCount, too Change-Id: I20c724c940c571aef1c12453da30c3e9fbb46466
2016-09-30Remove OStorePageData typedefStephan Bergmann
Change-Id: I9f4e8fa41a59325fe7036acb66d045a833294bd6
2016-09-30Remove "#if 1 /* EXP */"Stephan Bergmann
...whatever it was supposed to be good for Change-Id: I8f2a526aeaa484675e1bd6763fa692f8cbed2a51
2016-09-30No need for rtl_cache_* hereStephan Bergmann
...which shows that m_pCount will never be null Change-Id: I87c6e4bf5d258c59a8e91cd194c64b1ce85b4445
2016-09-19convert storeAccessMode to scoped enumNoel Grandin
Change-Id: I67705cdff0440487019a2992571147d648be1bfc
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-31store: remove STORE_IMPL_ISP2 and STORE_IMPL_CONCAT.Arnaud Versini
Change-Id: Iec6cff8da24515f17a5ad2b9ba6e1f92df124921 Reviewed-on: https://gerrit.libreoffice.org/28508 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-31store : Replace store::swap with std::swapArnaud Versini
Change-Id: I85c1026502dc69b229aaf287858ae76f9391a34d Reviewed-on: https://gerrit.libreoffice.org/28506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29loplugin:countusersofdefaultparams in store..svtoolsNoel Grandin
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6 Reviewed-on: https://gerrit.libreoffice.org/27580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-03-10Drop __store_ prefix from static entity (avoid reserved identifier)Stephan Bergmann
Change-Id: Ib03727f6b47d8f013f78a590d36d568ebc405bf3
2016-03-01loplugin:unuseddefaultparam in storeNoel Grandin
Change-Id: I825eb075b73daa5bf52e1d41c32cf2100abebe47
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-01-14loplugin:unusedmethods unused return value in store,svlNoel Grandin
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
2015-12-21loplugin:unusedfields in store,svtools,svxNoel Grandin
Change-Id: I9577c64e33950899c2e3467c7b481504e021d470
2015-12-10More loplugin:nullptr automatic rewrite (within templates)Stephan Bergmann
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-11-23loplugin:unusedfields in store/Noel Grandin
Change-Id: I0fae339e3736f98d5d534b8a01a3040c237c6621
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I2a4f84e8c36197a9d39a5bd36cb1e2401a956d87
2015-10-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22tdf#65108 use <> instead of "" in include lineFeyza Yavuz
Change-Id: Icc497610505d160ee7d0e3a129eb499fe4ba5c93 Reviewed-on: https://gerrit.libreoffice.org/19422 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-14coverity#1326107 Unchecked return valueCaolán McNamara
Change-Id: I6f2dc9c12349a5175ed34e22fa29d875d6b9bd0a
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I14985f98989861d74b3904ab79f3ced5a3d96f73
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I28d8bd79f266df7e9ea420f7238ed332ec4205a9
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I490f345d382b62001cf29a64ed732e854bdc5f7b
2015-10-01tdf#42949 remove unnecessary includes using iwyuNoel Grandin
Change-Id: I13960721b7e15b1761aff8497391e39ae5645b89 Reviewed-on: https://gerrit.libreoffice.org/18616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-21cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I19f02169a113b8c9bae634691e28cf9f9d6977b5
2015-09-13cppcheck: redundantPointerOpCaolán McNamara
Change-Id: Ifb32fc03b686aeb0835422764178e54650b183f5
2015-09-07cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I46f0e7c4cd45c7ac596dceae7ad28664b0cc2183
2015-08-29Avoid explicit casts of (sizeof) constants known at compile timeMatteo Casalin
Partially revert my previous commit eb4cbea657b9038c488f1b1bcf5107cc226a6681 "Silence some conversion warnings", since no warning was really raised for these obvious conversions. Change-Id: Ie035655cdc56ceeb12a6141b168f7e9a8b863fee
2015-08-21Silence some conversion warningsMatteo Casalin
Change-Id: I676ed010576f3a24b193ffc6c28a319bcc5ac968
2015-08-11new loplugin: defaultparamsNoel Grandin
find places where we do not need to be passing a parameter to a function, because that function has a default value which matches the value we are passing. Change-Id: I04d1fd6275204dd4925e6563282464f461123632
2015-08-10cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I0101893f5e8b65fb473a321e6169c3b610b33e60
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
2015-07-02loplugin:unusedmethods registry,storeNoel Grandin
Change-Id: Ie78eb881a7fc47d0cd7b9862bd0cd200153ce77d Reviewed-on: https://gerrit.libreoffice.org/16679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Iac7bb1008806efbef42ee1f9b32df0788a7c9915
2015-05-11Add back functionality erroneously removedStephan Bergmann
...with 09d5b31ebe187a4cd9f3efca5a7cb7f87e1e19f6 "loplugin:constantfunction: store," which apparently over-eagerly reduced functionality that happened to be constant in one specific implicit instantiation of a template, but not in others. (Plus, adapting the original code to silence false loplugin:staticmethods warnings.) Change-Id: I156df3aef1b3b0c9d36b2a54c57de29948749bde
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
generated by cgit (git 2.34.1) at 2025-01-10 04:07:42 +0000