summaryrefslogtreecommitdiff
path: root/svgio/source/svgreader
AgeCommit message (Collapse)Author
2016-05-27Get rid of unnecessary directory levels $D/inc/$DTor Lillqvist
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48 Reviewed-on: https://gerrit.libreoffice.org/25532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Fix typosAndrea Gelmini
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert SpreadMethod to scoped enumNoel Grandin
Change-Id: I2a04247bd58ed6f2af8da7e109b31ff83d6d5e49 Reviewed-on: https://gerrit.libreoffice.org/25298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Iba1556d1918a336e376c0fda5e7e14b3e890d267
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26tdf#48066 render stroke-miterlimit correctly in SVG importRegina Henschel
The property stroke-miterlimit is transported to the renderers via a new member mfMiterMinimumAngle in class LineAttribute Several drawPolyLine methods are adapted. This patch does not include changes in MetaAction. Presentation mode, printing, and PDF-export is still wrong. Corrected LineJoinMiter to LineJoinBevel in canvas, that s closer to NONE. Removed DrawPolyLine method without MiterMinimumAngle and adapted calls accordingly. Change-Id: I6bcd24add5d85c4d9a39e3788e0682091c5fc9c4 Reviewed-on: https://gerrit.libreoffice.org/23946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-12SVG: actually this code is unnecessary after...Xisco Fauli
... f5d4a688346a939a58b1df69d771dede177b3370 Change-Id: I2911763c38a6be275bcd7ae0c9a51cd7a2e9fe4a Reviewed-on: https://gerrit.libreoffice.org/24012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-04-12SVG: Clean up this code a litle bitXisco Fauli
Change-Id: Ib941321d43a9a04d57f3c7c4a55528927fed5036 Reviewed-on: https://gerrit.libreoffice.org/24009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-03SVG: Using the marker property from a style sheet is equivalent...Xisco Fauli
... to using all three (start, mid, end). However, shorthand properties cannot be used as presentation attributes. Change-Id: Ie3842b8fa87f562f038600f8f012d8434363b3cd Reviewed-on: https://gerrit.libreoffice.org/23749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-30tdf#97657: SVGIO: Don't iterate over parent's clip-paths...Xisco Fauli
... when it's a clip-path content Change-Id: I222b429a61409d9670b9d60357895542a15afc15 Reviewed-on: https://gerrit.libreoffice.org/23624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-29SVGIO: Don't inherit style attributes from parent if the...Xisco Fauli
... shapes define their own attributes. Partially revert commit c2d130425cc876cceb96cc7e47636426a9e48fa8 Change-Id: Iee98003f4ff63575a28818b091ab77431337192f Reviewed-on: https://gerrit.libreoffice.org/23571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-26SVGIO: Shapes within a clippath element might inherit...Xisco Fauli
... fill, stroke, stroke-width and others attributes from parent element, like use element Change-Id: I911bc50409428e81135b81e6dfc82acd1c21d113 Reviewed-on: https://gerrit.libreoffice.org/23527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-17tdf#98599 SVG: consider attributes of 'defs' elementRegina Henschel
The element 'defs' is not rendered, but children of it may inherit the attributes. Therefore these has to be considered. Change-Id: Ic6c21645439731db63f22adf5a5a4e2af2b74b71 Reviewed-on: https://gerrit.libreoffice.org/23309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-11tdf#47446: SVGIO: Take markers' parents into account tooXisco Fauli
Change-Id: I41b7228ab5980581ab5e1c8c4d4d466da6045086 Reviewed-on: https://gerrit.libreoffice.org/23124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-10tdf#97539: SVGIO: iterate over parent's clippathsXisco Fauli
Change-Id: Iadb335bf5b328fa3fd9683da5433c299e62afa8e Reviewed-on: https://gerrit.libreoffice.org/23106 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09tdf#47446: SVGIO: Set marker's fill attribute to black...Xisco Fauli
... if it's not set Change-Id: Iefec59f885c3708defec2b636836617bf97387fc Reviewed-on: https://gerrit.libreoffice.org/23046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-09SVGIO: Fix problem when style's parent contains a mask elementXisco Fauli
Change-Id: I26aab6c0f959f6cc78d040f59f1acf0c7e29931b Reviewed-on: https://gerrit.libreoffice.org/23045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-08Updated to solve problem with gerrit patch 22363Jan Iversen
Regina posted comment on 22363, that this change was needed. Change-Id: I9021d40ee7c1ca7ca74d67c61fe58ce976da38c0
2016-03-07SVGIO: tdf#97539: clip-path elements might contain...Xisco Fauli
reference to other clip-paths Change-Id: I3722b31cefa4df6225e369b3d1db9f46be5933ff Reviewed-on: https://gerrit.libreoffice.org/22956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-03tdf#98113: SVGIO: Add SvgANode class to handle transport ...Xisco Fauli
... attribute in anchor elements. I used Svggnode class a a reference for this. Change-Id: Id2a58bd913f9984dc91163ca0f333c016aa981f1 Reviewed-on: https://gerrit.libreoffice.org/22822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-01loplugin:unuseddefaultparam in svgioNoel Grandin
Change-Id: I47fe88cd8c943acb9162cdfca53fb5fdbaacec04
2016-02-28tdf#98119 Allow markers on zero-length linesRegina Henschel
Inkscape, Seamonkey, Chrome and Batik show markers on zero- length lines, LibreOffice should do that too. The patch removes the restriction start<>end. Change-Id: I984baf755df7b2689e00d2a23b40e3f059c0add0 Reviewed-on: https://gerrit.libreoffice.org/22740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-02-27Revert "SVGIO: tdf#97539: clip-path elements might contain..."Xisco Faulí
This reverts commit 7b7ffedfa6357b902a5e354d986dac39a3b2f462. Change-Id: I018830e17cb83c5fe3574b76939673877ac2004d Reviewed-on: https://gerrit.libreoffice.org/22726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-02-25Partially revert b6a62f07557fe4ae0931e0f3e0f306d2f69b116bXisco Fauli
it has been fixed by 423b79e7366203db3f57dea75b8cb9eb852b5614 in a better way Change-Id: Ia3192071f00522ac111d3e95e4dc05dc57a6267e Reviewed-on: https://gerrit.libreoffice.org/22677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-02-21tdf#97538 no cropping if width, height and viewBox missingRegina Henschel
Now the whole image is inserted, so that it can be cropped in the application. The patch repairs in addition a wrong ratio in the case height is missing but viewBox is given, and fixes some comments. Change in SvgImportTest.cxx by Xisco Fauli. Change-Id: I8c0fbf8b78cf7ab5bc97d04783b49892da3d2849 Reviewed-on: https://gerrit.libreoffice.org/22363 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-02-19new loplugin: find write-only fieldsNoel Grandin
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-19SVGIO: Fix problem when relative font-size depends on its...Xisco Fauli
... parent's font-size Change-Id: I13943923c401a5a06b3aa51181fd75292534e888 Reviewed-on: https://gerrit.libreoffice.org/22452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18tdf#97752 SVGIO ignore not matching parent paintsJochen Nitschke
fill attributes can have ONE of 3 kinds of paints: * pain colour fills * gradient fills * pattern fills if element has a fill we should not get fills of an other kind from parent Change-Id: I376a8fea4a7185b037a069a28191b7f37f6788bd Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-on: https://gerrit.libreoffice.org/22273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-02-18SVGIO: tdf#97941: Don't double tspan fontsizeXisco Fauli
Same as in 701324a1e1f7e0c181ff1a50956ced686785ea53 Change-Id: I531bef4821008ef71951506c133f999b9ab4f4ff Reviewed-on: https://gerrit.libreoffice.org/22450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-02-17SVGIO: tdf#97539: clip-path elements might contain...Xisco Fauli
reference to other clip-paths Change-Id: I0c426c892da2478293b78ea93db087d781275896 Reviewed-on: https://gerrit.libreoffice.org/22411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-13SVGIO: tdf#97659: Add support for RGBAXisco Fauli
Change-Id: Icbf3796cdc95f91d298a5ca52d44931b3985eac6 Reviewed-on: https://gerrit.libreoffice.org/22303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-11tdf#97542: SVGIO: First check the current fill attributeXisco Fauli
Differenciate when gradient is defined in the text element or in its parents Add unit tests Change-Id: I85b09f72fbb1a3c8d2fa7350b4396b5bf924277f Reviewed-on: https://gerrit.libreoffice.org/22131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08SVGIO: Return default font size if size value is negativeXisco Fauli
Change-Id: Iec18c6511b57c4e61047055b53589f71dda3d601 Reviewed-on: https://gerrit.libreoffice.org/21972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-02-07tdf#97543 SVGIO: Rework getVisibility()Xisco Fauli
Change-Id: Idb3eaa27e3e8ec177ebd2bad81f53c4d3da9d241 Reviewed-on: https://gerrit.libreoffice.org/22169 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05SVGIO: tdf#97383: Keep ratio in embedded images...Armin Le Grand
... when height and width are different SVG specifies embedded graphics to keep their aspect ratio (thanks to Regina for pointing out). To implement this for Office SVG import, I had to correctly set the graphic data unit dimensions to make the existing SvgAspectRatio mapping work. All together this now simplifies this method and packs all in clean linear transformations in the created stack of drwainglayer primitives. Change-Id: Id80c2f74ffb148085085b2c9627bc31bc15bdee5 Reviewed-on: https://gerrit.libreoffice.org/21830 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-02-01tdf#79163: SVGIO: Fix problem with opacity attributeXisco Fauli
Opacity attribute didn't work because it was always set to 1.0 Change-Id: I3a2029ef23acf9d8c0f346e04341db33c6802b8e Reviewed-on: https://gerrit.libreoffice.org/21911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-28SVGIO: tdf#45771: Fix issue when text size is twice its size...Xisco Fauli
... when using relative units (em, ex) This is because for nodes of type textnode, getFontSizeNumber is called from SvgCharacterNode::createSimpleTextPrimitive and from SvgNode::getCurrentFontSize(), so avoid the second call. Change-Id: Ibd418708a572e3c1643164a900fac7e7481afe81 Reviewed-on: https://gerrit.libreoffice.org/21801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-26SVGIO: Fix issue when font size is in percentage and ...Xisco Fauli
... there's no parent style set Sample: <?xml version="1.0" encoding="UTF-8"?> <svg height="600" width="400" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" font-size="100%"> <text x="5" y="15">Sample 1</text> </svg> Change-Id: Iec88c148475bf8a610286414083e9801faaf8d78 Reviewed-on: https://gerrit.libreoffice.org/21553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-22tdf#97275 SVGIO: Change default PPI to 96 in svg import...Xisco Fauli
... thus default font size is 16px from now on. More information: https://gerrit.libreoffice.org/#/c/21542/ Change-Id: If19b5be08d57a9d630647b9ad51a4bb6956c70ed Reviewed-on: https://gerrit.libreoffice.org/21617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-21tdf#85770 reuse variable instead of getting it againXisco Fauli
Change-Id: I268fd695e4cfd91dc8aba2b098911dbd9cf02ad7 Reviewed-on: https://gerrit.libreoffice.org/21639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-20SVGIO: Add support to font-size keywordsXisco Fauli
Similar to 0cae9c32ce9884a9809e220ba80b7c4cb4059565 Change-Id: Iac7a6bb30b36e51ea67a6c4f7b3421f480eeea57 Reviewed-on: https://gerrit.libreoffice.org/21542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-18tdf#85770 SVG: Don't display text elements if parent's...Xisco Fauli
... visibility is set to hidden Change-Id: I7633b895a3f0a7906c41d19c70e7201b1e420f9d Reviewed-on: https://gerrit.libreoffice.org/21500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-11tdf#69977: uno::Sequence is expensiveNoel Grandin
when used as a mutable data-structure. Plain std::vector halves the time taken to display the chart dialog Create a class to represent the std::vector we are going to be passing around, and move some of the utility methods into it to make the code prettier. Also create an optimised append(&&) method for the common case of appending small temporaries. Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I0164a67073395b865fa3e3ce342665f6497dc5b8